Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Joshua Ashton
On 2/3/23 19:34, Ville Syrjälä wrote: On Fri, Feb 03, 2023 at 09:25:38PM +0200, Ville Syrjälä wrote: On Fri, Feb 03, 2023 at 08:56:55PM +0200, Ville Syrjälä wrote: On Fri, Feb 03, 2023 at 01:28:20PM -0500, Harry Wentland wrote: On 2/3/23 11:00, Ville Syrjälä wrote: On Fri, Feb 03, 2023 a

Re: [PATCH 1/8] drm/amdgpu: UAPI for user queue management

2023-02-03 Thread Shashank Sharma
Hey Alex, On 03/02/2023 23:07, Alex Deucher wrote: On Fri, Feb 3, 2023 at 4:54 PM Shashank Sharma wrote: From: Alex Deucher This patch intorduces new UAPI/IOCTL for usermode graphics queue. The userspace app will fill this structure and request the graphics driver to add a graphics work queu

Re: [PATCH 1/8] drm/amdgpu: UAPI for user queue management

2023-02-03 Thread Alex Deucher
On Fri, Feb 3, 2023 at 4:54 PM Shashank Sharma wrote: > > From: Alex Deucher > > This patch intorduces new UAPI/IOCTL for usermode graphics > queue. The userspace app will fill this structure and request > the graphics driver to add a graphics work queue for it. The > output of this UAPI is a que

[pull] amdgpu drm-next-6.3

2023-02-03 Thread Alex Deucher
Hi Dave, Daniel, More stuff for 6.3. Mostly bug fixes. The following changes since commit aebd8f0c6f8280ba35bc989f4a9ea47469d3589a: Merge v6.2-rc6 into drm-next (2023-01-31 12:23:23 +0100) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm

[PATCH 4/8] drm/amdgpu: Add V11 graphics MQD functions

2023-02-03 Thread Shashank Sharma
From: Shashank Sharma MQD describes the properies of a user queue to the HW, and allows it to accurately configure the queue while mapping it in GPU HW. This patch adds: - A new header file which contains the userqueue MQD definition for V11 graphics engine. - A new function which fills it with

[PATCH 5/8] drm/amdgpu: Create context for usermode queue

2023-02-03 Thread Shashank Sharma
The FW expects us to allocate atleast one page as context space to process gang, process, shadow, GDS and FW_space related work. This patch creates some object for the same, and adds an IP specific functions to do this. Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Shashank Sharma --- d

[PATCH 6/8] drm/amdgpu: Map userqueue into HW

2023-02-03 Thread Shashank Sharma
From: Shashank Sharma This patch adds new fptrs to prepare the usermode queue to be mapped or unmapped into the HW. After this mapping, the queue will be ready to accept the workload. V1: Addressed review comments from Alex on the RFC patch series - Map/Unmap should be IP specific. Cc: Alex

[PATCH 7/8] drm/amdgpu: DO-NOT-MERGE add busy-waiting delay

2023-02-03 Thread Shashank Sharma
From: Arvind Yadav This patch adds 20 ms of busy-waiting delay after mapping the usermode queue in MES HW. It was observed during the testing that this delay is required for expected results. Cc: Alex Deucher Cc: Christian König Cc: Shashank Sharma Signed-off-by: Arvind Yadav --- drivers/g

[PATCH 8/8] drm/amdgpu: DO-NOT-MERGE doorbell hack

2023-02-03 Thread Shashank Sharma
From: Shashank Sharma The doorbell patches, being reviewed here, are requied for Usermode queues: https://patchwork.freedesktop.org/series/113669/ This hack patch adds a doorbell IOCTL just to test the usermode queues functionality, and must not be merged. Cc: Alex Deucher Cc: Christian König

[PATCH 3/8] drm/amdgpu: introduce userqueue MQD handlers

2023-02-03 Thread Shashank Sharma
From: Shashank Sharma A Memory queue descriptor (MQD) of a userqueue defines it in the harware's context. As the method of formation of a MQD, and its format can vary between different graphics IPs, we need gfx GEN specific handlers to create MQDs. This patch: - Introduces MQD hander functions f

[PATCH 2/8] drm/amdgpu: add usermode queues

2023-02-03 Thread Shashank Sharma
From: Shashank Sharma This patch adds skeleton code for usermode queue creation. It typically contains: - A new structure to keep all the user queue data in one place. - An IOCTL function to create/free a usermode queue. - A function to generate unique index for the queue. - A queue context manag

[PATCH 0/8] AMDGPU usermode queues

2023-02-03 Thread Shashank Sharma
From: Shashank Sharma This patch series introduces AMDGPU usermode graphics queues. User queues is a method of GPU workload submission into the graphics hardware without any interaction with kernel/DRM schedulers. In this method, a userspace graphics application can create its own workqueue and s

[PATCH 1/8] drm/amdgpu: UAPI for user queue management

2023-02-03 Thread Shashank Sharma
From: Alex Deucher This patch intorduces new UAPI/IOCTL for usermode graphics queue. The userspace app will fill this structure and request the graphics driver to add a graphics work queue for it. The output of this UAPI is a queue id. This UAPI maps the queue into GPU, so the graphics app can s

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Harry Wentland
On 2/3/23 14:34, Ville Syrjälä wrote: > On Fri, Feb 03, 2023 at 09:25:38PM +0200, Ville Syrjälä wrote: >> On Fri, Feb 03, 2023 at 08:56:55PM +0200, Ville Syrjälä wrote: >>> On Fri, Feb 03, 2023 at 01:28:20PM -0500, Harry Wentland wrote: On 2/3/23 11:00, Ville Syrjälä wrote: >

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Ville Syrjälä
On Fri, Feb 03, 2023 at 09:25:38PM +0200, Ville Syrjälä wrote: > On Fri, Feb 03, 2023 at 08:56:55PM +0200, Ville Syrjälä wrote: > > On Fri, Feb 03, 2023 at 01:28:20PM -0500, Harry Wentland wrote: > > > > > > > > > On 2/3/23 11:00, Ville Syrjälä wrote: > > > > On Fri, Feb 03, 2023 at 10:24:52AM -0

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Harry Wentland
On 2/3/23 14:25, Ville Syrjälä wrote: > On Fri, Feb 03, 2023 at 08:56:55PM +0200, Ville Syrjälä wrote: >> On Fri, Feb 03, 2023 at 01:28:20PM -0500, Harry Wentland wrote: >>> >>> >>> On 2/3/23 11:00, Ville Syrjälä wrote: On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: > >

Re: [PATCH] drm/amd: fix memory leak in amdgpu_cs_sync_rings

2023-02-03 Thread Alex Deucher
Applied. Thanks. I forgot to add it to the commit when I pushed it, but for posterity, Fixes: 3bd68b32c911 ("drm/amdgpu: fix pipeline sync v2:) Alex On Fri, Feb 3, 2023 at 11:53 AM Bert Karwatzki wrote: > > Here is the fix for (send again to test if I can get it right with > Evolution) > Bug:

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Ville Syrjälä
On Fri, Feb 03, 2023 at 08:56:55PM +0200, Ville Syrjälä wrote: > On Fri, Feb 03, 2023 at 01:28:20PM -0500, Harry Wentland wrote: > > > > > > On 2/3/23 11:00, Ville Syrjälä wrote: > > > On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: > > >> > > >> > > >> On 2/3/23 10:19, Ville Syrj

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Harry Wentland
On 2/3/23 13:56, Ville Syrjälä wrote: > On Fri, Feb 03, 2023 at 01:28:20PM -0500, Harry Wentland wrote: >> >> >> On 2/3/23 11:00, Ville Syrjälä wrote: >>> On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: On 2/3/23 10:19, Ville Syrjälä wrote: > On Fri, Feb 03, 20

[PATCH 14/14] drm/amdgpu: introduce doorbell bo in kernel

2023-02-03 Thread Shashank Sharma
From: Alex Deucher This patch does the following: - Removes doorbell ptr from adev. - Moves doorbell.num_doorbells into mman.num_doorbells. - Introduces a kernel bo for doorbell management in form of mman.doorbell_kernel_bo. This bo holds the doorbell space now. - Introduces mman.doorbell_bo_s

[PATCH 13/13] drm/amdgpu: introduce doorbell bo in kernel

2023-02-03 Thread Shashank Sharma
From: Alex Deucher This patch does the following: - Removes doorbell ptr from adev. - Moves doorbell.num_doorbells into mman.num_doorbells. - Introduces a kernel bo for doorbell management in form of mman.doorbell_kernel_bo. This bo holds the doorbell space now. - Introduces mman.doorbell_bo_s

[PATCH 13/14] drm/amdgpu: add domain info in bo_create_kernel_at

2023-02-03 Thread Shashank Sharma
From: Shashank Sharma This patch adds a domain input variable for amdgpu_bo_create_kernel_at, so that it could be used for both VRAM and DOORBELL domains objects. It also adds supporting code for existing callers. Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c |

[PATCH 12/13] drm/amdgpu: add domain info in bo_create_kernel_at

2023-02-03 Thread Shashank Sharma
From: Shashank Sharma This patch adds a domain input variable for amdgpu_bo_create_kernel_at, so that it could be used for both VRAM and DOORBELL domains objects. It also adds supporting code for existing callers. Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c |

[PATCH 12/14] drm/amdgpu: initialize doorbell memory pool

2023-02-03 Thread Shashank Sharma
From: Alex Deucher This patch initializes doorbell pool with bar manager, which will divide all the doorbell memory into pages. Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

[PATCH 10/13] drm/amdgpu: doorbell support in get_memory functions

2023-02-03 Thread Shashank Sharma
From: Alex Deucher This patch adds section for doorbell memory in memory status reporting functions like vm/bo_get_memory. Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 9 +

[PATCH 11/13] drm/amdgpu: initialize doorbell memory pool

2023-02-03 Thread Shashank Sharma
From: Shashank Sharma This patch initializes doorbell pool with bar manager, which will divide all the doorbell memory into pages. Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 11 +++ 1 file changed, 11 insertions(+) diff --

[PATCH 11/14] drm/amdgpu: doorbell support in get_memory functions

2023-02-03 Thread Shashank Sharma
From: Alex Deucher This patch adds section for doorbell memory in memory status reporting functions like vm/bo_get_memory. Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 9 +

[PATCH 10/14] drm/amdgpu: accommodate DOMAIN/PL_DOORBELL

2023-02-03 Thread Shashank Sharma
From: Alex Deucher This patch adds changes to accommodate the new GEM/TTM domain for doorbell memory. Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_bar_mgr.c | 19 ++-- drivers/g

[PATCH 09/14] drm/amdgpu: move doorbell aperture handling into ttm_init

2023-02-03 Thread Shashank Sharma
From: Alex Deucher To consolidate it with vram handling. Signed-off-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 96 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 64 +++ 2 files changed, 71 insertions(+), 89 d

[PATCH 06/13] drm/amdgpu: rename gmc.aper_base/size

2023-02-03 Thread Shashank Sharma
From: Alex Deucher This patch renames aper_base and aper_size parameters (in adev->gmc), to vram_aper_base and vram_aper_size, to differentiate it from the doorbell BAR. Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers

[PATCH 09/13] drm/amdgpu: accommodate DOMAIN/PL_DOORBELL

2023-02-03 Thread Shashank Sharma
From: Alex Deucher This patch adds changes to accommodate the new GEM/TTM domain for doorbell memory. Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_bar_mgr.c | 19 ++-- drivers/g

[PATCH 08/13] drm/amdgpu: move doorbell ptr into mman structure

2023-02-03 Thread Shashank Sharma
From: Alex Deucher This patch: - moves the doorbell.ptr variable to mman structure - renames it to doorbell_aper_base_kaddr for better readability; This change is to make doorbell's ttm management similar to vram's. Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/d

[PATCH 07/13] drm/amdgpu: store doorbell info in gmc structure

2023-02-03 Thread Shashank Sharma
From: Alex Deucher This patch moves doorbell info into adev->gmc structure, to align with vram info. This will prepare structures for proper ttm management of the doorbell BAR. Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 8 +++

[PATCH 05/13] drm/amdgpu: add doorbell support to amdgpu_bar_mgr

2023-02-03 Thread Shashank Sharma
From: Alex Deucher Adjust the code to handle doorbell BARs as well as VRAM. Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_bar_mgr.c | 101 drivers/gpu/drm/amd/amdgpu/amdgpu_bar_mgr.h | 1 + drivers/gpu/drm/amd/amdgpu/am

[PATCH 02/13] drm/amdgpu: rename vram_mgr functions to bar_mgr

2023-02-03 Thread Shashank Sharma
From: Alex Deucher Rename the VRAM manager functions so they can be resused to manage doorbell BAR as well. Cc: Christian Koenig Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c

[PATCH 04/13] drm/amdgpu: replace aper_base_kaddr with vram_aper_base_kaddr

2023-02-03 Thread Shashank Sharma
From: Alex Deucher To differentiate it from the doorbell BAR. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 14 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h| 2 +- drivers/gpu/drm/amd/amdg

[PATCH 03/13] drm/amdgpu: rename amdgpu_vram_mgr.c/h to amdgpu_bar_mgr.c/h

2023-02-03 Thread Shashank Sharma
From: Alex Deucher Rename the files. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- .../gpu/drm/amd/amdgpu/{amdgpu_vram_mgr.c => amdgpu_bar_mgr.c} | 0 .../gpu/drm/amd/amdgpu/{amdgpu_vram_mgr.h => amdgpu_bar_mgr.h} | 0 drivers/gpu/drm

[PATCH 01/13] drm/amdgpu: add UAPI for allocating doorbell memory

2023-02-03 Thread Shashank Sharma
From: Alex Deucher Signed-off-by: Alex Deucher --- include/uapi/drm/amdgpu_drm.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h index 4038abe8505a..fd1c65d78ded 100644 --- a/include/uapi/drm/amdgpu_drm.h ++

[PATCH 00/13] Re-design doorbell framework for usermode queues

2023-02-03 Thread Shashank Sharma
From: Shashank Sharma This patch series re-designs the current doorbell handling of the AMDGPU driver and prepares it for Usermode queues. The fundamental changes are: - Introduce and accommodate a new GEM domain for doorbells. - Prepare the AMDGPU ttm backend for handling doorbell memory. - Ren

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Ville Syrjälä
On Fri, Feb 03, 2023 at 01:28:20PM -0500, Harry Wentland wrote: > > > On 2/3/23 11:00, Ville Syrjälä wrote: > > On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: > >> > >> > >> On 2/3/23 10:19, Ville Syrjälä wrote: > >>> On Fri, Feb 03, 2023 at 09:39:42AM -0500, Harry Wentland wrote

[linux-next:master] BUILD REGRESSION 4fafd96910add124586b549ad005dcd179de8a18

2023-02-03 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 4fafd96910add124586b549ad005dcd179de8a18 Add linux-next specific files for 20230203 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202301301801.y5o08tqx-...@intel.com https

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Harry Wentland
On 2/3/23 11:00, Ville Syrjälä wrote: > On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: >> >> >> On 2/3/23 10:19, Ville Syrjälä wrote: >>> On Fri, Feb 03, 2023 at 09:39:42AM -0500, Harry Wentland wrote: On 2/3/23 07:59, Sebastian Wick wrote: > On Fri, Feb 3, 20

[PATCH] drm/amdgpu: Fix potential race processing vm->freed

2023-02-03 Thread Rob Clark
From: Rob Clark If userspace calls the AMDGPU_CS ioctl from multiple threads, because the vm is global to the drm_file, you can end up with multiple threads racing in amdgpu_vm_clear_freed(). So the freed list should be protected with the status_lock, similar to other vm lists. Fixes: d38ceaf99

Re: [PATCH] drm/amd: fix memory leak in amdgpu_cs_sync_rings

2023-02-03 Thread Bert Karwatzki
Here is the fix for (send again to test if I can get it right with Evolution) Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2360 From 6e064c9565ef0da890f3fcb2a4f6a8cd44a12fdb Mon Sep 17 00:00:00 2001 From: Bert Karwatzki Date: Thu, 2 Feb 2023 19:50:27 +0100 Subject: [PATCH] Fix memory leak

Re: [PATCH] drm/amd/display: fix read errors pertaining to dp_lttpr_status_show()

2023-02-03 Thread Aurabindo Pillai
On 2/3/23 10:43, Hamza Mahfooz wrote: Currently, it is likely that we will read the relevant LTTPR caps after link training has completed (which can cause garbage data to be read), however according to the DP 2.0 spec that should be done before link training has commenced. So, instead of reading

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Ville Syrjälä
On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: > > > On 2/3/23 10:19, Ville Syrjälä wrote: > > On Fri, Feb 03, 2023 at 09:39:42AM -0500, Harry Wentland wrote: > >> > >> > >> On 2/3/23 07:59, Sebastian Wick wrote: > >>> On Fri, Feb 3, 2023 at 11:40 AM Ville Syrjälä > >>> wrote: >

[PATCH] drm/amd/display: fix read errors pertaining to dp_lttpr_status_show()

2023-02-03 Thread Hamza Mahfooz
Currently, it is likely that we will read the relevant LTTPR caps after link training has completed (which can cause garbage data to be read), however according to the DP 2.0 spec that should be done before link training has commenced. So, instead of reading the registers on demand, use the values

[PATCH 11/12] drm/amd/display: avoid disable otg when dig was disabled

2023-02-03 Thread Qingqing Zhuo
From: Jingwen Zhu [Why] This is a workaround for an dcn3.15 hang that happens if otg dispclk is ramped while otg is on and stream enc is off. But this w/a should not trigger when we have a dig active. [How] Avoid disable otg when dig was disabled. [Note] Reapplying commit 82dca8576d14f3dcb775b3

[PATCH 12/12] drm/amd/display: 3.2.222

2023-02-03 Thread Qingqing Zhuo
From: Aric Cyr This version brings along the following: - FW 0.0.153.0 - Code re-organize for dc_link.c - Bug fixes on rotation, DRR and more - DCN314 domain power control moved to dmcub Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file cha

[PATCH 08/12] drm/amd/display: Move DCN314 DOMAIN power control to DMCUB

2023-02-03 Thread Qingqing Zhuo
From: Nicholas Kazlauskas [Why] DOMAIN power gating control is now required to be done via firmware due to interlock with other power features. This is to avoid intermittent issues in the LB memories. [How] If the firmware supports the command then use the new firmware as the sequence can avoid

[PATCH 09/12] drm/amd/display: Drop CONFIG_BACKLIGHT_CLASS_DEVICE ifdefs

2023-02-03 Thread Qingqing Zhuo
From: Hans de Goede Remove CONFI_BACKLIGHT_CLASS_DEVICE ifdef that was accidently introduced back. Reviewed-by: Hamza Mahfooz Acked-by: Qingqing Zhuo Signed-off-by: Hans de Goede Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 --- 1 file changed, 3 del

[PATCH 10/12] drm/amd/display: [FW Promotion] Release 0.0.153.0

2023-02-03 Thread Qingqing Zhuo
From: Anthony Koo [Why&How] - Reduce reserved size from 9 to 8 dwords to reduce structure size and allow the union dmub_rb_cmd to fit into max 64-bytes cmd size Reviewed-by: Aric Cyr Acked-by: Qingqing Zhuo Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 2 +-

[PATCH 06/12] drm/amd/display: Set max vratio for prefetch to 7.9 for YUV420 MPO

2023-02-03 Thread Qingqing Zhuo
From: Alvin Lee [Description] - Single 4K60 playing YUV420 MPO video blocks P-State because the required VRatio for prefetch is too high (luma plane for YUV420 is 1bpe, so swath height is 16 and prefetch requires more lines) - Allow max vratio per plane to be 7.9 for single display YUV420

[PATCH 05/12] drm/amd/display: Add HDMI manufacturer OUI and device id read

2023-02-03 Thread Qingqing Zhuo
From: "Leo (Hanghong) Ma" [Why && How] Add support to read manufacturer OUI and device id from HDMI SCDC. Reviewed-by: Wenjing Liu Acked-by: Qingqing Zhuo Signed-off-by: Leo (Hanghong) Ma --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 17 drivers/gpu/drm/amd/display/dc/

[PATCH 02/12] drm/amd/display: Do not commit pipe when updating DRR

2023-02-03 Thread Qingqing Zhuo
From: Wesley Chalmers [WHY] DRR and Pipe cannot be updated on the same frame, or else underflow will occur. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Wesley Chalmers --- drivers/gpu/drm/amd/display/dc/core/dc.c | 15 +++ drivers/gpu/drm/amd/display/dc/d

[PATCH 04/12] drm/amd/display: Fix null pointer deref error on rotation

2023-02-03 Thread Qingqing Zhuo
From: Aurabindo Pillai [Why&How] Fix the null pointer dererefence error when rotating the monitor on a DCN32 variant, which causes a call trace like: [ 42.469548] RIP: 0010:dcn20_program_front_end_for_ctx.cold+0x68/0x435 [amdgpu] [ 42.477140] Code: c1 4c 01 e8 48 8b b0 f0 01 00 00 e8 b6 1c

[PATCH 03/12] drm/amd/display: Only raise FP2 outside of lock

2023-02-03 Thread Qingqing Zhuo
From: Wesley Chalmers [WHY] If HUBP FP2 (VTG register) is higher than OTG FP2 (implicit), then underflow can occur. Since VTG is not double-buffered, there is risk of underflow when raising FP2 if VBLANK is hit before programming and unlocking OTG is completed. It appears that if HUBP FP2 is lo

[PATCH 01/12] drm/amd/display: Do not set DRR on pipe commit

2023-02-03 Thread Qingqing Zhuo
From: Wesley Chalmers [WHY] Writing to DRR registers such as OTG_V_TOTAL_MIN on the same frame as a pipe commit can cause underflow. [HOW] Defer all DPP adjustment requests till optimized_required is false. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Wesley Chalmers --- driv

[PATCH 00/12] DC Patches Feb 6th, 2023

2023-02-03 Thread Qingqing Zhuo
This DC patchset brings improvements in multiple areas. In summary, we have: - DC 3.2.222 - FW 0.0.153.0 - Code re-organize for dc_link.c - Bug fixes on rotation, DRR and more - DCN314 domain power control moved to dmcub Cc: Daniel Wheeler --- Alvin Lee (1): drm/amd/display: Set max vratio

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Harry Wentland
On 2/3/23 10:19, Ville Syrjälä wrote: > On Fri, Feb 03, 2023 at 09:39:42AM -0500, Harry Wentland wrote: >> >> >> On 2/3/23 07:59, Sebastian Wick wrote: >>> On Fri, Feb 3, 2023 at 11:40 AM Ville Syrjälä >>> wrote: On Fri, Feb 03, 2023 at 02:07:44AM +, Joshua Ashton wrote: > Use

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Ville Syrjälä
On Fri, Feb 03, 2023 at 09:39:42AM -0500, Harry Wentland wrote: > > > On 2/3/23 07:59, Sebastian Wick wrote: > > On Fri, Feb 3, 2023 at 11:40 AM Ville Syrjälä > > wrote: > >> > >> On Fri, Feb 03, 2023 at 02:07:44AM +, Joshua Ashton wrote: > >>> Userspace has no way of controlling or knowing

Re: [PATCH v3 00/19] fix DRM_USE_DYNAMIC_DEBUG regression

2023-02-03 Thread Stanislaw Gruszka
On Fri, Feb 03, 2023 at 11:34:02AM +0200, Jani Nikula wrote: > On Wed, 25 Jan 2023, Jim Cromie wrote: > > Hi everyone, > > > > In v6.1 DRM_USE_DYNAMIC_DEBUG=y has a regression enabling drm.debug in > > drivers at modprobe. > > I realize we haven't actually addressed the regression in any way yet,

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Harry Wentland
On 2/2/23 21:07, Joshua Ashton wrote: > Userspace has no way of controlling or knowing the pixel encoding > currently, so there is no way for it to ever get the right values here. > > When we do add pixel_encoding control from userspace,we can pick the > right value for the colorimetry packet b

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Harry Wentland
On 2/3/23 07:59, Sebastian Wick wrote: > On Fri, Feb 3, 2023 at 11:40 AM Ville Syrjälä > wrote: >> >> On Fri, Feb 03, 2023 at 02:07:44AM +, Joshua Ashton wrote: >>> Userspace has no way of controlling or knowing the pixel encoding >>> currently, so there is no way for it to ever get the rig

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Ville Syrjälä
On Fri, Feb 03, 2023 at 02:52:50PM +0100, Sebastian Wick wrote: > On Fri, Feb 3, 2023 at 2:35 PM Ville Syrjälä > wrote: > > > > On Fri, Feb 03, 2023 at 01:59:07PM +0100, Sebastian Wick wrote: > > > On Fri, Feb 3, 2023 at 11:40 AM Ville Syrjälä > > > wrote: > > > > > > > > On Fri, Feb 03, 2023 at

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Sebastian Wick
On Fri, Feb 3, 2023 at 2:35 PM Ville Syrjälä wrote: > > On Fri, Feb 03, 2023 at 01:59:07PM +0100, Sebastian Wick wrote: > > On Fri, Feb 3, 2023 at 11:40 AM Ville Syrjälä > > wrote: > > > > > > On Fri, Feb 03, 2023 at 02:07:44AM +, Joshua Ashton wrote: > > > > Userspace has no way of controlli

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Ville Syrjälä
On Fri, Feb 03, 2023 at 01:59:07PM +0100, Sebastian Wick wrote: > On Fri, Feb 3, 2023 at 11:40 AM Ville Syrjälä > wrote: > > > > On Fri, Feb 03, 2023 at 02:07:44AM +, Joshua Ashton wrote: > > > Userspace has no way of controlling or knowing the pixel encoding > > > currently, so there is no wa

Re: [PATCH] drm/amdgpu: only WARN freeing buffers when DMA is unavailable

2023-02-03 Thread Christian König
Nope, that is not related to any hw state. It's simply not allowed to free up resources during suspend since those can't be acquired again during resume. We had a couple of cases now where this was wrong. If you get a warning from that please fix the code which tried to free something during

Re: [PATCH] drm/amd: fix memory leak in amdgpu_cs_sync_rings

2023-02-03 Thread Christian König
Am 02.02.23 um 20:02 schrieb Bert Karwatzki: I hope I got it right this time: Here is the fix for Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2360 From 6e064c9565ef0da890f3fcb2a4f6a8cd44a12fdb Mon Sep 17 00:00:00 2001 From: Bert Karwatzki Date: Thu, 2 Feb 2023 19:50:27 +0100 Subject:

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Sebastian Wick
On Fri, Feb 3, 2023 at 11:40 AM Ville Syrjälä wrote: > > On Fri, Feb 03, 2023 at 02:07:44AM +, Joshua Ashton wrote: > > Userspace has no way of controlling or knowing the pixel encoding > > currently, so there is no way for it to ever get the right values here. > > That applies to a lot of the

Re: [PATCH] drm/amd: fix memory leak in amdgpu_cs_sync_rings

2023-02-03 Thread Mikhail Gavrilov
On Fri, Feb 3, 2023 at 12:10 AM Bert Karwatzki wrote: > > I hope I got it right this time: > Here is the fix for > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2360 > > From 6e064c9565ef0da890f3fcb2a4f6a8cd44a12fdb Mon Sep 17 00:00:00 2001 > From: Bert Karwatzki > Date: Thu, 2 Feb 2023 19

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Ville Syrjälä
On Fri, Feb 03, 2023 at 02:07:44AM +, Joshua Ashton wrote: > Userspace has no way of controlling or knowing the pixel encoding > currently, so there is no way for it to ever get the right values here. That applies to a lot of the other values as well (they are explicitly RGB or YCC). The idea

Re: [PATCH v3 00/19] fix DRM_USE_DYNAMIC_DEBUG regression

2023-02-03 Thread Jani Nikula
On Wed, 25 Jan 2023, Jim Cromie wrote: > Hi everyone, > > In v6.1 DRM_USE_DYNAMIC_DEBUG=y has a regression enabling drm.debug in > drivers at modprobe. I realize we haven't actually addressed the regression in any way yet, and any distro enabling DYNAMIC_DEBUG || DYNAMIC_DEBUG_CORE will have DRM_

[PATCH] drm/amd/pm: add SMU 13.0.7 missing GetPptLimit message mapping

2023-02-03 Thread Evan Quan
Add missing GetPptLimit message mapping. Signed-off-by: Evan Quan Change-Id: Ic4edfa3153988721a6ee66dd69a1d4ca8a5ea45c --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c b/drivers/gpu/