Re: [PATCH] drm/amd/powerplay: Remove duplicate header

2019-01-30 Thread Deucher, Alexander
; Quan, Evan; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); airl...@linux.ie; Zhang, Hawking; Huang, Ray; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; linux-ker...@vger.kernel.org; Sabyasachi Gupta Subject: Re: [PATCH] drm/amd/powerplay: Remove duplicate header

Re: [PATCH] drm/amd/display: Fix fclk idle state

2019-01-29 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of roman...@amd.com Sent: Tuesday, January 29, 2019 3:16:53 PM To: amd-gfx@lists.freedesktop.org; Xu, Feifei; Quan, Evan Cc: Chan, Carl; Wentland, Harry; Li, Roman Subject: [PATCH] drm/amd/display: Fix fclk idle

Re: regression in dcn linked to -msse2

2019-01-29 Thread Deucher, Alexander
See: https://bugs.freedesktop.org/show_bug.cgi?id=109487 From: amd-gfx on behalf of StDenis, Tom Sent: Tuesday, January 29, 2019 8:44:03 AM To: Wentland, Harry; amd-gfx mailing list Cc: Deucher, Alexander Subject: regression in dcn linked to -msse2 Testing

Re: [PATCH 4/4] drm/amd/powerplay: support Vega12 retrieving and setting ppfeatures

2019-01-24 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Thursday, January 24, 2019 2:48:05 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH 4/4] drm/amd/powerplay: support Vega12 retrieving and setting ppfeatures

Re: [PATCH 2/2] drm/amd/powerplay: avoid frequent metrics table export

2019-01-24 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Thursday, January 24, 2019 5:59:18 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH 2/2] drm/amd/powerplay: avoid frequent metrics table export That's

Re: [PATCH 2/2] drm/amd/powerplay: run btc before enabling all SMU features

2019-01-21 Thread Deucher, Alexander
Series is: Acked-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Monday, January 21, 2019 4:46:07 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH 2/2] drm/amd/powerplay: run btc before enabling all SMU features BTC is needed

Re: [PATCH 2/2] drm/amdgpu: fix wrong APU judgement

2019-01-16 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Wednesday, January 16, 2019 1:16:15 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH 2/2] drm/amdgpu: fix wrong APU judgement Fix the APU judgement to make it

Re: [PATCH] drm/amd/display: eDP fast bootup does not work for pre-raven asic

2019-01-15 Thread Deucher, Alexander
So 95f05a3a2e6895ecfd8b4f64b5d6c6 is still valid even with your patch and we should keep it? Thanks Alex From: Wu, Hersen Sent: Tuesday, January 15, 2019 12:04:30 PM To: Alex Deucher Cc: Deucher, Alexander; Li, Sun peng (Leo); amd-gfx@lists.freedesktop.org

Re: [PATCH] drm/amd/display: eDP fast bootup does not work for pre-raven asic

2019-01-15 Thread Deucher, Alexander
Can this patch be reverted with this change? commit 95f05a3a2e6895ecfd8b4f64b5d6c6cf0b6a3f4a Author: Alex Deucher Date: Thu Aug 16 15:35:21 2018 -0500 drm/amdgpu/display: disable eDP fast boot optimization on DCE8 Seems to cause blank screens. Bug:

Re: [PATCH 4/4] drm/amd/powerplay: support retrieving and adjusting dcefclock power levels

2019-01-15 Thread Deucher, Alexander
Seems reasonable to me. With those changes, Reviewed-by: Alex Deucher From: Quan, Evan Sent: Tuesday, January 15, 2019 1:59:42 AM To: Alex Deucher Cc: amd-gfx list; Deucher, Alexander Subject: RE: [PATCH 4/4] drm/amd/powerplay: support retrieving and adjusting

Re: [PATCH] drm/amdgpu: Setting doorbell range registers earlier

2019-01-15 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Zeng, Oak Sent: Monday, January 14, 2019 5:39:41 PM To: amd-gfx@lists.freedesktop.org Cc: Zeng, Oak Subject: [PATCH] drm/amdgpu: Setting doorbell range registers earlier HW doorbell writing routing policy:

Re: [PATCH] Revert "drm/amdgpu: validate user pitch alignment"

2019-01-11 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Michel Dänzer Sent: Friday, January 11, 2019 10:22:07 AM To: amd-gfx@lists.freedesktop.org Cc: Yu Zhao Subject: [PATCH] Revert "drm/amdgpu: validate user pitch alignment" From: Michel Dänzer The check

Re: [PATCH 1/2] drm/amdgpu: Add NBIO SMN headers v2

2019-01-09 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Russell, Kent Sent: Wednesday, January 9, 2019 9:43:51 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH 1/2] drm/amdgpu: Add NBIO SMN headers v2 We need these offsets for

Re: [PATCH xf86-video-ati 1/2] Only call drmmode_uevent_init if RandR is enabled

2019-01-09 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Michel Dänzer Sent: Wednesday, January 9, 2019 5:43:22 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH xf86-video-ati 1/2] Only call drmmode_uevent_init if RandR is enabled From: Michel

Re: [PATCH 0/6] kexec fixes

2019-01-08 Thread Deucher, Alexander
Yes, the checks are taken from the existing SMU and PSP code. Alex From: Kuehling, Felix Sent: Tuesday, January 8, 2019 6:22:48 PM To: Alex Deucher; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH 0/6] kexec fixes Thanks for this. I

Re: [PATCH] drm/amdgpu: expose sclk and mclk via hwmon

2019-01-08 Thread Deucher, Alexander
Ping? Useful for rocm-smi? From: Alex Deucher Sent: Monday, December 10, 2018 4:17:27 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu: expose sclk and mclk via hwmon Expose sclk (gfx clock) and mclk (memory clock) via

Re: [PATCH] drm/amdgpu: Add message print when unable to get valid hive

2019-01-07 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Liu, Shaoyun Sent: Monday, January 7, 2019 11:01:51 AM To: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: Add message print when unable to get valid hive Ping ... -Original Message-

Re: [PATCH 2/2] drm/amd/powerplay: create pp_od_clk_voltage device file under OD support

2019-01-07 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Monday, January 7, 2019 7:05:56 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Quan, Evan; Freehill, Chris Subject: [PATCH 2/2] drm/amd/powerplay: create

Re: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed

2019-01-03 Thread Deucher, Alexander
This bug may also be related: https://bugs.freedesktop.org/show_bug.cgi?id=109206 Alex From: Koenig, Christian Sent: Thursday, January 3, 2019 10:57:50 AM To: Yu, Xiangliang; Xu, Feifei; amd-gfx@lists.freedesktop.org; Deucher, Alexander Subject: Re: [PATCH 2/2

Re: [PATCH 2/2] drm/amdgpu/psp: make get_fw_type and prep_cmd_buf to be common interfaces

2019-01-03 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Hawking Zhang Sent: Thursday, January 3, 2019 9:00:44 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: [PATCH 2/2] drm/amdgpu/psp: make get_fw_type and prep_cmd_buf to be common

Re: [PATCH] drm/amd/powerplay: hint and error out when prerequisite not meet

2019-01-03 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Thursday, January 3, 2019 1:06:56 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: hint and error out when prerequisite not meet Do not ignore the

Re: [PATCH] drm/amdgpu/sriov: For finishing routine send rel event after init failed

2019-01-03 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Emily Deng Sent: Wednesday, January 2, 2019 10:58:37 PM To: amd-gfx@lists.freedesktop.org Cc: Deng, Emily Subject: [PATCH] drm/amdgpu/sriov: For finishing routine send rel event after init failed When init

Re: [PATCH 2/2] drm/amdgpu: set the executable flag on unused Vega10 PTEs

2019-01-02 Thread Deucher, Alexander
Series is: Acked-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Wednesday, January 2, 2019 8:35:06 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 2/2] drm/amdgpu: set the executable flag on unused Vega10 PTEs Otherwise we run into a

Re: [PATCH] drm/amdgpu: distinguish early and late re-init log in sriov

2019-01-02 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of wentalou Sent: Wednesday, January 2, 2019 3:03:56 AM To: amd-gfx@lists.freedesktop.org Cc: Lou, Wentao Subject: [PATCH] drm/amdgpu: distinguish early and late re-init log in sriov distinguish

Re: [PATCH] drm/amdgpu/gfx_v8_0: Reorder the gfx, kiq and kcq rings test sequence

2018-12-28 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Zhou, Tiecheng Sent: Friday, December 28, 2018 12:36:17 AM To: Zhou, Tiecheng; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu/gfx_v8_0: Reorder the gfx, kiq and kcq rings test sequence Ping...

Re: [PATCH] drm/amd/powerplay: support BOOTUP_DEFAULT power profile mode

2018-12-27 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Thursday, December 27, 2018 2:50:38 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: support BOOTUP_DEFAULT power profile mode This can avoid unexpected

Re: [PATCH] drm/amdgpu/gmc: fix compiler errors [-Werror,-Wmissing-braces]

2018-12-20 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of S, Shirish Sent: Thursday, December 20, 2018 9:01:33 AM To: Li, Sun peng (Leo); Wentland, Harry; Deucher, Alexander; Koenig, Christian Cc: amd-gfx@lists.freedesktop.org; S, Shirish Subject: [PATCH] drm

Re: [PATCH] drm/amd/display: fix compliler errors [-Werror,-Wmissing-braces]

2018-12-20 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of S, Shirish Sent: Thursday, December 20, 2018 9:01:04 AM To: Li, Sun peng (Leo); Wentland, Harry; Deucher, Alexander; Koenig, Christian Cc: amd-gfx@lists.freedesktop.org; S, Shirish Subject: [PATCH] drm/amd

Re: [PATCH] drm/amd/display: Fix MST dp_blank REG_WAIT timeout

2018-12-19 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Harry Wentland Sent: Wednesday, December 19, 2018 2:14:11 PM To: amd-gfx@lists.freedesktop.org Cc: Zuo, Jerry Subject: [PATCH] drm/amd/display: Fix MST dp_blank REG_WAIT timeout From: "Jerry (Fangzhi) Zuo"

Re: Powerplay clock information missing on Polaris 12 (msi RX550 LP OC) on armhf

2018-12-19 Thread Deucher, Alexander
Those messages are harmless and can be ignored. I think they have been removed in newer kernels. Alex From: amd-gfx on behalf of Luís Mendes Sent: Wednesday, December 19, 2018 12:31:44 PM To: Koenig, Christian; amd-gfx list Subject: Powerplay clock

Re: [PATCH] drm/amd/display: Use div_u64 for flip timestamp ns to ms

2018-12-19 Thread Deucher, Alexander
Could also use do_div. Either way: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Nicholas Kazlauskas Sent: Wednesday, December 19, 2018 9:12:09 AM To: amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo); Wentland, Harry; Kazlauskas, Nicholas Subject:

Re: [PATCH] drm/amdgpu/uvd:Change uvd ring name convention

2018-12-18 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Zhu, James Sent: Tuesday, December 18, 2018 4:07:21 PM To: amd-gfx@lists.freedesktop.org Cc: jzh...@gmail.com Subject: [PATCH] drm/amdgpu/uvd:Change uvd ring name convention Since umr tool can't handle

Re: [PATCH] drm/amdgpu: correct the return value for error case

2018-12-17 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Monday, December 17, 2018 4:59:02 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amdgpu: correct the return value for error case It should not return 0 for error

Re: [PATCH 1/1] drm/amdkfd: Fix handling of return code of dma_buf_get

2018-12-14 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Kuehling, Felix Sent: Friday, December 14, 2018 2:05:11 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix Subject: [PATCH 1/1] drm/amdkfd: Fix handling of return code of dma_buf_get On errors,

Re: [PATCH] drm/amdgpu: fix IH overflow on Vega10

2018-12-14 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: Christian König Sent: Friday, December 14, 2018 9:37:23 AM To: Deucher, Alexander; alexdeuc...@gmail.com; amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: fix IH overflow on Vega10 When an ring buffer overflow happens

Re: [PATCH] drm/amdgpu: WARN once if amdgpu_bo_unpin is called for an unpinned BO

2018-12-13 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Michel Dänzer Sent: Thursday, December 13, 2018 11:06:35 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: WARN once if amdgpu_bo_unpin is called for an unpinned BO From: Michel Dänzer It

Re: [PATCH] drm/amdgpu: unify Vega20 PSP SOS firmwares for A0 and A1

2018-12-13 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Thursday, December 13, 2018 1:14:51 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amdgpu: unify Vega20 PSP SOS firmwares for A0 and A1 The new PSP SOS firmware can

Re: [PATCH libdrm] tests/amdgpu/vcn: fix the nop command in IBs

2018-12-11 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Liu, Leo Sent: Tuesday, December 11, 2018 4:03 PM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: Liu, Leo Subject: [PATCH libdrm] tests/amdgpu/vcn: fix the nop command in IBs Just

Re: [PATCH] drm/amdgpu: Enable GPU recovery by default for CI

2018-12-11 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Andrey Grodzovsky Sent: Tuesday, December 11, 2018 3:35:16 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Grodzovsky, Andrey Subject: [PATCH] drm/amdgpu: Enable GPU recovery by default for CI

Re: [PATCH] drm/amdgpu:skip ASIC_INIT when posting card on vg20

2018-12-10 Thread Deucher, Alexander
vbios asic init will still work. It will wait on the psp init so I'd suggest we just drop this patch to keep the code consistent. There are also possibly some registers that are handled by vbios asic init rather than psp. Alex From: amd-gfx on behalf of

Re: [PATCH 1/2] drm/amdkfd: add new vega10 pci ids

2018-12-07 Thread Deucher, Alexander
Care to review the amdgpu series as well? From: amd-gfx on behalf of Kuehling, Felix Sent: Friday, December 7, 2018 4:38:20 PM To: Alex Deucher; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; sta...@vger.kernel.org Subject: Re: [PATCH 1/2] drm/amdkfd

Re: [PATCH] drm/amdgpu: Workaround build failure due to trace conflict

2018-12-07 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Kuehling, Felix Sent: Friday, December 7, 2018 5:07 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix Subject: [PATCH] drm/amdgpu: Workaround build failure due to trace conflict Avoid including

Re: [PATCH 1/2] drm/amdgpu: add some additional vega10 pci ids

2018-12-07 Thread Deucher, Alexander
Will do. Alex From: Kuehling, Felix Sent: Friday, December 7, 2018 4:14:39 PM To: Alex Deucher; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; sta...@vger.kernel.org Subject: Re: [PATCH 1/2] drm/amdgpu: add some additional vega10 pci ids Can you add them

Re: [PATCH] Revert "drm/amd/display: Set RMX_ASPECT as default"

2018-12-07 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Nicholas Kazlauskas Sent: Friday, December 7, 2018 12:15:01 PM To: amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo); Wentland, Harry; Lakha, Bhawanpreet; Kazlauskas, Nicholas Subject: [PATCH] Revert

Re: [PATCH 1/2] drm/amdgpu: update SMC firmware image for polaris10 variants

2018-12-07 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Junwei Zhang Sent: Friday, December 7, 2018 2:19:51 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jerry Subject: [PATCH 1/2] drm/amdgpu: update SMC firmware image for polaris10 variants Some

Re: [PATCH v2] drm/amdgpu/powerplay: Apply avfs cks-off voltages on VI

2018-12-07 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Kenneth Feng Sent: Friday, December 7, 2018 1:13:20 AM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH v2] drm/amdgpu/powerplay: Apply avfs cks-off voltages on VI Instead of EVV cks-off

Re: [PATCH] drm/amd/powerplay: rv dal-pplib interface refactor powerplay part

2018-12-05 Thread Deucher, Alexander
Looks reasonable to me. Acked-by: Alex Deucher From: Wu, Hersen Sent: Wednesday, December 5, 2018 1:03:57 PM To: amd-gfx@lists.freedesktop.org; Zhu, Rex; Deucher, Alexander Subject: RE: [PATCH] drm/amd/powerplay: rv dal-pplib interface refactor powerplay part

Re: [PATCH 3/3] drm/amdgpu/psp: Destroy psp ring when doing gpu reset

2018-12-05 Thread Deucher, Alexander
Series is: Acked-by: Alex Deucher From: amd-gfx on behalf of Xiangliang Yu Sent: Wednesday, December 5, 2018 1:46:31 AM To: amd-gfx@lists.freedesktop.org Cc: Min, Frank; Yu, Xiangliang Subject: [PATCH 3/3] drm/amdgpu/psp: Destroy psp ring when doing gpu reset

Re: [PATCH] drm/amdgpu: Update XGMI node print

2018-12-03 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Andrey Grodzovsky Sent: Monday, December 3, 2018 3:03:41 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Grodzovsky, Andrey Subject: [PATCH] drm/amdgpu: Update XGMI node print

Re: [PATCH v3 3/3] drm/amdgpu: Implement concurrent asic reset for XGMI.

2018-12-03 Thread Deucher, Alexander
Patches 1, 2: Reviewed-by: Alex Deucher Patch 3: Acked-by: Alex Deucher From: amd-gfx on behalf of Andrey Grodzovsky Sent: Friday, November 30, 2018 4:41:10 PM To: amd-gfx@lists.freedesktop.org; Deucher, Alexander; Wang, Ken; ckoenig.leichtzumer

Re: [PATCH] drm/amdgpu: Fix num_doorbell calculation issue

2018-11-30 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Oak Zeng Sent: Friday, November 30, 2018 10:39:21 AM To: amd-gfx@lists.freedesktop.org Cc: Yang, Philip; Zeng, Oak; Yin, Tianci (Rico) Subject: [PATCH] drm/amdgpu: Fix num_doorbell calculation issue When

Re: [PATCH] drm/amd/display: Fix NULL ptr deref for commit_planes_to_stream

2018-11-30 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Nicholas Kazlauskas Sent: Friday, November 30, 2018 10:09:28 AM To: amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo); Wentland, Harry; Kazlauskas, Nicholas Subject: [PATCH] drm/amd/display: Fix NULL ptr

Re: [PATCH] drm/amdgpu: remove amdgpu_bo_backup_to_shadow

2018-11-30 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Friday, November 30, 2018 7:45:17 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: remove amdgpu_bo_backup_to_shadow It is unused. Signed-off-by: Christian König ---

Re: [PATCH 09/16] drm/amd/display: fbc state could not reach while enable fbc

2018-11-29 Thread Deucher, Alexander
Do you think this will fix this bug? https://bugs.freedesktop.org/show_bug.cgi?id=108577 If so, we can re-enable fbc. Alex From: amd-gfx on behalf of sunpeng...@amd.com Sent: Thursday, November 29, 2018 10:52:16 AM To: amd-gfx@lists.freedesktop.org Cc: Wu,

Re: [PATCH] drm/ttm: fix LRU handling in ttm_buffer_object_transfer

2018-11-29 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Thursday, November 29, 2018 11:20:12 AM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: mar...@gmail.com Subject: [PATCH] drm/ttm: fix LRU handling in

Re: [PATCH] drm/amd/display: Fix unintialized max_bpc state values

2018-11-29 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Nicholas Kazlauskas Sent: Thursday, November 29, 2018 10:44:46 AM To: amd-gfx@lists.freedesktop.org Cc: Kazlauskas, Nicholas Subject: [PATCH] drm/amd/display: Fix unintialized max_bpc state values [Why] If

Re: [PATCH] drm/amdgpu: disable UVD/VCE for some polaris 12 variants

2018-11-28 Thread Deucher, Alexander
11/26/18 5:28 PM, Christian König wrote: >> >> Am 26.11.18 um 03:38 schrieb Zhang, Jerry(Junwei): >> >> On 11/24/18 3:32 AM, Deucher, Alexander wrote: >> >> Is this required? Are the harvesting fuses incorrect? If the blocks are >> harvested, we should ba

Re: [PATCH] drm/amd/display: Fix compile error with ACPI disabled

2018-11-27 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of David Francis Sent: Tuesday, November 27, 2018 11:18:14 AM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: Francis, David Subject: [PATCH] drm/amd/display: Fix compile error with ACPI

Re: [PATCH] drm/amd/display: limit high pixel clock modes on ST/CZ

2018-11-27 Thread Deucher, Alexander
Is this a DP to HDMI adapter? I think 4k@60 should be valid on DP in general on ST/CZ, but Harry or Leo should comment. Alex From: S, Shirish Sent: Tuesday, November 27, 2018 3:58:12 AM To: Deucher, Alexander; Li, Sun peng (Leo); Wentland, Harry Cc: amd-gfx

Re: [PATCH 4/7] drm/amdgpu: Doorbell index initialization for ASICs before vega10

2018-11-26 Thread Deucher, Alexander
Correct. SI does not use doorbells. Alex From: amd-gfx on behalf of Zeng, Oak Sent: Monday, November 26, 2018 12:20:10 PM To: Alex Deucher Cc: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 4/7] drm/amdgpu: Doorbell index initialization for ASICs before

Re: [PATCH 5/7] drm/amdgpu: Call doorbell index init on device initialization

2018-11-26 Thread Deucher, Alexander
Maybe it would be better to add this as a callback to struct amdgpu_asic_funcs to avoid adding asic specific code to amdgpu_device.c Alex From: amd-gfx on behalf of Deucher, Alexander Sent: Monday, November 26, 2018 10:59:02 AM To: Zeng, Oak; Alex Deucher Cc

Re: [PATCH 5/7] drm/amdgpu: Call doorbell index init on device initialization

2018-11-26 Thread Deucher, Alexander
Ah, ok. no problem. Alex From: amd-gfx on behalf of Zeng, Oak Sent: Monday, November 26, 2018 10:31:04 AM To: Alex Deucher Cc: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 5/7] drm/amdgpu: Call doorbell index init on device initialization Yes, that

Re: [PATCH] drm/amd/display: limit high pixel clock modes on ST/CZ

2018-11-26 Thread Deucher, Alexander
I thought there was a patch to do this already that got sent out a few weeks ago. Basically limit ST/CZ to modes that do not require a retimer. Is an additional patch needed? Alex From: amd-gfx on behalf of S, Shirish Sent: Monday, November 26, 2018

Re: [PATCH] drm/amdgpu: Moved doorbell structures to seperate file

2018-11-25 Thread Deucher, Alexander
Fwded. You can also see the archives here: https://lists.freedesktop.org/archives/amd-gfx/2018-November/028781.html Alex From: Zeng, Oak Sent: Friday, November 23, 2018 6:18:55 PM To: Deucher, Alexander; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm

Re: [PATCH] drm/amdgpu: Moved doorbell structures to seperate file

2018-11-23 Thread Deucher, Alexander
Did you see my other comments about consolidating vega10, raven, and vega12? Reviewed-by: Alex Deucher From: amd-gfx on behalf of Oak Zeng Sent: Friday, November 23, 2018 3:01:23 PM To: amd-gfx@lists.freedesktop.org Cc: Zeng, Oak Subject: [PATCH] drm/amdgpu:

Re: [PATCH] drm: should break if already get the best size

2018-11-23 Thread Deucher, Alexander
Please add a proper patch description. Alex From: amd-gfx on behalf of Zhu, Rex Sent: Friday, November 23, 2018 4:44:31 AM To: Liu, Monk; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm: should break if already get the best size Tested-by: Rex Zhu

Re: [PATCH] drm/amdgpu: disable UVD/VCE for some polaris 12 variants

2018-11-23 Thread Deucher, Alexander
Is this required? Are the harvesting fuses incorrect? If the blocks are harvested, we should bail out of the blocks properly during init. Also, please make this more explicit if we still need it. E.g., if ((adev->pdev->device == 0x67df) && (adev->pdev->revision ==

Re: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and future asic

2018-11-23 Thread Deucher, Alexander
The main idea is to be able to use different layouts on different asics that may share the same IP code. Alex From: amd-gfx on behalf of Christian K?nig Sent: Thursday, November 22, 2018 4:26:53 AM To: Alex Deucher; Zeng, Oak Cc: amd-gfx list Subject: Re:

Re: [PATCH] drm/amdgpu: disable page queue support for Vega20

2018-11-21 Thread Deucher, Alexander
Do we need this for vega12 as well? From: amd-gfx on behalf of Alex Deucher Sent: Wednesday, November 21, 2018 2:25:06 AM To: Quan, Evan Cc: amd-gfx list Subject: Re: [PATCH] drm/amdgpu: disable page queue support for Vega20 Reviewed-by: Alex Deucher On Wed,

RE: [PATCH 3/3] drm/amdgpu: enable paging queue based on FW version

2018-11-19 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx On Behalf Of > Yang, Philip > Sent: Monday, November 19, 2018 3:20 PM > To: amd-gfx@lists.freedesktop.org > Cc: Yang, Philip > Subject: [PATCH 3/3] drm/amdgpu: enable paging queue based on FW > version > > Based SDMA fw version to enable

Re: [PATCH 1/3] drm/amdgpu: fix typo in function sdma_v4_0_page_resume

2018-11-19 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Yang, Philip Sent: Monday, November 19, 2018 3:20:00 PM To: amd-gfx@lists.freedesktop.org Cc: Yang, Philip Subject: [PATCH 1/3] drm/amdgpu: fix typo in function sdma_v4_0_page_resume This looks like copy

Re: [PATCH v2 3/3] drm/amd:Enable/Disable NBPSTATE on On/OFF of UVD

2018-11-16 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Guttula, Suresh Sent: Friday, November 16, 2018 1:50:37 AM To: amd-gfx@lists.freedesktop.org Cc: Sharma, Deepak; Guttula, Suresh; Agrawal, Akshu Subject: [PATCH v2 3/3] drm/amd:Enable/Disable

Re: [PATCH] drm/amdgpu: Fix oops when pp_funcs->switch_power_profile is unset

2018-11-15 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Kuehling, Felix Sent: Thursday, November 15, 2018 4:56:51 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix; Joerg Roedel Subject: [PATCH] drm/amdgpu: Fix oops when pp_funcs->switch_power_profile is

Re: [PATCH] drm/amdgpu : Use XGMI mapping when devices on the same hive v2

2018-11-15 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Russell, Kent Sent: Thursday, November 15, 2018 11:54:27 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent; Liu, Shaoyun Subject: [PATCH] drm/amdgpu : Use XGMI mapping when devices on the same hive v2

Re: [PATCH] drm/amdgpu: fix bug with IH ring setup

2018-11-12 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Yang, Philip Sent: Monday, November 12, 2018 2:20 PM To: amd-gfx@lists.freedesktop.org Cc: Yang, Philip Subject: [PATCH] drm/amdgpu: fix bug with IH ring setup The bug limits the IH ring wptr address to

Re: [PATCH 1/2] drm/amdgpu: Add "max_bpc" connector property

2018-11-07 Thread Deucher, Alexander
FWIW there is a common property patch: https://patchwork.kernel.org/patch/10606697/ When should try and be compatible so we can transition. Alex From: amd-gfx on behalf of Nicholas Kazlauskas Sent: Wednesday, November 7, 2018 9:56:54 AM To:

Re: [PATCH] drm/amd/powerplay: correct code style

2018-11-07 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Jim Qu Sent: Wednesday, November 7, 2018 5:42:12 AM To: amd-gfx@lists.freedesktop.org Cc: Qu, Jim Subject: [PATCH] drm/amd/powerplay: correct code style Change-Id: I844949ae1738adae3dfad431a270913d04832f56

Re: [PATCH] drm/amd: Don't fail on backlight = 0

2018-11-06 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of David Francis Sent: Tuesday, November 6, 2018 11:14:46 AM To: amd-gfx@lists.freedesktop.org Cc: Francis, David; samant...@posteo.net; Wentland, Harry; Guttula, Suresh Subject: [PATCH] drm/amd: Don't fail on

RE: [PATCH 1/2] drm/amdgpu: Drop amdgpu_plane

2018-11-05 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx On Behalf Of > Harry Wentland > Sent: Monday, November 5, 2018 3:45 PM > To: amd-gfx@lists.freedesktop.org > Cc: Wentland, Harry > Subject: [PATCH 1/2] drm/amdgpu: Drop amdgpu_plane > > It's unnecessarily duplicating drm_plane_type. > >

RE: [PATCH 2/2] drm/amd/display: Stop leaking planes

2018-11-05 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx On Behalf Of > Harry Wentland > Sent: Monday, November 5, 2018 3:45 PM > To: amd-gfx@lists.freedesktop.org > Cc: Wentland, Harry > Subject: [PATCH 2/2] drm/amd/display: Stop leaking planes > > [Why] > drm_plane_cleanup does not free the plane. > >

Re: [PATCH] drm/amdkfd: fix interrupt spin lock

2018-11-02 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Friday, November 2, 2018 9:48:07 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdkfd: fix interrupt spin lock Vega10 has multiple interrupt rings, so this can be called from

Re: [PATCH] drm/amd: Update atom_smu_info_v3_3 structure

2018-11-02 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of sunpeng...@amd.com Sent: Friday, November 2, 2018 9:29:24 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Li, Sun peng (Leo); Wentland, Harry Subject: [PATCH] drm/amd: Update atom_smu_info_v3_3

Re: [PATCH] drm/amd/powerplay: do the comparison in the right Khz granularity

2018-11-01 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Thursday, November 1, 2018 3:16:38 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: do the comparison in the right Khz granularity Convert the operands

RE: [PATCH] drm/amdgpu: Expose an IP function to get register offset

2018-10-30 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx On Behalf Of Oak > Zeng > Sent: Tuesday, October 30, 2018 4:41 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zeng, Oak > Subject: [PATCH] drm/amdgpu: Expose an IP function to get register offset > > Expose get_reg_offset function of sdma_v4_0 for kfd

Re: [PATCH 4/4] drm/amdgpu: drop the remaining uses of ring idx in messages

2018-10-30 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Tuesday, October 30, 2018 8:17:53 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 4/4] drm/amdgpu: drop the remaining uses of ring idx in messages Consistently use the

Re: [PATCH libdrm] amdgpu: add VM test to exercise max/min address space

2018-10-26 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Friday, October 26, 2018 6:59:21 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH libdrm] amdgpu: add VM test to exercise max/min address space Make sure the kernel doesn't crash

Re: [PATCH] drm/amdgpu: fix VM leaf walking

2018-10-25 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Thursday, October 25, 2018 10:38 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: fix VM leaf walking Make sure we don't try to go down further after the leave walk

Re: [PATCH] drm/amdgpu: revert "enable gfxoff in non-sriov and stutter mode by default"

2018-10-24 Thread Deucher, Alexander
Is it gfx off or stutter mode that causes the problem for you? Can you narrow it down? Alex From: amd-gfx on behalf of Christian König Sent: Wednesday, October 24, 2018 8:59:10 AM To: Feng, Kenneth; amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu:

Re: [PATCH] drm/amd/pp: Fix pp_sclk/mclk_od not work on smu7

2018-10-24 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Rex Zhu Sent: Wednesday, October 24, 2018 10:55:08 AM To: amd-gfx@lists.freedesktop.org; Russell, Kent Cc: Zhu, Rex Subject: [PATCH] drm/amd/pp: Fix pp_sclk/mclk_od not work on smu7 not update the dpm table

Re: [PATCH 2/2] drm/amdkfd: Use functions from amdgpu to invalidate vmid in kfd

2018-10-23 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: Zhao, Yong Sent: Tuesday, October 23, 2018 2:15:59 PM To: brahma_sw_dev; amd-gfx@lists.freedesktop.org Cc: Zhao, Yong Subject: [PATCH 2/2] drm/amdkfd: Use functions from amdgpu to invalidate vmid in kfd As part of the

Re: [PATCH] drm/amdgpu: Fix amdgpu_vm_alloc_pts failed

2018-10-22 Thread Deucher, Alexander
This re-introduces a 64 division that is not handled correctly with the % operator. Alex From: amd-gfx on behalf of Rex Zhu Sent: Monday, October 22, 2018 12:09:21 PM To: amd-gfx@lists.freedesktop.org; Koenig, Christian Cc: Zhu, Rex Subject: [PATCH]

Re: [PATCH] drm/amdgpu: disable SDMA page queue on Vega20

2018-10-21 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Sunday, October 21, 2018 10:39:38 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Xu, Feifei; Kuehling, Felix; Quan, Evan; Koenig, Christian Subject: [PATCH] drm/amdgpu: disable

Re: [PATCH] drm/amdgpu: fix sdma v4 ring is disabled accidently

2018-10-19 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Yang, Philip Sent: Friday, October 19, 2018 3:13:56 PM To: amd-gfx@lists.freedesktop.org Cc: Yang, Philip Subject: [PATCH] drm/amdgpu: fix sdma v4 ring is disabled accidently For sdma v4, there is bug

Re: [PATCH 3/3] drm/amdkfd: Use functions from amdgpu for setting up page table base

2018-10-18 Thread Deucher, Alexander
Please include a patch description on 2 and 3, with that fixed, series is: Reviewed-by: Alex Deucher From: Zhao, Yong Sent: Thursday, October 18, 2018 5:13:04 PM To: amd-gfx@lists.freedesktop.org; brahma_sw_dev Cc: Zhao, Yong Subject: [PATCH 3/3] drm/amdkfd: Use

Re: [PATCH 3/3] drm/amdkfd: Add proper prefix to functions

2018-10-18 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Lin, Amber Sent: Thursday, October 18, 2018 5:15:24 PM To: amd-gfx@lists.freedesktop.org Cc: Lin, Amber Subject: [PATCH 3/3] drm/amdkfd: Add proper prefix to functions Add amdgpu_amdkfd_ prefix

Re: [PATCH v2] drm/amd/pp: enable power limit increase in OD mode

2018-10-18 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Greathouse, Joseph Sent: Thursday, October 18, 2018 3:44:39 PM To: amd-gfx@lists.freedesktop.org Cc: Greathouse, Joseph Subject: [PATCH v2] drm/amd/pp: enable power limit increase in OD mode OverDrive mode

Re: [PATCH xf86-video-ati] dri3: Handle radeon_get_pixmap_bo returning NULL

2018-10-18 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Michel Dänzer Sent: Thursday, October 18, 2018 4:13:58 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH xf86-video-ati] dri3: Handle radeon_get_pixmap_bo returning NULL From: Michel Dänzer We were

Re: regression on RV1

2018-10-17 Thread Deucher, Alexander
I think something like this should fix it. Alex From: amd-gfx on behalf of Deucher, Alexander Sent: Wednesday, October 17, 2018 12:15:21 PM To: StDenis, Tom; Koenig, Christian; amd-gfx mailing list Cc: Huang, Ray Subject: Re: regression on RV1 IIRC, APUs do

Re: regression on RV1

2018-10-17 Thread Deucher, Alexander
IIRC, APUs do not have a paging queue. Only dGPUs have it. Alex From: amd-gfx on behalf of StDenis, Tom Sent: Wednesday, October 17, 2018 11:54:33 AM To: Koenig, Christian; amd-gfx mailing list Cc: Huang, Ray Subject: regression on RV1 This commit: commit

Re: [PATCH] drm/amd/powerplay: error out when force clock level under auto dpm mode V2

2018-10-17 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: Evan Quan Sent: Wednesday, October 17, 2018 5:21:54 AM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex; Deucher, Alexander; Quan, Evan Subject: [PATCH] drm/amd/powerplay: error out when force clock level under auto dpm mode V2

<    5   6   7   8   9   10   11   12   13   14   >