RE: [PATCH] drm/amdgpu: Add lock around VF RLCG interface

2024-05-28 Thread Luo, Zhigang
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Zhigang Luo -Original Message- From: Skvortsov, Victor Sent: Monday, May 27, 2024 4:19 PM To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Lazar, Lijo ; Luo, Zhigang Cc: Skvortsov, Victor Subject: [PATCH] drm

RE: [PATCH 2/2] drm/amdgpu: Queue KFD reset workitem in VF FED

2024-05-19 Thread Luo, Zhigang
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Zhigang Luo -Original Message- From: amd-gfx On Behalf Of Victor Skvortsov Sent: Sunday, May 19, 2024 10:52 AM To: amd-gfx@lists.freedesktop.org Cc: Skvortsov, Victor Subject: [PATCH 2/2] drm/amdgpu: Queue KFD

RE: [PATCH 1/2] drm/amdgpu: Extend KIQ reg polling wait for VF

2024-05-19 Thread Luo, Zhigang
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Zhigang Luo -Original Message- From: amd-gfx On Behalf Of Victor Skvortsov Sent: Sunday, May 19, 2024 10:52 AM To: amd-gfx@lists.freedesktop.org Cc: Skvortsov, Victor Subject: [PATCH 1/2] drm/amdgpu: Extend KIQ reg

RE: [PATCH 4/4] drm/amdgpu: Move ras resume into SRIOV function

2024-04-30 Thread Luo, Zhigang
[AMD Official Use Only - General] Reviewed-by: Zhigang Luo -Original Message- From: amd-gfx On Behalf Of Yunxiang Li Sent: Thursday, April 25, 2024 11:58 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Lazar, Lijo ; Kuehling, Felix ; Deng, Emily ;

RE: [PATCH v4 2/4] drm/amdgpu: Add reset_context flag for host FLR

2024-04-30 Thread Luo, Zhigang
[AMD Official Use Only - General] Reviewed-by: Zhigang Luo -Original Message- From: amd-gfx On Behalf Of Yunxiang Li Sent: Friday, April 26, 2024 2:27 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Lazar, Lijo ; Kuehling, Felix ; Deng, Emily ; Li,

RE: [PATCH v2 3/4] drm/amdgpu: Fix amdgpu_device_reset_sriov retry logic

2024-04-30 Thread Luo, Zhigang
[AMD Official Use Only - General] Reviewed-by: Zhigang Luo -Original Message- From: amd-gfx On Behalf Of Yunxiang Li Sent: Friday, April 26, 2024 2:29 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Lazar, Lijo ; Kuehling, Felix ; Deng, Emily ; Li,

RE: [PATCH 1/3] amd/amdkfd: add a function to wait no process running in kfd

2024-03-25 Thread Luo, Zhigang
check if kfd_processes_table is empty. Thanks, Zhigang -Original Message- From: Joshi, Mukul Sent: Monday, March 25, 2024 12:08 PM To: Luo, Zhigang ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Saye, Sashank ; Chan, Hing Pong ; Yang, Philip ; Lazar, Lijo ; Luo, Zhigang Subject

RE: [PATCH] drm/amdgpu: Skip virt_exchange_init on SDMA poison consumption

2024-03-14 Thread Luo, Zhigang
[AMD Official Use Only - General] Reviewed-by: Zhigang Luo -Original Message- From: Skvortsov, Victor Sent: Tuesday, March 12, 2024 10:09 PM To: Skvortsov, Victor ; Chai, Thomas ; Zhang, Hawking ; Luo, Zhigang ; amd-gfx@lists.freedesktop.org Cc: Skvortsov, Victor Subject: [PATCH

RE: [PATCH] drm/amdgpu/: Remove bo_create_kernel_at path from virt page

2024-03-14 Thread Luo, Zhigang
[AMD Official Use Only - General] Reviewed-by: Zhigang Luo -Original Message- From: Skvortsov, Victor Sent: Tuesday, March 12, 2024 1:51 PM To: Skvortsov, Victor ; Luo, Zhigang ; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian Subject: [PATCH] drm/amdgpu/: Remove

RE: [PATCH 2/4] drm/amdgpu: Do not program SQ_TIMEOUT_CONFIG in SRIOV

2024-02-23 Thread Luo, Zhigang
[AMD Official Use Only - General] Reviewed By Zhigang Luo mailto:zhigang@amd.com>> From: Lu, Victor Cheng Chi (Victor) Sent: Friday, February 16, 2024 1:50 PM To: Luo, Zhigang Subject: Fw: [PATCH 2/4] drm/amdgpu: Do not program SQ_TIMEOUT_CONFIG in SRIOV [AMD Official Use Only - G

RE: [PATCH 3/4] drm/amdgpu: Use correct SRIOV macro for gmc_v9_0_vm_fault_interrupt_state

2024-02-16 Thread Luo, Zhigang
[AMD Official Use Only - General] Reviewed By Zhigang Luo From: Lu, Victor Cheng Chi (Victor) Sent: Friday, February 16, 2024 1:50 PM To: Luo, Zhigang Subject: Fw: [PATCH 3/4] drm/amdgpu: Use correct SRIOV macro for gmc_v9_0_vm_fault_interrupt_state [AMD Official Use Only - General

RE: [PATCH] drm/amdgpu: xgmi_fill_topology_info

2023-12-08 Thread Luo, Zhigang
[AMD Official Use Only - General] Reviewed-by: Zhigang Luo -Original Message- From: Chander, Vignesh Sent: Thursday, December 7, 2023 7:42 PM To: amd-gfx@lists.freedesktop.org Cc: Lazar, Lijo ; Luo, Zhigang ; Kim, Jonathan ; Chander, Vignesh Subject: [PATCH] drm/amdgpu

RE: [PATCH] drm/amdgpu/jpeg - skip change of power-gating state for sriov

2023-08-17 Thread Luo, Zhigang
[AMD Official Use Only - General] Reviewed-by: Zhigang Luo -Original Message- From: Dhume, Samir Sent: Wednesday, August 16, 2023 9:20 PM To: amd-gfx@lists.freedesktop.org Cc: Luo, Zhigang ; Liu, Leo ; Deucher, Alexander ; Dhume, Samir Subject: [PATCH] drm/amdgpu/jpeg - skip change

RE: [PATCH v3] drm/amdgpu: Add RLCG interface driver implementation for gfx v9.4.3 (v3)

2023-07-11 Thread Luo, Zhigang
[AMD Official Use Only - General] Reviewed-by: Zhigang Luo -Original Message- From: Lu, Victor Cheng Chi (Victor) Sent: Tuesday, July 11, 2023 10:18 AM To: amd-gfx@lists.freedesktop.org Cc: Skvortsov, Victor ; Ming, Davis ; Luo, Zhigang ; Lu, Victor Cheng Chi (Victor) Subject

RE: [PATCH 1/4] drm/amdgpu: skip reset other device in the same hive if it's SRIOV VF

2021-12-07 Thread Luo, Zhigang
[AMD Official Use Only] Shaoyun, please see my comments inline. Thanks, Zhigang -Original Message- From: Liu, Shaoyun Sent: December 7, 2021 2:15 PM To: Luo, Zhigang ; amd-gfx@lists.freedesktop.org Cc: Luo, Zhigang Subject: RE: [PATCH 1/4] drm/amdgpu: skip reset other device

RE: [PATCH] drm/amdgpu: correct MMSCH version

2021-08-16 Thread Luo, Zhigang
Message- From: Liu, Shaoyun Sent: August 16, 2021 10:49 AM To: Luo, Zhigang ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: correct MMSCH version [AMD Official Use Only] Is that information from MM team ? Please make sure it won't break the ASICs that use the same code path

RE: [PATCH 4/5] drm/amdgpu: add psp microcode init for arcturus and aldebaran sriov vf

2021-06-07 Thread Luo, Zhigang
[Public] Okay. I will update the change as you suggested. Thanks, Zhigang -Original Message- From: Zhang, Hawking Sent: June 7, 2021 9:52 AM To: Luo, Zhigang ; Liu, Shaoyun ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 4/5] drm/amdgpu: add psp microcode init for arcturus

RE: [PATCH 1/5] drm/amdgpu: remove sriov vf checking from getting fb location

2021-06-04 Thread Luo, Zhigang
Sent: June 4, 2021 9:46 AM To: Luo, Zhigang ; Deng, Emily ; Liu, Shaoyun ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/5] drm/amdgpu: remove sriov vf checking from getting fb location Well, but are you the one defining the compatibility policy? See usually Linux kernel code compatibility

RE: [PATCH 1/5] drm/amdgpu: remove sriov vf checking from getting fb location

2021-06-04 Thread Luo, Zhigang
, Zhigang -Original Message- From: Christian König Sent: June 4, 2021 7:14 AM To: Deng, Emily ; Liu, Shaoyun ; Luo, Zhigang ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/5] drm/amdgpu: remove sriov vf checking from getting fb location I was just about to question the same thing

RE: [PATCH 5/5] drm/amdgpu: allocate psp fw private buffer from VRAM for sriov vf

2021-06-03 Thread Luo, Zhigang
All new PSP release will have this feature. And it will not cause any failure even the PSP doesn't have this feature yet. Thanks, Zhigang -Original Message- From: Liu, Shaoyun Sent: June 3, 2021 11:15 AM To: Luo, Zhigang ; amd-gfx@lists.freedesktop.org Cc: Luo, Zhigang Subject: RE

RE: [PATCH 4/5] drm/amdgpu: add psp microcode init for arcturus and aldebaran sriov vf

2021-06-03 Thread Luo, Zhigang
Yeah, it will also init psp sos and asd mircrocode. But I think it's harmless. Thanks, Zhigang -Original Message- From: Liu, Shaoyun Sent: June 3, 2021 11:13 AM To: Luo, Zhigang ; amd-gfx@lists.freedesktop.org Cc: Luo, Zhigang Subject: RE: [PATCH 4/5] drm/amdgpu: add psp microcode

RE: [PATCH 2/5] drm/amdgpu: remove sriov vf gfxhub fb location programming

2021-06-03 Thread Luo, Zhigang
Yes, I double checked all gfx9 ASICs with sriov supported. -Original Message- From: Liu, Shaoyun Sent: June 3, 2021 11:11 AM To: Luo, Zhigang ; amd-gfx@lists.freedesktop.org Cc: Luo, Zhigang Subject: RE: [PATCH 2/5] drm/amdgpu: remove sriov vf gfxhub fb location programming [AMD

RE: [PATCH 1/1] drm/amdgpu: Add a new device ID for Aldebaran

2021-04-30 Thread Luo, Zhigang
[AMD Official Use Only - Internal Distribution Only] Thanks, Felix. The change looks good for me. --Zhigang -Original Message- From: Kuehling, Felix Sent: April 30, 2021 1:45 PM To: Luo, Zhigang ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/1] drm/amdgpu: Add a new device ID

RE: [PATCH 2/2] drm/amdgpu: Add Aldebaran virtualization support

2021-04-29 Thread Luo, Zhigang
[AMD Official Use Only - Internal Distribution Only] Thanks Alex. I will add it. --Zhigang -Original Message- From: Alex Deucher Sent: April 29, 2021 4:17 PM To: Luo, Zhigang Cc: amd-gfx list Subject: Re: [PATCH 2/2] drm/amdgpu: Add Aldebaran virtualization support On Thu, Apr 29

RE: [PATCH 1/1] drm/amdgpu: Add a new device ID for Aldebaran

2021-04-29 Thread Luo, Zhigang
[AMD Official Use Only - Internal Distribution Only] Thanks, Felix. Yes, I will sent out several patches for Aldebaran virtualization support soon. Thanks, Zhigang -Original Message- From: Kuehling, Felix Sent: April 29, 2021 2:40 PM To: Luo, Zhigang ; amd-gfx@lists.freedesktop.org

RE: [PATCH] drm/amd/powerplay: clear VBIOS scratchs on baco exit

2019-12-06 Thread Luo, Zhigang
[AMD Official Use Only - Internal Distribution Only] Thanks, Hawking. --Zhigang -Original Message- From: Zhang, Hawking Sent: December 6, 2019 12:35 PM To: Luo, Zhigang ; Alex Deucher Cc: Quan, Evan ; Yuan, Xiaojie ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amd

RE: [PATCH] drm/amd/powerplay: clear VBIOS scratchs on baco exit

2019-12-06 Thread Luo, Zhigang
[AMD Official Use Only - Internal Distribution Only] Thanks, Alex. > > This was reported by Zhigang team. Under their special use case, scratch > > register 7 has be to 0 to perform asic init(@Luo, Zhigang right?). Yes, sriov driver use this register to detect if asic in

RE: [PATCH] drm/amd/powerplay: clear VBIOS scratchs on baco exit

2019-12-06 Thread Luo, Zhigang
, Xiaojie ; Luo, Zhigang ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amd/powerplay: clear VBIOS scratchs on baco exit Ah yes, I made a logical mistake. This should work. Regards, Hawking -Original Message- From: Alex Deucher Sent: 2019年12月6日 22:01 To: Zhang, Hawking Cc: Quan, Evan