[PATCH umr] Add program memory dump to wave status.

It will display the leading 4 words up to the current PC value and then 4 words after. Signed-off-by: Tom St Denis --- src/app/print_waves.c | 44 +--- 1 file changed, 33 insertions(+), 11 deletions(-) diff --git a/src/app/print_waves.c b/src/app

Re: [PATCH 000/100] Add Vega10 Support

On 03/20/2017 06:34 PM, Jan Ziak wrote: On Mon, Mar 20, 2017 at 10:41 PM, Alex Deucher mailto:alexdeuc...@gmail.com>> wrote: On Mon, Mar 20, 2017 at 5:36 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com > wrote: > Hi > > https://cgit.freedesktop.org/~a

[PATCH umr] Add more PKT3 decoders ...

Various SI related PKT3 decoders. Signed-off-by: Tom St Denis --- src/lib/ring_decode.c | 52 +++ 1 file changed, 52 insertions(+) diff --git a/src/lib/ring_decode.c b/src/lib/ring_decode.c index a991f5ffa237..ab1cb9d46411 100644 --- a/src/lib

[PATCH umr] sync up registers/bits with staging tree

Signed-off-by: Tom St Denis --- scripts/parse_bits.sh| 4 +++- src/lib/ip/dce60_bits.i | 1 + src/lib/ip/smu712_regs.i | 1 + src/lib/ip/smu713_regs.i | 1 + 4 files changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/parse_bits.sh b/scripts/parse_bits.sh index ebaa6aefb1fa

[PATCH umr] add missing polaris10 DID

Signed-off-by: Tom St Denis --- src/lib/discover_by_did.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/discover_by_did.c b/src/lib/discover_by_did.c index 2851eb3a8d86..d8f64a091863 100644 --- a/src/lib/discover_by_did.c +++ b/src/lib/discover_by_did.c @@ -110,6 +110,7 @@ static

[PATCH umr] Add missing Polaris12 DIDs

And also remove an errant one. Signed-off-by: Tom St Denis --- src/lib/discover_by_did.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/lib/discover_by_did.c b/src/lib/discover_by_did.c index 271e8adce35d..2851eb3a8d86 100644 --- a/src/lib/discover_by_did.c +++ b/src

Re: [PATCH 1/2] drm/amdgpu/gfx8: enable cp/rlc ints after we disable clockgating

On 16/03/17 12:24 PM, Alex Deucher wrote: On Tue, Mar 14, 2017 at 3:32 PM, Alex Deucher wrote: Even if we disable clockgating, we still need to make sure the cp/rlc interrupts are enabled for powergating which might still be enabled. Signed-off-by: Alex Deucher Anyone? Haven't had a chanc

[PATCH umr] Add ability to write registers by address

Signed-off-by: Tom St Denis --- src/app/main.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/app/main.c b/src/app/main.c index 88b4feaf0058..72c29d6a26d4 100644 --- a/src/app/main.c +++ b/src/app/main.c @@ -216,9 +216,14 @@ int main(int argc, char **argv

[PATCH] drm/amd/amdgpu: Fix debugfs reg read/write address width

The MMIO space is wider now so we mask the lower 22 bits instead of 18. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu

[PATCH umr] Allow reading register by address instead of name

Signed-off-by: Tom St Denis --- src/app/main.c | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/src/app/main.c b/src/app/main.c index e8f786b39743..88b4feaf0058 100644 --- a/src/app/main.c +++ b/src/app/main.c @@ -257,26 +257,34 @@ int

[PATCH] drm/amd/amdgpu: Disable GFX_PG on Carrizo until compute issues solved

Currently compute jobs will stall if GFX_PG is enabled. Until this is resolved we'll disable GFX_PG. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/vi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/a

[PATCH umr] Clean up depth1 decoding and add depth0 decoding.

Now you can do cool things like umr -v 0@`umr -r *.*.mmUVD_LMI_RBC_RB_64BIT_BAR_LOW` 100 To read (in this case) the first 256 bytes of the UVD ring buffer. Signed-off-by: Tom St Denis --- src/lib/read_vram.c | 40 +--- 1 file changed, 29 insertions(+), 11

[PATCH umr] PM4 packets list number of dwords not bytes

When counting size of IBs count in dwords... Signed-off-by: Tom St Denis --- src/lib/ring_decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/ring_decode.c b/src/lib/ring_decode.c index 401d6caaa088..a991f5ffa237 100644 --- a/src/lib/ring_decode.c +++ b/src/lib

[PATCH umr] Add ability to read from virtual memory

Updates the --vram command to add the ability to read from one of the VM domains instead. Signed-off-by: Tom St Denis --- doc/umr.1 | 7 --- src/app/main.c | 16 ++-- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/doc/umr.1 b/doc/umr.1 index a12dfb0a00ff

[PATCH umr] Fix ring offset to dword instead of bytes

This allows you to specify (say) -R gfx[16:32] to read words 16 through 32 which is consistent with how the data is presented. This patch also correctly enables the PM4 decoder when specifying a range of words. Signed-off-by: Tom St Denis --- src/app/ring_read.c | 3 +++ 1 file changed, 3

Re: [PATCH] drm/amdgpu: Added more hqd debug messages

On 03/01/2017 04:28 PM, ozeng wrote: Dump register COMPUTE_PGM_RSRC1 and COMPUTE_PGM_RSRC2 in function kgd_hqd_dump Change-Id: I8e007f5bcc095d3283b642791860dd072dd43b1c Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_amdkf

[PATCH umr] Allow * for ipname in --read/--write/--write-bit (v2)

To simplify scripting you can now use * for ipnames as well. (v2) Continue matching other IP blocks after first register hit. Signed-off-by: Tom St Denis --- doc/umr.1 | 6 ++- src/app/main.c| 5 ++- src/app/scan.c| 32 --- src/app/set_bit.c | 117

Re: [PATCH umr] Allow * for ipname in --read/--write/--write-bit

On 23/02/17 01:41 PM, Andres Rodriguez wrote: On 2017-02-23 09:46 AM, Tom St Denis wrote: To simplify scripting you can now use * for ipnames as well. Thanks for the patch, this change is very welcome. Signed-off-by: Tom St Denis --- doc/umr.1 | 6 ++- src/app/main.c| 5

[PATCH umr] Allow * for ipname in --read/--write/--write-bit

To simplify scripting you can now use * for ipnames as well. Signed-off-by: Tom St Denis --- doc/umr.1 | 6 ++- src/app/main.c| 5 ++- src/app/scan.c| 21 ++ src/app/set_bit.c | 117 +++--- src/app/set_reg.c | 91

[PATCH umr] Simplify --scan and --list-regs syntax

Now it supports the same syntax as --read/--write, you can specify any of: *.ipname asicname.ipname ipname When using --scan and --list-regs now. e.g., umr --scan carrizo.uvd6 or umr --scan uvd6 Signed-off-by: Tom St Denis --- src/app/main.c | 39

[PATCH umr] Add SENSOR for SI/CIK/KV systems.

Signed-off-by: Tom St Denis --- src/app/top.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/app/top.c b/src/app/top.c index 92ab8ab854af..c97a0c9d93ab 100644 --- a/src/app/top.c +++ b/src/app/top.c @@ -231,6 +231,27 @@ static struct umr_bitfield

Re: [PATCH v3] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

St Denis Signed-off-by: Samuel Pitoiset Cool, you can throw my R-b on this and the first patch (which adds the sensors). Christian/Alex/etc can RB the DRM part. Reviewed-by: Tom St Denis Thanks, Tom --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++ 1 file changed, 6 insertions

Re: [PATCH] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

On 14/02/17 09:56 PM, Deucher, Alexander wrote: -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Tuesday, February 14, 2017 9:52 PM To: Deucher, Alexander; 'Samuel Pitoiset'; StDenis, Tom Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: expose amd

Re: [PATCH v2] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

On 14/02/17 12:52 PM, Tom St Denis wrote: On 14/02/17 12:16 PM, Tom St Denis wrote: On 14/02/17 12:01 PM, Samuel Pitoiset wrote: No worries. I thought that check was enough. Anyway, writing code without the hardware should be avoided. :) Can you try the thing suggested by Alex? Because I will

Re: [PATCH v2] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

On 14/02/17 12:52 PM, Tom St Denis wrote: On 14/02/17 12:16 PM, Tom St Denis wrote: On 14/02/17 12:01 PM, Samuel Pitoiset wrote: No worries. I thought that check was enough. Anyway, writing code without the hardware should be avoided. :) Can you try the thing suggested by Alex? Because I will

Re: [PATCH v2] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

On 14/02/17 12:16 PM, Tom St Denis wrote: On 14/02/17 12:01 PM, Samuel Pitoiset wrote: No worries. I thought that check was enough. Anyway, writing code without the hardware should be avoided. :) Can you try the thing suggested by Alex? Because I will need to fix up the DRM ioctl codepath as

Re: [PATCH v2] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

On 14/02/17 12:01 PM, Samuel Pitoiset wrote: On 02/14/2017 05:41 PM, Tom St Denis wrote: On 14/02/17 10:08 AM, Samuel Pitoiset wrote: Totally untested but as long as read_sensor() has been recently implemented for dpm based boards, amdgpu_sensors can now be exposed. v2: - make sure

Re: [PATCH] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

/amdgpu: expose amdgpu_sensors on pre-powerplay chips Totally untested but as long as read_sensor() has been recently implemented for dpm based boards, amdgpu_sensors can now be exposed. Cc: Tom St Denis Signed-off-by: Samuel Pitoiset --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 + 1

Re: [PATCH v2] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

On 14/02/17 10:08 AM, Samuel Pitoiset wrote: Totally untested but as long as read_sensor() has been recently implemented for dpm based boards, amdgpu_sensors can now be exposed. v2: - make sure read_sensor is not NULL on dpm chips - keep sanity check for powerplay chips Cc: Tom St Denis

Re: [PATCH] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

On 13/02/17 07:23 PM, Samuel Pitoiset wrote: Totally untested but as long as read_sensor() has been recently implemented for dpm based boards, amdgpu_sensors can now be exposed. Cc: Tom St Denis Signed-off-by: Samuel Pitoiset --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 + 1 file

Re: [PATCH 1/2] drm/amdgpu: implement read_sensor() for pre-powerplay chips

On 02/13/2017 06:40 PM, Samuel Pitoiset wrote: On 02/14/2017 12:17 AM, Tom St Denis wrote: Hi Samuel, Hi Tom, It would be helpful to modify amdgpu_debugfs_sensor_read() to support dpm based sensors as well. This will let me add it to umr. You mean removing the sanity check (for

Re: [PATCH 1/2] drm/amdgpu: implement read_sensor() for pre-powerplay chips

Hi Samuel, It would be helpful to modify amdgpu_debugfs_sensor_read() to support dpm based sensors as well. This will let me add it to umr. If you can swing that in here that would be helpful if not I can submit my own patch when this lands. Cheers, Tom On 02/13/2017 05:01 PM, Samuel Pi

Re: [PATCH 1/2] drm/amdgpu: implement read_sensor() for pre-powerplay chips

On 02/13/2017 05:13 PM, Deucher, Alexander wrote: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Samuel Pitoiset Sent: Monday, February 13, 2017 5:02 PM To: amd-gfx@lists.freedesktop.org Cc: Samuel Pitoiset Subject: [PATCH 1/2] drm/amdgpu: imp

[PATCH] drm/amd/amdgpu: Fix flow control in uvd_v4_2_stop()

Break out of outer loop properly. Signed-off-by: Tom St Denis Reported-by: Dan Carpenter --- drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c b/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c index

Re: [PATCH] Add new gmc/smu registers

On 13/02/17 11:35 AM, Nicolai Hähnle wrote: Hi Tom, it's probably a good idea to use subject prefixes for umr patches. git config format.subjectPrefix "PATCH umr" or edit .git/config accordingly, e.g. for libdrm I have this in .git/config: [format] subjectPrefix = PATCH libdrm Then f

[PATCH] Fix SMC read/write

The registers in umr are stored as byte addresses (mm registers are word addresses). Signed-off-by: Tom St Denis --- src/app/scan.c| 2 +- src/app/set_bit.c | 2 +- src/app/set_reg.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/app/scan.c b/src/app/scan.c index

Re: [PATCH] Add missing CIK devices

On 13/02/17 10:32 AM, Deucher, Alexander wrote: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Tom St Denis Sent: Monday, February 13, 2017 7:46 AM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH] Add missing CIK devices

[PATCH] Add new gmc/smu registers

Signed-off-by: Tom St Denis --- src/lib/ip/gmc60_bits.i | 2 ++ src/lib/ip/smu701_bits.i | 4 src/lib/ip/smu701_regs.i | 1 + src/lib/ip/smu711_bits.i | 4 src/lib/ip/smu711_regs.i | 1 + src/lib/ip/smu712_bits.i | 4 src/lib/ip/smu712_regs.i | 1 + src/lib/ip/smu713_bits.i | 4

Re: [PATCH] Add missing CIK devices

On 13/02/17 08:12 AM, Christian König wrote: Am 13.02.2017 um 13:46 schrieb Tom St Denis: Adds mullins, kabini, and hawaii ASICs to the library. Signed-off-by: Tom St Denis Acked-by: Christian König . Thanks. If there are no objections I'll push it out in a couple hours. Cheers

[PATCH] Add missing CIK devices

Adds mullins, kabini, and hawaii ASICs to the library. Signed-off-by: Tom St Denis --- src/lib/asic/CMakeLists.txt | 3 +++ src/lib/asic/hawaii.c | 40 src/lib/asic/kabini.c | 40 src/lib/asic

Re: Initial Public Release of AMDGPU debugger

On 13/02/17 05:00 AM, Nils Holland wrote: On Sat, Feb 04, 2017 at 06:44:12PM +, StDenis, Tom wrote: Hello all, We're pleased to announce the initial public release of the AMDGPU User Mode Register debugger (umr). This tool allows privileged users to read and write GPU registers in order t

Re: Initial Public Release of AMDGPU debugger

On 02/12/2017 09:39 PM, Dave Airlie wrote: We're pleased to announce the initial public release of the AMDGPU User Mode Register debugger (umr). This tool allows privileged users to read and write GPU registers in order to diagnose, debug, and aid in development of AMDGPU features. The tool sup

Re: [UMR] Add GPU_POWER (v3) + refactored cleanup

On 02/11/2017 01:57 PM, Kai Wasserbäch wrote: Hey Tom, Tom St Denis wrote on 11.02.2017 18:52: I split out the deletion of the unused bits in --top. thank you so much for bearing with me (and Edward, though I can't speak for him, obviously)! You can still have my R-b. ;-) Cheers, Kai

Re: [PATCH] Add GPU_POWER sensors (v2)

On 02/11/2017 08:29 AM, Kai Wasserbäch wrote: Hey Tom, Tom St Denis wrote on 11.02.2017 12:26: Add the ability to sample GPU_POWER sensors. Because the sensors have a high latency we read them from a background thread which means we've added the requirement for pthreads. Signed-off-by: T

[PATCH 1/2] Remove unused bits from --top

Signed-off-by: Tom St Denis --- src/app/top.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/app/top.c b/src/app/top.c index b081515a5b40..d9a474d78cf7 100644 --- a/src/app/top.c +++ b/src/app/top.c @@ -171,19 +171,14 @@ static struct umr_bitfield stat_uvd_pgfsm7_bits[] = { static

[PATCH 2/2] Add GPU_POWER sensors (v3)

Add the ability to sample GPU_POWER sensors. Because the sensors have a high latency we read them from a background thread which means we've added the requirement for pthreads. Signed-off-by: Tom St Denis (v2) Cleaned up CMake around pthreads (v3) Update readme, factor out some dele

[UMR] Add GPU_POWER (v3) + refactored cleanup

I split out the deletion of the unused bits in --top. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] Add GPU_POWER sensors

On 11/02/17 05:56 AM, Kai Wasserbäch wrote: Hey Tom, Tom St Denis wrote on 11.02.2017 02:02: On 02/10/2017 07:25 PM, Edward O'Callaghan wrote: Hey Tom, On 02/11/2017 05:10 AM, Tom St Denis wrote: Add the ability to sample GPU_POWER sensors. Because the sensors have a high latency we

[PATCH] Add GPU_POWER sensors (v2)

Add the ability to sample GPU_POWER sensors. Because the sensors have a high latency we read them from a background thread which means we've added the requirement for pthreads. Signed-off-by: Tom St Denis (v2) Cleaned up CMake around pthreads --- CMakeLists.txt | 4 +++ R

Re: [PATCH] Add GPU_POWER sensors

On 02/10/2017 07:25 PM, Edward O'Callaghan wrote: Hey Tom, On 02/11/2017 05:10 AM, Tom St Denis wrote: Add the ability to sample GPU_POWER sensors. Because the sensors have a high latency we read them from a background thread which means we've added the requirement for pthreads.

[PATCH] Add GPU_POWER sensors

Add the ability to sample GPU_POWER sensors. Because the sensors have a high latency we read them from a background thread which means we've added the requirement for pthreads. Signed-off-by: Tom St Denis --- CMakeLists.txt | 5 ++- README | 6 ++-- src/app/

[UMR] Add GPU_POWER Sensors

This patch adds the ability to read GPU_POWER sensors on smu7 hardware. Because there is an incredibly high latency on reading them I've added a pthread to handle that. Hence the project now requires pthreads to build. ___ amd-gfx mailing list amd-gf

[no subject]

Fix bug where GPU_POWER wasn't accessible because we wrote to *size early... ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amd/amdgpu: Update read_sensor calls to have size parameter (v2)

): Don't set size to 4 before reading GPU_POWER Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 26 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c

[PATCH] drm/amd/amdgpu: Update read_sensor calls to have size parameter

-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 26 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c| 28 +-- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 5

Re: Staging kernel failing to build on 32bit

On 08/02/17 11:53 AM, Jeremy Newton wrote: Hi, Heads up to whoever is using or developing for the following kernel branch: https://cgit.freedesktop.org/~agd5f/linux/tree/?h=amd-staging-4.9 It seems like a recent commit has caused 32bit builds to fail. I haven't been able to look into it myself

Re: [PATCH] Autodetect libdrm path (v2)

On 07/02/17 06:02 AM, Emil Velikov wrote: On 6 February 2017 at 22:39, StDenis, Tom wrote: Apparently I missed the bottom of your reply (all of the clients I have outlook/gmail do top post only ...) Both Outlook and Gmail can do inline replies and plain text. There might be some magic requir

[PATCH] Allow reading all of ring buffer and decode partial ranges

Fixes bug where say "-R gfx" would not actually dump the full ring contents. Adds feature where if you specify start and stop, e.g., "-R gfx[0:16]" will enable the decoder. Signed-off-by: Tom St Denis --- src/app/ring_read.c | 11 ++- 1 file changed, 6 insert

[PATCH] Autodetect libdrm path (v2)

(v2): Use findLibDRM script instead of directly finding path Signed-off-by: Tom St Denis --- CMakeLists.txt | 3 +++ cmake_modules/FindLibDRM.cmake | 35 +++ src/lib/query_drm.c| 4 ++-- 3 files changed, 40 insertions(+), 2

[PATCH] autodetect path to libdrm

Signed-off-by: Tom St Denis --- CMakeLists.txt | 4 +++- src/lib/query_drm.c | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index bef94fdba788..d2f393f0fa9b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -25,6 +25,8

Add autodetect for libdrm to umr

While the cmake commits haven't been pushed yet I'd like to get feedback on this patch which helps find the libdrm headers. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amd/amdgpu: Add PCI info to gca_config debugfs

So we can determine which device the entry is before connecting a display. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd

[PATCH] drm/amd/amdgpu: De-numberify golden SI registers

Where possible replace numeric constants in the table with their register names. Compile tested + executed on a Tahiti. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/si.c | 975 1 file changed, 492 insertions(+), 483 deletions(-) diff

[PATCH] drm/amd/amdgpu: Widen mmio trace register address width

Support wider address spaces, make it 32-bit so we don't have to revisit this for a while. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/driver

GPR read support via debugfs (v2)

These patches introduce debugfs access to read GPRs (SGPRs for now). (v2): Fixes white space, addressing is in dwords not bytes, and removes the buggy sanity checking. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedeskto

[PATCH 2/3] drm/amd/amdgpu: Add gpr reading for GFX v6

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c index c0b2f4ebadea..01b58c65f37c 100644 --- a/drivers/gpu/drm/amd

[PATCH 3/3] drm/amd/amdgpu: Add gpr reading for GFX v7

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c index bbef2e86ea1f..4c4fb9bdd185 100644 --- a/drivers/gpu/drm/amd

[PATCH 1/3] drm/amd/amdgpu: Add debugfs support for reading GPRs (v2)

Implemented for SGPRs for GFX v8 initially. (v2) cleanup minor whitespace and remove sanity check and addressing is in dwords not bytes Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 67

[PATCH 1/3] drm/amd/amdgpu: Add debugfs support for reading GPRs

Implemented for SGPRs for GFX v8 initially. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 72 ++ drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 25 +++ 3 files changed, 99

[PATCH 2/3] drm/amd/amdgpu: Add gpr reading for GFX v6

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c index c0b2f4ebadea..01b58c65f37c 100644 --- a/drivers/gpu/drm/amd

debugfs support for reading GPRs

The following patches add support for GFX v6, v7, and v8 to allow userspace to read GPRs (SGPRs) via debugfs. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 3/3] drm/amd/amdgpu: Add gpr reading for GFX v7

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c index bbef2e86ea1f..4c4fb9bdd185 100644 --- a/drivers/gpu/drm/amd

[PATCH 2/2] drm/amd/amdgpu: Tidy up formatting in si_enums.h

Clean up formatting/alignment in si_enums.h to make it more presentable. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/si_enums.h | 241 +- 1 file changed, 121 insertions(+), 120 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si_enums.h b

[PATCH 1/2] drm/amd/amdgpu: port of DCE v6 to new headers (v2)

Port of SI DCE v6 over to new AMDGPU headers. Tested on a Tahiti with GNOME through various hot plugs/rotations/sizes/fullscreen/windowed and staging drm/xf86-video-amdgpu. (v2) Re-factored to remove formatting changes to si_enums.h as well rename various defines. Signed-off-by: Tom St

[PATCH] drm/amd/amdgpu: port of DCE v6 to new headers

Port of SI DCE v6 over to new AMDGPU headers. Tested on a Tahiti with GNOME through various hot plugs/rotations/sizes/fullscreen/windowed and staging drm/xf86-video-amdgpu. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 441 +++-- drivers

[PATCH] drm/amd/amdgpu: Port GMC v6 driver to new SI headers (v2)

Port the GMC v6 driver over to the new SI headers. Tested with a Tahiti SI ASIC. (v2) Fixed a couple of typos (in commented code) and moved defines to si_enums.h Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 323 ++ drivers/gpu

[PATCH] drm/amd/amdgpu: Fix gfxv6 driver issues from porting to new headers

This patch fixes a couple of bugs that fell out from the porting effort. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0

[PATCH 2/2] drm/amd/amdgpu: Clean up wave gfx8 helper

De-numberify indirect register access for gfx v8. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c index 4f46d706675b

[PATCH 1/2] drm/amd/amdgpu: Clean up wave gfx7 helper

De-numberify indirect register access for gfx v7. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c index 4dda3ddb3fec

Clean up indirect SQ register accessors for gfx7/8

Denumberify the two indirect accessors to make the code cleaner. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amd/amdgpu: Put in rest of wave fields

Add the rest of the basic SQ WAVE fields to finish off the implementation. Eventually, a separate interface will be needed for GPRs. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 6 ++ drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 ++ 2 files changed, 12

[PATCH] drm/amd/amdgpu: re-factor debugfs wave reader

Move IP version specific code into a callback. Also add support for gfx7 devices. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 29 ++--- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 25

[PATCH] drm/amdgpu/si_dpm: Limit clocks on HD86xx part

From: Tom St Denis Limit clocks on a specific HD86xx part to avoid crashes (while awaiting an appropriate PP fix). Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/si_dpm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/si_dpm.c b/drivers/gpu

[PATCH] drm/radeon/si_dpm: Limit clocks on HD86xx part

Limit clocks on a specific HD86xx part to avoid crashes (while awaiting an appropriate PP fix). Signed-off-by: Tom St Denis --- drivers/gpu/drm/radeon/si_dpm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c index

Fix lock imbalance in debugfs wave reader

I introduced a lock imbalance in the debugfs wave reader. This patch fixes that. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amd/amdgpu: Fix debugfs wave reader

On non VI/CZ platforms it would not free the grbm index lock. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu

More debugfs entries

Resending the MMIO upgrades for completeness. Christian offered an ACK but I'd like to see a RB or NAK. This also adds a debugfs entry used to read wave data on CZ/VI platforms (tested on my Carrizo). The patch #3 already has a use in reading SQ information from user space so I'd like to advoc

[PATCH 1/3] drm/amd/amdgpu: Add wave reader to debugfs

Currently supports CZ/VI. Allows nearly atomic read of wave data from GPU. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu

[PATCH 2/3] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

Allow any of the se/sh/instance fields to be specified as a broadcast by submitting 0x3FF. (v2) Fix broadcast range checking Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu

[PATCH 3/3] drm/amd/amdgpu: Make debugfs write compliment read

Add PG lock support as well as bank selection to the MMIO write function. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 43 ++ 1 file changed, 43 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm

Re: [PATCH] drm/amd/amdgpu: Make debugfs write compliment read

> > Am 10.10.2016 um 14:51 schrieb Tom St Denis: > > Add PG lock support as well as bank selection to > > the MMIO write function. > > > > Signed-off-by: Tom St Denis > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 43 >

[PATCH] drm/amd/amdgpu: Make debugfs write compliment read

Add PG lock support as well as bank selection to the MMIO write function. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 43 ++ 1 file changed, 43 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm

Re: [PATCH] drm/amdgpu: remove duplicate evict_vram in suspend path

Yup that's what I said in another part of the thread :-) i'm a trailblazer of bad ideas at times :-) hehehehe Tom On Sun, Oct 9, 2016 at 11:13 AM Christian König wrote: > Am 05.10.2016 um 21:42 schrieb Alex Deucher: > > Looks like fallout from a rebase or merge. > > > > Signed-off-by: Alex Deu

[PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

Allow any of the se/sh/instance fields to be specified as a broadcast by submitting 0x3FF. (v2) Fix broadcast range checking Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu

[PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read

Allow any of the se/sh/instance fields to be specified as a broadcast by submitting 0x3FF. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd

Re: [PATCH] drm/amdgpu: remove duplicate evict_vram in suspend path

I proposed to remove that when running into SDMA job out-of-order issues and Christian K very strongly NAK'ed that (a couple of times). So I suspect he'll do it again. Tom On Wed, Oct 5, 2016 at 8:10 PM Dave Airlie wrote: > On 6 October 2016 at 05:42, Alex Deucher wrote: > > Looks like fallo

[PATCH 2/2] drm/amd/amdgpu: Enable UVD PG on Tonga

Tested by reading tile/clk bits during load/idle. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/vi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c index c6bc3df36118..c4394a6b82e9 100644 --- a

Enable UVD PG for SMU7 and turn on for Tonga

Patch #1 fixes the UVD powergating function in the smu7 driver as well as senses vce/uvd features (so we can fix/add vce PG later on). Patch #2 enables it for tonga. Tested by reading tile/clk bits during load/idle. ___ amd-gfx mailing list amd-gfx@lis

[PATCH 1/2] drm/amd/powerplay: Enable UVD powergating for SMU7

This patch enables detecting VCE/UVD PG features and fixes the UVD powergate function. Tested on a Tonga (by reading UVD tile/clk bits during playback/idle). Signed-off-by: Tom St Denis --- .../gpu/drm/amd/powerplay/hwmgr/smu7_clockpowergating.c| 12 +--- drivers/gpu/drm/amd

[PATCH 3/3] drm/amd/amdgpu: Various cleanups for DCEv6

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 46 --- 1 file changed, 10 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c index dce5414f4ae3..a4fa30b9924a 100644

<    3   4   5   6   7   8   9   10   >