RE: [PATCH 2/2] drm/amdgpu: allow GTT overcommit during bind

2017-10-17 Thread Zhu, Rex
Patch is Tested-by: Rex Zhu Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian König Sent: Tuesday, October 17, 2017 4:28 PM To: Zhou, David(ChunMing); amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amdgp

Re: Regression: Crash/freeze when resuming from suspend or locked screen

2017-10-10 Thread Zhu, Rex
Hi Martin, Can you try to reproduce this issue with amdgpu.dc=0 when modprobe amdgpu Best Regards Rex From: amd-gfx on behalf of Deucher, Alexander Sent: Tuesday, October 10, 2017 10:41:29 PM To: 'Martin Babutzka'; amd-gfx@lists.freedesktop.org Subject: RE: Reg

Re: tonga mclk regression

2017-10-05 Thread Zhu, Rex
Thanks Tom. The attached patch can fix this bug. Best Regards Rex From: StDenis, Tom Sent: Thursday, October 5, 2017 9:42 PM To: amd-gfx mailing list Cc: Zhu, Rex; Deucher, Alexander Subject: tonga mclk regression I've bisected it to this commit

RE: some more powerplay/pwr virus size reduction patches

2017-09-29 Thread Zhu, Rex
Hi Alex, We can use Polaris's PwrVirusTable on Fiji. So can remove fiji_pwrvirus.h Best Regards Rex -Original Message- From: Deucher, Alexander Sent: Friday, September 29, 2017 11:13 AM To: 'Dave Airlie'; amd-gfx mailing list; Alex Deucher; Zhu, Rex Subject: RE: some

Recall: [PATCH] drm/amdgpu: correct reference clock value on vega10

2017-09-29 Thread Zhu, Rex
Zhu, Rex would like to recall the message, "[PATCH] drm/amdgpu: correct reference clock value on vega10". ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amdgpu: correct reference clock value on vega10

2017-09-29 Thread Zhu, Rex
Reviewed-by: Rex Zhu Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of ken.w...@amd.com Sent: Friday, September 29, 2017 4:35 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Ken Subject: [PATCH] drm/amdgpu: correct reference cloc

RE: [amd-staging-drm-next] regression - no fan info (sensors) on RX580

2017-09-29 Thread Zhu, Rex
September 29, 2017 10:11 PM To: Dieter Nützel; Zhu, Rex Cc: amd-devel; DRI Devel; Wentland, Harry; Michel Dänzer Subject: Re: [amd-staging-drm-next] regression - no fan info (sensors) on RX580 Rex, probably related to the recent cleanups in powerplay. On Fri, Sep 29, 2017 at 10:09 AM, Dieter Nüt

RE: [PATCH] drm/amd/powerplay: fix a warning in pp_hw_init

2017-09-29 Thread Zhu, Rex
Hi Alex, Thanks for pointing out the logic error in pp_hw_init. Please review the attached patch. Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Saturday, September 30, 2017 12:38 AM To: amd-gfx@lists.fr

RE: powerplay change breaks driver

2017-09-25 Thread Zhu, Rex
Thanks Tom. Have found the root cause. An copy error when initialize smu function table. case AMDGPU_FAMILY_CZ: - hwmgr->smumgr_funcs = &ci_smu_funcs; + hwmgr->smumgr_funcs = &cz_smu_funcs; Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-bou

Re: [PATCH 16/16] drm/amd/powerplay: Tidy up vega10_thermal_initialize()

2017-09-11 Thread Zhu, Rex
Series is: Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Tom St Denis Sent: Saturday, September 9, 2017 12:01 AM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH 16/16] drm/amd/powerplay: Tidy up vega10_thermal_initial

RE: unclear code in vega10 pp

2017-09-05 Thread Zhu, Rex
Yes. Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Tom St Denis Sent: Wednesday, September 06, 2017 12:23 AM To: amd-gfx@lists.freedesktop.org Subject: Re: unclear code in vega10 pp After seeing this style a few other place

RE: [PATCH] drm/amd/powerplay: Fix psm_set_user_performance_state()

2017-09-05 Thread Zhu, Rex
Thanks Tom. Patch is Reviewed-By: Rex Zhu Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Tom St Denis Sent: Tuesday, September 05, 2017 8:03 PM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH] drm/amd/pow

Re: [PATCH 4/4] drm/amd/powerplay: set uvd/vce/nb/mclk level as UMD P-state required

2017-09-01 Thread Zhu, Rex
Hi Alex, 》BTW, can you review my stable p-state fix for CZ? 》https://patchwork.freedesktop.org/patch/174102 Patch is Reviewed-by: Rex Zhu Best Regards Rex From: Deucher, Alexander Sent: Friday, September 1, 2017 11:03:10 PM To: Zhu, Rex; amd-gfx

Re: [PATCH] drm/amd/powerplay/hwmgr: Remove null check before kfree

2017-08-29 Thread Zhu, Rex
op.org; Deucher, Alexander; Zhu, Rex; Koenig, Christian Subject: Re: [PATCH] drm/amd/powerplay/hwmgr: Remove null check before kfree On 2017-08-29 09:12 AM, Himanshu Jha wrote: > kfree on NULL pointer is a no-op and therefore checking is redundant. > > Signed-off-by: Himanshu Jha Rev

RE: [PATCH] drm/amd/powerplay: fixed wrong data type declaration for ppfeaturemask

2017-07-05 Thread Zhu, Rex
Reviewed-by: Rex Zhu Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Evan Quan Sent: Thursday, July 06, 2017 10:02 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: fixed wrong data type

Re: [PATCH] drm/amd/powerplay: fix copy error in powerplay.

2017-06-08 Thread Zhu, Rex
>>s/diable/disable/ >>Also, why not make "Failed" lower-case at the same time? Of course. thanks. Best Regards Rex From: amd-gfx on behalf of William Lewis Sent: Thursday, June 8, 2017 8:47:58 PM To: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/a

RE: [PATCH 4/4] drm/amd/powerplay/smu7: disable mclk switching for high refresh rates

2017-05-24 Thread Zhu, Rex
We met similar issue on CI(SWDEV-103046). In high refresh rate, Dal need to notify powerpaly the min_mclk. Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Wednesday, May 24, 2017 5:27 AM To: amd-gfx@lists.f

RE: [PATCH 3/4] drm/amd/powerplay/smu7: add vblank check for mclk switching (v2)

2017-05-24 Thread Zhu, Rex
+ if (vblank_time_us < switch_limit_us) + return true; + else + return false; How about change the code to return vblank_time_us < switch_limit_us ? true : false; anyway, patch is reviewed-by: Rex Zhu Best Regards Rex -Original Message- Fr

Re: [PATCH] drm/amd/powerplay: fix a signedness bugs

2017-05-22 Thread Zhu, Rex
Patches has been applied. Thanks. Best Regards Rex From: Huang, JinHuiEric Sent: Friday, May 19, 2017 12:28:09 AM To: Dan Carpenter; Deucher, Alexander; Zhu, Rex Cc: Koenig, Christian; David Airlie; Wang, Ken; Huang, Ray; amd-gfx@lists.freedesktop.org; dri

Fw: [PATCH 1/5] drm/amdgpu: add amd fan ctrl mode define.

2017-05-05 Thread Zhu, Rex
Change-Id: Ida8f8168d9600503146b5140ea47c913733888cf Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/include/amd_shared.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h index 2ccf44e..1d1ac1e 100644 -

Fw: [PATCH 3/5] drm/amd/powerplay: refine pwm1_enable callback functions on vega10.

2017-05-05 Thread Zhu, Rex
Change-Id: Ib8681558cabab99da804d1d10987aca63435b1e5 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 43 -- .../gpu/drm/amd/powerplay/hwmgr/vega10_thermal.h | 1 + 2 files changed, 25 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/

Fw: [PATCH 4/5] drm/amd/powerplay: refine pwm1_enable callback functions on vi.

2017-05-05 Thread Zhu, Rex
Signed-off-by: Rex Zhu Change-Id: I72d61851630e5d4ff5b3236ca33abac6f5b200c6 --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 35 -- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c | 9 +++--- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.h | 2 +- drivers/gpu

Fw: [PATCH 5/5] drm/amd/powerplay: refine pwm1_enable callback functions on CI.

2017-05-05 Thread Zhu, Rex
Change-Id: Ieb05cfa95e4072357e18f631ab71780de0688008 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/ci_dpm.c b/drivers/gpu/drm/amd/amdgpu/ci_dpm.c index a

Fw: [PATCH 2/5] drm/amdgpu: refine pwm1_enable call back functions.

2017-05-05 Thread Zhu, Rex
Change-Id: Ie5fe90762f75497fab68b913874956bbeab11e72 --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c index e00ed19..1d9d571 100644 --- a/dr

Re: [PATCH] drm/amdgpu: Fix module unload hang by KIQ on Vega10

2017-04-18 Thread Zhu, Rex
I think no need to check function type. Best Regards Rex From: amd-gfx on behalf of Deucher, Alexander Sent: Tuesday, April 18, 2017 9:33:58 PM To: Huang, Trigger; amd-gfx@lists.freedesktop.org Cc: Huang, Trigger Subject: RE: [PATCH] drm/amdgpu: Fix module unloa

Re: [PATCH 12/12] drm/amdgpu/gfx9: Switch baremetal to use KIQ for compute ring management. (v3)

2017-04-17 Thread Zhu, Rex
+static int gfx_v9_0_kiq_kcq_disable(struct amdgpu_device *adev) ... + DRM_ERROR("KCQ enable failed (scratch(0x%04X)=0x%08X)\n", should be disable here. Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Tuesday, Apr

Re: [PATCH] drm/amdgpu/gfx8: move MEC doorbell range setting

2017-04-10 Thread Zhu, Rex
Patch was Tested-by and Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Tuesday, April 11, 2017 1:02:02 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/gfx8: move MEC doorbell rang

Re: [PATCH] drm/amdgpu/gfx8: set doorbell range for polaris as well

2017-04-10 Thread Zhu, Rex
Patch was Tested-by and Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Tuesday, April 11, 2017 12:51:01 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/gfx8: set doorbell range f

RE: [PATCH 3/3] drm/amdgpu: do not block gpu resume when cp ring test failed.

2017-03-29 Thread Zhu, Rex
: Thursday, March 30, 2017 2:14 PM To: Zhu, Rex Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/3] drm/amdgpu: do not block gpu resume when cp ring test failed. On 30/03/17 02:42 PM, Rex Zhu wrote: > As kiq enabled, ring test may randomly failed because of timing. > it was not c

Re: [PATCH 4/4] drm/amdgpu: extend profiling mode.

2017-02-07 Thread Zhu, Rex
Not set max fan speed in high performance level because of the fan noise. Best Regards Rex From: amd-gfx on behalf of Zhu, Rex Sent: Monday, February 6, 2017 10:09 PM To: Andy Furniss; Alex Deucher Cc: amd-gfx list Subject: RE: [PATCH 4/4] drm/amdgpu: extend

Re: [PATCH 1/2] drm/amd/display: fix array lenth error.

2017-02-06 Thread Zhu, Rex
2017 10:54:24 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amd/display: fix array lenth error. On 2017-02-06 12:08 AM, Rex Zhu wrote: > Change-Id: I09011c5e6d5493db7e3d9a7ff7ab8c871a8db862 > Signed-off-by: Rex Zhu > --- > drivers/gpu/drm/amd/

RE: [PATCH 4/4] drm/amdgpu: extend profiling mode.

2017-02-06 Thread Zhu, Rex
Please see in line. Best Regards Rex -Original Message- From: Andy Furniss [mailto:adf.li...@gmail.com] Sent: Monday, February 06, 2017 8:32 PM To: Zhu, Rex; Alex Deucher Cc: amd-gfx list Subject: Re: [PATCH 4/4] drm/amdgpu: extend profiling mode. Zhu, Rex wrote: > Sorry for the l

RE: [PATCH 04/21] drm/amdgpu:fix powerplay logic

2017-02-06 Thread Zhu, Rex
Hi Monk, In static int pp_suspend(void *handle) { ret = pp_check(pp_handle); if (ret != 0) return ret; in suspend function, when dpm disabled/srv, also neet to return 0. Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-bou

RE: [PATCH 2/2] drm/amd/powerplay: refine code to avoid potential bug that the memory not cleared.

2017-02-06 Thread Zhu, Rex
+ clocks->count = mclk_table->count Missing semicolon. Will fix in V2. Best Regards Rex -Original Message- From: Rex Zhu [mailto:rex@amd.com] Sent: Monday, February 06, 2017 1:09 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 2/2] drm/amd/pow

RE: [PATCH 4/4] drm/amdgpu: extend profiling mode.

2017-02-06 Thread Zhu, Rex
Regards Rex -Original Message- From: Andy Furniss [mailto:adf.li...@gmail.com] Sent: Wednesday, February 01, 2017 11:37 PM To: Alex Deucher Cc: Zhu, Rex; amd-gfx list Subject: Re: [PATCH 4/4] drm/amdgpu: extend profiling mode. Alex Deucher wrote: > On Tue, Jan 31, 2017 at 6:19 PM, A

Re: [PATCH 00/12] mise patch related uvd/vce cg and pg.

2017-02-03 Thread Zhu, Rex
lf of Christian König Sent: Friday, January 27, 2017 4:34 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 00/12] mise patch related uvd/vce cg and pg. I only skimmed over it, but what I saw looked mostly good to me. Patch #7: Please add a code comment explaining why we do

Re: [PATCH] drm/amd/powerplay: header should be defining _SMU7_CLOCK_POWER_GATING_H_

2017-01-25 Thread Zhu, Rex
Thanks. Reviewed-by: Rex Zhu Best Regards Rex From: Colin King Sent: Wednesday, January 25, 2017 8:07 PM To: Deucher, Alexander; Koenig, Christian; David Airlie; Wang, Ken; Daenzer, Michel; Zhu, Rex; amd-gfx@lists.freedesktop.org; dri-de

RE: Bug (and probably, fix): UVD initialization / clock gating issue on kabini

2017-01-23 Thread Zhu, Rex
we fixed this issue on Kv as uvd pg was enabled on APU. We need to change the uvd cg mode. When idle, use hw cg. And encode, use sw cg. So WREG32(mmUVD_CGC_GATE, 0); // ture off cg. Then uvd_v4_2_set_dcm(adev, true); // set sw cg. The first patch can fix this issue. The second dpm patch can

RE: [PATCH 1/4] drm/amd/powerplay: Configuring DIDT blocks only SQ enabled on Polaris11.

2017-01-10 Thread Zhu, Rex
Hi Alex, >>> This will set the caps on Polaris10 as well? Intended? Rex: Yes, Currently, New didt messages were only supported on Polaris11. Best Regards Rex -Original Message- From: Deucher, Alexander Sent: Monday, January 09, 2017 10:12 PM To: Zhu, Rex

RE: [PATCH 4/4] drm/amd/powerplay: add profiling mode in dpm level

2017-01-09 Thread Zhu, Rex
niss [mailto:adf.li...@gmail.com] Sent: Monday, January 09, 2017 6:29 PM To: Zhu, Rex; Alex Deucher Cc: amd-gfx list Subject: Re: [PATCH 4/4] drm/amd/powerplay: add profiling mode in dpm level Hi, that change does fix it for me. The patch doesn't apply directly to drm-next-4.10-wip, here's what I t

RE: [PATCH 4/4] drm/amd/powerplay: add profiling mode in dpm level

2017-01-08 Thread Zhu, Rex
Thanks Andy, The attached patch can fix this bug. Please review. Best Regards Rex -Original Message- From: Andy Furniss [mailto:adf.li...@gmail.com] Sent: Monday, January 09, 2017 4:18 AM To: Alex Deucher; Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 4/4] drm/amd/powerplay: add

RE: [PATCH] drm/amdgpu: show gfx clock gating status to user

2017-01-04 Thread Zhu, Rex
Sorry, update. User just need to know the cg/pg feature's state(enable/disable), not current CG state. Best Regards Rex -Original Message- From: Zhu, Rex Sent: Thursday, January 05, 2017 11:34 AM To: Huang, Ray; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org; Mao, Davi

RE: [PATCH] drm/amdgpu: show gfx clock gating status to user

2017-01-04 Thread Zhu, Rex
/pg state. Best Regards Rex -Original Message- From: Huang Rui [mailto:ray.hu...@amd.com] Sent: Wednesday, January 04, 2017 10:22 AM To: Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org; Zhu, Rex; Mao, David; Fu, Ping Subject: Re: [PATCH] drm/amdgpu: show gfx clock gating status to

RE: [PATCH] drm/amdgpu: refine pg code for gfx_v8.

2016-12-07 Thread Zhu, Rex
reboot VM. Patch 0006 -0007: refine set clockgating code for tonga/polars. Best Regards Rex -Original Message- From: Deucher, Alexander Sent: Tuesday, December 06, 2016 5:07 AM To: Zhu, Rex; Alex Deucher; StDenis, Tom Cc: amd-gfx list Subject: RE: [PATCH] drm/amdgpu: refine pg code

RE: [PATCH] drm/amdgpu: refine pg code for gfx_v8.

2016-12-02 Thread Zhu, Rex
---Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Thursday, December 01, 2016 11:44 PM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH] drm/amdgpu: refine pg code for gfx_v8. On Thu, Dec 1, 2016 at 3:24 AM, Rex Zhu wrote: > 1. bit CP_PG_DISABLE was reversed. Pl

RE: [PATCH 6/6] drm/amd/powerplay: Fix potential NULL pointer issue

2016-11-30 Thread Zhu, Rex
This patch is Reviewed-by: Rex Zhu Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Xiangliang Yu Sent: Wednesday, November 30, 2016 3:03 PM To: amd-gfx@lists.freedesktop.org Cc: Yu, Xiangliang Subject: [PATCH 6/6] drm/amd/pow

RE: [PATCH] drm/amd/powerplay: fix issue dpm can't work on iceland.

2016-11-14 Thread Zhu, Rex
97403 Please review. Best Regards Rex -Original Message- From: Deucher, Alexander Sent: Friday, November 11, 2016 10:55 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: RE: [PATCH] drm/amd/powerplay: fix issue dpm can't work on iceland. > -Original Messag

RE: [PATCH] drm/amdgpu: set bypass mode when uvd is idle.

2016-11-07 Thread Zhu, Rex
Sent: Friday, November 04, 2016 9:43 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: set bypass mode when uvd is idle. > -Original Message- > From: Zhu, Rex > Sent: Thursday, November 03, 2016 11:18 PM > To: Deucher, Alexander; amd-gfx@lists.freedesk

RE: [PATCH] drm/amdgpu: set bypass mode when uvd is idle.

2016-11-03 Thread Zhu, Rex
a687c4971a40 Fix the sequence of UVD powergate function in smu7_clockgating.c. Best Regards Rex -Original Message- From: Deucher, Alexander Sent: Thursday, November 03, 2016 10:21 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: RE: [PATCH] drm/amdgpu: set bypass m

RE: [PATCH 1/7] drm/amdgpu/powerplay: pp module only enable smu when dpm disabled.

2016-11-02 Thread Zhu, Rex
--- From: Grazvydas Ignotas [mailto:nota...@gmail.com] Sent: Wednesday, November 02, 2016 9:17 PM To: Zhu, Rex Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/7] drm/amdgpu/powerplay: pp module only enable smu when dpm disabled. On Wed, Nov 2, 2016 at 12:27 PM, Rex Zhu wrote: >

[PATCH 5/6] [V2]drm/amdgpu: disable dpm before turn off clock when vce idle.

2016-10-26 Thread Zhu, Rex
Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/ci_dpm.c b/drivers/gpu/drm/amd/amdgpu/ci_dpm.c index 54a7019..8f6e7a0 100644 --- a/drivers/gpu/drm/amd/amdgpu/ci_dpm.c +++ b/driver

RE: [PATCH] drm/amd/powerplay: don't give up if DPM is already running

2016-10-20 Thread Zhu, Rex
Hi Gražvydas, In GPU passthrough case, I can't find better solution than yours from driver. So will apply your patch and just update reproduce step. Thanks. Best Regards Rex -Original Message- From: Zhu, Rex Sent: Wednesday, October 19, 2016 10:00 PM To: 'Grazvydas Ignotas

RE: [PATCH] drm/amd/powerplay: don't give up if DPM is already running

2016-10-19 Thread Zhu, Rex
not be initialized, so kernel panic when we visited those tables in set power state. I will send the fix patch for review tomorrow. Thanks. Best Regards Rex -Original Message- From: Grazvydas Ignotas [mailto:nota...@gmail.com] Sent: Sunday, October 16, 2016 2:55 AM To: Zhu, Rex Cc

Re: [PATCH 1/7] drm/amdgpu: check min clock set by DAL before set ps.

2016-10-14 Thread Zhu, Rex
Ok. i will add CI support in powerplay next week. Best Regards Rex From: Deucher, Alexander Sent: Friday, October 14, 2016 9:42:42 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: RE: [PATCH 1/7] drm/amdgpu: check min clock set by DAL before

RE: [PATCH 1/8] drm/amdgpu: move dpm related definitions to amdgpu_dpm.h

2016-10-14 Thread Zhu, Rex
Patch3-8 are Reviewed-by: Rex Zhu Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian König Sent: Thursday, October 13, 2016 3:15 PM To: Alex Deucher; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [P

RE: [PATCH] drm/amd/powerplay: don't give up if DPM is already running

2016-10-14 Thread Zhu, Rex
Hi Alex, Your new attached patch is Tested-by and Reviewed-by: Rex Zhu Just one question, Do we need to set clock_gate for smu? Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Thursday, October 13, 2016 11:29 PM To: Zhu, Rex Cc

RE: [PATCH] drm/amd/powerplay: don't give up if DPM is already running

2016-10-13 Thread Zhu, Rex
Hi all, The attached patches were also for this issue. Disable dpm when rmmod amdgpu. Please help to review. Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Zhu, Rex Sent: Wednesday, October 12, 2016 9:45 PM To: Alex

RE: [PATCH] drm/amd/powerplay: don't give up if DPM is already running

2016-10-12 Thread Zhu, Rex
Hi Grazvydas and Alex, We needed to disable dpm when rmmod amdgpu for this issue. I am checking the function of disable dpm task. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Wednesday, October 12, 2016 4:01 AM To: Grazvydas Ignotas; Zhu

RE: [PATCH 5/6] drm/amdgpu/powerplay: add an implementation for get_vce_clock_table

2016-10-12 Thread Zhu, Rex
return copy_to_user(out, &vce_clk_table, + min((size_t)size, sizeof(vce_clk_table))) ? -EFAULT : 0; + } Best Regards Rex From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian König Sent: Wednesday, Oct

RE: [PATCH 5/6] drm/amdgpu/powerplay: add an implementation for get_vce_clock_table

2016-10-12 Thread Zhu, Rex
fy UMD by add a member in struct drm_amdgpu_info_vce_clock_table. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Wednesday, October 12, 2016 4:07 AM To: amd-gfx list; Fang, Peter; Zhang, Boyuan; Zhu, Rex Cc: Deucher, Alexander Subject: Re: [PATCH 5

RE: [PATCH v2 00/16] powerplay code refactoring.

2016-09-13 Thread Zhu, Rex
Hi Christian, Thanks. I will refine those patches. Best Regards Rex -Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: Monday, September 12, 2016 6:52 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH v2 00/16] powerplay code refactoring

Re: [PATCH 0/9] misc patches related to powerplay

2016-09-09 Thread Zhu, Rex
Hi Christian, you are right, I missed mult-gpu case. i will refine related patches. Thanks. Best Regards Rex From: Christian König Sent: Saturday, September 10, 2016 1:51:30 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 0/9] misc

Re: [PATCH 0/9] misc patches related to powerplay

2016-09-09 Thread Zhu, Rex
ble_funcs; + } Best Regards Rex From: Christian König Sent: Friday, September 9, 2016 10:23:26 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 0/9] misc patches related to powerplay Patch #1-#7 and #9 are Acked-by: Christian König . Patch #8: That looks

RE: [PATCH] drm/amd/powerplay: fix issue vce dpm can't be enabled on tonga.

2016-08-31 Thread Zhu, Rex
-Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian König Sent: Tuesday, August 30, 2016 5:51 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/powerplay: fix issue vce dpm can't be enabled on tonga

Re: [PATCH] drm/amd/amdgpu: S3 resumed failed after 4-5 times loop

2016-08-18 Thread Zhu, Rex
do we need to check those status(lmi status,firmware loaded, vce status and etc) when vce suspend? it is weird that we didn't implement vce suspend function as hw spec suggested. Best Regards Rex From: amd-gfx on behalf of Christian König Sent: Thursday, A

Re: [PATCH 07/14] drm/amd/powerplay: remove enable_clock_power_gatings_tasks from initialize and resume events

2016-07-28 Thread Zhu, Rex
For the series: Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Tom St Denis Sent: Thursday, July 28, 2016 10:19:05 PM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH 07/14] drm/amd/powerplay: remove enable_clock_power_g

Re: [PATCH 4/4] drm/amd/powerplay: Prevent UVD powerdown before init

2016-07-28 Thread Zhu, Rex
you mean +if (cz_hwmgr->uvd_power_gated == bgate) { return 0; +} I didn't pay any attention at first. Best Regards Rex From: StDenis, Tom Sent: Thursday, July 28, 2016 8:44:11 PM To: Zhu, Rex; Alex Deucher Cc: amd-gfx list Sub

Re: [PATCH 4/4] drm/amd/powerplay: Prevent UVD powerdown before init

2016-07-28 Thread Zhu, Rex
Looks good to me. Best Regards Rex From: StDenis, Tom Sent: Thursday, July 28, 2016 8:19:52 PM To: Zhu, Rex; Alex Deucher Cc: amd-gfx list Subject: Re: [PATCH 4/4] drm/amd/powerplay: Prevent UVD powerdown before init Nevermind I moved the locking into

RE: [PATCH 4/4] drm/amd/powerplay: Prevent UVD powerdown before init

2016-07-28 Thread Zhu, Rex
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Thursday, July 28, 2016 1:46 PM To: Tom St Denis Cc: StDenis, Tom; amd-gfx list Subject: Re: [PATCH 4/4] drm/amd/powerplay: Prevent UVD powerdown before init On Tue, Jul 26, 2016 at 11:38 AM, Tom St Deni

<    1   2   3