RE: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-14 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Friday, November 12, 2021 4:46 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Borislav Petkov > > Subject: Re: [PATCH] drm/amd/pm: avoid duplicate power

Re: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-12 Thread Lazar, Lijo
On 11/11/2021 1:27 PM, Evan Quan wrote: Just bail out if the target IP block is already in the desired powergate/ungate state. This can avoid some duplicate settings which sometimes may cause unexpected issues. Link: https://lore.kernel.org/all/yv81vidwqlwva...@zn.tnic/ Change-Id:

[PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-10 Thread Evan Quan
Just bail out if the target IP block is already in the desired powergate/ungate state. This can avoid some duplicate settings which sometimes may cause unexpected issues. Link: https://lore.kernel.org/all/yv81vidwqlwva...@zn.tnic/ Change-Id: I66346c69f121df0f5ee20182451313ae4fda2d04

Re: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-10 Thread Lazar, Lijo
On 11/9/2021 2:15 PM, Quan, Evan wrote: [AMD Official Use Only] -Original Message- From: Lazar, Lijo Sent: Tuesday, November 9, 2021 12:15 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Borislav Petkov Subject: Re: [PATCH] drm/amd/pm: avoid duplicate

RE: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-09 Thread Quan, Evan
ect: Re: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate > setting > > > > On 11/9/2021 12:46 PM, Christian König wrote: > > Am 08.11.21 um 15:41 schrieb Lazar, Lijo: > >> > >> > >> On 11/8/2021 7:44 PM, Christian König wrote: > >>>

RE: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-09 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Tuesday, November 9, 2021 12:15 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Borislav Petkov > > Subject: Re: [PATCH] drm/amd/pm: avoid duplicate power

Re: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-08 Thread Christian König
Am 09.11.21 um 08:28 schrieb Lazar, Lijo: [SNIP] Ok guys I've double checked the git history and found that this here is not as it is intended to be. See the code in question was just added in August by the following commit: commit 859e4659273f1df3a23e3990826bcb41e85f68a5 Author: Evan

Re: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-08 Thread Lazar, Lijo
On 11/9/2021 12:46 PM, Christian König wrote: Am 08.11.21 um 15:41 schrieb Lazar, Lijo: On 11/8/2021 7:44 PM, Christian König wrote: Am 08.11.21 um 12:15 schrieb Borislav Petkov: On Mon, Nov 08, 2021 at 09:51:03AM +0100, Paul Menzel wrote: Please elaborate the kind of issues. It fails

Re: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-08 Thread Christian König
Am 08.11.21 um 15:41 schrieb Lazar, Lijo: On 11/8/2021 7:44 PM, Christian König wrote: Am 08.11.21 um 12:15 schrieb Borislav Petkov: On Mon, Nov 08, 2021 at 09:51:03AM +0100, Paul Menzel wrote: Please elaborate the kind of issues. It fails to reboot on Carrizo-based laptops. That doesn't

Re: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-08 Thread Lazar, Lijo
On 11/9/2021 9:10 AM, Quan, Evan wrote: [AMD Official Use Only] -Original Message- From: Lazar, Lijo Sent: Monday, November 8, 2021 7:16 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Borislav Petkov Subject: Re: [PATCH] drm/amd/pm: avoid duplicate

RE: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-08 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Monday, November 8, 2021 10:41 PM > To: Koenig, Christian ; Borislav Petkov > ; Paul Menzel > Cc: Deucher, Alexander ; Quan, Evan > ; amd-gfx@lists.freedesktop.org > Subject: Re: [

RE: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-08 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Monday, November 8, 2021 7:16 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Borislav Petkov > > Subject: Re: [PATCH] drm/amd/pm: avoid duplicate power

RE: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-08 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Borislav Petkov > Sent: Monday, November 8, 2021 7:15 PM > To: Paul Menzel > Cc: Quan, Evan ; Deucher, Alexander > ; Lazar, Lijo ; amd- > g...@lists.freedesktop.org > Subject: Re: [PATCH] drm/amd/pm: avoid du

RE: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-08 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Paul Menzel > Sent: Monday, November 8, 2021 4:51 PM > To: Quan, Evan > Cc: Deucher, Alexander ; Lazar, Lijo > ; Borislav Petkov ; amd- > g...@lists.freedesktop.org > Subject: Re: [PATCH] drm/amd/pm: avoid du

Re: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-08 Thread Lazar, Lijo
On 11/8/2021 7:44 PM, Christian König wrote: Am 08.11.21 um 12:15 schrieb Borislav Petkov: On Mon, Nov 08, 2021 at 09:51:03AM +0100, Paul Menzel wrote: Please elaborate the kind of issues. It fails to reboot on Carrizo-based laptops. That doesn't necessary sounds like a good idea to me

Re: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-08 Thread Christian König
Am 08.11.21 um 12:15 schrieb Borislav Petkov: On Mon, Nov 08, 2021 at 09:51:03AM +0100, Paul Menzel wrote: Please elaborate the kind of issues. It fails to reboot on Carrizo-based laptops. That doesn't necessary sounds like a good idea to me then. What exactly is going wrong here? And what

Re: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-08 Thread Borislav Petkov
On Mon, Nov 08, 2021 at 09:51:03AM +0100, Paul Menzel wrote: > Please elaborate the kind of issues. It fails to reboot on Carrizo-based laptops. Whoever commits this, pls add Link: https://lore.kernel.org/r/yv81vidwqlwva...@zn.tnic so that it is clear what the whole story way. Thx. --

Re: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-08 Thread Lazar, Lijo
On 11/8/2021 10:17 AM, Evan Quan wrote: Just bail out if the target IP block is already in the desired powergate/ungate state. This can avoid some duplicate settings which sometime may cause unexpected issues. Change-Id: I66346c69f121df0f5ee20182451313ae4fda2d04 Signed-off-by: Evan Quan

Re: [PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-08 Thread Paul Menzel
Dear Evan, Am 08.11.21 um 05:47 schrieb Evan Quan: Just bail out if the target IP block is already in the desired powergate/ungate state. This can avoid some duplicate settings which sometime may cause unexpected issues. sometime*s* Please elaborate the kind of issues. On what systems did

[PATCH] drm/amd/pm: avoid duplicate powergate/ungate setting

2021-11-07 Thread Evan Quan
Just bail out if the target IP block is already in the desired powergate/ungate state. This can avoid some duplicate settings which sometime may cause unexpected issues. Change-Id: I66346c69f121df0f5ee20182451313ae4fda2d04 Signed-off-by: Evan Quan Tested-by: Borislav Petkov ---