Re: [PATCH] drm/amd/powerplay: Fix double unlock bug in smu_sys_set_pp_table()

2019-03-21 Thread Julia Lawall
t; ; Huang, Ray ; Gao, Likun > > > > ; Gui, Jack ; amd- > > > > g...@lists.freedesktop.org; kernel-janit...@vger.kernel.org > > > > Subject: [PATCH] drm/amd/powerplay: Fix double unlock bug in > > > > smu_sys_set_pp_table() > > > > > > >

RE: [PATCH] drm/amd/powerplay: Fix double unlock bug in smu_sys_set_pp_table()

2019-03-21 Thread Julia Lawall
, David(ChunMing) > > ; David Airlie ; Daniel Vetter > > ; Huang, Ray ; Gao, Likun > > ; Gui, Jack ; amd- > > g...@lists.freedesktop.org; kernel-janit...@vger.kernel.org > > Subject: [PATCH] drm/amd/powerplay: Fix double unlock bug in > > smu_sys_set_pp_table() &g

Re: [PATCH] drm/amd/powerplay: Fix double unlock bug in smu_sys_set_pp_table()

2019-03-21 Thread Dan Carpenter
; > To: Deucher, Alexander ; Wang, Kevin(Yang) > > > > > > Cc: Koenig, Christian ; Zhou, David(ChunMing) > > > ; David Airlie ; Daniel Vetter > > > ; Huang, Ray ; Gao, Likun > > > ; Gui, Jack ; amd- > > > g...@lists.freedeskto

Re: [PATCH] drm/amd/powerplay: Fix double unlock bug in smu_sys_set_pp_table()

2019-03-21 Thread Wang, Kevin(Yang)
, March 21, 2019 2:28:22 PM To: Deucher, Alexander; Wang, Kevin(Yang) Cc: Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; Huang, Ray; Gao, Likun; Gui, Jack; amd-gfx@lists.freedesktop.org; kernel-janit...@vger.kernel.org Subject: [PATCH] drm/amd/powerplay: Fix double unlock bug

RE: [PATCH] drm/amd/powerplay: Fix double unlock bug in smu_sys_set_pp_table()

2019-03-21 Thread Huang, Ray
Gao, Likun > ; Gui, Jack ; amd- > g...@lists.freedesktop.org; kernel-janit...@vger.kernel.org > Subject: [PATCH] drm/amd/powerplay: Fix double unlock bug in > smu_sys_set_pp_table() > > We already unlocked a few lines earlier so this code unlocks twice on the > success path.

[PATCH] drm/amd/powerplay: Fix double unlock bug in smu_sys_set_pp_table()

2019-03-21 Thread Dan Carpenter
We already unlocked a few lines earlier so this code unlocks twice on the success path. Fixes: 5809d7420f97 ("drm/amd/powerplay: implement sysfs of pp_table for smu11 (v2)") Signed-off-by: Dan Carpenter --- I'm not sure what this bug looks like at runtime, but it's slightly weird that no one