Re: [PATCH] drm/amdgpu: Skip put_reset_domain if it doesnt exist

Looks OK to me. Reviewed by : shaoyun.liu From: Chander, Vignesh Sent: September 28, 2022 3:03 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun ; Chander, Vignesh Subject: [PATCH] drm/amdgpu: Skip put_reset_domain if it doesnt exist For xgmi sriov

[PATCH] drm/amdgpu: Skip put_reset_domain if it doesnt exist

For xgmi sriov, the reset is handled by host driver and hive->reset_domain is not initialized so need to check if it exists before doing a put. Signed-off-by: Vignesh Chander --- drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] drm/amdgpu: Skip put_reset_domain if it doesnt exist

Am 28.09.22 um 20:22 schrieb Vignesh Chander: For xgmi sriov, the reset is handled by host driver and hive->reset_domain is not initialized so need to check if it exists before doing a put. Once more: General practice is to make the *_put_*() functions NULL tolerant. So rather make this

[PATCH] drm/amdgpu: Skip put_reset_domain if it doesnt exist

For xgmi sriov, the reset is handled by host driver and hive->reset_domain is not initialized so need to check if it exists before doing a put. Signed-off-by: Vignesh Chander --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

RE: [PATCH] drm/amdgpu: Skip put_reset_domain if it doesnt exist

nal Message- From: Christian König Sent: Wednesday, September 28, 2022 1:45 PM To: Chander, Vignesh ; amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun Subject: Re: [PATCH] drm/amdgpu: Skip put_reset_domain if it doesnt exist Am 28.09.22 um 19:43 schrieb Vignesh Chander: > For sriov, the reset

Re: [PATCH] drm/amdgpu: Skip put_reset_domain if it doesnt exist

Am 28.09.22 um 19:43 schrieb Vignesh Chander: For sriov, the reset domain is no longer created so need to check if it exists before doing a put. Why is the reset domain no longer created for SRIOV? Regards, Christian. Signed-off-by: Vignesh Chander ---

RE: [PATCH] drm/amdgpu: Skip put_reset_domain if it doesnt exist

ent: Wednesday, September 28, 2022 1:38 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun ; Chander, Vignesh Subject: [PATCH] drm/amdgpu: Skip put_reset_domain if it doesnt exist Change-Id: Ifd6121fb94db3fadaa1dee61d35699abe1259409 Signed-off-by: Vignesh Chander --- drivers/gpu/drm/amd/amd

Re: [PATCH] drm/amdgpu: Skip put_reset_domain if it doesnt exist

Am 28.09.22 um 19:37 schrieb Vignesh Chander: Change-Id: Ifd6121fb94db3fadaa1dee61d35699abe1259409 Signed-off-by: Vignesh Chander --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c

[PATCH] drm/amdgpu: Skip put_reset_domain if it doesnt exist

For sriov, the reset domain is no longer created so need to check if it exists before doing a put. Signed-off-by: Vignesh Chander --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c

Re: [PATCH] drm/amdgpu: Skip put_reset_domain if it doesnt exist

On 2022-09-28 13:37, Vignesh Chander wrote: Change-Id: Ifd6121fb94db3fadaa1dee61d35699abe1259409 Signed-off-by: Vignesh Chander Please remove the Change-Id and provide commit message body. --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH] drm/amdgpu: Skip put_reset_domain if it doesnt exist

Change-Id: Ifd6121fb94db3fadaa1dee61d35699abe1259409 Signed-off-by: Vignesh Chander --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c index