On 2018-04-18 11:57 AM, Qu, Jim wrote:
> OK, Please push your patch ASAP.
Done:
commit 9f6a8905611b5b1d8fcd31bebbc9af7ca1355cc3
Author: Jim Qu
Date: Tue Apr 17 19:11:16 2018 +0800
Wait for pending scanout update before calling drmmode_crtc_scanout_free
--
Earthling
OK, Please push your patch ASAP.
Thanks
JimQu
发件人: Michel Dänzer <mic...@daenzer.net>
发送时间: 2018年4月18日 17:54
收件人: Qu, Jim
抄送: amd-gfx@lists.freedesktop.org
主题: Re: 答复: 答复: [PATCH] sync amdgpu scanout update event before mode setting
On 2018-04-18
On 2018-04-18 11:44 AM, Qu, Jim wrote:
> Yeah, I realize that it should use || . I will check it again with your
> modification.
I've verified that it fixes the crash.
> and then push it immediately. The issue has delayed a long time.
Really? I haven't seen anything about this before you
件人: Qu, Jim
抄送: amd-gfx@lists.freedesktop.org
主题: Re: 答复: [PATCH] sync amdgpu scanout update event before mode setting
On 2018-04-18 11:12 AM, Qu, Jim wrote:
> Hi Michel,
>
> drmmode_crtc_wait_pending_event(drmmode_crtc, pAMDGPUEnt->fd,
> drmmo
On 2018-04-18 11:12 AM, Qu, Jim wrote:
> Hi Michel,
>
> drmmode_crtc_wait_pending_event(drmmode_crtc, pAMDGPUEnt->fd,
> drmmode_crtc->flip_pending ||
> drmmode_crtc->scanout_update_pending);
>
> Here, should not use && for this
on?
Thanks
JimQu
发件人: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> 代表 Qu, Jim <jim...@amd.com>
发送时间: 2018年4月18日 17:00
收件人: Michel Dänzer
抄送: amd-gfx@lists.freedesktop.org
主题: 答复: [PATCH] sync amdgpu scanout update event before
Okay if I make that modification before pushing?
A: Yes , of course :p)
Thanks
JimQu
发件人: Michel Dänzer <mic...@daenzer.net>
发送时间: 2018年4月18日 16:55
收件人: Qu, Jim
抄送: amd-gfx@lists.freedesktop.org
主题: Re: [PATCH] sync amdgpu scanout update event
On 2018-04-17 01:11 PM, Jim Qu wrote:
> There is a case that when set screen from reverse to normal, the old
> scanout damage is freed in modesetting before sanout update handler,
> so it causes segment fault issue.
Good catch, thanks.
> diff --git a/src/drmmode_display.c
Hi,
Any comments for this patch?
Thanks
JimQu
发件人: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> 代表 Jim Qu <jim...@amd.com>
发送时间: 2018年4月17日 19:11
收件人: amd-gfx@lists.freedesktop.org
抄送: Qu, Jim
主题: [PATCH] sync amdgpu scanout update event
There is a case that when set screen from reverse to normal, the old
scanout damage is freed in modesetting before sanout update handler,
so it causes segment fault issue.
Change-Id: I0fc6282688054d1e0f23d1ba66d4227553de53f3
Signed-off-by: Jim Qu
---
src/drmmode_display.c | 3
10 matches
Mail list logo