Re: [PATCH] drm/scheduler: add NULL pointer check for run queue (v2)

2018-07-16 Thread Zhang, Jerry (Junwei)
On 07/16/2018 05:54 PM, Michel Dänzer wrote: On 2018-07-16 11:23 AM, Junwei Zhang wrote: To check rq pointer before adding entity into it. That avoids NULL pointer access in some case. v2: move the check to caller Suggested-by: Christian König Signed-off-by: Junwei Zhang ---

Re: [PATCH] drm/scheduler: add NULL pointer check for run queue (v2)

2018-07-16 Thread Michel Dänzer
On 2018-07-16 11:23 AM, Junwei Zhang wrote: > To check rq pointer before adding entity into it. > That avoids NULL pointer access in some case. > > v2: move the check to caller > > Suggested-by: Christian König > Signed-off-by: Junwei Zhang > --- > drivers/gpu/drm/scheduler/gpu_scheduler.c |

Re: [PATCH] drm/scheduler: add NULL pointer check for run queue (v2)

2018-07-16 Thread Christian König
Am 16.07.2018 um 11:23 schrieb Junwei Zhang: To check rq pointer before adding entity into it. That avoids NULL pointer access in some case. v2: move the check to caller Suggested-by: Christian König Signed-off-by: Junwei Zhang Reviewed-by: Christian König ---

Re: [PATCH] drm/scheduler: add NULL pointer check for run queue

2018-07-16 Thread Zhang, Jerry (Junwei)
On 07/16/2018 05:11 PM, Christian König wrote: Am 16.07.2018 um 11:01 schrieb Zhang, Jerry (Junwei): On 07/16/2018 04:31 PM, Christian König wrote: Am 16.07.2018 um 04:59 schrieb Junwei Zhang: To check rq pointer before adding entity into it. That avoids NULL pointer access in some case.

Re: [PATCH] drm/scheduler: add NULL pointer check for run queue

2018-07-16 Thread Christian König
Am 16.07.2018 um 11:01 schrieb Zhang, Jerry (Junwei): On 07/16/2018 04:31 PM, Christian König wrote: Am 16.07.2018 um 04:59 schrieb Junwei Zhang: To check rq pointer before adding entity into it. That avoids NULL pointer access in some case. Suggested-by: Christian König Signed-off-by:

Re: [PATCH] drm/scheduler: add NULL pointer check for run queue

2018-07-16 Thread Zhang, Jerry (Junwei)
On 07/16/2018 04:31 PM, Christian König wrote: Am 16.07.2018 um 04:59 schrieb Junwei Zhang: To check rq pointer before adding entity into it. That avoids NULL pointer access in some case. Suggested-by: Christian König Signed-off-by: Junwei Zhang ---

Re: [PATCH] drm/scheduler: add NULL pointer check for run queue

2018-07-16 Thread Christian König
Am 16.07.2018 um 04:59 schrieb Junwei Zhang: To check rq pointer before adding entity into it. That avoids NULL pointer access in some case. Suggested-by: Christian König Signed-off-by: Junwei Zhang --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 4 1 file changed, 4 insertions(+)