Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

2023-01-17 Thread Guilherme G. Piccoli
On 17/01/2023 13:24, Limonciello, Mario wrote: > [...] >>> Though I see two problems with that: first, I'm not sure what's the >>> impact in the GPU functioning when I disable some IP block. >>> > > It depends on the individual block what the impact is. For example > if you don't have VCN, then

RE: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

2023-01-17 Thread Limonciello, Mario
s.freedesktop.org; Lazar, Lijo > ; kernel-...@igalia.com; Deucher, Alexander > ; Zhu, James ; > Koenig, Christian ; Pierre-Loup Griffais > > Subject: Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force > (en/dis)abling indirect SRAM mode > > On Tue, Jan 17, 2023 at 9:33 AM

Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

2023-01-17 Thread Alex Deucher
On Tue, Jan 17, 2023 at 9:33 AM Guilherme G. Piccoli wrote: > > On 16/01/2023 23:33, Limonciello, Mario wrote: > > [...] > > > > For debugging these type of problems, I think an effective debugging > > tactic would have been to mask the IP block (amdgpu.ip_block_mask). > > Thank you, it worked

Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

2023-01-17 Thread Guilherme G. Piccoli
On 16/01/2023 23:33, Limonciello, Mario wrote: > [...] > > For debugging these type of problems, I think an effective debugging > tactic would have been to mask the IP block (amdgpu.ip_block_mask). Thank you, it worked indeed - nice suggestion! Though I see two problems with that: first, I'm

Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

2023-01-17 Thread Guilherme G. Piccoli
On 16/01/2023 20:00, Alex Deucher wrote: > [...] > > It's not clear to me when this would be used. We only disable it > briefly during new asic bring up, after that we never touch it again. > No end user on production hardware should ever have to change it and > doing so would break VCN on their

Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

2023-01-16 Thread Limonciello, Mario
On 1/16/2023 18:47, Guilherme G. Piccoli wrote: On 16/01/2023 20:00, Alex Deucher wrote: [...] It's not clear to me when this would be used. We only disable it briefly during new asic bring up, after that we never touch it again. No end user on production hardware should ever have to change

Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

2023-01-16 Thread Alex Deucher
On Mon, Jan 16, 2023 at 5:34 PM Guilherme G. Piccoli wrote: > > On 16/01/2023 19:27, Liu, Leo wrote: > > Secure part requires PSP load VCN boot sequence which is with indirect > > sram mode. > > > > Regards, > > Leo > > With that said, and with the plans of just setting the indirect sram > mode

Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

2023-01-16 Thread Guilherme G. Piccoli
On 16/01/2023 19:27, Liu, Leo wrote: > Secure part requires PSP load VCN boot sequence which is with indirect > sram mode. > > Regards, > Leo With that said, and with the plans of just setting the indirect sram mode nevertheless (with no switch/cases anymore - I'll submit the V2 tomorrow if

Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

2023-01-16 Thread Liu, Leo
; dri-de...@lists.freedesktop.org ; Lazar, Lijo ; Limonciello, Mario ; kernel-...@igalia.com ; Deucher, Alexander ; Zhu, James ; Liu, Leo ; Koenig, Christian Subject: Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode On Mon, Jan 16, 2023 at 4:21 PM

Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

2023-01-16 Thread Alex Deucher
On Mon, Jan 16, 2023 at 4:21 PM Guilherme G. Piccoli wrote: > > Currently the FW loading path perform some checks based on IP model > and in case it is advertised as supported, the VCN indirect SRAM > mode is used. > > Happens that in case there's any issue on FW and this mode ends-up > not being