Re: lock/unlock mismatch in ttm_bo.c

2018-01-22 Thread Tom St Denis
On 22/01/18 01:42 AM, Chunming Zhou wrote: On 2018年01月20日 02:23, Tom St Denis wrote: On 19/01/18 01:14 PM, Tom St Denis wrote: Hi all, In the function ttm_bo_cleanup_refs() it seems possible to get to line 551 without entering the block on 516 which means you'll be unlocking a mutex that

[PATCH 3/3] drm/amdgpu: move static CSA address to top of address space

2018-01-22 Thread Christian König
There seems to be a design flaw with this since the address of the static CSA is never exported anywhere. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 15 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h | 6 -- 2 files

[PATCH 1/3] drm/amdgpu: reduce reserved VA size

2018-01-22 Thread Christian König
1MB should be more than enough, currently we use about 8K. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h

[PATCH 2/3] drm/amdgpu: apply top reserved VA space to pre Vega10 as well

2018-01-22 Thread Christian König
Reserve VA space at the top for older generations as well. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 3 ++- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 3 ++-

[PATCH umr] Continue decoding a PDB when using --vm-decode

2018-01-22 Thread Tom St Denis
Previously if a PTE was hit with V=0 the decoder would stop. Now it continues but only if you're doing a --vm-decode. Signed-off-by: Tom St Denis Reported-by: Christian König --- src/lib/read_vram.c | 8 1 file changed, 4 insertions(+), 4

[PATCH 2/3] drm/amdgpu: fallback to generic HDP operation

2018-01-22 Thread Christian König
When ring special operations aren't available we can fallback to the generic ASIC operations. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git

[PATCH 5/5] drm/amdgpu: retire soc15ip.h

2018-01-22 Thread Hawking Zhang
Change-Id: Ieaa45fa9cfcdb9dec68dd777d27daac675d94a00 Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/include/soc15ip.h | 1343 - 1 file changed, 1343 deletions(-) delete mode 100644 drivers/gpu/drm/amd/include/soc15ip.h diff --git

[PATCH 3/5] drm/amd/pp: include new ip and ip offset headers

2018-01-22 Thread Hawking Zhang
Change-Id: I9b3a56147dfc00830a0229bf59990bfe9e8a7e95 Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/powerplay/inc/pp_soc15.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/inc/pp_soc15.h

[PATCH 4/5] drm/amd/dc: include new ip and ip_offset headers

2018-01-22 Thread Hawking Zhang
Change-Id: I886747dbfea9eec4f3f7f8af8ce99f04c2a8f1b7 Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c| 3 ++- drivers/gpu/drm/amd/display/dc/dce120/dce120_hw_sequencer.c | 3 ++-

[PATCH 3/3] drm/amdgpu: remove now superflous *_hdp operation

2018-01-22 Thread Christian König
All HDP invalidation and most flush can now be replaced by the generic ASIC function. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 7 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 1

[PATCH 1/3] drm/amdgpu: add optional ring to *_hdp callbacks

2018-01-22 Thread Christian König
This adds an optional ring to the invalidate_hdp and flush_hdp callbacks. If the ring isn't specified or the emit_wreg function not available the HDP operation will be done with the CPU otherwise by writing on the ring. Signed-off-by: Christian König ---

[PATCH libdrm] amdgpu: fix high VA mask

2018-01-22 Thread Christian König
That constant needs to be 64bits. Fixes: amdgpu: use the high VA range if possible v2 Signed-off-by: Christian König --- amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/amdgpu/amdgpu_device.c b/amdgpu/amdgpu_device.c index

[PATCH 2/5] drm/amdgpu: include new ip and ip offset headers

2018-01-22 Thread Hawking Zhang
Change-Id: I4abff0cc4cd1ffcbc7a571d3eed9df12b3ff7b7c Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/vega10_reg_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vega10_reg_init.c

[PATCH 1/5] drm/amdgpu: split soc15ip header into ip and ip_offset header

2018-01-22 Thread Hawking Zhang
ip base could be different per ASIC since from soc15. split soc15 header into common ip/hw_id header and asic specific ip offset header Change-Id: I54e5856e1b99d4e313e61328c0fcd85cdd3b3267 Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/include/soc15_hw_ip.h |

Re: [PATCH 1/5] drm/amdgpu: split soc15ip header into ip and ip_offset header

2018-01-22 Thread Christian König
Am 22.01.2018 um 13:15 schrieb Hawking Zhang: ip base could be different per ASIC since from soc15. split soc15 header into common ip/hw_id header and asic specific ip offset header Change-Id: I54e5856e1b99d4e313e61328c0fcd85cdd3b3267 Signed-off-by: Hawking Zhang

Re: [PATCH] drm/amdgpu: drop the drm irq pre/post/un install callbacks

2018-01-22 Thread Harry Wentland
On 2018-01-22 12:22 PM, Alex Deucher wrote: > The preinstall callback didn't do anything because not all > of the IPs were initialized when it was called. > > Move the postinstall setup into sequence in the driver. > > The uninstall callback disabled all interrupt source, but > it got called too

Re: [PATCH 01/13] drm/amdgpu: rename static functions in amdgpu_display.c

2018-01-22 Thread Christian König
Am 22.01.2018 um 20:38 schrieb Samuel Li: Add display to the name for consistency. Signed-off-by: Samuel Li Nice cleanup, series is Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 41 -

Re: [PATCH] drm/amdgpu: drop the drm irq pre/post/un install callbacks

2018-01-22 Thread Lipski, Mikita
Tested-By: Mikita Lipski Thanks, Nick From: Grodzovsky, Andrey Sent: Monday, January 22, 2018 1:36:01 PM To: Wentland, Harry; Alex Deucher; amd-gfx@lists.freedesktop.org; Lipski, Mikita Cc: Deucher, Alexander Subject: Re: [PATCH]

[PATCH 03/13] drm/amdgpu: rename amdgpu_crtc_set_config

2018-01-22 Thread Samuel Li
Add display to the name for consistency. Signed-off-by: Samuel Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h| 4 ++-- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c |

[PATCH 01/13] drm/amdgpu: rename static functions in amdgpu_display.c

2018-01-22 Thread Samuel Li
Add display to the name for consistency. Signed-off-by: Samuel Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 41 - 1 file changed, 22 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c

[PATCH 10/13] drm/amdgpu: rename amdgpu_crtc_scaling_mode_fixup

2018-01-22 Thread Samuel Li
Add display to the name for consistency. Signed-off-by: Samuel Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h| 6 +++--- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c

[PATCH 08/13] drm/amdgpu: rename amdgpu_modeset_create_props

2018-01-22 Thread Samuel Li
Add display to the name for consistency. Signed-off-by: Samuel Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c| 2 +-

[PATCH 07/13] drm/amdgpu: rename amdgpu_user_framebuffer_create

2018-01-22 Thread Samuel Li
Add display to the name for consistency. Signed-off-by: Samuel Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 8 drivers/gpu/drm/amd/amdgpu/amdgpu_display.h | 6 +++--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 3 files changed, 8

[PATCH 04/13] drm/amdgpu: rename amdgpu_print_display_setup

2018-01-22 Thread Samuel Li
Add display to the name for consistency. Signed-off-by: Samuel Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h| 2 +- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 +-

[PATCH 13/13] drm/amdgpu: rename amdgpu_freesync_ioctl

2018-01-22 Thread Samuel Li
Add display to the name for consistency. Signed-off-by: Samuel Li --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- 3 files changed, 5 insertions(+), 5

[PATCH 02/13] drm/amdgpu: rename amdgpu_crtc_page_flip_target

2018-01-22 Thread Samuel Li
Add display to the name for consistency. Signed-off-by: Samuel Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h| 10 +- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +-

[PATCH 06/13] drm/amdgpu: rename amdgpu_framebuffer_init

2018-01-22 Thread Samuel Li
Add display to the name for consistency. Signed-off-by: Samuel Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 11 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h| 8 3 files changed, 11

[PATCH 09/13] drm/amdgpu: rename amdgpu_update_display_priority

2018-01-22 Thread Samuel Li
Rename as amdgpu_display_update_priority for consistency. Signed-off-by: Samuel Li --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +-

[PATCH 05/13] drm/amdgpu: rename amdgpu_ddc_probe

2018-01-22 Thread Samuel Li
Add display to the name for consistency. Signed-off-by: Samuel Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 10 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_display.c| 6 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 3 ++- 3 files changed, 11

[PATCH 11/13] drm/amdgpu: rename amdgpu_get_crtc_scanoutpos

2018-01-22 Thread Samuel Li
Add display to the name for consistency. Signed-off-by: Samuel Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 14 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 8

[PATCH 12/13] drm/amdgpu: rename amdgpu_crtc_idx_to_irq_type

2018-01-22 Thread Samuel Li
Add display to the name for consistency. Signed-off-by: Samuel Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 2 +-

Re: kasan report while running piglit

2018-01-22 Thread Tom St Denis
On 22/01/18 09:03 AM, Tom St Denis wrote: I've rolled back quite a ways from the tip of drm-next (to 196f74897ba79f6d586894519f09796447d95be5) which is ~1700 commits back from the tip and still get the attached KASAN report every time. I'm running piglit with DRI_PRIME=1 with the max size

Re: [PATCH] drm/amdgpu: drop the drm irq pre/post/un install callbacks

2018-01-22 Thread Christian König
Am 22.01.2018 um 18:22 schrieb Alex Deucher: The preinstall callback didn't do anything because not all of the IPs were initialized when it was called. Move the postinstall setup into sequence in the driver. The uninstall callback disabled all interrupt source, but it got called too late in

Re: [PATCH] drm/amdgpu: drop the drm irq pre/post/un install callbacks

2018-01-22 Thread Andrey Grodzovsky
+ Mikita who verified the patch. Andrey On 01/22/2018 01:34 PM, Harry Wentland wrote: On 2018-01-22 12:22 PM, Alex Deucher wrote: The preinstall callback didn't do anything because not all of the IPs were initialized when it was called. Move the postinstall setup into sequence in the

[PATCH libdrm] amdgpu: typedef syncobj handle

2018-01-22 Thread Chunming Zhou
Change-Id: I1e798d0fbb7e2023d6619f515a9cfaf029b62b6d Signed-off-by: Chunming Zhou --- amdgpu/amdgpu.h| 21 + amdgpu/amdgpu_cs.c | 16 2 files changed, 21 insertions(+), 16 deletions(-) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h

Re: x11vnc display output problem while the physical monitor display is normal.

2018-01-22 Thread Lvzhihong (ReJohn)
As we debug into the code, we found that the calls of glreadpixels function returns a large number of pixels which value are '0'. It means that when the problem appear, the call of glreadpixels function will get wrong pixels from framebuffer. But we still confused why and when the problem

Re: [PATCH] drm/amdgpu: use queue 0 for kiq ring

2018-01-22 Thread Alex Deucher
On Mon, Jan 22, 2018 at 8:45 AM, Huang Rui wrote: > It must use queue id 0, because CGPG_IDLE/SAVE/LOAD/RUN only can be issued on > queue 0. > > Signed-off-by: Huang Rui > Acked-by: Hawking Zhang > Reviewed-by: Alex Deucher

Re: [PATCH 15/24] drm/amd/display: Fix deadlock when flushing irq

2018-01-22 Thread Lipski, Mikita
Hi Andrey, I've checked to revert this change and use Alex's change on switching irq destruction sequence and it worked no problem. You can reject this change if Alex's change is pulled in. Thanks, Nick From: Grodzovsky, Andrey Sent: Friday, January 19, 2018

Re: [PATCH] drm/amdgpu: use queue 0 for kiq ring

2018-01-22 Thread Felix Kuehling
KFD currently hard-codes MEC2, Pipe0, Queue0 for the HIQ. (For some reason KFD numbers MECs starting from 1, not 0.) So that narrows your choice for KIQ on MEC2 down to pipe == 1, queue == 0. Regards,   Felix On 2018-01-22 08:45 AM, Huang Rui wrote: > It must use queue id 0, because

Re: [PATCH v2] drm/amd/display: dc: Remove unused display_mode_vba.c

2018-01-22 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Harry Wentland Sent: Monday, January 22, 2018 4:27 PM To: amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey; Cheng,

Re: [PATCH xf86-video-amdgpu] Fix linear check in amdgpu_glamor_share_pixmap_backing

2018-01-22 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Jan 22, 2018 at 6:36 PM, Michel Dänzer wrote: > From: Michel Dänzer > > We were incorrectly interpreting the tiling information. > > Reported-by: Marek Olšák >

Re: [PATCH xf86-video-amdgpu] Fix linear check in amdgpu_glamor_share_pixmap_backing

2018-01-22 Thread Alex Deucher
On Mon, Jan 22, 2018 at 12:36 PM, Michel Dänzer wrote: > From: Michel Dänzer > > We were incorrectly interpreting the tiling information. > > Reported-by: Marek Olšák > Signed-off-by: Michel Dänzer

Re: atomic debugfs files not created

2018-01-22 Thread Alex Deucher
On Mon, Jan 22, 2018 at 3:20 PM, Drew Davenport wrote: > I was doing some debugging and found that /sys/kernel/debug/dri/0/state > doesn't get created for amdgpu. After a bit of digging around I found that > the DRIVER_ATOMIC feature flag gets set in dm_early_init in

Re: [PATCH] drm/amdgpu: use queue 0 for kiq ring

2018-01-22 Thread Alex Deucher
On Mon, Jan 22, 2018 at 12:53 PM, Andres Rodriguez wrote: > > > On 2018-01-22 08:45 AM, Huang Rui wrote: >> >> It must use queue id 0, because CGPG_IDLE/SAVE/LOAD/RUN only can be issued >> on >> queue 0. >> >> Signed-off-by: Huang Rui >> Acked-by: Hawking

Re: [PATCH 01/13] drm/amdgpu: rename static functions in amdgpu_display.c

2018-01-22 Thread Alex Deucher
On Mon, Jan 22, 2018 at 2:42 PM, Christian König wrote: > Am 22.01.2018 um 20:38 schrieb Samuel Li: >> >> Add display to the name for consistency. >> >> Signed-off-by: Samuel Li > > > Nice cleanup, series is Acked-by: Christian König

Re: [PATCH] drm/amdgpu: use queue 0 for kiq ring

2018-01-22 Thread Huang Rui
On Tue, Jan 23, 2018 at 06:28:52AM +0800, Kuehling, Felix wrote: > KFD currently hard-codes MEC2, Pipe0, Queue0 for the HIQ. (For some > reason KFD numbers MECs starting from 1, not 0.) > > So that narrows your choice for KIQ on MEC2 down to pipe == 1, queue == 0. > Yes, actually, we use mec2

Re: [RFC] Per file OOM badness

2018-01-22 Thread Andrey Grodzovsky
On 01/22/2018 06:23 PM, Andrew Morton wrote: On Thu, 18 Jan 2018 11:47:48 -0500 Andrey Grodzovsky wrote: Hi, this series is a revised version of an RFC sent by Christian König a few years ago. The original RFC can be found at

RE: [PATCH 3/3] drm/amdgpu: move static CSA address to top of address space

2018-01-22 Thread He, Roger
-Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Monday, January 22, 2018 6:44 PM To: Liu, Monk ; amd-gfx@lists.freedesktop.org Subject: [PATCH 3/3] drm/amdgpu: move static CSA address to top of address

Re: [PATCH 3/3] drm/amdgpu: remove now superflous *_hdp operation

2018-01-22 Thread Chunming Zhou
Acked-by: Chunming Zhou for series. On 2018年01月22日 18:00, Christian König wrote: All HDP invalidation and most flush can now be replaced by the generic ASIC function. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h

Re: [RFC] Per file OOM badness

2018-01-22 Thread Andrew Morton
On Thu, 18 Jan 2018 11:47:48 -0500 Andrey Grodzovsky wrote: > Hi, this series is a revised version of an RFC sent by Christian König > a few years ago. The original RFC can be found at > https://lists.freedesktop.org/archives/dri-devel/2015-September/089778.html > >

Re: [PATCH 3/3] drm/amdgpu: move static CSA address to top of address space

2018-01-22 Thread Liu, Monk
Any bug introduced by original design ? I don't see why 8MB- 8KB as the start vm address of CSA has any trouble compared with top range ? Besides, please note that you also need modify gfx8/9 source to align emit_cs/de_meta with your change From: He, Roger

Re: [PATCH 3/3] drm/amdgpu: move static CSA address to top of address space

2018-01-22 Thread Liu, Monk
anyway I prefer no change on that part unless there issues or bug need to fix by the change. the CSA address is for use by CPG h/w not s/w, and since 8MB is a reserved range for each VM I don't see it's a design flaw with it From: Liu, Monk Sent: Tuesday,

Re: [PATCH] drm/amdgpu: Avoid leaking PM domain on driver unbind

2018-01-22 Thread Alex Deucher
On Sun, Jan 21, 2018 at 7:46 AM, Lukas Wunner wrote: > amdgpu_device_init() calls vga_switcheroo_init_domain_pm_ops() either > if the device has the PowerXpress flag set or if the user has set the > "runpm" module param to 1. > > However amdgpu_device_fini() calls

Re: [PATCH 15/24] drm/amd/display: Fix deadlock when flushing irq

2018-01-22 Thread Harry Wentland
On 2018-01-22 09:57 AM, Andrey Grodzovsky wrote: > You guys just need to revert it on dal-dev branch and don't promote to > amd-staging-drm-next. > K. I'll leave it out of amd-staging-drm-next and we'll revert on our internal branch. Thanks for following up on this and good to hear we found a

Re: [PATCH 15/24] drm/amd/display: Fix deadlock when flushing irq

2018-01-22 Thread Andrey Grodzovsky
NP. Alex just a reminder to push your patch from SWDEV-143068 into the tree. Thanks, Andrey On 01/22/2018 10:53 AM, Harry Wentland wrote: On 2018-01-22 09:57 AM, Andrey Grodzovsky wrote: You guys just need to revert it on dal-dev branch and don't promote to amd-staging-drm-next. K.

Re: [PATCH libdrm] amdgpu: fix high VA mask

2018-01-22 Thread Alex Deucher
On Mon, Jan 22, 2018 at 7:18 AM, Christian König wrote: > That constant needs to be 64bits. > > Fixes: amdgpu: use the high VA range if possible v2 > > Signed-off-by: Christian König Reviewed-by: Alex Deucher

[PATCH umr] Continue reading PDB if V=0 if in vm-decode mode

2018-01-22 Thread Tom St Denis
This will skip to the next page boundary (assumes page=4K right now) if in --vm-decode mode. Signed-off-by: Tom St Denis Reported-by: Christian König --- src/lib/read_vram.c | 25 + 1 file changed, 21 insertions(+), 4

Re: [PATCH 3/3] drm/amd/amdgpu: Add Polaris version check

2018-01-22 Thread Leo Liu
On 01/18/2018 10:49 AM, James Zhu wrote: Add Polaris version check if firmware support UVD encode Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 21 + 1 file changed, 21 insertions(+) diff --git

[PATCH] drm/amdgpu: use queue 0 for kiq ring

2018-01-22 Thread Huang Rui
It must use queue id 0, because CGPG_IDLE/SAVE/LOAD/RUN only can be issued on queue 0. Signed-off-by: Huang Rui Acked-by: Hawking Zhang Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 8 ++-- 1

Re: [PATCH umr] Continue decoding a PDB when using --vm-decode

2018-01-22 Thread Christian König
Am 22.01.2018 um 13:56 schrieb Tom St Denis: Previously if a PTE was hit with V=0 the decoder would stop. Now it continues but only if you're doing a --vm-decode. Signed-off-by: Tom St Denis Reported-by: Christian König Acked-by: Christian

kasan report while running piglit

2018-01-22 Thread Tom St Denis
I've rolled back quite a ways from the tip of drm-next (to 196f74897ba79f6d586894519f09796447d95be5) which is ~1700 commits back from the tip and still get the attached KASAN report every time. I'm running piglit with DRI_PRIME=1 with the max size memory tests disabled. Tom [0.00]

Re: [PATCH 15/24] drm/amd/display: Fix deadlock when flushing irq

2018-01-22 Thread Andrey Grodzovsky
You guys just need to revert it on dal-dev branch and don't promote to amd-staging-drm-next. So NAK for the change. Thanks, Andrey On 01/22/2018 09:38 AM, Lipski, Mikita wrote: Hi Andrey, I've checked to revert this change and use Alex's change on switching irq destruction sequence

[PATCH] drm/amdgpu: drop the drm irq pre/post/un install callbacks

2018-01-22 Thread Alex Deucher
The preinstall callback didn't do anything because not all of the IPs were initialized when it was called. Move the postinstall setup into sequence in the driver. The uninstall callback disabled all interrupt source, but it got called too late in the driver sequence and caused problems with IPs

Re: [PATCH 15/24] drm/amd/display: Fix deadlock when flushing irq

2018-01-22 Thread Deucher, Alexander
Thanks for verifying. Sent out for review. Alex From: Grodzovsky, Andrey Sent: Monday, January 22, 2018 11:01:36 AM To: Wentland, Harry; Lipski, Mikita; amd-gfx@lists.freedesktop.org; Deucher, Alexander Subject: Re: [PATCH 15/24] drm/amd/display: Fix deadlock

Re: [PATCH] drm/amdgpu: use queue 0 for kiq ring

2018-01-22 Thread Andres Rodriguez
On 2018-01-22 08:45 AM, Huang Rui wrote: It must use queue id 0, because CGPG_IDLE/SAVE/LOAD/RUN only can be issued on queue 0. Signed-off-by: Huang Rui Acked-by: Hawking Zhang Reviewed-by: Alex Deucher ---

Re: Depth 30 enablement for ati-ddx + exa. Rev 3

2018-01-22 Thread Michel Dänzer
On 2018-01-22 03:14 AM, Mario Kleiner wrote: > Ok, 3rd revision, now with per-x-screen drmmode_crtc_funcs rec > and set_gamma = NULL in the depth 30 case. Also back to Fredrik's > original exa 10 bit patch, just with his signed-off tacked on. > > Tested with single and dual x-screen, depth 24,