Re: [PATCH 3/8] drm/amdgpu:Add DPG support flag

2018-09-26 Thread James Zhu
On 2018-09-26 04:02 AM, Christian König wrote: Am 25.09.2018 um 21:55 schrieb James Zhu: Add DPG support flag for VCN DPG mode. Signed-off-by: James Zhu ---   drivers/gpu/drm/amd/include/amd_shared.h | 2 ++   1 file changed, 2 insertions(+) diff --git

RE: [PATCH v2 1/8] drm/amdgpu:Use register UVD_SCRATCH9 for VCN ring/ib test

2018-09-26 Thread Huang, Ray
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of James Zhu > Sent: Wednesday, September 26, 2018 7:03 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, James > Subject: [PATCH v2 1/8] drm/amdgpu:Use register UVD_SCRATCH9 for VCN > ring/ib

Re: [PATCH] drm/amdgpu: Fix copy error in uvd_v6/7_0.c

2018-09-26 Thread Christian König
Am 26.09.2018 um 14:41 schrieb Rex Zhu: Signed-off-by: Rex Zhu Actually that code can just be removed because uvd_*_enc_get_destroy_msg is only called with direct=true. Christian. --- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 2 +- 2 files

[PATCH] drm/amdgpu: Fix copy error in uvd_v6/7_0.c

2018-09-26 Thread Rex Zhu
Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c index 8ef4a53..2ceab76 100644 ---

[PATCH 7/7] drm/amdgpu: Change the gfx/sdma init/fini sequence

2018-09-26 Thread Rex Zhu
initialize gfx/sdma before dpm features enabled. and disable dpm features before gfx/sdma fini. Acked-by: Alex Deucher Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/cik.c | 17 + drivers/gpu/drm/amd/amdgpu/si.c| 13 +++-- drivers/gpu/drm/amd/amdgpu/soc15.c

[PATCH 6/7] drm/amd/pp: Export load_firmware interface

2018-09-26 Thread Rex Zhu
Export this interface for the AMDGPU_FW_LOAD_SMU type. gfx/sdma can request smu to load firmware. Split the smu7/8_start_smu function into two functions 1. start_smu, used for load smu firmware in smu7/8 and check smu firmware version. 2. request_smu_load_fw, used for load other ip's firmware

[PATCH 5/7] drm/amd/pp: Remove useless code in smu

2018-09-26 Thread Rex Zhu
Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c| 1 - drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 - drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 5 - drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c | 5 - 4 files changed, 12

Re: [PATCH] drm/amdgpu: Fix copy error in uvd_v6/7_0.c

2018-09-26 Thread Zhu, Rex
Ok. I will remove the code. Best Regards Rex From: Christian König Sent: Wednesday, September 26, 2018 8:45 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Fix copy error in uvd_v6/7_0.c Am 26.09.2018 um 14:41 schrieb Rex Zhu:

[PATCH 1/7] drm/amd/pp: Expose the smu support for SDMA PG cntl

2018-09-26 Thread Rex Zhu
SDMA IP can be power up/down via smu message Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 18 ++ drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 8 drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 + 3 files changed, 27

[PATCH 4/7] drm/amd/pp: Remove wrong code in fiji_start_smu

2018-09-26 Thread Rex Zhu
HW CG feature will be enabled after hw ip initialized Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c

[PATCH 3/7] drm/amd/pp: Remove uncessary extra vcn pg cntl in smu

2018-09-26 Thread Rex Zhu
the vcn power will be controlled by VCN. Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/smumgr/smu10_smumgr.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu10_smumgr.c

[PATCH 2/7] drm/amdgpu: Move out power up/down sdma out of smu

2018-09-26 Thread Rex Zhu
smu only expose interface to other ip blocks. in order to reduce dependence between smu and other ip blocks Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 6 ++ drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 1 +

Re: [PATCH v2 1/8] drm/amdgpu:Use register UVD_SCRATCH9 for VCN ring/ib test

2018-09-26 Thread James Zhu
On 2018-09-26 06:38 AM, Huang, Ray wrote: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of James Zhu Sent: Wednesday, September 26, 2018 7:03 AM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James Subject: [PATCH v2 1/8] drm/amdgpu:Use register

[PATCH] drm/amdkfd: Remove the requirement for atomic Ops on vg20

2018-09-26 Thread Kent Russell
From: Shaoyun Liu Firmware have the workaround to replace the atomic Ops with read-modify-write on CP side. User should not expect atomic Ops on system memory works normally if system didn't not support it. Change-Id: I89395b099fe0931b9b3627651b512dde3149fadd Signed-off-by: Shaoyun Liu

[PATCH 03/12] drm/amdgpu: remove VM fault_credit handling

2018-09-26 Thread Christian König
printk_ratelimit() is much better suited to limit the number of reported VM faults. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 37 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 5 - drivers/gpu/drm/amd/amdgpu/cik_ih.c | 18

[PATCH 05/12] drm/amdgpu: remove IV prescreening

2018-09-26 Thread Christian König
Not used any more. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h | 2 -- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 4 drivers/gpu/drm/amd/amdgpu/cik_ih.c | 13 - drivers/gpu/drm/amd/amdgpu/cz_ih.c | 13 -

[PATCH 02/12] drm/amdgpu: send IVs to the KFD only after processing them

2018-09-26 Thread Christian König
This allows us to filter out VM faults in the GMC code. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 29 + drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 2 +-

[PATCH 07/12] drm/amdgpu: simplify IH programming

2018-09-26 Thread Christian König
Calculate all the addresses and pointers in amdgpu_ih.c Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 34 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h | 23 - drivers/gpu/drm/amd/amdgpu/cik_ih.c | 9 -

[PATCH 08/12] drm/amdgpu: enable IH ring 1 and ring 2 v2

2018-09-26 Thread Christian König
The entries are ignored for now, but it at least stops crashing the hardware when somebody tries to push something to the other IH rings. v2: limit ring size, add TODO comment Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h | 4 +-

[PATCH 09/12] drm/amdgpu: add the IH to the IV trace

2018-09-26 Thread Christian König
To distinct on which IH ring an IV was found. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 11 +++ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git

[PATCH 11/12] drm/amdgpu: add support for self irq on Vega10

2018-09-26 Thread Christian König
This finally enables processing of ring 1 & 2. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 68 +++--- 1 file changed, 63 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c

[PATCH 10/12] drm/amdgpu: add support for processing IH ring 1 & 2

2018-09-26 Thread Christian König
Previously we only added the ring buffer memory, now add the handling as well. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 32 drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h | 4 +++- 2 files changed, 35 insertions(+), 1 deletion(-)

[PATCH 12/12] drm/amdgpu: disable IH ring 2 WPTR overflow on Vega10

2018-09-26 Thread Christian König
That should add back pressure on the client. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c b/drivers/gpu/drm/amd/amdgpu/vega10_ih.c index dd155a207fdd..c8525c29fc16 100644

[PATCH 06/12] drm/amdgpu: add IH ring to ih_get_wptr/ih_set_rptr v2

2018-09-26 Thread Christian König
Let's start to support multiple rings. v2: decode IV is needed as well Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 6 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h | 13 drivers/gpu/drm/amd/amdgpu/cik_ih.c | 29 +

[PATCH 01/12] drm/amdgpu: add missing error handling

2018-09-26 Thread Christian König
We ignored the return code here. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index f35d7a554ad5..2420ae90047e 100644 ---

RE: [PATCH 3/9] drm/amdgpu: cleanup amdgpu_ih.c

2018-09-26 Thread Huang, Ray
> -Original Message- > From: Koenig, Christian > Sent: Wednesday, September 26, 2018 4:58 PM > To: Huang, Ray > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 3/9] drm/amdgpu: cleanup amdgpu_ih.c > > Am 26.09.2018 um 10:52 schrieb Huang, Ray: > >> -Original Message- > >>

[PATCH 04/12] drm/amdgpu: move IV prescreening into the GMC code

2018-09-26 Thread Christian König
The GMC/VM subsystem is causing the faults, so move the handling here as well. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 59 + drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 69 -- 2 files changed, 59

Re: [PATCH 6/7] drm/amd/pp: Export load_firmware interface

2018-09-26 Thread Alex Deucher
On Wed, Sep 26, 2018 at 8:53 AM Rex Zhu wrote: > > Export this interface for the AMDGPU_FW_LOAD_SMU type. > gfx/sdma can request smu to load firmware. > > Split the smu7/8_start_smu function into two functions > 1. start_smu, used for load smu firmware in smu7/8 and >check smu firmware

Re: [PATCH 5/7] drm/amd/pp: Remove useless code in smu

2018-09-26 Thread Alex Deucher
On Wed, Sep 26, 2018 at 8:52 AM Rex Zhu wrote: > > Signed-off-by: Rex Zhu Please describe why the code is useless and can be removed. Thanks, Alex > --- > drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c| 1 - > drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 - >

Re: [PATCH 2/7] drm/amdgpu: Move out power up/down sdma out of smu

2018-09-26 Thread Alex Deucher
On Wed, Sep 26, 2018 at 8:52 AM Rex Zhu wrote: > > smu only expose interface to other ip blocks. > in order to reduce dependence between smu and other ip blocks > > Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 6 ++ >

Re: [PATCH 3/7] drm/amd/pp: Remove uncessary extra vcn pg cntl in smu

2018-09-26 Thread Alex Deucher
On Wed, Sep 26, 2018 at 8:52 AM Rex Zhu wrote: > > the vcn power will be controlled by VCN. > > Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/smumgr/smu10_smumgr.c | 16 +--- > 1 file changed, 1 insertion(+), 15 deletions(-) > > diff --git

Re: [PATCH 4/7] drm/amd/pp: Remove wrong code in fiji_start_smu

2018-09-26 Thread Alex Deucher
On Wed, Sep 26, 2018 at 8:52 AM Rex Zhu wrote: > > HW CG feature will be enabled after hw ip initialized > > Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c | 10 -- > 1 file changed, 10 deletions(-) > > diff --git

[PATCH -next] drm/amdgpu: remove set but not used variable 'header'

2018-09-26 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c: In function 'amdgpu_ucode_init_bo': drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c:431:39: warning: variable 'header' set but not used [-Wunused-but-set-variable] Signed-off-by: YueHaibing ---

RE: [PATCH 6/7] drm/amd/pp: Export load_firmware interface

2018-09-26 Thread Zhu, Rex
> -Original Message- > From: Alex Deucher > Sent: Wednesday, September 26, 2018 10:15 PM > To: Zhu, Rex > Cc: amd-gfx list > Subject: Re: [PATCH 6/7] drm/amd/pp: Export load_firmware interface > > On Wed, Sep 26, 2018 at 8:53 AM Rex Zhu wrote: > > > > Export this interface for the

Re: [PATCH 6/7] drm/amd/pp: Export load_firmware interface

2018-09-26 Thread Alex Deucher
On Wed, Sep 26, 2018 at 11:21 AM Zhu, Rex wrote: > > > > > -Original Message- > > From: Alex Deucher > > Sent: Wednesday, September 26, 2018 10:15 PM > > To: Zhu, Rex > > Cc: amd-gfx list > > Subject: Re: [PATCH 6/7] drm/amd/pp: Export load_firmware interface > > > > On Wed, Sep 26,

RE: [PATCH 6/7] drm/amd/pp: Export load_firmware interface

2018-09-26 Thread Zhu, Rex
> -Original Message- > From: Alex Deucher > Sent: Wednesday, September 26, 2018 11:39 PM > To: Zhu, Rex > Cc: amd-gfx list > Subject: Re: [PATCH 6/7] drm/amd/pp: Export load_firmware interface > > On Wed, Sep 26, 2018 at 11:21 AM Zhu, Rex wrote: > > > > > > > > > -Original

Re: [PATCH 1/7] drm/amd/pp: Expose the smu support for SDMA PG cntl

2018-09-26 Thread Alex Deucher
On Wed, Sep 26, 2018 at 8:51 AM Rex Zhu wrote: > > SDMA IP can be power up/down via smu message > > Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 18 ++ > drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 8

[PATCH 2/2] drm/amdgpu/vcn: whitespace cleanup

2018-09-26 Thread Alex Deucher
Fix some indentation issues. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 36 - 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c index

Re: [PATCH] drm/amdkfd: Remove the requirement for atomic Ops on vg20

2018-09-26 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Kent Russell Sent: Wednesday, September 26, 2018 9:41:52 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent; Liu, Shaoyun Subject: [PATCH] drm/amdkfd: Remove the requirement for atomic Ops on vg20 From:

Re: [PATCH 1/2] drm/amdgpu/soc15: fix warnings in register macro

2018-09-26 Thread James Zhu
On 2018-09-26 12:25 PM, Alex Deucher wrote: expects argument of type ‘unsigned int’ has type ‘long int’ Fixes: 52e211c1f04 ("drm/amdgpu:Add error message when register failed to reach expected value") Signed-off-by: Alex Deucher Reviewed-by: James Zhu for the series. ---

[PATCH 06/16] drm/amd/display: block DP YCbCr420 modes

2018-09-26 Thread sunpeng.li
From: Eric Yang [why] Currently not supported, will black screen when set. [How] Fail validate timing helper for those modes. Signed-off-by: Eric Yang Reviewed-by: Tony Cheng Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c | 3 +++

[PATCH 04/16] drm/amd/display: Calculate swizzle mode using bpp during validation

2018-09-26 Thread sunpeng.li
From: Su Sung Chung [Why] Previously bandwidth validation was failing because swizzle mode was not initialized during plane_state allocation. The swizzle mode was calculated using pixed format which is how swizzle mode is initially calculated in addrlib. [How] * Set default swizzle mode for

[PATCH 05/16] drm/amd/display: Add function to fetch clock requirements

2018-09-26 Thread sunpeng.li
From: Eryk Brol Also add dram clock to clocks struct, for systems that uses them. Signed-off-by: Eryk Brol Reviewed-by: Jun Lei Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/core/dc.c | 13 + drivers/gpu/drm/amd/display/dc/dc.h | 4 +++-

[PATCH 07/16] drm/amd/display: clean up encoding checks

2018-09-26 Thread sunpeng.li
From: Eric Yang [Why] All ASICS we support has YCbCr support, so the check is unnecessary, the currently logic in validate output also returns true all the time, so the unneccessary logic is removed Signed-off-by: Eric Yang Reviewed-by: Tony Cheng Acked-by: Leo Li ---

[PATCH 03/16] drm/amd/display: Add a check-function for virtual signal type

2018-09-26 Thread sunpeng.li
From: Nikola Cornij [why] Same functions exist for all other signal types. [how] Add a function that checks against virtual signal type. Signed-off-by: Nikola Cornij Reviewed-by: Leo Li --- drivers/gpu/drm/amd/display/include/signal_types.h | 5 + 1 file changed, 5 insertions(+) diff

[PATCH 08/16] drm/amd/display: WA for DF keeps awake after S0i3.

2018-09-26 Thread sunpeng.li
From: Yongqiang Sun [Why] DF keeps awake after S0i3 resume due to DRAM_STATE_CNTL is set by bios command table during dcn init_hw. [How] As a work around, check STATE_CNTL status before init_hw, if it is 0 before init_hw and set to 1 after init_hw, change it to 0. Signed-off-by: Yongqiang Sun

[PATCH 09/16] drm/amd/display: Fix Edid emulation for linux

2018-09-26 Thread sunpeng.li
From: Bhawanpreet Lakha [Why] EDID emulation didn't work properly for linux, as we stop programming if nothing is connected physically. [How] We get a flag from DRM when we want to do edid emulation. We check if this flag is true and nothing is connected physically, if so we only program the

[PATCH 10/16] drm/amd/display: dc 3.1.68

2018-09-26 Thread sunpeng.li
From: Tony Cheng Signed-off-by: Tony Cheng Reviewed-by: Steven Chiu Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index f328483..1995271

[PATCH 11/16] drm/amd/display: fix memory leak in resource pools

2018-09-26 Thread sunpeng.li
From: Jun Lei [why] ddc engines were recently changed to be independently tracked from pipe count. the change was reflected in resource constructor but not in destructor. this manifests as a memory leak when pipe harvesting is enabled, since not all constructed ddc engines are freed [how]

[PATCH 12/16] drm/amd/display: Flatten irq handler data struct

2018-09-26 Thread sunpeng.li
From: Leo Li [Why] There is no reason why the common data needs to be kept separate. [How] Flatten the struct by moving common data into the DM IRQ struct. Signed-off-by: Leo Li Reviewed-by: David Francis Acked-by: Leo Li --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 37

[PATCH 13/16] drm/amd/display: fix Interlace video timing.

2018-09-26 Thread sunpeng.li
From: Charlene Liu [Description] interlace mode shows wrong vertical timing. Interface timing in Edid is half vertical timing as progressive timing. driver doubled the vertical timing in edid_paser, no need to double in optc again. Signed-off-by: Charlene Liu Reviewed-by: Chris Park Acked-by:

[PATCH 01/16] drm/amd/display: Add DC build_id to determine build type

2018-09-26 Thread sunpeng.li
From: Jun Lei [why] Sometimes there are indications that the incorrect driver is being loaded in automated tests. This change adds the ability for builds to be tagged with a string, and picked up by the test infrastructure. [how] dc.c will allocate const for build id, which is init-ed with

[PATCH 00/16] DC Patches Sep 26, 2018

2018-09-26 Thread sunpeng.li
From: Leo Li Summary of change: * Edid emulation fix * S3 resume fix on Vega10 * Add build types for internal tracking * Fix screen corruption on polaris * Interlace video timing fix Bhawanpreet Lakha (1): drm/amd/display: Fix Edid emulation for linux Charlene Liu (2): drm/amd/display: fix

[PATCH 02/16] drm/amd/display: fix 4K stereo screen flash issue

2018-09-26 Thread sunpeng.li
From: Charlene Liu [Why] HDMI_scramber is not enabled for pixel rate >340Mhz. [How] Calculate the phy clock to include the Hw frame packing factor. Signed-off-by: Charlene Liu Reviewed-by: Chris Park Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 3 +++ 1 file

Re: [PATCH 1/2] drm/amdgpu/soc15: fix warnings in register macro

2018-09-26 Thread Christian König
Am 26.09.2018 um 18:25 schrieb Alex Deucher: expects argument of type ‘unsigned int’ has type ‘long int’ Fixes: 52e211c1f04 ("drm/amdgpu:Add error message when register failed to reach expected value") Signed-off-by: Alex Deucher Reviewed-by: Christian König for the series. ---

[PATCH 1/2] drm/amdgpu/soc15: fix warnings in register macro

2018-09-26 Thread Alex Deucher
expects argument of type ‘unsigned int’ has type ‘long int’ Fixes: 52e211c1f04 ("drm/amdgpu:Add error message when register failed to reach expected value") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc15_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 16/16] drm/amd/display: Raise dispclk value for dce_update_clocks

2018-09-26 Thread sunpeng.li
From: Nicholas Kazlauskas [Why] The DISPCLK value was previously requested to be 15% higher for all ASICS that went through the dce110 bandwidth code path. As part of a refactoring of dce_clocks and dce110 set_bandwidth this was removed for power saving considerations. This changed caused

[PATCH 14/16] drm/amd/display: HLK Periodic Frame Notification test failed

2018-09-26 Thread sunpeng.li
From: Murton Liu [Why] Due to a small pre-fetch window, the active vline timing is a couple of lines off when compared to what it should be. [How] Changed the calculation for the start vline to account for this window. Signed-off-by: Murton Liu Reviewed-by: Aric Cyr Acked-by: Leo Li ---

[PATCH 15/16] drm/amd/display: Fix Vega10 lightup on S3 resume

2018-09-26 Thread sunpeng.li
From: Roman Li [Why] There have been a few reports of Vega10 display remaining blank after S3 resume. The regression is caused by workaround for mode change on Vega10 - skip set_bandwidth if stream count is 0. As a result we skipped dispclk reset on suspend, thus on resume we may skip the clock

Re: [PATCH 02/12] drm/amdgpu: send IVs to the KFD only after processing them

2018-09-26 Thread Jay Cornwall
On Wed, Sep 26, 2018, at 08:53, Christian König wrote: > This allows us to filter out VM faults in the GMC code. > > Signed-off-by: Christian König The KFD needs to receive notification of unhandled VM faults; when demand paging is disabled or the address is not pageable. It propagates this to

Re: [PATCH 11/12] drm/amdgpu: add support for self irq on Vega10

2018-09-26 Thread Alex Deucher
On Wed, Sep 26, 2018 at 9:54 AM Christian König wrote: > > This finally enables processing of ring 1 & 2. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 68 > +++--- > 1 file changed, 63 insertions(+), 5 deletions(-) > > diff

[PATCH] drm/amdgpu: fix a NULL check in debugfs init

2018-09-26 Thread Dan Carpenter
The debugfs_create_file() returns error pointers if DEBUGFS isn't enabled. But here, we know that it is enabled so it returns NULL on error which could lead to a NULL dereference a few lines later. Signed-off-by: Dan Carpenter --- If someone wanted to delete the error handling as well that

[PATCH] drm/amd/powerplay: enable fan RPM and pwm settings V2

2018-09-26 Thread Evan Quan
Manual fan RPM and pwm setting on vega20 are available now. V2: correct the register for fan speed setting and avoid divide-by-zero Change-Id: Iad45a169d6984acc091c4efaf46973619fe43a29 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher Reviewed-by: Rex Zhu ---

[PATCH v2 4/8] drm/amdgpu:Add DPG mode read/write macro

2018-09-26 Thread James Zhu
Some registers read/write needs program through SDRAM pool under DPG mode. Signed-off-by: James Zhu Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc15_common.h | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc15_common.h

[PATCH v2 7/8] drm/amdgpu:Add DPG pause mode support

2018-09-26 Thread James Zhu
Add functions to support VCN DPG pause mode. Signed-off-by: James Zhu Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 161 +++- 1 file changed, 159 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c

[PATCH v2 2/8] drm/amdgpu:Add new register offset/mask to support VCN DPG mode

2018-09-26 Thread James Zhu
New register offset/mask need to be added to support VCN DPG mode. Signed-off-by: James Zhu Reviewed-by: Alex Deucher --- .../drm/amd/include/asic_reg/vcn/vcn_1_0_offset.h | 8 +++ .../drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h | 25 ++ 2 files changed, 33

Re: [PATCH 7/9] drm/amdgpu: add IH ring to ih_get_wptr/ih_set_rptr

2018-09-26 Thread Huang Rui
On Mon, Sep 24, 2018 at 02:38:18PM +0200, Christian König wrote: > Let's start to support multiple rings. > > Signed-off-by: Christian König Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 6 +++--- > drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h | 8 >

[PATCH v2 6/8] drm/amdgpu:Add DPG pause state

2018-09-26 Thread James Zhu
Add DPG pause state to support VCN DPG mode. Signed-off-by: James Zhu Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h index

[PATCH v2 1/8] drm/amdgpu:Use register UVD_SCRATCH9 for VCN ring/ib test

2018-09-26 Thread James Zhu
Use register UVD_SCRATCH9 for VCN ring/ib test. Since those registers can't be directly accessed under DPG(Dynamic Power Gate) mode. Signed-off-by: James Zhu Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 16 1 file changed, 8 insertions(+), 8

[PATCH v2 8/8] drm/amdgpu:Enable DPG mode on PCO

2018-09-26 Thread James Zhu
Add flag AMD_PG_SUPPORT_DPG to enable DPG mode on Picasso Signed-off-by: James Zhu Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc15.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c

[PATCH v2 3/8] drm/amdgpu:Add DPG support flag

2018-09-26 Thread James Zhu
Add DPG support flag for VCN DPG mode. Signed-off-by: James Zhu Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/include/amd_shared.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h index 86b167e..2083c30

[PATCH v2 5/8] drm/amdgpu:Add DPG mode support for vcn 1.0

2018-09-26 Thread James Zhu
Add DPG mode start/stop/mc_resume/clock_gating to support vcn 1.0 DPG mode. Signed-off-by: James Zhu Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 319 +- 1 file changed, 313 insertions(+), 6 deletions(-) diff --git

Re: [PATCH 7/9] drm/amdgpu: add IH ring to ih_get_wptr/ih_set_rptr

2018-09-26 Thread Huang Rui
On Mon, Sep 24, 2018 at 02:38:18PM +0200, Christian König wrote: > Let's start to support multiple rings. > > Signed-off-by: Christian König Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 6 +++--- > drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h | 8 >

Re: [PATCH 6/9] drm/amdgpu: separate IH and IRQ funcs

2018-09-26 Thread Huang Rui
On Mon, Sep 24, 2018 at 02:38:17PM +0200, Christian König wrote: > One for the ring buffer and one for the IV handling. > > Signed-off-by: Christian König Reviewed-by: Huang Rui How about merge amdgpu_ih.c into amdgpu_irq.c? As I think, we don't need two common interrupt handle files. IH is

Re: [PATCH 3/8] drm/amdgpu:Add DPG support flag

2018-09-26 Thread Christian König
Am 25.09.2018 um 21:55 schrieb James Zhu: Add DPG support flag for VCN DPG mode. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/include/amd_shared.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h

Re: [PATCH 6/9] drm/amdgpu: separate IH and IRQ funcs

2018-09-26 Thread Christian König
Am 26.09.2018 um 08:05 schrieb Huang Rui: On Mon, Sep 24, 2018 at 02:38:17PM +0200, Christian König wrote: One for the ring buffer and one for the IV handling. Signed-off-by: Christian König Reviewed-by: Huang Rui How about merge amdgpu_ih.c into amdgpu_irq.c? As I think, we don't need two

[PATCH] drm/amd/powerplay: Enable/Disable NBPSTATE on On/OFF of UVD

2018-09-26 Thread Satyajit Sahu
From: Akshu Agrawal We observe black lines (underflow) on display when playing a 4K video with UVD. On Disabling Low memory P state this issue is not seen. Multiple runs of power measurement shows no imapct. Change-Id: I6171ced550ee244e6b9a961fb50247d12f4168a0 Signed-off-by: Akshu Agrawal

Re: [PATCH 5/6] drm/amdgpu: add timeline support in amdgpu CS

2018-09-26 Thread Nicolai Hähnle
static int amdgpu_cs_submit(struct amdgpu_cs_parser *p, diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h index 1ceec56de015..412359b446f1 100644 --- a/include/uapi/drm/amdgpu_drm.h +++ b/include/uapi/drm/amdgpu_drm.h @@ -517,6 +517,8 @@ struct drm_amdgpu_gem_va {

RE: [PATCH 8/9] drm/amdgpu: simplify IH programming

2018-09-26 Thread Huang, Ray
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian K?nig > Sent: Monday, September 24, 2018 8:38 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 8/9] drm/amdgpu: simplify IH programming > > Calculate all the addresses and

RE: [PATCH 9/9] drm/amdgpu: enable IH ring 1 and ring 2

2018-09-26 Thread Huang, Ray
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian K?nig > Sent: Monday, September 24, 2018 8:38 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 9/9] drm/amdgpu: enable IH ring 1 and ring 2 > > The entries are ignored for

Re: [PATCH 5/9] drm/amdgpu: move more defines into amdgpu_irq.h

2018-09-26 Thread Huang Rui
On Mon, Sep 24, 2018 at 02:38:16PM +0200, Christian König wrote: > Everything that isn't related to the IH ring. > > Signed-off-by: Christian König Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h| 22 +--- >

Re: [PATCH 5/6] drm/amdgpu: add timeline support in amdgpu CS

2018-09-26 Thread Nicolai Hähnle
Hey Chunming, On 20.09.2018 13:03, Chunming Zhou wrote: @@ -1113,48 +1117,91 @@ static int amdgpu_syncobj_lookup_and_add_to_sync(struct amdgpu_cs_parser *p, } static int amdgpu_cs_process_syncobj_in_dep(struct amdgpu_cs_parser *p, - struct

RE: [PATCH 3/9] drm/amdgpu: cleanup amdgpu_ih.c

2018-09-26 Thread Huang, Ray
> -Original Message- > From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] > Sent: Tuesday, September 25, 2018 7:01 PM > To: Huang, Ray > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 3/9] drm/amdgpu: cleanup amdgpu_ih.c > > Am 25.09.2018 um 12:28 schrieb Huang Rui:

Re: [PATCH 3/9] drm/amdgpu: cleanup amdgpu_ih.c

2018-09-26 Thread Christian König
Am 26.09.2018 um 10:52 schrieb Huang, Ray: -Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Tuesday, September 25, 2018 7:01 PM To: Huang, Ray Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/9] drm/amdgpu: cleanup amdgpu_ih.c Am

RE: [PATCH 6/9] drm/amdgpu: separate IH and IRQ funcs

2018-09-26 Thread Huang, Ray
> -Original Message- > From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] > Sent: Wednesday, September 26, 2018 4:09 PM > To: Huang, Ray > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 6/9] drm/amdgpu: separate IH and IRQ funcs > > Am 26.09.2018 um 08:05 schrieb

Re: [PATCH 6/9] drm/amdgpu: separate IH and IRQ funcs

2018-09-26 Thread Christian König
Am 26.09.2018 um 11:16 schrieb Huang, Ray: -Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Wednesday, September 26, 2018 4:09 PM To: Huang, Ray Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 6/9] drm/amdgpu: separate IH and IRQ funcs Am

Re: [PATCH 4/9] drm/amdgpu: move more interrupt processing into amdgpu_irq.c

2018-09-26 Thread Huang Rui
On Mon, Sep 24, 2018 at 02:38:15PM +0200, Christian König wrote: > Add a callback to amdgpu_ih_process to remove most of the IV logic. > > Signed-off-by: Christian König Acked-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 24 +--- >