Re: [PATCH 11/12] drm/amdgpu: remove maximum BO size limitation.

2017-07-02 Thread Michel Dänzer
On 30/06/17 08:22 PM, Christian König wrote: > From: Christian König > > We can finally remove this now. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 11 --- > 1 file changed, 11 deletions(-) >

Re: [PATCH] amdgpu: Set cik/si_support to 1 by default if radeon isn't built

2017-07-02 Thread Michel Dänzer
On 30/06/17 11:41 PM, axie wrote: > Hi Michel, > > MODULE_PARM_DESC is "used to document arguments that the module can > take. It takes two parameters: a variable name and a free form string > describing that variable" > > I think we should avoid changing document when config change. > > How

Re: [PATCH RFC 2/2] drm/amdgpu: Set/clear CPU_ACCESS flag on page fault and move to VRAM

2017-07-02 Thread Michel Dänzer
On 02/07/17 09:52 PM, Christian König wrote: > Am 30.06.2017 um 17:18 schrieb John Brooks: >> When a BO is moved to VRAM, clear AMDGPU_BO_FLAG_CPU_ACCESS. This >> allows it >> to potentially later move to invisible VRAM if the CPU does not access it >> again. >> >> Setting the CPU_ACCESS flag in

Re: [PATCH 2/2] drm/amdgpu: Don't call amd_powerplay_destroy() if we don't have powerplay

2017-07-02 Thread Alex Deucher
On Sat, Jul 1, 2017 at 1:13 PM, John Brooks wrote: > amd_powerplay_destroy() expects a handle pointing to a struct pp_instance. > On chips without PowerPlay, pp_handle points to a struct amdgpu_device. The > resulting attempt to kfree() fields of the wrong struct ends in fire:

Re: [PATCH] drm/amdgpu: fix the build error if disable CONFIG_DEBUG_FS

2017-07-02 Thread Christian König
Am 02.07.2017 um 14:52 schrieb Huang Rui: This patch fixes the build error if CONFIG_DEBUG_FS is not enabled. Otherwise, below error will be triggered. tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 89a39f3c7086301342175c461c4db43c68d34cc7 commit:

[PATCH] drm/amdgpu: fix the build error if disable CONFIG_DEBUG_FS

2017-07-02 Thread Huang Rui
This patch fixes the build error if CONFIG_DEBUG_FS is not enabled. Otherwise, below error will be triggered. tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 89a39f3c7086301342175c461c4db43c68d34cc7 commit: 4f0955fcc052b556446f6f041ad8c83d70c3b253

Re: [PATCH RFC 2/2] drm/amdgpu: Set/clear CPU_ACCESS flag on page fault and move to VRAM

2017-07-02 Thread Christian König
Am 30.06.2017 um 17:18 schrieb John Brooks: When a BO is moved to VRAM, clear AMDGPU_BO_FLAG_CPU_ACCESS. This allows it to potentially later move to invisible VRAM if the CPU does not access it again. Setting the CPU_ACCESS flag in amdgpu_fault_reserve_notify() also means that we can remove the

Re: [PATCH 3/3] drm/amdgpu: Use polling for KIQ read/write register

2017-07-02 Thread Christian König
Am 30.06.2017 um 17:54 schrieb Shaoyun Liu: Change-Id: I87762bfc9903401ac06892bed10efa1767c15025 Signed-off-by: Shaoyun Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 47 +++- 1 file changed, 34 insertions(+), 13 deletions(-) diff --git

Re: [PATCH] drm: amd: amdgpu: constify ttm_place structures.

2017-07-02 Thread Christian König
Am 02.07.2017 um 11:13 schrieb Arvind Yadav: ttm_place are not supposed to change at runtime. All functions working with ttm_place provided by work with const ttm_place. So mark the non-const structs as const. Signed-off-by: Arvind Yadav Reviewed-by: Christian

Re: [PATCH] drm: radeon: radeon_ttm: constify ttm_place structures.

2017-07-02 Thread Christian König
Am 02.07.2017 um 11:06 schrieb Arvind Yadav: ttm_place are not supposed to change at runtime. All functions working with ttm_place provided by work with const ttm_place. So mark the non-const structs as const. File size before: text data bss dec hex filename 9235

Re: [PATCH 2/2] drm/amdgpu: Don't call amd_powerplay_destroy() if we don't have powerplay

2017-07-02 Thread Christian König
Am 01.07.2017 um 19:13 schrieb John Brooks: amd_powerplay_destroy() expects a handle pointing to a struct pp_instance. On chips without PowerPlay, pp_handle points to a struct amdgpu_device. The resulting attempt to kfree() fields of the wrong struct ends in fire: [ 91.560405] BUG: unable to

Re: [PATCH 1/2] drm/ttm: Fix use-after-free in ttm_bo_clean_mm

2017-07-02 Thread Christian König
Am 01.07.2017 um 19:13 schrieb John Brooks: We unref the man->move fence in ttm_bo_clean_mm() and then call ttm_bo_force_list_clean() which waits on it, except the refcount is now zero so a warning is generated (or worse): [149492.279301] refcount_t: increment on 0; use-after-free.

[PATCH] drm: amd: amdgpu: constify ttm_place structures.

2017-07-02 Thread Arvind Yadav
ttm_place are not supposed to change at runtime. All functions working with ttm_place provided by work with const ttm_place. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +- 1 file changed, 1

[PATCH] drm: radeon: radeon_ttm: constify ttm_place structures.

2017-07-02 Thread Arvind Yadav
ttm_place are not supposed to change at runtime. All functions working with ttm_place provided by work with const ttm_place. So mark the non-const structs as const. File size before: textdata bss dec hex filename 9235 344 136971525f3