Re: [PATCH 10/14] drm/amdkfd: Use ref count to prevent kfd_process destruction

On 2017-11-28 04:52 AM, Christian König wrote: > Am 28.11.2017 um 00:29 schrieb Felix Kuehling: >> Use a reference counter instead of a lock to prevent process >> destruction while functions running out of process context are using >> the kfd_process structure. In many cases these functions don't

Re: [PATCH v2] drm/amdgpu: Get rid of dep_sync as a seperate object.

On 12/01/2017 02:59 PM, Christian König wrote: Am 01.12.2017 um 20:39 schrieb Andrey Grodzovsky: Instead mark fence as explicit in it's amdgpu_sync_entry. v2: Fix use after free bug and add new parameter description. Signed-off-by: Andrey Grodzovsky ---  

[PATCH 3/5] drm/amdgpu: Avoid use SOC15_REG_OFFSET in static const array

Change-Id: I59828a9a10652988e22b50d87dd1ec9df8ae7a1d Signed-off-by: Shaoyun Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 19 +++ drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 233 +++--- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 20 +--

RE: [PATCH 3/5] drm/amdgpu: Avoid use SOC15_REG_OFFSET in static const array

Please ignore this change , forgot to include uvd related changes as suggested . Regards Shaoayun.liu -Original Message- From: Liu, Shaoyun Sent: Friday, December 01, 2017 2:58 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun Subject: [PATCH 3/5] drm/amdgpu: Avoid use

[PATCH 3/5] drm/amdgpu: Avoid use SOC15_REG_OFFSET in static const array

Change-Id: I59828a9a10652988e22b50d87dd1ec9df8ae7a1d Signed-off-by: Shaoyun Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 19 +++ drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 233 +++--- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 20 +--

Re: [PATCH 1/2] drm/amdgpu: add license to Makefiles

Thanks Alex. The series is Acked-by: Felix Kuehling On 2017-11-30 09:30 PM, Alex Deucher wrote: > Was missing license text. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/acp/Makefile | 21 >

[PATCH v2] drm/amdgpu: Get rid of dep_sync as a seperate object.

Instead mark fence as explicit in it's amdgpu_sync_entry. v2: Fix use after free bug and add new parameter description. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 14 +++---

Re: [PATCH 1/1] drm/amdkfd: Do not ignore requested queue size during allocation

On 2017-11-30 06:51 PM, Jan Vesely wrote: > > It's not a userspace queue that stops. I'm using kernel dbgdev to issue > wave_resume commands. (waves are halted after executing > s_sendmsg_halt). > I bumped KFD_KERNEL_QUEUE_SIZE to 16KB to make sure all 320 resume > commads fit (otherwise I get

Re: [PATCH] drm/amdgpu: Get rid of dep_sync as a seperate object.

Please ignore this patch, there is a bug in this patch which I will fix and resend the patch soon. Thanks, Andrey On 12/01/2017 01:59 PM, Andrey Grodzovsky wrote: Instead mark fence as explicit in it's amdgpu_sync_entry. Signed-off-by: Andrey Grodzovsky ---

Re: [PATCH libdrm 0/3] amdgpu: amdgpu_get_marketing_name cleanups

On 2017-12-01 11:56 AM, Michel Dänzer wrote: From: Michel Dänzer The first two patches are preparatory for patch 3, which is the meat of the series. Michel Dänzer (3): amdgpu: Clean up amdgpu_parse_asic_ids error handling amdgpu: Simplify error handling in

[PATCH] drm/amdgpu: Get rid of dep_sync as a seperate object.

Instead mark fence as explicit in it's amdgpu_sync_entry. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 14 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 2 +-

Re: [PATCH 1/1] drm/amdkfd: Do not ignore requested queue size during allocation

To answer your questions about decoding MQDs, take a look at struct vi_mqd in drivers/gpu/drm/amd/include/vi_structs.h. What you're looking at is a binary dump of that structure, one per queue. The information in the MQD may not always be up to date, because the MQD represents an unmapped queue.

Re: [PATCH 1/1] drm/amdkfd: Do not ignore requested queue size during allocation

DIQ is the debug interface queue. Are you running a GPU debugger? Otherwise I would not expect to even see a DIQ. Are you not seeing any compute queues in mqds? If there are no compute queues in mqds, that means your queue has been destroyed. That would explain why the read pointer is not

[PATCH libdrm 0/3] amdgpu: amdgpu_get_marketing_name cleanups

From: Michel Dänzer The first two patches are preparatory for patch 3, which is the meat of the series. Michel Dänzer (3): amdgpu: Clean up amdgpu_parse_asic_ids error handling amdgpu: Simplify error handling in parse_one_line amdgpu: Only remember the device's

[PATCH libdrm 2/3] amdgpu: Simplify error handling in parse_one_line

From: Michel Dänzer * Move empty/commented line check before the strdup and return -EAGAIN directly * Initialize r = -EAGAIN and remove redundant assignments * Set r = -ENOMEM if last strdup fails, and remove redundant goto Signed-off-by: Michel Dänzer

[PATCH libdrm 3/3] amdgpu: Only remember the device's marketing name

From: Michel Dänzer There's no point in keeping around the full table of marketing names, when amdgpu_get_marketing_name only ever returns the device's marketing name. Signed-off-by: Michel Dänzer --- amdgpu/Android.mk| 3 +-

Re: [PATCH 1/2] drm/amdgpu: add license to Makefiles

On 2017-12-01 03:31 AM, Christian König wrote: > Am 01.12.2017 um 03:30 schrieb Alex Deucher: >> Was missing license text. >> >> Signed-off-by: Alex Deucher > > We need copyright text on the Makefiles as well? Well, yeah makes sense. > Going to keep that in mind. >

Re: [PATCH 0/2] Move scheduler out of AMDGPU

Am Freitag, den 01.12.2017, 16:55 +0100 schrieb Christian König: > Am 01.12.2017 um 16:28 schrieb Lucas Stach: > > Hi all, > > > > so this is the first step to make the marvelous AMDGPU scheduler > > useable > > for other drivers. I have a (mostly) working prototype of Etnaviv > > using > > the

Re: [PATCH 0/2] Move scheduler out of AMDGPU

Am 01.12.2017 um 16:28 schrieb Lucas Stach: Hi all, so this is the first step to make the marvelous AMDGPU scheduler useable for other drivers. I have a (mostly) working prototype of Etnaviv using the scheduler, but those patches need to keep baking for a while. I'm sending this out as I want

[PATCH 1/2] drm: move amd_gpu_scheduler into common location

This moves and renames the AMDGPU scheduler to a common location in DRM in order to facilitate re-use by other drivers. This is mostly a straight forward rename with no code changes. One notable exception is the function to_drm_sched_fence(), which is no longer a inline header function to avoid

[PATCH 0/2] Move scheduler out of AMDGPU

Hi all, so this is the first step to make the marvelous AMDGPU scheduler useable for other drivers. I have a (mostly) working prototype of Etnaviv using the scheduler, but those patches need to keep baking for a while. I'm sending this out as I want to avoid rebasing this change too much and

[PATCH 2/2] drm/sched: move fence slab handling to module init/exit

This is the only part of the scheduler which must not be called from different drivers. Move it to module init/exit so it is done a single time when loading the scheduler. Signed-off-by: Lucas Stach --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8

Re: [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

On Fri, Dec 01, 2017 at 08:19:16AM +0100, Daniel Vetter wrote: > On Thu, Nov 30, 2017 at 11:49:53PM +, Sudip Mukherjee wrote: > > Hi Daniel, > > > > > > > > > > > > > > > > > > Greg? > > > > > > > > > > Yes, if no one is working to get it out of staging, that means no one > > > > > cares

Re: [PATCH xf86-video-ati] Add radeon_dirty_src_drawable helper

From: amd-gfx on behalf of Michel Dänzer Sent: Friday, December 1, 2017 9:56 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH xf86-video-ati] Add radeon_dirty_src_drawable helper From: Michel Dänzer

[PATCH xf86-video-ati] Add radeon_dirty_src_drawable helper

From: Michel Dänzer Allows tidying up radeon_dirty_src_equals and redisplay_dirty slightly. (Cherry picked from amdgpu commit 1d65ac395971571094df21ca0408d5972c6b56ec) Signed-off-by: Michel Dänzer --- src/radeon.h | 18 +-

Re: [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

On 30 November 2017 at 23:49, Sudip Mukherjee wrote: > Hi Daniel, > > On Wed, Nov 29, 2017 at 10:56:34AM +0100, Daniel Vetter wrote: >> On Tue, Nov 28, 2017 at 12:30:30PM +, Sudip Mukherjee wrote: >> > On Tue, Nov 28, 2017 at 12:32:38PM +0100, Greg KH wrote: >> > >

[PATCH 06/20] drm/amd/display: add assert to verify dcn_calc input validity

From: Dmytro Laktyushkin This reverts commit 978482d0de86 Revert noisy assert messages Signed-off-by: Dmytro Laktyushkin Reviewed-by: Tony Cheng Acked-by: Harry Wentland ---

[PATCH 07/20] drm/amd/display: dpp clean up

From: Yue Hin Lau Signed-off-by: Yue Hin Lau Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_cm.c | 4 +++-

[PATCH 02/20] drm/amd/display: Print DC_VER at DC init

This has proven helpful on other OSes to give a quick state of the DC driver when a bug is reported. Signed-off-by: Harry Wentland Reviewed-by: Tony Cheng Acked-by: Harry Wentland ---

[PATCH 05/20] drm/amd/display: Add dppclk to dcn_bw_clocks

From: Dmytro Laktyushkin Signed-off-by: Dmytro Laktyushkin Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dce/dce_hwseq.h| 3 ++-

[PATCH 12/20] drm/amd/display: Move OPP mpc tree initialization to hw_init

From: Eric Bernstein Move OPP initialization of mpc tree parameters to hw_init function. Signed-off-by: Eric Bernstein Reviewed-by: Tony Cheng Acked-by: Harry Wentland ---

[PATCH 20/20] drm/amd/display: dal 3.1.25

From: Tony Cheng Signed-off-by: Tony Cheng Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 14/20] drm/amd/display: Move wait for hpd ready out from edp power control.

From: Yongqiang Sun It may take over 200ms for wait hpd ready. To optimize the resume time, we can power on eDP in init_hw, wait for hpd ready when doing link training. also create separate eDP enable function to make sure eDP is powered up before doing and DPCD access,

[PATCH 11/20] drm/amd/display: use REG_UPDATE for MPC mux

From: Eric Bernstein Use REG_UPDATE instead of REG_SET for programming MPC out mux. Signed-off-by: Eric Bernstein Reviewed-by: Tony Cheng Acked-by: Harry Wentland ---

[PATCH 19/20] drm/amd/display: Add TODO item to remove vector.c

Signed-off-by: Harry Wentland Reviewed-by: Jordan Lazare Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/TODO | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/display/TODO

[PATCH 01/20] drm/amd/display: really fix time out in init sequence

From: Tony Cheng REG_UPDATE_2 return the reg value it write out through MMIO we need to do a REG_READ to confirm the value is written out Signed-off-by: Tony Cheng Reviewed-by: Tony Cheng Acked-by: Harry Wentland

[PATCH 16/20] drm/amd/display: use clamping rather than truncation for CM fp conversions

From: Dmytro Laktyushkin Signed-off-by: Dmytro Laktyushkin Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/basics/fixpt31_32.c | 24 ++

[PATCH 10/20] drm/amd/display: Correct fixed point calculation.

From: Vitaly Prosyak When convert from fixed31_32 to other fixed point format use math operation round instead of floor. Signed-off-by: Vitaly Prosyak Reviewed-by: Roman Li Reviewed-by: Krunoslav Kovac

[PATCH 00/20] DC Patches Dec 1, 2017

* Bunch of fixes for DCN BW * DCN programming sequence optimizations * Leave Freesync disabled unless usermode turns it on * Print DC version at initialization Dmytro Laktyushkin (4): drm/amd/display: set chroma taps to 1 when not scaling drm/amd/display: Add dppclk to dcn_bw_clocks

[PATCH 17/20] drm/amd/display: Remove redundant NULL check in DCE11 HWSS

We already check this a couple lines earlier. Signed-off-by: Harry Wentland Reviewed-by: Jordan Lazare Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 3 +-- 1 file changed, 1

[PATCH 15/20] drm/amd/display: remove format_control from set_cursor_attributes

From: Yue Hin Lau Signed-off-by: Yue Hin Lau Reviewed-by: Eric Bernstein Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c | 7 --- 1 file changed, 7 deletions(-) diff

[PATCH 18/20] drm/amd/display: Remove grph_object_id.c and move function to bios_parser

Signed-off-by: Harry Wentland Reviewed-by: Jordan Lazare Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/basics/Makefile | 2 +- .../gpu/drm/amd/display/dc/basics/grph_object_id.c | 75

[PATCH 13/20] drm/amd/display: fix missing pixel clock adjustment for dongle

From: Eric Yang Signed-off-by: Eric Yang Reviewed-by: Tony Cheng Reviewed-by: Andrew Jiang Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 +++- 1 file

[PATCH 09/20] drm/amd/display: OPTC cleanup/implementation

From: Yue Hin Lau Signed-off-by: Yue Hin Lau Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- .../drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 2 +- .../gpu/drm/amd/display/dc/dcn10/dcn10_resource.c

[PATCH 04/20] drm/amd/display: set chroma taps to 1 when not scaling

From: Dmytro Laktyushkin Signed-off-by: Dmytro Laktyushkin Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.c | 9 +

[PATCH 08/20] drm/amd/display: Move unity TF type to predefined types

From: Vitaly Prosyak Also handle fixpoint y values for CM curves Signed-off-by: Vitaly Prosyak Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc.h

[PATCH 03/20] drm/amd/display: Disable freesync by default

From: "Leo (Sunpeng) Li" Freesync properties are being set to the 'freesync_capable' flag, which will enable freesync on all freesync capable displays. Don't do this, since freesync should be disabled by default regardless of capabilities. Signed-off-by: Leo (Sunpeng) Li

Re: [PATCH 1/2] drm/amdgpu: add license to Makefiles

Am 01.12.2017 um 03:30 schrieb Alex Deucher: Was missing license text. Signed-off-by: Alex Deucher We need copyright text on the Makefiles as well? Well, yeah makes sense. Going to keep that in mind. Acked-by: Christian König for both

Re: [PATCH 0/4] Backported amdgpu ttm deadlock fixes for 4.14

Am 01.12.2017 um 01:23 schrieb Lyude Paul: I haven't gone to see where it started, but as of late a good number of pretty nasty deadlock issues have appeared with the kernel. Easy reproduction recipe on a laptop with i915/amdgpu prime with lockdep enabled: DRI_PRIME=1 glxinfo Acked-by:

Re: [PATCH 2/5] drm/amdgpu: Use the dynamic IP based offset for register access for SOC15

Am 30.11.2017 um 23:53 schrieb Shaoyun Liu: Change-Id: I29f33ee3b4bbd6737f3426385a9e8452fb528a67 Signed-off-by: Shaoyun Liu Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c| 126 ++

Re: [PATCH 3/5] drm/amdgpu: Avoid to use SOC15_REG_OFFSET in static const array

static const struct amdgpu_ring_funcs uvd_v7_0_ring_vm_funcs = { .type = AMDGPU_RING_TYPE_UVD, .align_mask = 0xf, .nop = PACKET0(SOC15_REG_OFFSET(UVD, 0, mmUVD_NO_OP), 0), That one is trivial. There is an .insert_nop callback a bit further down: .insert_nop =