RE: [PATCH] drm/amd/pp: Fix NULL point check error in smu_set_watermarks_for_clocks_ranges

Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Thursday, April 19, 2018 12:48 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH]

[PATCH] drm/amd/pp: Fix NULL point check error in smu_set_watermarks_for_clocks_ranges

It is caused by 'commit d6c9a7dc86cd ("drm/amd/pp: Move common code to smu_helper.c")' Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/amd/pp: Fix NULL point check error in smu_set_watermarks_for_clocks_ranges

Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c index 7c23741..93a3d02 100644 ---

Re: [PATCH] drm/amdgpu: fix list not initialized

On 04/19/2018 10:30 AM, zhoucm1 wrote: On 2018年04月19日 09:48, Zhang, Jerry (Junwei) wrote: On 04/18/2018 06:37 PM, Chunming Zhou wrote: Otherwise, cpu stuck for 22s with kernel panic. Change-Id: I5b87cde662a4658c9ab253ba88d009c9628a44ca Signed-off-by: Chunming Zhou ---

[PATCH] drm/amd/pp: Print out voltage/clock range in sysfs

when user cat pp_od_clk_voltage add display info about the sclk/mclk/vddc range that user can overdrive as: OD_SCLK: 0:300MHz900 mV 1:400MHz912 mV 2:500MHz925 mV 3:600MHz937 mV 4:700MHz950 mV 5:800MHz

Re: [PATCH] drm/amdgpu: fix list not initialized

On 2018年04月19日 09:48, Zhang, Jerry (Junwei) wrote: On 04/18/2018 06:37 PM, Chunming Zhou wrote: Otherwise, cpu stuck for 22s with kernel panic. Change-Id: I5b87cde662a4658c9ab253ba88d009c9628a44ca Signed-off-by: Chunming Zhou ---   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

Re: [PATCH 3/3] drm/amd/pp: Add OVERDRIVE support on Vega10

On Wed, Apr 18, 2018 at 9:13 AM, Rex Zhu wrote: > Signed-off-by: Rex Zhu Please include a patch description. More comments below. > --- > drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 705 > +++-- >

Re: [PATCH 1/3] drm/amd/pp: Remove reduplicate code in smu7_check_dpm_table_updated

On Wed, Apr 18, 2018 at 9:13 AM, Rex Zhu wrote: > Signed-off-by: Rex Zhu Please include a patch description. With that fixed: Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 8 ++-- > 1

Re: [PATCH 2/3] drm/amd/pp: Change voltage/clk range for OD feature on VI

On Wed, Apr 18, 2018 at 9:13 AM, Rex Zhu wrote: > read vddc range from vbios. > > Signed-off-by: Rex Zhu > --- > drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c | 28 > drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.h | 3 ++ >

Re: [PATCH] drm/amdgpu: fix list not initialized

On 04/18/2018 06:37 PM, Chunming Zhou wrote: Otherwise, cpu stuck for 22s with kernel panic. Change-Id: I5b87cde662a4658c9ab253ba88d009c9628a44ca Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 16/20] drm/amd/powerplay: add control gfxoff enabling in late init

Signed-off-by: Huang Rui Reviewed-by: Hawking Zhang Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH 17/20] drm/amdgpu: it should disable gfxoff when system is going to suspend

Signed-off-by: Huang Rui Reviewed-by: Hawking Zhang Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH 18/20] drm/amdgpu: fix to disable powergating in hw_fini

We need enable CGPG and GFXOFF together. If only enable one of them, this system will get hang after startx (do draw command). So when gfxoff is disabled, it also need disable CGPG after that. Signed-off-by: Huang Rui Reviewed-by: Hawking Zhang

[PATCH 19/20] drm/amdgpu: set CGPG if gfxoff is enabled for raven

Signed-off-by: Huang Rui Reviewed-by: Hawking Zhang Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc15.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c

[PATCH 20/20] drm/amd/powerplay: use the flag to decide whether send gfxoff smc message

Signed-off-by: Huang Rui Reviewed-by: Hawking Zhang Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH 14/20] drm/amdgpu: use pp_feature member to store the mask

Signed-off-by: Huang Rui Reviewed-by: Hawking Zhang Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 2 ++ drivers/gpu/drm/amd/amdgpu/ci_dpm.c

[PATCH 15/20] drm/amdgpu: clear gfxoff featue mask if the asic is not raven

Signed-off-by: Huang Rui Reviewed-by: Hawking Zhang Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH 10/20] drm/amdgpu: add gfxoff feature mask

Signed-off-by: Huang Rui Reviewed-by: Hawking Zhang Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/include/amd_shared.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/include/amd_shared.h

[PATCH 12/20] drm/amd/powerplay: add gfx off control function

gfx_off_control is used to be called for sending enabling/disabling gfxoff message. Signed-off-by: Huang Rui Reviewed-by: Hawking Zhang Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 36

[PATCH 13/20] drm/amd/powerplay: enable/disable gfxoff through smu

Signed-off-by: Huang Rui Reviewed-by: Hawking Zhang Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH 11/20] drm/amdgpu: set gfxoff disabled by default

Signed-off-by: Huang Rui Reviewed-by: Hawking Zhang Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 09/20] drm/amdgpu: move PP_FEATURE_MASK to amd_shared header

It will be used not only for powerplay but also on amdgpu part in future patches. So move it into amd_shared header file. Signed-off-by: Huang Rui Reviewed-by: Hawking Zhang Reviewed-by: Alex Deucher ---

[PATCH 08/20] drm/amd/powerplay: send CGPG smc message if PG is enabled for raven

Signed-off-by: Huang Rui Acked-by: Hawking Zhang Acked-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 8 +++- drivers/gpu/drm/amd/powerplay/inc/rv_ppsmc.h | 1 + 2 files changed, 8

[PATCH 07/20] drm/amdgpu: add setting powergating method for gfx9

Signed-off-by: Huang Rui Acked-by: Hawking Zhang Acked-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c

[PATCH 05/20] drm/amdgpu: cleanup init power gating function

Remove gfx_v9_0_enable_sck_slow_down_on_power_up/down and CP power gating enabling functions because they only need to be called on setting power gating behavior. We keep it in set_powergating callback to enable/disable PG in late_init. Signed-off-by: Huang Rui Acked-by:

[PATCH 06/20] drm/amdgpu: revise init_rlc_save_restore_list behavior to support latest register_list_format/register_restore table

RLC save/restore list will be used on CGPG and GFXOFF function, it loads two bin table of register_list_format/register_restore in RLC firmware. Signed-off-by: Huang Rui Acked-by: Hawking Zhang Acked-by: Alex Deucher ---

[PATCH 04/20] drm/amdgpu: enter rlc safe mode before set cgpg

Signed-off-by: Huang Rui Acked-by: Hawking Zhang Acked-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH 00/20] drm/amdgpu: gfx off support

GFXOFF is the new GPU feature that save power consumption. It used RLC to poweroff the gfx engine dynamicly when there is no workload on gfx pipe and make gfx into "idle" state. 1. Add three additional RLC ucodes, and use psp to load them. 2. Revise RLC save restore list. 3. Enable CGPG (GFX power

[PATCH 03/20] drm/amdgpu: add save restore list cntl gpm and srm firmware support

RLC save/restore list cntl/gpm_mem/srm_mem ucodes are used for CGPG and gfxoff function. Signed-off-by: Huang Rui Acked-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 15 + drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 36

[PATCH 01/20] drm/amdgpu: update psp gfx if header

Signed-off-by: Huang Rui Acked-by: Hawking Zhang Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h | 67 ++--- 1 file changed, 46 insertions(+), 21 deletions(-) diff --git

[PATCH 02/20] drm/amdgpu: add new rlc firmware header format v2.1

Signed-off-by: Huang Rui Acked-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 34 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 19 + 2 files changed, 51 insertions(+), 2 deletions(-)

Re: [PATCH 3/3] drm/amdgpu: Enable scatter gather display support

On Wed, Apr 18, 2018 at 5:51 PM, Samuel Li wrote: > It's auto by default. For CZ/ST, auto setting enables sg display > when vram size is small; otherwise still uses vram. > This patch fixed some potention issues introduced by change > "allow framebuffer in GART memory as well"

Re: [PATCH 2/3] drm/amdgpu: Remove VRAM from shared bo domains.

On Wed, Apr 18, 2018 at 5:51 PM, Samuel Li wrote: > Signed-off-by: Samuel Li Please add a commit message. E.g., This fixes a potential regression introduced when SG display support was initially added which could lead to a shared buffer ending up pinned

Re: [PATCH 1/3] drm/amdgpu: Rename amdgpu_display_framebuffer_domains()

On Wed, Apr 18, 2018 at 5:50 PM, Samuel Li wrote: > It returns supported domains, and domains actually used are to be > decided later. maybe clarify the commit message a bit. E.g., It returns supported domains for display, and domains actually used are to be decided later

[PATCH 2/3] drm/amdgpu: Remove VRAM from shared bo domains.

Signed-off-by: Samuel Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c index 24f582c..8dc782a 100644 ---

[PATCH 3/3] drm/amdgpu: Enable scatter gather display support

It's auto by default. For CZ/ST, auto setting enables sg display when vram size is small; otherwise still uses vram. This patch fixed some potention issues introduced by change "allow framebuffer in GART memory as well" due to CZ/ST hardware limitation. v2: Change default setting to auto. v3:

[PATCH 1/3] drm/amdgpu: Rename amdgpu_display_framebuffer_domains()

It returns supported domains, and domains actually used are to be decided later. Signed-off-by: Samuel Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_display.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c

Re: Raven Ridge Ryzen 2500U hang reproduced

Hi Nicolai, It makes sense. The easiest way to reproduce the real freeze is to: - Run vblank_mode=0 glxgears - Open https://hangouts.google.com/start - Activate KDE compositing It will freeze within a few minutes. Cheers, Bráulio On Mon, Apr 16, 2018 at 4:44 AM Nicolai Hähnle

Re: Which branch to test latest support for Raven Ridge?

FYI, getting a blank screen and system freeze when lightdm is loaded with both drm-next-4.18-wip and amd-staging-drm-next branches. On Fri, Apr 13, 2018 at

[PATCH] drm/amd/display: Disallow enabling CRTC without primary plane with FB

The below commit "drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2" introduces a slight behavioral change to rmfb. Instead of disabling a crtc when the primary plane is disabled, it now preserves it. Since DC is currently not equipped to handle this we need to

[PATCH umr] Allow specifying a zero size for --vm-disasm to have it size the shader automatically

Signed-off-by: Tom St Denis --- doc/umr.1 | 3 ++- src/app/main.c | 9 - 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/doc/umr.1 b/doc/umr.1 index 83706b887894..f1f5fec55946 100644 --- a/doc/umr.1 +++ b/doc/umr.1 @@ -115,7 +115,8 @@ Write

Re: [PATCH] drm: Print unadorned pointers

On Wed, Apr 18, 2018 at 12:24:50PM +0300, Alexey Brodkin wrote: > After commit ad67b74 ("printk: hash addresses printed with %p") > pointers are being hashed when printed. However, this makes > debug output completely useless. Switch to %px in order to see the > unadorned kernel pointers. > >

Re: [PATCH 1/1] drm/amdgpu: Enable scatter gather display support

On 2018-04-18 12:16 PM, Christian König wrote: > Am 18.04.2018 um 17:29 schrieb Samuel Li: >> >> On 2018-04-18 12:14 AM, Alex Deucher wrote: >>> On Tue, Apr 17, 2018 at 8:40 PM, Samuel Li wrote: It's auto by default. For CZ/ST, auto setting enables sg display when

Re: [PATCH 1/1] drm/amdgpu: Enable scatter gather display support

Am 18.04.2018 um 17:29 schrieb Samuel Li: On 2018-04-18 12:14 AM, Alex Deucher wrote: On Tue, Apr 17, 2018 at 8:40 PM, Samuel Li wrote: It's auto by default. For CZ/ST, auto setting enables sg display when vram size is small; otherwise still uses vram. This patch fixed

Re: [PATCH 1/1] drm/amdgpu: Enable scatter gather display support

On 2018-04-18 04:34 AM, Christian König wrote: > Am 18.04.2018 um 06:14 schrieb Alex Deucher: >> On Tue, Apr 17, 2018 at 8:40 PM, Samuel Li wrote: >>> It's auto by default. For CZ/ST, auto setting enables sg display >>> when vram size is small; otherwise still uses vram. >>>

Re: [PATCH] drm: Print unadorned pointers

On 2018-04-18 05:24 AM, Alexey Brodkin wrote: > After commit ad67b74 ("printk: hash addresses printed with %p") > pointers are being hashed when printed. However, this makes > debug output completely useless. Switch to %px in order to see the > unadorned kernel pointers. My understanding of the

Re: [PATCH 1/1] drm/amdgpu: Enable scatter gather display support

On 2018-04-18 12:14 AM, Alex Deucher wrote: > On Tue, Apr 17, 2018 at 8:40 PM, Samuel Li wrote: >> It's auto by default. For CZ/ST, auto setting enables sg display >> when vram size is small; otherwise still uses vram. >> This patch fixed some potention hang issue introduced

Re: PROBLEM: linux-firmware provided firmware files do not support AMDVLK driver

Thanks. I wasn't aware of that issue. The updated firmware seems to work fine with Radeon drivers on my machine. (After updating the firmware, I booted with Radeon.si_support=1 Radeon.cik_support=1 amdgpu.si_support=0 amdgpu.cik_support=0) though I've messed with my system a lot to get AMDVLK

Re: [PATCH] drm/amdgpu: print DMA-buf status in debugfs

Reviewed-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Wednesday, April 18, 2018 6:13:09 AM To: amd-gfx@lists.freedesktop.org Subject: Re:

Re: [PATCH v2] drm/amd/amdgpu: passing i2s instance value as platform data

Reviewed-by: Alex Deucher From: Vijendar Mukunda Sent: Wednesday, April 18, 2018 4:56:32 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Agrawal, Akshu; Mukunda, Vijendar Subject: [PATCH v2]

[PATCH] drm: Print unadorned pointers

After commit ad67b74 ("printk: hash addresses printed with %p") pointers are being hashed when printed. However, this makes debug output completely useless. Switch to %px in order to see the unadorned kernel pointers. This was done with the following one-liner: find drivers/gpu/drm -type f -name

[PATCH] drm/amd/amdgpu: Add missing DCN CMx_TEST_DEBUG bitfields

Only the bitfields for CM0 were initially added. This adds the rest for CM1..CM3 that way umr can pick up the bitfields for all of the debug registers. Signed-off-by: Tom St Denis --- .../gpu/drm/amd/include/asic_reg/dcn/dcn_1_0_sh_mask.h| 15 +++ 1 file

[PATCH 3/3] drm/amd/pp: Add OVERDRIVE support on Vega10

Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 705 +++-- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.h | 25 +- .../gpu/drm/amd/powerplay/inc/hardwaremanager.h| 3 +- 3 files changed, 376 insertions(+), 357

[PATCH 2/3] drm/amd/pp: Change voltage/clk range for OD feature on VI

read vddc range from vbios. Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c | 28 drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.h | 3 ++ drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 56

[PATCH 1/3] drm/amd/pp: Remove reduplicate code in smu7_check_dpm_table_updated

Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c index 720ac47..9654593

Re: [PATCH] drm/amdgpu: fix list not initialized

Am 18.04.2018 um 12:37 schrieb Chunming Zhou: Otherwise, cpu stuck for 22s with kernel panic. Change-Id: I5b87cde662a4658c9ab253ba88d009c9628a44ca Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH] drm/scheduler: fix build broken by "move last_sched fence updating prior to job popping"

On Wed, Apr 18, 2018 at 12:06:27PM +0200, Christian König wrote: > We don't have s_fence as local variable here. > > Signed-off-by: Christian König I just also meet this issue, and file the patch. And found you already fixed it. Acked-by: Huang Rui

Re: [PATCH] drm/scheduler: fix build broken by "move last_sched fence updating prior to job popping"

On 2018-04-18 12:06 PM, Christian König wrote: > We don't have s_fence as local variable here. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/scheduler/gpu_scheduler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH xf86-video-amdgpu 2/3] Track DRM event queue sequence number in scanout_update_pending

From: Michel Dänzer Preparation for next change, no behaviour change intended. Signed-off-by: Michel Dänzer --- src/amdgpu_kms.c | 16 src/drmmode_display.h | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff

[PATCH xf86-video-amdgpu 1/3] Ignore AMDGPU_DRM_QUEUE_ERROR (0) in amdgpu_drm_abort_entry

From: Michel Dänzer This allows a following change to be slightly simpler. Signed-off-by: Michel Dänzer --- src/amdgpu_drm_queue.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amdgpu_drm_queue.c b/src/amdgpu_drm_queue.c index

[PATCH] drm/amdgpu: fix list not initialized

Otherwise, cpu stuck for 22s with kernel panic. Change-Id: I5b87cde662a4658c9ab253ba88d009c9628a44ca Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH xf86-video-amdgpu 3/3] Abort scanout_update_pending event when possible

From: Michel Dänzer We don't need to wait for a non-TearFree scanout update before scanning out from the screen pixmap or before flipping, as the scanout update won't be visible anyway. Instead, just abort it. Signed-off-by: Michel Dänzer ---

RE: [PATCH] drm/scheduler: fix build broken by "move last_sched fence updating prior to job popping"

Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Wednesday, April 18, 2018 6:06 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/scheduler: fix build broken by

Re: [PATCH] drm/amdgpu: print DMA-buf status in debugfs

Ping? Could anybody review that? Thanks, Christian. Am 11.04.2018 um 15:09 schrieb Christian König: Just note if a BO was imported/exported. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 11 +++ 1 file changed, 11

Re: [PATCH] sync amdgpu scanout update event before mode setting

On 2018-04-18 11:57 AM, Qu, Jim wrote: > OK, Please push your patch ASAP. Done: commit 9f6a8905611b5b1d8fcd31bebbc9af7ca1355cc3 Author: Jim Qu Date: Tue Apr 17 19:11:16 2018 +0800 Wait for pending scanout update before calling drmmode_crtc_scanout_free -- Earthling

[PATCH] drm/scheduler: fix build broken by "move last_sched fence updating prior to job popping"

We don't have s_fence as local variable here. Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c

答复: 答复: 答复: [PATCH] sync amdgpu scanout update event before mode setting

OK, Please push your patch ASAP. Thanks JimQu 发件人: Michel Dänzer 发送时间: 2018年4月18日 17:54 收件人: Qu, Jim 抄送: amd-gfx@lists.freedesktop.org 主题: Re: 答复: 答复: [PATCH] sync amdgpu scanout update event before mode setting On 2018-04-18 11:44

Re: 答复: 答复: [PATCH] sync amdgpu scanout update event before mode setting

On 2018-04-18 11:44 AM, Qu, Jim wrote: > Yeah, I realize that it should use || . I will check it again with your > modification. I've verified that it fixes the crash. > and then push it immediately. The issue has delayed a long time. Really? I haven't seen anything about this before you

答复: 答复: [PATCH] sync amdgpu scanout update event before mode setting

Yeah, I realize that it should use || . I will check it again with your modification. and then push it immediately. The issue has delayed a long time. May I get your RB? Thanks JimQu 发件人: Michel Dänzer 发送时间: 2018年4月18日 17:29 收件人:

Re: [PATCH] drm: Print unadorned pointers

Op 18-04-18 om 11:24 schreef Alexey Brodkin: > After commit ad67b74 ("printk: hash addresses printed with %p") > pointers are being hashed when printed. However, this makes > debug output completely useless. Switch to %px in order to see the > unadorned kernel pointers. > > This was done with the

Re: 答复: [PATCH] sync amdgpu scanout update event before mode setting

On 2018-04-18 11:12 AM, Qu, Jim wrote: > Hi Michel, > > drmmode_crtc_wait_pending_event(drmmode_crtc, pAMDGPUEnt->fd, > drmmode_crtc->flip_pending || > drmmode_crtc->scanout_update_pending); > > Here, should not use && for this

答复: [PATCH] sync amdgpu scanout update event before mode setting

Hi Michel, drmmode_crtc_wait_pending_event(drmmode_crtc, pAMDGPUEnt->fd, drmmode_crtc->flip_pending || drmmode_crtc->scanout_update_pending); Here, should not use && for this condition? Thanks JimQu

Re: force app kill patch

Am 18.04.2018 um 11:00 schrieb Liu, Monk: 1.Drm_sched_entity_fini(): it exit right after entity->job_queue empty, [ but that time scheduler is not fast enough to deal with this entity now ] That should never happen. The last job from the entity->job_queue is only removed after the

RE: force app kill patch

1.Drm_sched_entity_fini(): it exit right after entity->job_queue empty, [ but that time scheduler is not fast enough to deal with this entity now ] That should never happen. The last job from the entity->job_queue is only removed after the scheduler is done with the entity (at least

答复: [PATCH] sync amdgpu scanout update event before mode setting

Okay if I make that modification before pushing? A: Yes , of course :p) Thanks JimQu 发件人: Michel Dänzer 发送时间: 2018年4月18日 16:55 收件人: Qu, Jim 抄送: amd-gfx@lists.freedesktop.org 主题: Re: [PATCH] sync amdgpu scanout update event before

Re: [PATCH 1/2] drm/scheduler: always put last_sched fence in entity_fini

Am 18.04.2018 um 10:45 schrieb Pixel Ding: Fix the potential memleak since scheduler main thread always hold one last_sched fence. Signed-off-by: Pixel Ding Reviewed-by: Christian König for the whole series. ---

Re: [PATCH] sync amdgpu scanout update event before mode setting

On 2018-04-17 01:11 PM, Jim Qu wrote: > There is a case that when set screen from reverse to normal, the old > scanout damage is freed in modesetting before sanout update handler, > so it causes segment fault issue. Good catch, thanks. > diff --git a/src/drmmode_display.c

[PATCH v2] drm/amd/amdgpu: passing i2s instance value as platform data

i2s instance value is passed as platform data to dwc driver. this parameter will be useful to distinguish current i2s instance value when multiple i2s controller instances are created. Signed-off-by: Vijendar Mukunda --- v1->v2: moved I2S instance macros from dwc driver

[PATCH 2/2] drm/scheduler: move last_sched fence updating prior to job popping

Make sure main thread won't update last_sched fence when entity is cleanup. Fix a racing issue which is caused by putting last_sched fence twice. Running vulkaninfo in tight loop can produce this issue as seeing wild fence pointer. Signed-off-by: Pixel Ding ---

[PATCH 1/2] drm/scheduler: always put last_sched fence in entity_fini

Fix the potential memleak since scheduler main thread always hold one last_sched fence. Signed-off-by: Pixel Ding --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c

Re: force app kill patch

See that in “sched_entity_fini”, we only call dma_fence_put(entity->last_scheduled”under the condition of “If (entity->fini_status)”, so This way there is memory leak for the case of “entity->fini_stats ==0” Good catch, we indeed should fix that. 1.Drm_sched_entity_fini(): it exit right

Re: [PATCH 1/1] drm/amdgpu: Enable scatter gather display support

Am 18.04.2018 um 06:14 schrieb Alex Deucher: On Tue, Apr 17, 2018 at 8:40 PM, Samuel Li wrote: It's auto by default. For CZ/ST, auto setting enables sg display when vram size is small; otherwise still uses vram. This patch fixed some potention hang issue introduced by change

Re: [PATCH 1/2] drm/amdgpu: set preferred_domain independent of fallback handling

Am 18.04.2018 um 04:19 schrieb Chunming Zhou: When GEM needs to fallback to GTT for VRAM BOs we still want the preferred domain to be untouched so that the BO has a cance to move back to VRAM in the future. Change-Id: I8cfdf3f30532f7e5d80b8e4266b7800211de2f0b Signed-off-by: Chunming Zhou

Re: RFC for a render API to support adaptive sync and VRR

On Wed, Apr 18, 2018 at 5:58 AM, Keith Packard wrote: > Michel Dänzer writes: >> Time-based presentation seems to be the right approach for preventing >> micro-stutter in games as well, Croteam developers have been researching >> this. > > Both the Vulkan

RE: force app kill patch

*Correctio for the scenario * After we move fence_put(entity->last_sched) out of the fini_status check: A potential race issue for the scenario: 1.Drm_sched_entity_fini(): it exit right after entity->job_queue empty, [ but that time scheduler is not fast enough to deal with this

force app kill patch

Hi Christian & Emily I think the v4 fix for "fix force app kill hang" is still not good enough: First: See that in "sched_entity_fini", we only call dma_fence_put(entity->last_scheduled" under the condition of "If (entity->fini_status)", so This way there is memory leak for the case of