Re: [PATCH] drm/amdgpu: correctly sign extend 48bit addresses v3

2018-08-29 Thread Christian König
Am 30.08.2018 um 04:43 schrieb Zhang, Jerry (Junwei): On 08/29/2018 05:39 PM, Christian König wrote: Am 29.08.2018 um 04:03 schrieb Zhang, Jerry (Junwei): On 08/28/2018 08:17 PM, Christian König wrote: Correct sign extend the GMC addresses to 48bit. Could you explain a bit more why to extend

[PATCH 4/5] drm: expand replace_fence to support timeline point v2

2018-08-29 Thread Chunming Zhou
we can place a fence to a timeline point after expanded. v2: change func parameter order Signed-off-by: Chunming Zhou Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 14 -- drivers/gpu/drm/i915/i915_ge

[PATCH 3/5] drm: expand drm_syncobj_find_fence to support timeline point v2

2018-08-29 Thread Chunming Zhou
we can fetch timeline point fence after expanded. v2: The parameter fence is the result of the function and should come last. Signed-off-by: Chunming Zhou Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 5 +++-- drivers/gp

[PATCH 2/5] drm: rename null fence to stub fence in syncobj v2

2018-08-29 Thread Chunming Zhou
moved to front of file. stub fence will be used by timeline syncobj as well. Signed-off-by: Chunming Zhou Cc: Jason Ekstrand Reviewed-by: Christian König --- drivers/gpu/drm/drm_syncobj.c | 53 +++ 1 file changed, 29 insertions(+), 24 deletions(-) diff --git a/

[PATCH 5/5] [RFC]drm: add syncobj timeline support v3

2018-08-29 Thread Chunming Zhou
VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline semaphores support the following operations: * CPU query - A host operation that allows querying the payload of the timeline semaphore.

[PATCH 1/5] drm: fix syncobj null_fence_enable_signaling

2018-08-29 Thread Chunming Zhou
That is certainly totally nonsense. dma_fence_enable_sw_signaling() is the function who is calling this callback. Signed-off-by: Chunming Zhou Cc: Jason Ekstrand Reviewed-by: Christian König Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_syncobj.c | 1 - 1 file changed, 1 deletion(-) diff -

Re: When to kmap PT BOs?

2018-08-29 Thread Christian König
Hi Felix, ah, crap you are right. I moved the kmap to amdgpu_vm_update_directories() because I thought that it would be cleaner to have that closer where it is used. But that sounds like it doesn't work as intended. Going to revert that patch. Thanks, Christian. Am 30.08.2018 um 00:30 sch

Re: [PATCH 0/2] Provide init/release functions for struct ttm_bo_global

2018-08-29 Thread Christian König
Hi Thomas, Am 30.08.2018 um 08:34 schrieb Thomas Zimmermann: Hi Christian, I just wanted to ask if there's something else required to get this patch set reviewed and landed. I just need to find some time to review them. On top of these two patches, I have a patch set that replaces the drive

Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-29 Thread Christian König
As explained before we don't need a GART mapping any more for small allocations. Additional to that we want it to support early bringup where no VRAM is attached to the ASIC. Regards, Christian. Am 30.08.2018 um 05:48 schrieb Xiao, Jack: Can you explain what the benefits can be gained from

Re: [PATCH 0/2] Provide init/release functions for struct ttm_bo_global

2018-08-29 Thread Thomas Zimmermann
Hi Christian, I just wanted to ask if there's something else required to get this patch set reviewed and landed. On top of these two patches, I have a patch set that replaces the driver-specific global-bo-and-mem combos with a single struct ttm_global structure. It further merges struct drm_globa

RE: [PATCH] drm/amd/powerplay: added vega20 overdrive support

2018-08-29 Thread Quan, Evan
Hi Alex, OK, I got your concern. Then how about the followings? If user want to change the FMin and FMax, they just need to pass in the new clock values. E.g, "s 0 350 10" will update the Fmin to 350Mhz and increase its voltage by 10mV. "s 7 1000 -10" will update the Fmax to 1000Mhz and decrea

RE: [PATCH] drm/amd/powerplay: added vega20 overdrive support

2018-08-29 Thread Quan, Evan
Thanks Paul, Comment inline > -Original Message- > From: Paul Menzel > Sent: 2018年8月29日 20:23 > To: Quan, Evan > Cc: amd-gfx@lists.freedesktop.org; Alex Deucher > ; Zhu, Rex > Subject: Re: [PATCH] drm/amd/powerplay: added vega20 overdrive support > > Dear Evan, > > > On 08/29/18 11:

Re: [PATCH] drm/amd/powerplay: added vega20 overdrive support

2018-08-29 Thread Alex Deucher
On Wed, Aug 29, 2018 at 11:54 PM Quan, Evan wrote: > > Hi Alex, > > > >What about the min/max sclk? Do the curve values take that into > >account? What about max mclk? > > Voltage curve does not take these into consideration. And the max sclk and > mclk can be set through existing sysfs interfac

Re: [PATCH] drm/amd/powerplay: correct data type to support under voltage

2018-08-29 Thread Alex Deucher
On Thu, Aug 30, 2018 at 12:49 AM Evan Quan wrote: > > For under voltage, negative value will be applied to voltage > offset. Update the data type to cover this case. > > Change-Id: I955da13fd9777320b0605b6b620133d596b573be > Signed-off-by: Evan Quan Reviewed-by: Alex Deucher > --- > drivers/g

Re: When to kmap PT BOs?

2018-08-29 Thread Zhang, Jerry (Junwei)
On 08/30/2018 06:30 AM, Felix Kuehling wrote: Hi, Currently PT BOs are kmapped in amdgpu_vm_update_directories. That means, to avoid kernel oopses after page table evictions, I need to call amdgpu_vm_update_directories before calling amdgpu_vm_bo_update. But amdgpu_vm_bo_update can also move PT

[PATCH] drm/amd/powerplay: correct data type to support under voltage

2018-08-29 Thread Evan Quan
For under voltage, negative value will be applied to voltage offset. Update the data type to cover this case. Change-Id: I955da13fd9777320b0605b6b620133d596b573be Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/inc/smu11_driver_if.h | 6 +++--- 1 file changed, 3 insertions(+), 3 delet

Re: [PATCH 6/7] drm/amdgpu: enable AGP aperture for GMC9

2018-08-29 Thread Zhang, Jerry (Junwei)
On 08/29/2018 10:08 PM, Christian König wrote: Enable the old AGP aperture to avoid GART mappings. Signed-off-by: Christian König Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 10 +- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c| 1 + drivers/gpu/drm/amd/

Re: [PATCH] drm/amd/powerplay: added vega20 overdrive support

2018-08-29 Thread Quan, Evan
Hi Alex, >What about the min/max sclk? Do the curve values take that into >account? What about max mclk? Voltage curve does not take these into consideration. And the max sclk and mclk can be set through existing sysfs interface pp_sclk_od and pp_mclk_od. For min sclk, as i know there is no i

Re: [PATCH 5/5] [RFC]drm: add syncobj timeline support v3

2018-08-29 Thread zhoucm1
On 2018年08月29日 19:42, Christian König wrote: Am 29.08.2018 um 12:44 schrieb Chunming Zhou: VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline semaphores support the following operations:   

RE: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-29 Thread Xiao, Jack
Can you explain what the benefits can be gained from AGP aperture enablement? Otherwise, it would increase our maintenance workload. Regards, Jack -Original Message- From: Christian König Sent: Wednesday, August 29, 2018 4:47 PM To: Kuehling, Felix ; Koenig, Christian ; Xiao, Jack ;

Re: [PATCH 5/7] drm/amdgpu: manually map the shadow BOs again

2018-08-29 Thread Zhang, Jerry (Junwei)
On 08/29/2018 10:08 PM, Christian König wrote: Otherwise we won't be able to use the AGP aperture. do you mean we use AGP for GTT shadow only now? Jerry Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5

Re: [PATCH 4/7] drm/amdgpu: use the AGP aperture for system memory access v2

2018-08-29 Thread Zhang, Jerry (Junwei)
On 08/29/2018 10:08 PM, Christian König wrote: Start to use the old AGP aperture for system memory access. v2: Move that to amdgpu_ttm_alloc_gart Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 23 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 1 + driv

Re: [PATCH 3/7] drm/amdgpu: add amdgpu_gmc_agp_location v2

2018-08-29 Thread Zhang, Jerry (Junwei)
On 08/29/2018 10:08 PM, Christian König wrote: Helper to figure out the location of the AGP BAR. v2: fix a couple of bugs Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 43 + drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 5 +++ 2 files cha

Re: [PATCH xf86-video-amdgpu 2/2] glamor: Handle ihandle == -1 in amdgpu_glamor_set_shared_pixmap_backing

2018-08-29 Thread Alex Deucher
On Wed, Aug 29, 2018 at 11:39 AM Michel Dänzer wrote: > > From: Michel Dänzer > > (Ported from radeon commit de88ea2755611bdcb18d91d8234d2ab5be8ff2e9) > > Signed-off-by: Michel Dänzer Series is: Acked-by: Alex Deucher > --- > src/amdgpu_glamor.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [PATCH 2/7] drm/amdgpu: put GART away from VRAM v2

2018-08-29 Thread Zhang, Jerry (Junwei)
On 08/29/2018 10:08 PM, Christian König wrote: Always try to put the GART away from where VRAM is. v2: correctly handle the 4GB limitation Signed-off-by: Christian König Fix my concern :) Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 8 +--- 1 file change

Re: [PATCH] drm/amdgpu: correctly sign extend 48bit addresses v3

2018-08-29 Thread Zhang, Jerry (Junwei)
On 08/29/2018 05:39 PM, Christian König wrote: Am 29.08.2018 um 04:03 schrieb Zhang, Jerry (Junwei): On 08/28/2018 08:17 PM, Christian König wrote: Correct sign extend the GMC addresses to 48bit. Could you explain a bit more why to extend the sign? The hardware works like this, in other wor

Re: [PATCH] drm/amdgpu: remove redundant memset

2018-08-29 Thread Zhang, Jerry (Junwei)
On 08/29/2018 11:17 PM, Philip Yang wrote: kvmalloc_array uses __GFP_ZERO flag ensures that the returned address is zeroed already, memset it to zero again afterwards is unnecessary, and in this case buggy because we only clear the first entry. Change-Id: If94a59d3cbf2690dd2a1e2add71bc393df6a968

When to kmap PT BOs?

2018-08-29 Thread Felix Kuehling
Hi, Currently PT BOs are kmapped in amdgpu_vm_update_directories. That means, to avoid kernel oopses after page table evictions, I need to call amdgpu_vm_update_directories before calling amdgpu_vm_bo_update. But amdgpu_vm_bo_update can also move PTs on the vm->relocated list during huge page han

PS4 Linux AMD Drivers Request.

2018-08-29 Thread Ugo Borde
Hello all Team, I search with our Group (PS4Linux) request AMD drivers for PS4. FailOverFlow Team write some drivers and one Guys, Marcan can run VULKAN ! Is it possible for you to help us ? I send you the Telegram of our Group link: @ps4linux4homebrews https://t.me/ps4linux4homebrews Or you can

[pull] amdgpu drm-fixes-4.19

2018-08-29 Thread Alex Deucher
Hi Dave, Fixes for 4.19: - SR-IOV fixes - Kasan and page fault fix on device removal - S3 stability fix for CZ/ST - VCE regression fixes for CIK parts - Avoid holding the mn_lock when allocating memory - DC memory leak fix - BO eviction fix The following changes since commit 9d1d02ff36783f954a206

Re: How to gracefully handle pci remove

2018-08-29 Thread Deucher, Alexander
Take a look at what the udl drm driver does. It's a usb display chip. Alex From: amd-gfx on behalf of Andrey Grodzovsky Sent: Wednesday, August 29, 2018 2:28:42 PM To: Daniel Vetter; Noralf Trønnes Cc: Dave Airlie; amd-gfx@lists.freedesktop.org; ML dri-devel;

Re: How to gracefully handle pci remove

2018-08-29 Thread Andrey Grodzovsky
Actually, I've just spotted this drm_dev_unplug, does it make sense to use it in our pci_driver.remove hook instead of explicitly doing drm_dev_unregister and drm_dev_put(dev) ? This way at least any following IOCTL will fail with ENODEV. Andrey On 08/29/2018 11:07 AM, Daniel Vetter wrote:

[PATCH xf86-video-amdgpu 2/3] Don't use xorg_list_for_each_entry_safe for signalled flips

2018-08-29 Thread Michel Dänzer
From: Michel Dänzer drm_wait_pending_flip can get called from drm_handle_event, in which case xorg_list_for_each_entry_safe can end up processing the same entry in both. To avoid this, just process the first list entry until the list is empty. Signed-off-by: Michel Dänzer --- src/amdgpu_drm_qu

[PATCH xf86-video-amdgpu 1/3] Always delete entry from list in drm_queue_handler

2018-08-29 Thread Michel Dänzer
From: Michel Dänzer We left entries without a handler hook in the list, so the list could keep taking longer to process and use up more memory. Signed-off-by: Michel Dänzer --- src/amdgpu_drm_queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amdgpu_drm_queue.c b/s

[PATCH xf86-video-amdgpu 3/3] Bail early from drm_wait_pending_flip if there's no pending flip

2018-08-29 Thread Michel Dänzer
From: Michel Dänzer No need to process any events in that case. Signed-off-by: Michel Dänzer --- src/amdgpu_drm_queue.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amdgpu_drm_queue.c b/src/amdgpu_drm_queue.c index ba841d1ef..61732b11c 100644 --- a/src/amdgpu_drm_queue.c +++ b/sr

Re: [PATCH] drm/amd/powerplay: added vega20 overdrive support

2018-08-29 Thread Alex Deucher
On Wed, Aug 29, 2018 at 5:13 AM Evan Quan wrote: > > Vega20 supports only sclk voltage overdrive. And user can > only tell three groups of . SMU > firmware will recalculate the frequency/voltage curve. Other > intermediate levles will be stretched/shrunk accordingly. > What about the min/max sclk

Re: [PATCH] drm/amdgpu: Relocate some definitions

2018-08-29 Thread Felix Kuehling
On 2018-08-29 10:42 AM, Amber Lin wrote: > Move some KFD-related (but used in amdgpu_drv.c) definitions from > kfd_priv.h to kgd_kfd_interface.h so we don't need to include kfd_priv.h > in amdgpu_drv.c. This fixes a build failure when AMDGPU is enabled but > MMU_NOTIFIER is not. > This patch also

Re: [PATCH] drm/amdgpu: remove redundant memset

2018-08-29 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Philip Yang Sent: Wednesday, August 29, 2018 11:17:44 AM To: amd-gfx@lists.freedesktop.org Cc: Yang, Philip Subject: [PATCH] drm/amdgpu: remove redundant memset kvmalloc_array uses __GFP_ZERO flag ensures th

[PATCH xf86-video-amdgpu 1/2] Handle ihandle == -1 in amdgpu_set_shared_pixmap_backing

2018-08-29 Thread Michel Dänzer
From: Michel Dänzer It means to stop using the shared pixmap backing. (Ported from radeon commit 1799680f7bd84e0618f34f4c7486799521ddaf83) Signed-off-by: Michel Dänzer --- src/amdgpu_bo_helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amdgpu_bo_helper.c b/src/amdgpu_bo_help

[PATCH xf86-video-amdgpu 2/2] glamor: Handle ihandle == -1 in amdgpu_glamor_set_shared_pixmap_backing

2018-08-29 Thread Michel Dänzer
From: Michel Dänzer (Ported from radeon commit de88ea2755611bdcb18d91d8234d2ab5be8ff2e9) Signed-off-by: Michel Dänzer --- src/amdgpu_glamor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amdgpu_glamor.c b/src/amdgpu_glamor.c index 13d68fe36..699861f73 100644 --- a

Re: How to gracefully handle pci remove

2018-08-29 Thread Andrey Grodzovsky
Thanks. Andrey On 08/29/2018 11:07 AM, Daniel Vetter wrote: On Wed, Aug 29, 2018 at 4:43 PM, Andrey Grodzovsky wrote: Just another ping... Daniel, Dave - maybe you could give some advise on that ? P.S I tried with Intel card (i915) driver on 4.18.1 kernel to do the same to get some referen

[PATCH] drm/amdgpu: remove redundant memset

2018-08-29 Thread Philip Yang
kvmalloc_array uses __GFP_ZERO flag ensures that the returned address is zeroed already, memset it to zero again afterwards is unnecessary, and in this case buggy because we only clear the first entry. Change-Id: If94a59d3cbf2690dd2a1e2add71bc393df6a9686 Signed-off-by: Philip Yang --- drivers/gp

Re: [PATCH] drm/amdgpu: remove redundant memset

2018-08-29 Thread Christian König
Am 29.08.2018 um 17:13 schrieb Philip Yang: kvmalloc_array uses __GFP_ZERO flag ensures that the returned address is zeroed already, memset it to zero again afterwards is unnecessary and in this case buggy because we only clear the first entry. Change-Id: If94a59d3cbf2690dd2a1e2add71bc393df6

[PATCH] drm/amdgpu: remove redundant memset

2018-08-29 Thread Philip Yang
kvmalloc_array uses __GFP_ZERO flag ensures that the returned address is zeroed already, memset it to zero again afterwards is unnecessary Change-Id: If94a59d3cbf2690dd2a1e2add71bc393df6a9686 Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 - 1 file changed, 1 deletion(

Re: How to gracefully handle pci remove

2018-08-29 Thread Daniel Vetter
On Wed, Aug 29, 2018 at 4:43 PM, Andrey Grodzovsky wrote: > Just another ping... > > Daniel, Dave - maybe you could give some advise on that ? > > P.S I tried with Intel card (i915) driver on 4.18.1 kernel to do the same to > get some reference point, but it just hanged. drm_device hot-unplug is

Re: [PATCH] drm/amdgpu: remove redundant memset

2018-08-29 Thread Christian König
Am 29.08.2018 um 17:01 schrieb Philip Yang: Change-Id: If94a59d3cbf2690dd2a1e2add71bc393df6a9686 Signed-off-by: Philip Yang You need to add a commit message, explaining why that can be removed. With that done the patch is Reviewed-by: Christian König . Regards, Christian. --- drivers/g

[PATCH] drm/amdgpu: remove redundant memset

2018-08-29 Thread Philip Yang
Change-Id: If94a59d3cbf2690dd2a1e2add71bc393df6a9686 Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index 153c9be..33d9ce2 100644 --- a/driver

Re: [PATCH v5 5/5] drm/amdgpu: move PD/PT bos on LRU again

2018-08-29 Thread Christian König
Am 29.08.2018 um 16:51 schrieb Michel Dänzer: On 2018-08-29 10:57 a.m., Christian König wrote: Am 29.08.2018 um 09:52 schrieb Michel Dänzer: On 2018-08-28 7:03 p.m., Michel Dänzer wrote: On 2018-08-28 11:14 a.m., Michel Dänzer wrote: On 2018-08-22 9:52 a.m., Huang Rui wrote: The new bulk mov

Re: [PATCH v5 5/5] drm/amdgpu: move PD/PT bos on LRU again

2018-08-29 Thread Michel Dänzer
On 2018-08-29 10:57 a.m., Christian König wrote: > Am 29.08.2018 um 09:52 schrieb Michel Dänzer: >> On 2018-08-28 7:03 p.m., Michel Dänzer wrote: >>> On 2018-08-28 11:14 a.m., Michel Dänzer wrote: On 2018-08-22 9:52 a.m., Huang Rui wrote: > The new bulk moving functionality is ready, the o

Re: How to gracefully handle pci remove

2018-08-29 Thread Andrey Grodzovsky
Just another ping... Daniel, Dave - maybe you could give some advise on that ? P.S I tried with Intel card (i915) driver on 4.18.1 kernel to do the same to get some reference point, but it just hanged. Andrey On 08/27/2018 12:04 PM, Andrey Grodzovsky wrote: Hi everybody , I am trying to re

[PATCH] drm/amdgpu: Relocate some definitions

2018-08-29 Thread Amber Lin
Move some KFD-related (but used in amdgpu_drv.c) definitions from kfd_priv.h to kgd_kfd_interface.h so we don't need to include kfd_priv.h in amdgpu_drv.c. This fixes a build failure when AMDGPU is enabled but MMU_NOTIFIER is not. This patch also disables KFD-related module options when HSA_AMD is

[PATCH 6/7] drm/amdgpu: enable AGP aperture for GMC9

2018-08-29 Thread Christian König
Enable the old AGP aperture to avoid GART mappings. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 10 +- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c| 1 + drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 10 +- 3 files changed, 11 insertions(+), 10 deleti

[PATCH 3/7] drm/amdgpu: add amdgpu_gmc_agp_location v2

2018-08-29 Thread Christian König
Helper to figure out the location of the AGP BAR. v2: fix a couple of bugs Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 43 + drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 5 +++ 2 files changed, 48 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 5/7] drm/amdgpu: manually map the shadow BOs again

2018-08-29 Thread Christian König
Otherwise we won't be able to use the AGP aperture. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_obje

[PATCH 1/7] drm/amdgpu: correctly sign extend 48bit addresses v3

2018-08-29 Thread Christian König
Correct sign extend the GMC addresses to 48bit. v2: sign extending turned out easier than thought. v3: clean up the defines and move them into amdgpu_gmc.h as well Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c |

[PATCH 7/7] drm/amdgpu: try to make kernel allocations USWC

2018-08-29 Thread Christian König
Not 100% sure if that is a good idea or not. In theory only the writeback BO should be read most of the time, but who knows? Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amd

[PATCH 2/7] drm/amdgpu: put GART away from VRAM v2

2018-08-29 Thread Christian König
Always try to put the GART away from where VRAM is. v2: correctly handle the 4GB limitation Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/g

[PATCH 4/7] drm/amdgpu: use the AGP aperture for system memory access v2

2018-08-29 Thread Christian König
Start to use the old AGP aperture for system memory access. v2: Move that to amdgpu_ttm_alloc_gart Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 23 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 58 +++

Re: [PATCH] drm/amd/powerplay: added vega20 overdrive support

2018-08-29 Thread Paul Menzel
Dear Evan, I forgot, that in the commit message summary, the imperative mood should be used. > Add vega20 overdrive support On 08/29/18 14:23, Paul Menzel wrote: > On 08/29/18 11:12, Evan Quan wrote: >> Vega20 supports only sclk voltage overdrive. And user can >> only tell three groups of . SM

Re: [PATCH] drm/amd/powerplay: added vega20 overdrive support

2018-08-29 Thread Paul Menzel
Dear Evan, On 08/29/18 11:12, Evan Quan wrote: > Vega20 supports only sclk voltage overdrive. And user can > only tell three groups of . SMU Do you mean: The user can only configure three groups of …? > firmware will recalculate the frequency/voltage curve. Other > intermediate levles will be s

Re: [PATCH 5/5] [RFC]drm: add syncobj timeline support v3

2018-08-29 Thread Christian König
Am 29.08.2018 um 12:44 schrieb Chunming Zhou: VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline semaphores support the following operations: * CPU query - A host operation that allows query

[PATCH 4/5] drm: expand replace_fence to support timeline point v2

2018-08-29 Thread Chunming Zhou
we can place a fence to a timeline point after expanded. v2: change func parameter order Signed-off-by: Chunming Zhou Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 14 -- drivers/gpu/drm/i915/i915_ge

[PATCH 5/5] [RFC]drm: add syncobj timeline support v3

2018-08-29 Thread Chunming Zhou
VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline semaphores support the following operations: * CPU query - A host operation that allows querying the payload of the timeline semaphore.

[PATCH 3/5] drm: expand drm_syncobj_find_fence to support timeline point v2

2018-08-29 Thread Chunming Zhou
we can fetch timeline point fence after expanded. v2: The parameter fence is the result of the function and should come last. Signed-off-by: Chunming Zhou Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 5 +++-- drivers/gp

[PATCH 2/5] drm: rename null fence to stub fence in syncobj

2018-08-29 Thread Chunming Zhou
stub fence will be used by timeline syncobj as well. Signed-off-by: Chunming Zhou Cc: Jason Ekstrand Reviewed-by: Christian König --- drivers/gpu/drm/drm_syncobj.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers

[PATCH 1/5] drm: fix syncobj null_fence_enable_signaling

2018-08-29 Thread Chunming Zhou
That is certainly totally nonsense. dma_fence_enable_sw_signaling() is the function who is calling this callback. Signed-off-by: Chunming Zhou Cc: Jason Ekstrand Reviewed-by: Christian König Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_syncobj.c | 1 - 1 file changed, 1 deletion(-) diff -

Re: [PATCH 03/10] drm/amdgpu: fix amdgpu_gmc_gart_location a little bit

2018-08-29 Thread Christian König
Am 27.08.2018 um 21:03 schrieb Alex Deucher: On Mon, Aug 27, 2018 at 12:55 PM Christian König wrote: Improve the VCE limitation handling. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 28 - 1 file changed, 13 insertions(+), 15 deletion

Re: [PATCH] drm/amdgpu: correctly sign extend 48bit addresses v3

2018-08-29 Thread Christian König
Am 29.08.2018 um 04:03 schrieb Zhang, Jerry (Junwei): On 08/28/2018 08:17 PM, Christian König wrote: Correct sign extend the GMC addresses to 48bit. Could you explain a bit more why to extend the sign? The hardware works like this, in other words when bit 47 is set we must extend that into

Re: [PATCH] drm/amd/powerplay: expose vega20 OD features

2018-08-29 Thread Quan, Evan
I just sent out a new patch which reuses existing APIs. Let's move future discussion there. Regards, Evan From: Quan, Evan Sent: Wednesday, August 29, 2018 9:12 AM To: Alex Deucher; Zhu, Rex Cc: Deucher, Alexander; amd-gfx list; Xu, Feifei; Kuehling, Felix; Zhang,

[PATCH] drm/amd/powerplay: added vega20 overdrive support

2018-08-29 Thread Evan Quan
Vega20 supports only sclk voltage overdrive. And user can only tell three groups of . SMU firmware will recalculate the frequency/voltage curve. Other intermediate levles will be stretched/shrunk accordingly. Change-Id: I403cb38a95863db664cf06d030ac42a19bff6b33 Signed-off-by: Evan Quan --- drive

Re: [PATCH] drm/amdgpu: Need to set moved to true when evict bo

2018-08-29 Thread Zhang, Jerry (Junwei)
On 08/29/2018 04:53 PM, Christian König wrote: Am 29.08.2018 um 04:52 schrieb Zhang, Jerry (Junwei): On 08/28/2018 08:40 PM, Emily Deng wrote: Fix the VMC page fault when the running sequence is as below: 1.amdgpu_gem_create_ioctl 2.ttm_bo_swapout->amdgpu_vm_bo_invalidate, as not called amdgpu_

Re: [PATCH 2/2] drm/amdkfd: Release an acquired process vm

2018-08-29 Thread Christian König
Am 28.08.2018 um 19:34 schrieb Oak Zeng: For compute vm acquired from amdgpu, vm.pasid is managed by kfd. Decouple pasid from such vm on process destroy to avoid duplicate pasid release. Signed-off-by: Oak Zeng One minor nit pick below, apart from that Acked-by: Christian König --- dri

Re: [PATCH v5 5/5] drm/amdgpu: move PD/PT bos on LRU again

2018-08-29 Thread Michel Dänzer
On 2018-08-29 10:57 a.m., Christian König wrote: > Am 29.08.2018 um 09:52 schrieb Michel Dänzer: >> On 2018-08-28 7:03 p.m., Michel Dänzer wrote: >>> On 2018-08-28 11:14 a.m., Michel Dänzer wrote: On 2018-08-22 9:52 a.m., Huang Rui wrote: > The new bulk moving functionality is ready, the o

Re: [PATCH v5 5/5] drm/amdgpu: move PD/PT bos on LRU again

2018-08-29 Thread Christian König
Am 29.08.2018 um 09:52 schrieb Michel Dänzer: On 2018-08-28 7:03 p.m., Michel Dänzer wrote: On 2018-08-28 11:14 a.m., Michel Dänzer wrote: On 2018-08-22 9:52 a.m., Huang Rui wrote: The new bulk moving functionality is ready, the overhead of moving PD/PT bos to LRU is fixed. So move them on LRU

Re: [PATCH] drm/amdgpu: Need to set moved to true when evict bo

2018-08-29 Thread Christian König
Am 29.08.2018 um 04:52 schrieb Zhang, Jerry (Junwei): On 08/28/2018 08:40 PM, Emily Deng wrote: Fix the VMC page fault when the running sequence is as below: 1.amdgpu_gem_create_ioctl 2.ttm_bo_swapout->amdgpu_vm_bo_invalidate, as not called amdgpu_vm_bo_base_init, so won't called list_add_tail(&

Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-29 Thread Christian König
Completely agree with Felix here. It makes system memory access slightly simpler, but I would say that you accidentally corrupt the GART table and that you accidentally corrupt the the AGP aperture is equally likely. Regards, Christian. Am 28.08.2018 um 20:12 schrieb Felix Kuehling: The GPU

Re: [PATCH v5 5/5] drm/amdgpu: move PD/PT bos on LRU again

2018-08-29 Thread Michel Dänzer
On 2018-08-28 7:03 p.m., Michel Dänzer wrote: > On 2018-08-28 11:14 a.m., Michel Dänzer wrote: >> On 2018-08-22 9:52 a.m., Huang Rui wrote: >>> The new bulk moving functionality is ready, the overhead of moving PD/PT >>> bos to >>> LRU is fixed. So move them on LRU again. >>> >>> Signed-off-by: Hu

Re: [PATCH] drm/amdgpu: add missing CHIP_HAINAN in amdgpu_ucode_get_load_type

2018-08-29 Thread Michel Dänzer
On 2018-08-28 9:19 p.m., Alex Deucher wrote: > This caused a confusing error message, but there is functionally > no problem since the default method is DIRECT. > > Signed-off-by: Alex Deucher > Cc: sta...@vger.kernel.org > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 1 + > 1 file changed,