RE: [PATCH] drm/amdgpu: print mmhub client name for dimgrey_cavefish

2020-12-15 Thread Chen, Jiansong (Simon)
[AMD Public Use] Reviewed-by: Jiansong Chen -Original Message- From: Zhou1, Tao Sent: Wednesday, December 16, 2020 11:40 AM To: Chen, Jiansong (Simon) ; Gui, Jack ; Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu: print mmhub client name for

[PATCH] drm/amdgpu: print mmhub client name for dimgrey_cavefish

2020-12-15 Thread Tao Zhou
This makes it easier to debug what block is causing the fault, same as sienna_cichlid. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c index

RE: [PATCH] drm/amdgpu/disply: fix documentation warnings in display manager

2020-12-15 Thread Lin, Wayne
[AMD Public Use] Thanks Alex! Sorry for any inconvenience.. Reviewed-by: Wayne Lin > -Original Message- > From: Alex Deucher > Sent: Wednesday, December 16, 2020 1:10 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Lin, Wayne > ; Stephen Rothwell > Subject: [PATCH]

RE: [PATCH] drm/amdgpu: set mode1 reset as default for dimgrey_cavefish

2020-12-15 Thread Zhou1, Tao
[AMD Public Use] Thanks for your reminder, I'll add another patch to enable gpu recovery. Tao From: Deucher, Alexander Sent: Tuesday, December 15, 2020 10:27 PM To: Chen, Jiansong (Simon) ; Zhou1, Tao ; Gui, Jack ; Zhang, Hawking ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH]

Re: [PATCH] drm/amd/display: Add get_dig_frontend implementation for DCEx

2020-12-15 Thread Rodrigo Siqueira
Applied to amd-staging-drm-next. Thanks On 12/15, Alex Deucher wrote: > On Tue, Dec 15, 2020 at 10:45 AM Rodrigo Siqueira > wrote: > > > > Some old ASICs might not implement/require get_dig_frontend helper; in > > this scenario, we can have a NULL pointer exception when we try to call > > it

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-12-15 Thread Andrey Grodzovsky
On 11/24/20 11:44 AM, Christian König wrote: Am 24.11.20 um 17:22 schrieb Andrey Grodzovsky: On 11/24/20 2:41 AM, Christian König wrote: Am 23.11.20 um 22:08 schrieb Andrey Grodzovsky: On 11/23/20 3:41 PM, Christian König wrote: Am 23.11.20 um 21:38 schrieb Andrey Grodzovsky: On

Re: 8353d30e747f ("drm/amd/display: disable stream if pixel clock changed with link active")

2020-12-15 Thread Borislav Petkov
On Tue, Dec 15, 2020 at 02:00:58PM -0500, Rodrigo Siqueira wrote: > Thanks for reporting this issue and test the fix. It was my pleasure. Thanks for the quick fix! :-) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

Re: 8353d30e747f ("drm/amd/display: disable stream if pixel clock changed with link active")

2020-12-15 Thread Rodrigo Siqueira
On 12/15, Borislav Petkov wrote: > On Tue, Dec 15, 2020 at 12:04:23PM -0500, Alex Deucher wrote: > > That patch trivially backports to 5.10. See attached backported > > patch. @Borislav Petkov does the attached patch fix 5.10 for you? > > Yes, thanks. > > Reported-and-tested-by: Borislav

Re: 8353d30e747f ("drm/amd/display: disable stream if pixel clock changed with link active")

2020-12-15 Thread Borislav Petkov
On Tue, Dec 15, 2020 at 12:04:23PM -0500, Alex Deucher wrote: > That patch trivially backports to 5.10. See attached backported > patch. @Borislav Petkov does the attached patch fix 5.10 for you? Yes, thanks. Reported-and-tested-by: Borislav Petkov -- Regards/Gruss, Boris.

Re: [PATCH] drm/amd/display: Add get_dig_frontend implementation for DCEx

2020-12-15 Thread Rodrigo Siqueira
On 12/15, Alex Deucher wrote: > On Tue, Dec 15, 2020 at 10:45 AM Rodrigo Siqueira > wrote: > > > > Some old ASICs might not implement/require get_dig_frontend helper; in > > this scenario, we can have a NULL pointer exception when we try to call > > it inside vbios disable operation. For example,

Re: [PATCH] drm/amd/display: Add get_dig_frontend implementation for DCEx

2020-12-15 Thread Alex Deucher
On Tue, Dec 15, 2020 at 10:45 AM Rodrigo Siqueira wrote: > > Some old ASICs might not implement/require get_dig_frontend helper; in > this scenario, we can have a NULL pointer exception when we try to call > it inside vbios disable operation. For example, this situation might > happen when using

[PATCH] drm/amdgpu/disply: fix documentation warnings in display manager

2020-12-15 Thread Alex Deucher
Add documentation for crc window. Fixes: c920888c604d ("drm/amd/display: Expose new CRC window property") Signed-off-by: Alex Deucher Cc: Wayne Lin Reported-by: Stephen Rothwell --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 21 ++- 1 file changed, 20 insertions(+), 1

Re: 8353d30e747f ("drm/amd/display: disable stream if pixel clock changed with link active")

2020-12-15 Thread Alex Deucher
On Tue, Dec 15, 2020 at 11:42 AM Rodrigo Siqueira wrote: > > On 12/15, Alex Deucher wrote: > > On Tue, Dec 15, 2020 at 11:07 AM Rodrigo Siqueira > > wrote: > > > > > > Hi, > > > > > > Could you try on Alex's repo? > > > > > > git://people.freedesktop.org/~agd5f/linux > > > branch:

Re: 8353d30e747f ("drm/amd/display: disable stream if pixel clock changed with link active")

2020-12-15 Thread Rodrigo Siqueira
On 12/15, Alex Deucher wrote: > On Tue, Dec 15, 2020 at 11:07 AM Rodrigo Siqueira > wrote: > > > > Hi, > > > > Could you try on Alex's repo? > > > > git://people.freedesktop.org/~agd5f/linux > > branch: amd-staging-drm-next > > > > My patch should apply without any issue on top of this branch.

RE: Overlay issues

2020-12-15 Thread Cornij, Nikola
[AMD Public Use] Yeah, but... it works with bigger FBs (300x300). So looks like some clipping somewhere works OK until a corner-case is reached. -Original Message- From: Simon Ser Sent: Tuesday, December 15, 2020 2:58 AM To: Cornij, Nikola Cc: Alex Deucher ; Kazlauskas, Nicholas ;

Re: [PATCH] drm/amd/display: Add get_dig_frontend implementation for DCEx

2020-12-15 Thread Alex Deucher
On Tue, Dec 15, 2020 at 10:45 AM Rodrigo Siqueira wrote: > > Some old ASICs might not implement/require get_dig_frontend helper; in > this scenario, we can have a NULL pointer exception when we try to call > it inside vbios disable operation. For example, this situation might > happen when using

Re: 8353d30e747f ("drm/amd/display: disable stream if pixel clock changed with link active")

2020-12-15 Thread Borislav Petkov
On Tue, Dec 15, 2020 at 10:47:03AM -0500, Rodrigo Siqueira wrote: > Hi Boris, > > Could you check if your branch has this commit: > > drm/amd/display: Fix module load hangs when connected to an eDP > > If so, could you try this patch: > > https://patchwork.freedesktop.org/series/84965/ So I

Re: 8353d30e747f ("drm/amd/display: disable stream if pixel clock changed with link active")

2020-12-15 Thread Alex Deucher
On Tue, Dec 15, 2020 at 11:07 AM Rodrigo Siqueira wrote: > > Hi, > > Could you try on Alex's repo? > > git://people.freedesktop.org/~agd5f/linux > branch: amd-staging-drm-next > > My patch should apply without any issue on top of this branch. Can you help me identify what patches we need to

Re: 8353d30e747f ("drm/amd/display: disable stream if pixel clock changed with link active")

2020-12-15 Thread Rodrigo Siqueira
Hi, Could you try on Alex's repo? git://people.freedesktop.org/~agd5f/linux branch: amd-staging-drm-next My patch should apply without any issue on top of this branch. Thanks On 12/15, Borislav Petkov wrote: > On Tue, Dec 15, 2020 at 10:47:03AM -0500, Rodrigo Siqueira wrote: > > Hi Boris, >

Re: 8353d30e747f ("drm/amd/display: disable stream if pixel clock changed with link active")

2020-12-15 Thread Alex Deucher
On Tue, Dec 15, 2020 at 10:49 AM Rodrigo Siqueira wrote: > > Hi Alex, > > I made the below patch that might fix the issue; I need to hear Boris's > feedback first. Alex, did you already revert it? I have not reverted it yet. Alex > > * https://patchwork.freedesktop.org/series/84965/ > > Thanks

Re: 8353d30e747f ("drm/amd/display: disable stream if pixel clock changed with link active")

2020-12-15 Thread Rodrigo Siqueira
Hi Alex, I made the below patch that might fix the issue; I need to hear Boris's feedback first. Alex, did you already revert it? * https://patchwork.freedesktop.org/series/84965/ Thanks On 12/14, Alex Deucher wrote: > On Fri, Dec 11, 2020 at 11:49 AM Borislav Petkov wrote: > > > > Hi, > > >

Re: 8353d30e747f ("drm/amd/display: disable stream if pixel clock changed with link active")

2020-12-15 Thread Rodrigo Siqueira
Hi Boris, Could you check if your branch has this commit: drm/amd/display: Fix module load hangs when connected to an eDP If so, could you try this patch: https://patchwork.freedesktop.org/series/84965/ Thanks On 12/11, Borislav Petkov wrote: > Hi, > > patch in $Subject breaks booting on

[PATCH] drm/amd/display: Add get_dig_frontend implementation for DCEx

2020-12-15 Thread Rodrigo Siqueira
Some old ASICs might not implement/require get_dig_frontend helper; in this scenario, we can have a NULL pointer exception when we try to call it inside vbios disable operation. For example, this situation might happen when using Polaris12 with an eDP panel. This commit avoids this situation by

Re: [PATCH] drm/amdgpu: remove h from printk format specifier

2020-12-15 Thread Alex Deucher
On Tue, Dec 15, 2020 at 10:11 AM Christian König wrote: > > Am 15.12.20 um 16:06 schrieb Tom Rix: > > On 12/15/20 6:47 AM, Christian König wrote: > >> Am 15.12.20 um 15:38 schrieb t...@redhat.com: > >>> From: Tom Rix > >>> > >>> See Documentation/core-api/printk-formats.rst. > >>> h should no

[PATCH] drm/radeon: remove h from printk format specifier

2020-12-15 Thread trix
From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/gpu/drm/radeon/radeon_uvd.c | 2 +- drivers/gpu/drm/radeon/radeon_vce.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH] drm/amdgpu: remove h from printk format specifier

2020-12-15 Thread Tom Rix
On 12/15/20 6:47 AM, Christian König wrote: > Am 15.12.20 um 15:38 schrieb t...@redhat.com: >> From: Tom Rix >> >> See Documentation/core-api/printk-formats.rst. >> h should no longer be used in the format specifier for printk. > > In general looks valid to me, but my question is how does that

Re: [PATCH] drm/amdgpu: remove h from printk format specifier

2020-12-15 Thread Christian König
Am 15.12.20 um 16:06 schrieb Tom Rix: On 12/15/20 6:47 AM, Christian König wrote: Am 15.12.20 um 15:38 schrieb t...@redhat.com: From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. In general looks valid to me, but my

Re: [PATCH] drm/amdgpu: Fix spelling mistake "Heterogenous" -> "Heterogeneous"

2020-12-15 Thread Alex Deucher
On Tue, Dec 15, 2020 at 5:56 AM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in a comment in the Kconfig. Fix it. > > Signed-off-by: Colin Ian King Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdkfd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] drm/amdgpu: remove h from printk format specifier

2020-12-15 Thread Christian König
Am 15.12.20 um 15:38 schrieb t...@redhat.com: From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. In general looks valid to me, but my question is how does that work? I mean we specify h here because it is a short int.

[PATCH] drm/amdgpu: remove h from printk format specifier

2020-12-15 Thread trix
From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4

Re: [PATCH] drm/amdgpu: set mode1 reset as default for dimgrey_cavefish

2020-12-15 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] You will also need to add the asic_type to amdgpu_device_should_recover_gpu() if you the driver to actually use GPU reset when it encounters a hang. Alex From: amd-gfx on behalf of Chen, Jiansong (Simon)

Re: [PATCH v3 2/3] drm/amd/display: Add freesync video modes based on preferred modes

2020-12-15 Thread Aurabindo Pillai
On Tue, 2020-12-15 at 08:32 +0530, Shashank Sharma wrote: > > On 15/12/20 3:50 am, Aurabindo Pillai wrote: > > [Why] > > If experimental freesync video mode module parameter is enabled, > > add > > few extra display modes into the driver's mode list corresponding > > to common > > video frame

[PATCH] drm/amdgpu: Fix spelling mistake "Heterogenous" -> "Heterogeneous"

2020-12-15 Thread Colin King
From: Colin Ian King There is a spelling mistake in a comment in the Kconfig. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdkfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig

RE: [PATCH] drm/amdgpu: set mode1 reset as default for dimgrey_cavefish

2020-12-15 Thread Chen, Jiansong (Simon)
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Jiansong Chen -Original Message- From: Zhou1, Tao Sent: Tuesday, December 15, 2020 6:23 PM To: Chen, Jiansong (Simon) ; Gui, Jack ; Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH]

[PATCH] drm/amdgpu: set mode1 reset as default for dimgrey_cavefish

2020-12-15 Thread Tao Zhou
Use mode1 reset for dimgrey_cavefish by default. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/nv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c index ac02dd707c44..6bee3677394a 100644 ---

RE: [PATCH] drm/amd/pm: correct the sensor value of power for vangogh

2020-12-15 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Evan Quan -Original Message- From: Du, Xiaojian Sent: Tuesday, December 15, 2020 3:40 PM To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray ; Quan, Evan ; Deucher, Alexander ; Wang, Kevin(Yang) ; Huang, Shimmer ; Lazar,