[PATCH] drm/amdkfd: Fix the warning of array-index-out-of-bounds

2022-10-07 Thread Ma Jun
Increasing the simbling array size to fix the warning of array-index-out-of-bounds. The VCRAT_SIZE_FOR_GPU is also increased accrordingly. Signed-off-by: Ma Jun --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_crat.h | 2 +- 2 files changed, 2 insertions(+), 2

RE: [PATCH 2/4] drm/amdgpu: Add software ring callbacks for gfx9 (v7)

2022-10-07 Thread Gao, Likun
[AMD Official Use Only - General] Yes, thanks for helping explanation. Regards, Likun -Original Message- From: Zhu, Jiadong Sent: Saturday, October 8, 2022 1:17 PM To: Zhang, Hawking ; Gao, Likun ; amd-gfx@lists.freedesktop.org Cc: Grodzovsky, Andrey ; Michel Dänzer ; Tuikov, Luben

RE: [PATCH 2/4] drm/amdgpu: Add software ring callbacks for gfx9 (v7)

2022-10-07 Thread Zhu, Jiadong
I think Likun means to stop creating sw ring if there is no gfx ring existed. Thanks, Jiadong -Original Message- From: Zhang, Hawking Sent: Saturday, October 8, 2022 12:37 PM To: Gao, Likun ; Zhu, Jiadong ; amd-gfx@lists.freedesktop.org Cc: Grodzovsky, Andrey ; Michel Dänzer ;

RE: [PATCH 2/4] drm/amdgpu: Add software ring callbacks for gfx9 (v7)

2022-10-07 Thread Zhu, Jiadong
I agree, let me update the patch. Thanks, Jiadong -Original Message- From: Gao, Likun Sent: Saturday, October 8, 2022 11:52 AM To: Zhu, Jiadong ; amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Michel Dänzer ; Zhu, Jiadong ; Koenig, Christian ; Grodzovsky, Andrey Subject: RE:

RE: [PATCH 2/4] drm/amdgpu: Add software ring callbacks for gfx9 (v7)

2022-10-07 Thread Zhang, Hawking
[AMD Official Use Only - General] I don't think so. In such case, current cwsr and user queue mechanism handle the pre-emption very well. The command submission actually bypass drm GPU scheduler. Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Gao, Likun Sent:

RE: [PATCH 2/4] drm/amdgpu: Add software ring callbacks for gfx9 (v7)

2022-10-07 Thread Gao, Likun
[AMD Official Use Only - General] Shall we need to deal with the situation that no real gfx ring exist? (adev->gfx.num_gfx_rings is 0) Regards, Likun -Original Message- From: amd-gfx On Behalf Of jiadong@amd.com Sent: Thursday, September 29, 2022 5:07 PM To:

RE: [PATCH] drm/amdgpu: Fix SDMA engine resume issue under SRIOV

2022-10-07 Thread Zhang, Bokun
[AMD Official Use Only - General] Tested-by: Bokun, Zhang This patch is better since it extracted the unset code and only execute it in the SRIOV routine. I have tested it with multi-VF. Thanks! -Original Message- From: Alex Deucher Sent: Thursday, October 6, 2022 3:56 PM To:

[linux-next:master] BUILD REGRESSION 082fce125e57cff60687181c97f3a8ee620c38f5

2022-10-07 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 082fce125e57cff60687181c97f3a8ee620c38f5 Add linux-next specific files for 20221007 Error/Warning reports: https://lore.kernel.org/linux-doc/202209201326.sy9kholm-...@intel.com https

Re: [20/23] drm/amd/display: Fix watermark calculation

2022-10-07 Thread Limonciello, Mario
On 10/6/2022 16:26, Qingqing Zhuo wrote: From: Alvin Lee Watermark calculation was incorrect due to missing brackets. Reviewed-by: Rodrigo Siqueira Acked-by: Qingqing Zhuo Signed-off-by: Alvin Lee This just landed upstream for 6.0 and is a trivial fix for what the intention was, it

Re: [01/23] drm/amd/display: Update PMFW z-state interface for DCN314

2022-10-07 Thread Limonciello, Mario
On 10/6/2022 16:26, Qingqing Zhuo wrote: From: Nicholas Kazlauskas [Why] Request from PMFW to change the messaging format to specify whether we support z-state via individual bits. [How] Update the args we pass in the support message. Reviewed-by: Charlene Liu Acked-by: Qingqing Zhuo

Re: mainline build failure due to 5d8c3e836fc2 ("drm/amd/display: fix array-bounds error in dc_stream_remove_writeback()")

2022-10-07 Thread Linus Torvalds
On Thu, Oct 6, 2022 at 1:50 PM Sudip Mukherjee wrote: > > > And it looks like Sudip's proposed fix for this particular code is > > additionally fixing unsigned vs signed as well. I think -Warray-bounds > > did its job (though, with quite a confusing index range in the report). > > Not my.

Re: drm/amd/display: explicitly disable psr_feature_enable appropriately

2022-10-07 Thread Limonciello, Mario
On 10/6/2022 23:28, Shirish S wrote: [Why] If psr_feature_enable is set to true by default, it continues to be enabled for non capable links. [How] explicitly disable the feature on links that are not capable of the same. Signed-off-by: Shirish S Reviewed-by: Leo Li This has been a problem

Re: [PATCH] drm/amd/display: explicitly disable psr_feature_enable appropriately

2022-10-07 Thread Leo Li
On 2022-10-07 00:28, Shirish S wrote: [Why] If psr_feature_enable is set to true by default, it continues to be enabled for non capable links. [How] explicitly disable the feature on links that are not capable of the same. Signed-off-by: Shirish S Reviewed-by: Leo Li Thanks! ---