[AMD Official Use Only - General]
Reviewed-by: Tao Zhou
> -Original Message-
> From: amd-gfx On Behalf Of
> Stanley.Yang
> Sent: Thursday, September 28, 2023 11:46 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Yang, Stanley
> Subject: [PATCH Review 1/1] drm/amdgpu: Fix potential null
[AMD Official Use Only - General]
Reviewed-by: Tao Zhou
> -Original Message-
> From: amd-gfx On Behalf Of
> Stanley.Yang
> Sent: Thursday, September 28, 2023 11:42 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Yang, Stanley
> Subject: [PATCH Review 1/1] drm/amdgpu: Skip ring test
The amdgpu_ras_get_context may return NULL if device
not support ras feature, so add check before using.
Signed-off-by: Stanley.Yang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
This is workaround due to ring test failed during ras
do gpu recovery for aqua vanjaram.
Signed-off-by: Stanley.Yang
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
Applied. Thanks!
Alex
On Wed, Sep 27, 2023 at 2:57 PM Wang, Yang(Kevin)
wrote:
>
> [AMD Official Use Only - General]
>
> Thanks.
>
> Reviewed-by: Yang Wang
>
> Best Regards,
> Kevin
>
> -Original Message-
> From: Dan Carpenter
> Sent: Wednesday, September 27, 2023 8:38 PM
> To: Evan
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn35/dcn35_fpu.c:261
dcn35_update_bw_bounding_box_fpu() warn: inconsistent indenting
Signed-off-by: Yang Li
---
.../drm/amd/display/dc/dml/dcn35/dcn35_fpu.c | 144 +-
1 file changed, 72 insertions(+), 72 deletions(-)
diff --git
[Public]
Acked-by: Alex Deucher
From: amd-gfx on behalf of Victor Zhao
Sent: Monday, September 25, 2023 11:08 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhao, Victor
Subject: [PATCH] drm/amd/pm: Disallow managing power profiles on SRIOV for
gc11.0.3
disable
ping for review.
On 9/20/2023 12:32 PM, Xiaogang.Chen wrote:
From: Xiaogang Chen
This patch implements partial migration in gpu page fault according to migration
granularity(default 2MB) and not split svm range in cpu page fault handling.
A svm range may include pages from both system ram and
On 2023-09-25 15:49, Melissa Wen wrote:
> From: Joshua Ashton
>
> Create drm_color_ctm_3x4 to support 3x4-dimension plane CTM matrix and
> convert DRM CTM to DC CSC float matrix.
>
> v3:
> - rename ctm2 to ctm_3x4 (Harry)
>
> Signed-off-by: Joshua Ashton
Reviewed-by: Harry Wentland
On 2023-09-25 15:49, Melissa Wen wrote:
> Map the plane CTM driver-specific property to DC plane, instead of DC
> stream. The remaining steps to program DPP block are already implemented
> on DC shared-code.
>
> v3:
> - fix comment about plane and CRTC CTMs priorities (Harry)
>
>
On 2023-09-25 15:49, Melissa Wen wrote:
> From: Joshua Ashton
>
> Need to funnel the color caps through to these functions so it can check
> that the hardware is capable.
>
> v2:
> - remove redundant color caps assignment on plane degamma map (Harry)
> - pass color caps to degamma params
>
>
On 2023-09-25 15:49, Melissa Wen wrote:
> Map DC shaper LUT to DM plane color management. Shaper LUT can be used
> to delinearize and/or normalize the color space for computational
> efficiency and achiving specific visual styles. If a plane degamma is
> apply to linearize the color space, a
On 2023-09-25 15:49, Melissa Wen wrote:
> Add 3D LUT property for plane color transformations using a 3D lookup
> table. 3D LUT allows for highly accurate and complex color
> transformations and is suitable to adjust the balance between color
> channels. It's also more complex to manage and
Enum values used by the ioctl `AMDGPU_INFO_FW_VERSION`/`AMDGPU_INFO_FW_TA`
are not exported so clients need to keep their own copy of the definitions
while looking up firmware versions for the TA.
Move this to uapi instead.
Signed-off-by: Mario Limonciello
--
v1->v2:
* Rename while moving
All other `drm_amdgpu_ta_fw_type` enums are exported for
`AMDGPU_INFO_FW_TA`. ASD is available via `AMDGPU_INFO_FW_ASD` but
for symmetry in other values export as part of `AMDGPU_INFO_FW_TA` as well.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 5 +
1 file
On Wed, Sep 27, 2023 at 2:21 PM Mario Limonciello
wrote:
>
> Enum values used by the ioctl `AMDGPU_INFO_FW_VERSION`/`AMDGPU_INFO_FW_TA`
> are not exported so clients need to keep their own copy of the definitions
> while looking up firmware versions for the TA.
>
> Move this to uapi instead.
>
>
On 9/12/23 06:22, Michel Dänzer wrote:
From: Michel Dänzer
It was only checking planes which had any state changes in the same
commit. However, it also needs to check other enabled planes.
Not doing this meant that a commit might spuriously "succeed", resulting
in the cursor plane displaying
On 9/27/2023 9:29 AM, Philip Yang wrote:
On 2023-09-26 16:43, Chen, Xiaogang wrote:
On 9/22/2023 4:37 PM, Philip Yang wrote:
Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking links, or responding.
Otherwise kfd flush tlb
We normally place GART based on the location of VRAM and the
available address space around that, but provide an option
to force a particular location for hardware that needs it.
v2: Switch to passing the placement via parameter
Signed-off-by: Alex Deucher
---
Needed to avoid a hardware issue.
v2: force high for all GC11 parts for consistency (Alex)
v3: rebase
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
Enum values used by the ioctl `AMDGPU_INFO_FW_VERSION`/`AMDGPU_INFO_FW_TA`
are not exported so clients need to keep their own copy of the definitions
while looking up firmware versions for the TA.
Move this to uapi instead.
Signed-off-by: Mario Limonciello
---
On 27/09/2023 19:27, Felix Kuehling wrote:
[+Mukul]
On 2023-09-27 12:16, Arvind Yadav wrote:
This patch is to adjust the absolute doorbell offset
against the doorbell id considering the doorbell
size of 32/64 bit.
Cc: Christian Koenig
Cc: Alex Deucher
Signed-off-by: Shashank Sharma
On 2023-09-27 10:07, Harry Wentland wrote:
>
>
> On 2023-09-27 01:23, Christian König wrote:
>> Am 26.09.23 um 15:09 schrieb Harry Wentland:
>>>
>>> On 2023-09-26 01:56, Cong Liu wrote:
This patch fixes a null pointer dereference in the error message that is
printed when the Display
[+Mukul]
On 2023-09-27 12:16, Arvind Yadav wrote:
This patch is to adjust the absolute doorbell offset
against the doorbell id considering the doorbell
size of 32/64 bit.
Cc: Christian Koenig
Cc: Alex Deucher
Signed-off-by: Shashank Sharma
Signed-off-by: Arvind Yadav
---
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: 18030226a48de1fbfabf4ae16aaa2695a484254f Add linux-next specific
files for 20230927
Error/Warning reports:
https://lore.kernel.org/oe-kbuild-all/202308282000.2xnh0k6d-...@intel.com
https
On 2023-09-26 12:39, Alex Deucher wrote:
I think this was an abstraction back from when
kfd supported both radeon and amdgpu. Since we just
support amdgpu now, there is no more need for this and
we can use the amdgpu structures directly.
This also avoids having the kfd_cu_info structures on
On 2023-09-26 12:39, Alex Deucher wrote:
kfd_topology.c:2082:1: warning: the frame size of 1440 bytes is larger than
1024 bytes
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2866
Cc: Arnd Bergmann
Signed-off-by: Alex Deucher
Reviewed-by: Felix Kuehling
---
On 2023-09-26 15:29, Arnd Bergmann wrote:
On Tue, Sep 26, 2023, at 20:47, Deucher, Alexander wrote:
From: Arnd Bergmann
Subject: Re: [PATCH 2/2] drm/amdkfd: drop struct kfd_cu_info
On Tue, Sep 26, 2023, at 18:39, Alex Deucher wrote:
I think this was an abstraction back from when kfd
Adding felix.kuehl...@amd.com for review.
Thanks
~Arvind
On 9/27/2023 9:46 PM, Arvind Yadav wrote:
This patch is to adjust the absolute doorbell offset
against the doorbell id considering the doorbell
size of 32/64 bit.
Cc: Christian Koenig
Cc: Alex Deucher
Signed-off-by: Shashank Sharma
Adding felix.kuehl...@amd.com for review.
Thanks
~Arvind
On 9/27/2023 9:46 PM, Arvind Yadav wrote:
On older chips, the absolute doorbell offset within
the doorbell page is based on the queue ID.
KFD is using queue ID and doorbell size to get an
absolute doorbell offset in userspace.
This
This patch is to adjust the absolute doorbell offset
against the doorbell id considering the doorbell
size of 32/64 bit.
Cc: Christian Koenig
Cc: Alex Deucher
Signed-off-by: Shashank Sharma
Signed-off-by: Arvind Yadav
---
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 11 ++-
On older chips, the absolute doorbell offset within
the doorbell page is based on the queue ID.
KFD is using queue ID and doorbell size to get an
absolute doorbell offset in userspace.
This patch is to adjust the absolute doorbell offset
against the doorbell id considering the doorbell
size of
On Wed, Sep 27, 2023 at 1:37 AM Christian König
wrote:
>
> I'm still not happy with moving the GART fixed to the end. We abandoned
> this for good reasons.
We didn't abandon it, there is still code which decides where to put
the gart based on the relative sizes of the address space before and
On 9/27/2023 9:19 AM, Eric Huang wrote:
Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking links, or responding.
On 2023-09-26 23:00, Xiaogang.Chen wrote:
From: Xiaogang Chen
prange->svm_bo unref can happen in both mmu callback
On 2023-09-26 16:43, Chen, Xiaogang
wrote:
On 9/22/2023 4:37 PM, Philip Yang wrote:
Caution: This message originated from an
External Source. Use proper caution when opening attachments,
clicking links, or responding.
On 2023-09-26 23:00, Xiaogang.Chen wrote:
From: Xiaogang Chen
prange->svm_bo unref can happen in both mmu callback and a callback after
migrate to system ram. Both are async call in different tasks. Sync svm_bo
unref operation to avoid random "use-after-free".
Signed-off-by: Xiaogang.Chen
[AMD Official Use Only - General]
Series is
Reviewed-by: Yang Wang
Best Regards,
Kevin
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Wednesday, September 27, 2023 1:30 AM
To: Deucher, Alexander
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2]
[AMD Official Use Only - General]
Thanks.
Reviewed-by: Yang Wang
Best Regards,
Kevin
-Original Message-
From: Dan Carpenter
Sent: Wednesday, September 27, 2023 8:38 PM
To: Evan Quan ; Wang, Yang(Kevin)
Cc: Deucher, Alexander ; Koenig, Christian
; Pan, Xinhui ; David Airlie
;
On 2023-09-27 01:23, Christian König wrote:
> Am 26.09.23 um 15:09 schrieb Harry Wentland:
>>
>> On 2023-09-26 01:56, Cong Liu wrote:
>>> This patch fixes a null pointer dereference in the error message that is
>>> printed when the Display Core (DC) fails to initialize. The original
>>> message
On 2023-09-26 23:00, Xiaogang.Chen
wrote:
From: Xiaogang Chen
prange->svm_bo unref can happen in both mmu callback and a callback after
migrate to system ram. Both are async call in different tasks. Sync svm_bo
unref operation to avoid random
Hi Ilpo,
On 9/27/2023 7:03 PM, Ilpo Järvinen wrote:
> On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
>
>> From: Basavaraj Natikar
>>
>> AMDSFH has information about the Ambient light via the Ambient
>> Light Sensor (ALS) which is part of the AMD sensor fusion hub.
>> Add PMF and AMDSFH interface
Hi Hans,
On 9/27/2023 6:34 PM, Hans de Goede wrote:
> HI,
>
> On 9/26/23 15:17, Christian König wrote:
>> Am 26.09.23 um 14:56 schrieb Hans de Goede:
>>> Hi,
>>>
>>> On 9/26/23 13:24, Shyam Sundar S K wrote:
Hi Hans,
On 9/26/2023 4:05 PM, Hans de Goede wrote:
> Hi,
>
>
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
> From: Basavaraj Natikar
>
> AMDSFH has information about the Ambient light via the Ambient
> Light Sensor (ALS) which is part of the AMD sensor fusion hub.
> Add PMF and AMDSFH interface to get this information.
>
> Co-developed-by: Shyam Sundar S
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
> From: Basavaraj Natikar
>
> AMDSFH has information about the User presence information via the Human
> Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub.
> Add PMF and AMDSFH interface to get this information.
>
>
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
> For the Smart PC Solution to fully work, it has to enact to the actions
> coming from TA. Add the initial code path for set interface to AMDGPU.
>
> Co-developed-by: Mario Limonciello
> Signed-off-by: Mario Limonciello
> Signed-off-by: Shyam
[AMD Official Use Only - General]
Good idea ! Thanks.
-Original Message-
From: Alex Deucher
Sent: Wednesday, September 27, 2023 9:13 PM
To: Koenig, Christian
Cc: Zhang, Yifan ; amd-gfx@lists.freedesktop.org;
Deucher, Alexander ; Wentland, Harry
Subject: Re: [PATCH] drm/amd/display:
HI,
On 9/26/23 15:17, Christian König wrote:
> Am 26.09.23 um 14:56 schrieb Hans de Goede:
>> Hi,
>>
>> On 9/26/23 13:24, Shyam Sundar S K wrote:
>>> Hi Hans,
>>>
>>> On 9/26/2023 4:05 PM, Hans de Goede wrote:
Hi,
On 9/22/23 19:50, Shyam Sundar S K wrote:
> For the Smart PC
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
> In order to provide GPU inputs to TA for the Smart PC solution to work, we
> need to have interface between the PMF driver and the AMDGPU driver.
>
> Add the initial code path for get interface from AMDGPU.
>
> Co-developed-by: Mario Limonciello
>
On Wed, Sep 27, 2023 at 8:26 AM Christian König
wrote:
>
> Am 27.09.23 um 07:41 schrieb Yifan Zhang:
> > With S/G display becomes stable, enable S/G display for recent APUs
> > by default rather than white list.
> >
> > Signed-off-by: Yifan Zhang
> > ---
> >
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
> A policy binary is OS agnostic, and the same policies are expected to work
> across the OSes. At times it becomes difficult to debug when the policies
> inside the policy binaries starts to misbehave. Add a way to sideload such
> policies
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
> P3T (Peak Package Power Limit) is a metric within the SMU controller
> that can influence the power limits. Add support from the driver
> to update P3T limits accordingly.
>
> Reviewed-by: Mario Limonciello
> Signed-off-by: Shyam Sundar S K
> ---
"ret" was checked earlier inside the loop, so we know it is zero here.
No need to check a second time.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
> PMF driver based on the output actions from the TA can request to update
> the system states like entering s0i3, lock screen etc. by generating
> an uevent. Based on the udev rules set in the userspace the event id
> matching the uevent shall get
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
> PMF driver sends constant inputs to TA which its gets via the other
> subsystems in the kernel. To debug certain TA issues knowing what inputs
> being sent to TA becomes critical. Add debug facility to the driver which
> can isolate Smart PC and TA
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
> PMF Policy binary is a encrypted and signed binary that will be part
> of the BIOS. PMF driver via the ACPI interface checks the existence
> of Smart PC bit. If the advertised bit is found, PMF driver walks
> the acpi namespace to find out the policy
[AMD Official Use Only - General]
Series is Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Tao Zhou
Sent: Wednesday, September 27, 2023 18:20
To: amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao
Subject: [PATCH 2/2] drm/amdgpu: update retry times
Am 27.09.23 um 07:41 schrieb Yifan Zhang:
With S/G display becomes stable, enable S/G display for recent APUs
by default rather than white list.
Signed-off-by: Yifan Zhang
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 43 +--
1 file changed, 10 insertions(+), 33
[AMD Official Use Only - General]
Ping on this patch. Please help review.
Thanks,
Victor
-Original Message-
From: Victor Zhao
Sent: Tuesday, September 26, 2023 11:09 AM
To: amd-gfx@lists.freedesktop.org
Cc: Zhao, Victor
Subject: [PATCH] drm/amd/pm: Disallow managing power profiles on
No need to perform the full reset operation in case of gpu reset
failure.
Signed-off-by: Tao Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
Increase the retry loops and replace the constant number with macro.
Signed-off-by: Tao Zhou
---
drivers/gpu/drm/amd/amdgpu/psp_v13_0.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v13_0.c
b/drivers/gpu/drm/amd/amdgpu/psp_v13_0.c
index
On 2023-09-26 01:56, Cong Liu wrote:
This patch fixes a null pointer dereference in the error message that is
printed when the Display Core (DC) fails to initialize. The original
message includes the DC version number, which is undefined if the DC is
not initialized.
Fixes: 9788d087caff
61 matches
Mail list logo
