Re: ATPX changes in drm-next-4.8 and D3cold handling

2016-07-28 Thread Lukas Wunner
On Thu, Jul 28, 2016 at 03:33:25PM +, Deucher, Alexander wrote: > > From: Peter Wu [mailto:pe...@lekensteyn.nl] > > Sent: Thursday, July 21, 2016 6:43 AM > > In case you missed it, Dave's D3cold patches were succeeded by changes > > in PCI core. Relevant commits in the pci/pm branch: > > > >

[PATCH 0/5] Thunderbolt GPU fixes

2017-02-24 Thread Lukas Wunner
11 PCI pull for some reason: http://www.spinics.net/lists/linux-pci/msg58123.html I've pushed the present series to GitHub in case anyone prefers reviewing it in a GUI: https://github.com/l1k/linux/commits/thunderbolt_gpu_v1 Thanks, Lukas Lukas Wunner (5): PCI: Recognize Thunderbolt devices

[PATCH 1/5] PCI: Recognize Thunderbolt devices

2017-02-24 Thread Lukas Wunner
...@intel.com> Signed-off-by: Lukas Wunner <lu...@wunner.de> --- drivers/pci/pci.h | 2 ++ drivers/pci/probe.c | 21 + include/linux/pci.h | 23 +++ 3 files changed, 46 insertions(+) diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index cb1

[PATCH 4/5] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo

2017-02-24 Thread Lukas Wunner
. Cc: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Lukas Wunner <lu...@wunner.de> --- drivers/gpu/drm/radeon/radeon_device.c | 7 +-- drivers/gpu/drm/radeon/radeon_kms.c| 3 ++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon

[PATCH 5/5] drm/amdgpu: Don't register Thunderbolt eGPU with vga_switcheroo

2017-02-24 Thread Lukas Wunner
. Cc: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Lukas Wunner <lu...@wunner.de> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c| 3 ++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/dr

Re: [PATCH] drm/amdgpu: disable CRTCs before teardown

2016-09-26 Thread Lukas Wunner
On Sun, Sep 25, 2016 at 11:34:48PM +0300, Grazvydas Ignotas wrote: > Some code called by drm_crtc_force_disable_all() wants to wait for all > fences, so only do fence teardown after CRTCs are disabled. > > Signed-off-by: Grazvydas Ignotas Fixes: 84b89bdcedf8 ("drm/amdgpu:

Re: [PATCH] drm/amdgpu: disable CRTCs before teardown

2016-09-26 Thread Lukas Wunner
On Sun, Sep 25, 2016 at 11:34:48PM +0300, Grazvydas Ignotas wrote: > Some code called by drm_crtc_force_disable_all() wants to wait for all > fences, so only do fence teardown after CRTCs are disabled. Ugh, how embarrassing, that was added by me. Do you have a BUG splat (e.g. soft lockup) for

Re: [pull] radeon and amdgpu drm-next-4.9

2016-09-16 Thread Lukas Wunner
On Fri, Sep 16, 2016 at 04:42:43PM -0400, Alex Deucher wrote: > drm/amdgpu: skip suspend/resume on DRM_SWITCH_POWER_DYNAMIC_OFF > drm/radeon: skip suspend/resume on DRM_SWITCH_POWER_DYNAMIC_OFF Those two are unnecessary, it can't happen that the ->suspend hook is executed with the

Re: [pull] radeon and amdgpu drm-next-4.9

2016-09-18 Thread Lukas Wunner
On Fri, Sep 16, 2016 at 06:07:36PM -0400, Alex Deucher wrote: > On Fri, Sep 16, 2016 at 5:38 PM, Lukas Wunner <lu...@wunner.de> wrote: > > On Fri, Sep 16, 2016 at 04:42:43PM -0400, Alex Deucher wrote: > >> drm/amdgpu: skip suspend/resume on DRM_SWITCH_POWER_DYNAMIC_O

Re: [RFC] Using DC in amdgpu for upcoming GPU

2016-12-13 Thread Lukas Wunner
On Tue, Dec 13, 2016 at 10:03:58AM -0500, Cheng, Tony wrote: > On 12/13/2016 4:40 AM, Lukas Wunner wrote: > > If the Linux community contributes to DC, I guess those contributions > > can generally be assumed to be GPLv2 licensed. Yet a future version > > of the macOS dri

Re: [PATCH 0/5] Thunderbolt GPU fixes

2017-03-10 Thread Lukas Wunner
On Thu, Mar 09, 2017 at 04:03:47PM +0100, Daniel Vetter wrote: > On Fri, Feb 24, 2017 at 08:19:45PM +0100, Lukas Wunner wrote: > > Fix Thunderbolt-related issues in apple-gmux and vga_switcheroo: > > > > Patch [1/5] ("Recognize Thunderbolt devices") has already been

Re: [PATCH 4/5] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo

2017-03-08 Thread Lukas Wunner
On Wed, Mar 08, 2017 at 11:46:33AM +0100, Peter Wu wrote: > On Wed, Mar 08, 2017 at 06:01:54AM +0100, Lukas Wunner wrote: > > On Tue, Mar 07, 2017 at 03:30:30PM -0500, Alex Deucher wrote: > > > On Fri, Feb 24, 2017 at 2:19 PM, Lukas Wunner <lu...@wunner.de> wrote: > &g

Re: [PATCH 4/5] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo

2017-03-07 Thread Lukas Wunner
On Tue, Mar 07, 2017 at 03:30:30PM -0500, Alex Deucher wrote: > On Fri, Feb 24, 2017 at 2:19 PM, Lukas Wunner <lu...@wunner.de> wrote: > > An external Thunderbolt GPU can neither drive the laptop's panel nor be > > powered off by the platform, so there's no

Re: iMac 10,1 with Ubuntu 16.04: black screen after suspend

2017-07-17 Thread Lukas Wunner
On Fri, Jun 02, 2017 at 06:47:07PM +0200, Florian Echtler wrote: > Regarding the SMC, there's actually only one key that consistently seems to > have > a different value whether the display is on or off: > > --- blank 2017-05-05 08:40:53.694565045 +0200 > +++ non_blank 2017-05-05

Re: iMac 10,1 with Ubuntu 16.04: black screen after suspend

2017-07-25 Thread Lukas Wunner
On Tue, Jul 25, 2017 at 07:14:23AM +0200, Mario Kleiner wrote: > On 07/24/2017 03:45 PM, Florian Echtler wrote: > > thanks for the hint. I've applied this patch to the v4.12 tree I'm > > currently running, and it didn't seem to make any difference (i.e. > > display stays black after suspend). > >

Re: [REGRESSION] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo

2017-05-18 Thread Lukas Wunner
On Wed, May 17, 2017 at 11:08:23PM +0200, Nicolai Stange wrote: > I'm experiencing a boot failure on next-20170515: > > BUG: unable to handle kernel NULL pointer dereference at 07cb > IP: radeon_driver_load_kms+0xeb/0x230 [radeon] [snip] > Bisection lead to commit 7ffb0ce31cf9

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-22 Thread Lukas Wunner
On Tue, May 23, 2017 at 12:09:49PM +0900, Michel Dänzer wrote: > On 22/05/17 11:04 PM, Lukas Wunner wrote: > > On Sun, May 21, 2017 at 09:31:09AM +0200, Nicolai Stange wrote: > >> On Thu, May 18 2017, Lukas Wunner wrote: > > [snip] > >>> Reported-by:

Re: iMac 10,1 with Ubuntu 16.04: black screen after suspend

2017-05-26 Thread Lukas Wunner
[cc += dri-devel, amd-gfx] On Fri, May 26, 2017 at 02:13:29PM +0200, Florian Echtler wrote: > I'm running Ubuntu 16.04.2 on a 27" unibody iMac 10,1 from 2009. However, even > with the most recent HWE stack (kernel 4.8), the display stays black after > suspend. I can ssh into the machine, so

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-22 Thread Lukas Wunner
On Sun, May 21, 2017 at 09:31:09AM +0200, Nicolai Stange wrote: > On Thu, May 18 2017, Lukas Wunner wrote: [snip] > > Reported-by: Nicolai Stange <nicsta...@gmail.com> > > Fixes: 7ffb0ce31cf9 ("drm/radeon: Don't register Thunderbolt eGPU with > > vga_switcheroo&q

[PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-18 Thread Lukas Wunner
xeb/0x230 [radeon] RSP: b96f0147b9d0 CR2: 07cb ---[ end trace 89cc4ba7e569c65c ]--- Reported-by: Nicolai Stange <nicsta...@gmail.com> Fixes: 7ffb0ce31cf9 ("drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo") Signed-off-by: Lukas Wunner <lu...@wunne

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-23 Thread Lukas Wunner
On Mon, May 22, 2017 at 03:35:48PM -0400, Sean Paul wrote: > On Mon, May 22, 2017 at 04:04:07PM +0200, Lukas Wunner wrote: > > On Sun, May 21, 2017 at 09:31:09AM +0200, Nicolai Stange wrote: > > > On Thu, May 18 2017, Lukas Wunner wrote: > > [snip] > > > >

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-23 Thread Lukas Wunner
On Tue, May 23, 2017 at 09:32:38AM +0200, Christian König wrote: > Am 23.05.2017 um 05:55 schrieb Michel Dänzer: > >On 23/05/17 12:50 PM, Lukas Wunner wrote: > >>On Tue, May 23, 2017 at 12:09:49PM +0900, Michel Dänzer wrote: > >>>On 22/05/17 11:04 PM, Lukas Wunner wro

Re: iMac 10,1 with Ubuntu 16.04: black screen after suspend

2017-05-30 Thread Lukas Wunner
On Tue, May 30, 2017 at 11:34:17AM +0200, Florian Echtler wrote: > On 26.05.2017 23:03, Lukas Wunner wrote: > > On Fri, May 26, 2017 at 02:13:29PM +0200, Florian Echtler wrote: > >> I'm running Ubuntu 16.04.2 on a 27" unibody iMac 10,1 from 2009. However, > >> ev

Re: iMac 10,1 with Ubuntu 16.04: black screen after suspend

2017-05-31 Thread Lukas Wunner
On Wed, May 31, 2017 at 10:48:37AM +0200, Florian Echtler wrote: > On 30.05.2017 12:54, Lukas Wunner wrote: > > On Tue, May 30, 2017 at 11:34:17AM +0200, Florian Echtler wrote: > >> On 26.05.2017 23:03, Lukas Wunner wrote: > >>> On Fri, May 26, 2017 at 02:13:29P

[PATCH] drm/amdgpu: Avoid leaking PM domain on driver unbind

2018-01-21 Thread Lukas Wunner
ns. (Note this issue isn't present in radeon. It was introduced when the driver was forked.) Cc: sta...@vger.kernel.org Cc: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Lukas Wunner <lu...@wunner.de> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 in

Re: [V3] vga_switcheroo: set audio client id according to bound GPU id

2018-07-17 Thread Lukas Wunner
switcheroo. > > if the audio client is not the third registration, audio > id will set in vga_switcheroo enable function. if the > audio client is the last registration when vga_switcheroo > _ready() get true, we should get audio client id from bound > GPU directly. > > Signe

Re: [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-16 Thread Lukas Wunner
On Sat, Jul 14, 2018 at 02:15:24PM +0800, jimqu wrote: > ??? 2018/7/13 17:27, Lukas Wunner ??: > >On Fri, Jul 13, 2018 at 04:06:02PM +0800, Jim Qu wrote: > >>On modern laptop, there are more and more platforms > >>have two GPUs, and each of them maybe have audio c

Re: [alsa-devel] [V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-16 Thread Lukas Wunner
On Mon, Jul 16, 2018 at 04:47:11PM +0200, Takashi Iwai wrote: > On Mon, 16 Jul 2018 16:43:42 +0200, > Lukas Wunner wrote: > > > > On Mon, Jul 16, 2018 at 02:06:35PM +0800, Jim Qu wrote: > > > + > > > + list_for_each_entry(client, _priv.clients, list) { > &g

Re: [alsa-devel] [V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-16 Thread Lukas Wunner
On Mon, Jul 16, 2018 at 02:06:35PM +0800, Jim Qu wrote: > + > + list_for_each_entry(client, _priv.clients, list) { > + if (!client_is_audio(client) || client_id(client) != > + VGA_SWITCHEROO_UNKNOWN_ID) Don't you have to check for client_id(client) !=

Re: [PATCH 1/2] ALSA: HDA: use PCI_BASE_CLASS_DISPLAY to cover more display adapters

2018-07-13 Thread Lukas Wunner
On Fri, Jul 13, 2018 at 04:06:01PM +0800, Jim Qu wrote: > Signed-off-by: Jim Qu Empty commit message. Please add an explanation why the change is necessary so folks browsing the git history understand it's motivation. I think here the motivation is that the PCI class is sometimes

Re: [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-13 Thread Lukas Wunner
On Fri, Jul 13, 2018 at 04:06:02PM +0800, Jim Qu wrote: > On modern laptop, there are more and more platforms > have two GPUs, and each of them maybe have audio codec > for HDMP/DP output. For some dGPU which is no output, > audio codec usually is disabled. > > In currect HDA audio driver, it

Re: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-09 Thread Lukas Wunner
On Mon, Jul 09, 2018 at 08:52:33AM +, Qu, Jim wrote: > Now, I found the audio device will auto suspend even if the gpu is active, > and if I plug in a HDMI device it also do not resume back. > > 1. Did you encounter similar issue before? > 2. audio will auto suspend as default at beginning

Re: [alsa-devel] ??????: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-09 Thread Lukas Wunner
On Mon, Jul 09, 2018 at 05:52:49PM +0200, Takashi Iwai wrote: > On Mon, 09 Jul 2018 17:47:34 +0200, Lukas Wunner wrote: > > Since v4.17, every time the GPU is powered up, the HDA controller is > > runtime resumed to PCI_D0. (See the call to pci_wakeup_bus() in > > vga_swit

Re: [alsa-devel] ??????: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-09 Thread Lukas Wunner
On Mon, Jul 09, 2018 at 05:04:22PM +0200, Takashi Iwai wrote: > On Mon, 09 Jul 2018 15:58:51 +0200, Alex Deucher wrote: > > On Mon, Jul 9, 2018 at 6:16 AM, Qu, Jim wrote: > > > > You're saying above that the HDA controller isn't runtime resumed on > > > > hotplug of a display. Is that necessary

Re: [PATCH] drm/amdgpu: Avoid leaking PM domain on driver unbind

2018-01-23 Thread Lukas Wunner
On Mon, Jan 22, 2018 at 11:22:58PM -0500, Alex Deucher wrote: > On Sun, Jan 21, 2018 at 7:46 AM, Lukas Wunner <lu...@wunner.de> wrote: > > amdgpu_device_init() calls vga_switcheroo_init_domain_pm_ops() either > > if the device has the PowerXpress flag set or if the user h

Re: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-06-29 Thread Lukas Wunner
> On Thu, Jun 28, 2018 at 2:22 AM, Jim Qu wrote: > > On modern laptop, there are more and more platforms > > have two GPUs, and each of them maybe have audio codec > > for HDMP/DP output. For some dGPU which is no output, > > audio codec usually is disabled. > > > > In currect HDA audio driver,

Re: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-06-29 Thread Lukas Wunner
On Fri, Jun 29, 2018 at 08:55:40AM +, Qu, Jim wrote: > When our dGPU does suspend by runtime pm. amdgpu driver for dgpu will > also call vgaswtichroo to power off its audio. vgaswitchroo driver will > find audio codec by vgaswitchroo dgpu client id(VGA_SWITCHEROO_DIS). That is no longer the

Re: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-06-29 Thread Lukas Wunner
On Fri, Jun 29, 2018 at 10:40:50AM +, Qu, Jim wrote: > > That is no longer the case since v4.17. The HDA controller now runtime > > suspends autonomously, see commit 07f4f97d7b4b ("vga_switcheroo: Use > > device link for HDA controller"). > > > > Your patch appears to be geared towards an

Re: [PATCH] gpu: drm: radeon: Set DPM_FLAG_NEVER_SKIP when enabling PM-runtime

2019-02-16 Thread Lukas Wunner
On Fri, Feb 15, 2019 at 11:01:04AM -0500, Alex Deucher wrote: > On Fri, Feb 15, 2019 at 10:39 AM Rafael J. Wysocki wrote: > > On HP ProBook 4540s, if PM-runtime is enabled in the radeon driver > > and the direct-complete optimization is used for the radeon device > > during system-wide suspend,

Re: [PATCH 08/19] drm/amdgpu: rename amdgpu_device_is_px to amdgpu_device_supports_boco

2019-10-12 Thread Lukas Wunner
On Thu, Oct 10, 2019 at 08:45:25PM -0500, Alex Deucher wrote: > To better match what we are checking for and to align with > amdgpu_device_supports_baco. > > BACO - Bus Active, Chip Off > BOCO - Bus Off, Chip Off It would be useful to spell out BACO in the preceding patches as well. > - *

Re: [PATCH 02/19] drm/amdgpu: add supports_baco callback for soc15 asics.

2019-10-12 Thread Lukas Wunner
On Thu, Oct 10, 2019 at 08:45:19PM -0500, Alex Deucher wrote: > Check the BACO capabilities from the powerplay table. > > Signed-off-by: Alex Deucher [...] > @@ -997,6 +1020,7 @@ static const struct amdgpu_asic_funcs vega20_asic_funcs = > .read_bios_from_rom = _read_bios_from_rom, >

Re: [PATCH 09/19] drm/amdgpu: add additional boco checks to runtime suspend/resume

2019-10-12 Thread Lukas Wunner
On Thu, Oct 10, 2019 at 08:45:26PM -0500, Alex Deucher wrote: > + if (amdgpu_device_supports_boco(drm_dev)) > + drm_dev->switch_power_state = DRM_SWITCH_POWER_CHANGING; > > + if (amdgpu_device_supports_boco(drm_dev)) { > + if (amdgpu_is_atpx_hybrid() || > +

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

2020-05-02 Thread Lukas Wunner
On Sat, May 02, 2020 at 09:11:58AM +0200, Takashi Iwai wrote: > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -673,6 +673,12 @@ static int amdgpu_dm_audio_component_bind(struct device > *kdev, > struct amdgpu_device

Re: [PATCH 0/6] RFC Support hot device unplug in amdgpu

2020-05-11 Thread Lukas Wunner
On Mon, May 11, 2020 at 11:54:33AM +0200, Daniel Vetter wrote: > - One unfortunate thing with drm_dev_unplug is that the driver core is > very opinionated and doesn't tell you whether it's a hotunplug or a > driver unload. In the former case trying to shut down hw just wastes > time (and

Re: [PATCH 0/6] RFC Support hot device unplug in amdgpu

2020-05-11 Thread Lukas Wunner
On Mon, May 11, 2020 at 02:21:57PM +0200, Daniel Vetter wrote: > On Mon, May 11, 2020 at 1:43 PM Lukas Wunner wrote: > > On Mon, May 11, 2020 at 11:54:33AM +0200, Daniel Vetter wrote: > > > - One unfortunate thing with drm_dev_unplug is that the driver core is > > > v

[PATCH] PCI/ACPI: Whitelist hotplug ports for D3 if power managed by ACPI

2020-10-01 Thread Lukas Wunner
rg/drm/amd/-/issues/1252 Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1304 Reported-and-tested-by: Arthur Borsboom Reported-and-tested-by: matoro Reported-by: Aaron Zakhrov Reported-by: Michal Rostecki Reported-by: Shai Coleman Signed-off-by: Lukas Wunner Cc: sta...@vger.kernel.org Cc: Al

Re: [Nouveau] [PATCH 1/4] drm: retrieve EDID via ACPI _DDC method

2020-08-08 Thread Lukas Wunner
On Mon, Jul 27, 2020 at 03:53:54PM -0500, Daniel Dadap wrote: > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -34,6 +34,7 @@ > #include > #include > #include > +#include Nit: Alphabetic ordering. > +static u64 *get_dod_entries(acpi_handle handle, int *count) >

Re: [PATCH v2 3/9] PCI: drop `is_thunderbolt` attribute

2022-02-13 Thread Lukas Wunner
On Fri, Feb 11, 2022 at 12:23:51PM +0200, Mika Westerberg wrote: > On Thu, Feb 10, 2022 at 04:43:23PM -0600, Mario Limonciello wrote: > > @@ -2955,7 +2955,7 @@ bool pci_bridge_d3_possible(struct pci_dev *bridge) > > return true; > > > > /* Even the oldest 2010

Re: [PATCH v3 03/12] PCI: Move check for old Apple Thunderbolt controllers into a quirk

2022-02-13 Thread Lukas Wunner
On Fri, Feb 11, 2022 at 01:32:41PM -0600, Mario Limonciello wrote: > `pci_bridge_d3_possible` currently checks explicitly for a Thunderbolt > controller to indicate that D3 is possible. As this is used solely > for older Apple systems, move it into a quirk that enumerates across > all Intel TBT

Re: [PATCH v3 03/12] PCI: Move check for old Apple Thunderbolt controllers into a quirk

2022-02-13 Thread Lukas Wunner
On Sun, Feb 13, 2022 at 10:19:20AM +0100, Lukas Wunner wrote: > Apple had been using its own scheme to put Thunderbolt controllers > into D3cold when nothing is plugged in, about a decade before Microsoft > defined the ACPI property. I meant to say "half a decade", sorry.

Re: [PATCH v3 04/12] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-13 Thread Lukas Wunner
On Fri, Feb 11, 2022 at 01:32:42PM -0600, Mario Limonciello wrote: > The `is_thunderbolt` attribute is currently a dumping ground for a > variety of things. It's not as arbitrary as it may seem. Quite a bit of thought went into the current design. > Instead use the driver core removable

Re: [PATCH v4 00/10] Overhaul `is_thunderbolt`

2022-02-14 Thread Lukas Wunner
On Mon, Feb 14, 2022 at 06:01:50PM -0600, Mario Limonciello wrote: > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- > drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 2 +- > drivers/gpu/drm/nouveau/nouveau_vga.c | 4 +- > drivers/gpu/drm/radeon/radeon_device.c | 4 +- >

Re: [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-28 Thread Lukas Wunner
On Mon, Feb 28, 2022 at 04:13:44PM -0600, Bjorn Helgaas wrote: > On Mon, Feb 28, 2022 at 03:33:13PM +, Limonciello, Mario wrote: > > > On Fri, Feb 25, 2022 at 11:42:24AM -0600, Bjorn Helgaas wrote: > > > > That would just leave the "PCI_VSEC_ID_INTEL_TBT implies external- > > > facing" > > > >

Re: [PATCH v3 05/12] PCI: Detect root port of internal USB4 devices by `usb4-host-interface`

2022-02-14 Thread Lukas Wunner
On Mon, Feb 14, 2022 at 09:34:26AM +0200, Mika Westerberg wrote: > On Fri, Feb 11, 2022 at 03:45:46PM -0600, Bjorn Helgaas wrote: > > My expectation is that "USB" (like "PCI" and "PCIe") tells me > > something about how a device is electrically connected and how > > software can operate it. It

Re: [PATCH v2 6/9] PCI: Rename is_thunderbolt to is_tunneled

2023-11-05 Thread Lukas Wunner
On Fri, Nov 03, 2023 at 02:07:55PM -0500, Mario Limonciello wrote: > The `is_thunderbolt` bit has been used to indicate that a PCIe device > contained the Intel VSEC which is used by various parts of the kernel > to change behavior. To later allow usage with USB4 controllers as well, > rename this

Re: [PATCH v2 6/9] PCI: Rename is_thunderbolt to is_tunneled

2023-11-06 Thread Lukas Wunner
On Mon, Nov 06, 2023 at 10:59:13AM -0600, Mario Limonciello wrote: > On 11/5/2023 11:39, Lukas Wunner wrote: > > On Fri, Nov 03, 2023 at 02:07:55PM -0500, Mario Limonciello wrote: > > > The `is_thunderbolt` bit has been used to indicate that a PCIe device > > > con

Re: [PATCH v2 8/9] PCI: Exclude PCIe ports used for tunneling in pcie_bandwidth_available()

2023-11-06 Thread Lukas Wunner
On Fri, Nov 03, 2023 at 02:07:57PM -0500, Mario Limonciello wrote: > The USB4 spec specifies that PCIe ports that are used for tunneling > PCIe traffic over USB4 fabric will be hardcoded to advertise 2.5GT/s and > behave as a PCIe Gen1 device. The actual performance of these ports is > controlled

Re: [PATCH v2 8/9] PCI: Exclude PCIe ports used for tunneling in pcie_bandwidth_available()

2023-11-06 Thread Lukas Wunner
On Mon, Nov 06, 2023 at 12:44:25PM -0600, Mario Limonciello wrote: > Tangentially related; the link speed is currently symmetric but there are > two sysfs files. Mika left a comment in drivers/thunderbolt/switch.c it may > be asymmetric in the future. So we may need to keep that in mind on any >

Re: [PATCH v2 3/3] drm: Call vga_switcheroo_process_delayed_switch() in drm_lastclose

2023-01-17 Thread Lukas Wunner
On Thu, Jan 12, 2023 at 09:11:56PM +0100, Thomas Zimmermann wrote: > Several lastclose helpers call vga_switcheroo_process_delayed_switch(). > It's better to call the helper from drm_lastclose() after the kernel > client's screen has been restored. This way, all drivers can benefit > without