RE: [PATCH] drm/amdkfd: add sdma poison consumption handling

2021-06-04 Thread Li, Dennis
[AMD Official Use Only] This patch looks good to me. Reviewed-by: Dennis Li -Original Message- From: Zhang, Hawking Sent: Friday, June 4, 2021 12:58 PM To: amd-gfx@lists.freedesktop.org; Li, Dennis ; Deucher, Alexander ; Kuehling, Felix Cc: Zhang, Hawking Subject: [PATCH] drm

RE: [PATCH 6/7] drm/amdgpu: enable ras error count query and reset for HDP

2021-04-29 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] This patch looks good to me. Reviewed-by: Dennis Li -Original Message- From: Hawking Zhang Sent: Thursday, April 29, 2021 2:26 PM To: Deucher, Alexander ; Li, Dennis ; Clements, John ; amd-gfx@lists.freedesktop.org Cc: Zhang

RE: [PATCH 7/7] drm/amdgpu: retired reset_ras_error_count from hdp callbacks

2021-04-29 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] This patch looks good to me. Reviewed-by: Dennis Li -Original Message- From: Hawking Zhang Sent: Thursday, April 29, 2021 2:26 PM To: Deucher, Alexander ; Li, Dennis ; Clements, John ; amd-gfx@lists.freedesktop.org Cc: Zhang

RE: [PATCH 5/7] drm/amdgpu: init/fini hdp v4_0 ras

2021-04-29 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] This patch looks good to me. Reviewed-by: Dennis Li -Original Message- From: Hawking Zhang Sent: Thursday, April 29, 2021 2:26 PM To: Deucher, Alexander ; Li, Dennis ; Clements, John ; amd-gfx@lists.freedesktop.org Cc: Zhang

RE: [PATCH 4/7] drm/amdgpu: initialize hdp v4_0 ras functions

2021-04-29 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] This patch looks good to me. Reviewed-by: Dennis Li -Original Message- From: Hawking Zhang Sent: Thursday, April 29, 2021 2:26 PM To: Deucher, Alexander ; Li, Dennis ; Clements, John ; amd-gfx@lists.freedesktop.org Cc: Zhang

RE: [PATCH 3/7] drm/amdgpu: implement hdp v4_0 ras functions

2021-04-29 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] This patch looks good to me. Reviewed-by: Dennis Li -Original Message- From: Hawking Zhang Sent: Thursday, April 29, 2021 2:26 PM To: Deucher, Alexander ; Li, Dennis ; Clements, John ; amd-gfx@lists.freedesktop.org Cc: Zhang

RE: [PATCH 2/7] drm/amdgpu: add helpers for hdp ras init/fini

2021-04-29 Thread Li, Dennis
m: Hawking Zhang Sent: Thursday, April 29, 2021 2:26 PM To: Deucher, Alexander ; Li, Dennis ; Clements, John ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: [PATCH 2/7] drm/amdgpu: add helpers for hdp ras init/fini hdp ras init/fini are common functions that can be shared

RE: [PATCH] drm/amdgpu: disable gfx ras by default in aldebaran

2021-04-22 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Looks good to me. Reviewed-by: Dennis Li Best Regards Dennis Li -Original Message- From: Hawking Zhang Sent: Thursday, April 22, 2021 10:06 PM To: amd-gfx@lists.freedesktop.org; Li, Dennis Cc: Zhang, Hawking Subject: [PATCH] drm

RE: [PATCH] drm/amdgpu: correct default gfx wdt timeout setting

2021-04-16 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Dennis Li -Original Message- From: Zhang, Hawking Sent: Friday, April 16, 2021 2:46 PM To: amd-gfx@lists.freedesktop.org; Li, Dennis Cc: Zhang, Hawking Subject: [PATCH] drm/amdgpu: correct default gfx wdt timeout

RE: [PATCH 0/4] Refine GPU recovery sequence to enhance its stability

2021-04-13 Thread Li, Dennis
tian König Sent: Tuesday, April 13, 2021 3:10 PM To: Grodzovsky, Andrey ; Koenig, Christian ; Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Kuehling, Felix ; Zhang, Hawking ; Daniel Vetter Subject: Re: [PATCH 0/4] Refine GPU recovery sequence to enhance its stability Am 12.04.2

RE: [PATCH Review 1/1] drm/amdgpu: support sdma error injection

2021-04-01 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Reivewed-by: Dennis Li -Original Message- From: Stanley.Yang Sent: Thursday, April 1, 2021 7:14 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Clements, John ; Li, Dennis ; Yang, Stanley Subject: [PATCH Review 1/1] drm

RE: [PATCH 1/2] drm/amd/pm: drop redundant and unneeded BACO APIs

2021-03-19 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Hi, Evan, It is better to replace all nv_asic_supports_baco callings with amdgpu_dpm_is_baco_supported, and remove nv_asic_supports_baco function. >>> static bool nv_asic_supports_baco(struct amdgpu_device *adev) { >>> - struct

RE: [PATCH] drm/amdgpu: Fix the page fault issue in amdgpu_irq_fini

2021-03-19 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Hi, Emily, What about refine struct amdgpu_irq_src with refcount? Your change could fix this issue, but it is unreadable. Best Regards Dennis Li -Original Message- From: amd-gfx On Behalf Of Deng, Emily Sent: Friday, March 19,

RE: [PATCH 0/4] Refine GPU recovery sequence to enhance its stability

2021-03-18 Thread Li, Dennis
tter method to solve this problem. Do you have some suggestion? Best Regards Dennis Li From: Koenig, Christian Sent: Thursday, March 18, 2021 4:59 PM To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Kuehling, Felix ; Zhang, Hawking Subject: AW: [PATCH 0/4] Refine GPU recovery s

RE: [PATCH 0/4] Refine GPU recovery sequence to enhance its stability

2021-03-18 Thread Li, Dennis
mple, the user thread hold the read lock and waiting for the fence, if recovery thread try to hold write lock and then complete fences, in this case, recovery thread will always be blocked. Best Regards Dennis Li -Original Message- From: Koenig, Christian Sent: Thursday, March 18, 2021 3

RE: [PATCH] drm/amdgpu: capture invalid hardware access v2

2021-03-10 Thread Li, Dennis
--Original Message- From: Christian König Sent: Wednesday, March 10, 2021 9:03 PM To: Li, Dennis ; Grodzovsky, Andrey ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: capture invalid hardware access v2 > I assumed that pre-reset functions could complete all fences And exactly that

RE: [PATCH] drm/amdgpu: capture invalid hardware access v2

2021-03-09 Thread Li, Dennis
R will be blocked until all read locks are released. Best Regards Dennis Li -Original Message- From: Grodzovsky, Andrey Sent: Wednesday, March 10, 2021 1:42 PM To: Li, Dennis ; Christian König ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: capture invalid hardware access

RE: [PATCH] drm/amdgpu: capture invalid hardware access v2

2021-03-09 Thread Li, Dennis
To: Li, Dennis ; amd-gfx@lists.freedesktop.org Cc: Grodzovsky, Andrey Subject: Re: [PATCH] drm/amdgpu: capture invalid hardware access v2 Hi Dennis, why do you think that this will always assert in reset thread? In the reset thread while we are holding the reset lock write side

RE: [PATCH] drm/amdgpu: capture invalid hardware access v2

2021-03-09 Thread Li, Dennis
l Message- From: Grodzovsky, Andrey Sent: Wednesday, March 10, 2021 2:26 AM To: Christian König ; Li, Dennis ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: capture invalid hardware access v2 On 2021-03-09 12:47 p.m., Christian König wrote: > No it won't. Accessing t

RE: [PATCH] drm/amdgpu: capture invalid hardware access v2

2021-03-08 Thread Li, Dennis
@lists.freedesktop.org Cc: Grodzovsky, Andrey ; Li, Dennis Subject: [PATCH] drm/amdgpu: capture invalid hardware access v2 From: Dennis Li When recovery thread has begun GPU reset, there should be not other threads to access hardware, otherwise system randomly hang. v2 (chk): rewritten from

RE: [PATCH] drm/amdgpu: remove unnecessary reading for epprom header

2021-02-25 Thread Li, Dennis
Hi, Hawking, Agree with your suggestion, and it could further simplify our codes. I will refactor them again. Best Regards Dennis Li -Original Message- From: Zhang, Hawking Sent: Friday, February 26, 2021 12:30 PM To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Chen, Guchun

RE: [PATCH] drm/amdgpu: protect eeprom update from GPU reset

2020-10-14 Thread Li, Dennis
[AMD Public Use] Hi, Hawking, Driver has multi-path into GPU reset, so driver couldn't guarantee that bad record update has been done before GPU reset. Best Regards Dennis Li -Original Message- From: Zhang, Hawking Sent: Wednesday, October 14, 2020 5:52 PM To: Li, Dennis ; amd

RE: [PATCH] drm/amdgpu: clean up ras sysfs creation (v2)

2020-09-24 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Dennis Li -Original Message- From: Chen, Guchun Sent: Thursday, September 24, 2020 10:52 PM To: amd-gfx@lists.freedesktop.org; Koenig, Christian ; Zhang, Hawking ; Li, Dennis ; Zhou1, Tao ; Clements, John ; Deucher

RE: [PATCH v4 1/8] drm/amdgpu: Avoid accessing HW when suspending SW state

2020-09-02 Thread Li, Dennis
est Regards Dennis Li -Original Message- From: Andrey Grodzovsky Sent: Thursday, September 3, 2020 2:42 AM To: amd-gfx@lists.freedesktop.org; sathyanarayanan.kuppusw...@linux.intel.com; linux-...@vger.kernel.org Cc: Deucher, Alexander ; Das, Nirmoy ; Li, Dennis ; Koenig, Christian ; Tuikov, Lu

RE: [PATCH] drm/kfd: fix a system crash issue during GPU recovery

2020-09-02 Thread Li, Dennis
u. Best Regards Dennis Li -Original Message- From: Kuehling, Felix Sent: Wednesday, September 2, 2020 11:26 AM To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Hawking ; Koenig, Christian Subject: Re: [PATCH] drm/kfd: fix a system crash issue during GPU recov

RE: [PATCH] drm/kfd: fix a system crash issue during GPU recovery

2020-09-01 Thread Li, Dennis
this queue object has been added in to qpd->queues_list in the old code. Best Regards Dennis Li -Original Message- From: Kuehling, Felix Sent: Tuesday, September 1, 2020 9:26 PM To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Hawking ; Koenig, Christ

RE: [PATCH] drm/amdgpu: block ring buffer access during GPU recovery

2020-08-31 Thread Li, Dennis
1, 2020 9:40 AM To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Kuehling, Felix ; Zhang, Hawking ; Koenig, Christian Subject: Re: [PATCH] drm/amdgpu: block ring buffer access during GPU recovery On 8/31/20 9:17 PM, Dennis Li wrote: > When GPU is in reset, its status

RE: [PATCH 1/7] drm/amdgpu: Implement DPC recovery

2020-08-26 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Hi, Andrey, I found that the sequences of amdgpu_pci_slot_reset is mostly similar to amdgpu_do_asic_reset. Could help us refactor them to reuse more codes? Best Regards Dennis Li -Original Message- From: amd-gfx On Behalf Of

RE: [PATCH] drm/amdgpu: correct SE number for arcturus gfx ras

2020-08-26 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Dennis Li -Original Message- From: Chen, Guchun Sent: Wednesday, August 26, 2020 3:53 PM To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Li, Dennis ; Zhou1, Tao Cc: Chen, Guchun Subject: [PATCH] drm/amdgpu

RE: [PATCH v2] drm/amdgpu: change reset lock from mutex to rw_semaphore

2020-08-20 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] [AMD Official Use Only - Internal Distribution Only] Hi, Monk, Got it, thanks for your explanation. Best Regards Dennis Li -Original Message- From: Liu, Monk Sent: Friday, August 21, 2020 11:14 AM To: Li, Dennis ; amd-gfx

RE: [PATCH] drm/amd/display: remove unintended executable mode

2020-08-20 Thread Li, Dennis
, August 19, 2020 4:18 PM To: Deucher, Alexander ; Koenig, Christian ; Li, Dennis ; Zuo, Jerry Cc: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; linux-ker...@vger.kernel.org; Chen, Guchun ; Wu, Hersen ; Lukas Bulwahn Subject: [PATCH] drm/amd/display: remove unintended

RE: [PATCH v2] drm/amdgpu: change reset lock from mutex to rw_semaphore

2020-08-20 Thread Li, Dennis
: Thursday, August 20, 2020 5:33 PM To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Kuehling, Felix ; Zhang, Hawking ; Koenig, Christian Cc: Li, Dennis Subject: [PATCH v2] drm/amdgpu: change reset lock from mutex to rw_semaphore clients don't need reset-lock for synchronization when

RE: [PATCH v2] drm/amdgpu: change reset lock from mutex to rw_semaphore

2020-08-20 Thread Li, Dennis
@lists.freedesktop.org; Deucher, Alexander ; Kuehling, Felix ; Zhang, Hawking ; Koenig, Christian Cc: Li, Dennis Subject: [PATCH v2] drm/amdgpu: change reset lock from mutex to rw_semaphore clients don't need reset-lock for synchronization when no GPU recovery. v2: change to return the return value

RE: [PATCH] drm/amdgpu: change reset lock from mutex to rw_semaphore

2020-08-20 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Hi, Christian, Thanks for your review. I will update it according to your suggestion. Best Regards Dennis Li -Original Message- From: Christian König Sent: Thursday, August 20, 2020 5:11 PM To: Li, Dennis ; amd-gfx

RE: [PATCH] drm/amdgpu: fix the nullptr issue when reenter GPU recovery

2020-08-20 Thread Li, Dennis
, August 20, 2020 4:24 PM To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Kuehling, Felix ; Koenig, Christian Cc: Li, Dennis Subject: RE: [PATCH] drm/amdgpu: fix the nullptr issue when reenter GPU recovery [AMD Public Use] Hi Dennis, Can you elaborate the case that driver re

RE: [PATCH v2] drm/amdgpu: refine create and release logic of hive info

2020-08-18 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Hi, Christian, Thanks for your review. I will update a new patch according to your suggestion. Best Regards Dennis Li -Original Message- From: Christian König Sent: Tuesday, August 18, 2020 7:50 PM To: Li, Dennis ; amd-gfx

RE: [PATCH] drm/amdgpu: fix amdgpu_bo_release_notify() comment error

2020-08-17 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Dennis Li -Original Message- From: amd-gfx On Behalf Of Kevin Wang Sent: Monday, August 17, 2020 3:36 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Wang, Kevin(Yang) ; Koenig, Christian Subject: [PATCH]

RE: [PATCH] drm/amdgpu: Fix incorrect return value in sysfs for pp_od_clk_voltage

2020-08-13 Thread Li, Dennis
/ return here parameter_size++; while (isspace(*tmp_str)) tmp_str++; } Best Regards Dennis Li -Original Message- From: Matt Coffin Sent: Friday, August 14, 2020 9:15 AM To: amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; Li, Dennis ; Matt Co

RE: [PATCH] drm/amdgpu: guard ras debugfs creation/removal based on CONFIG_DEBUG_FS

2020-08-13 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Dennis Li -Original Message- From: Chen, Guchun Sent: Thursday, August 13, 2020 3:04 PM To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Li, Dennis ; Zhou1, Tao ; Clements, John ; Deucher, Alexander Cc: Chen

RE: [PATCH] drm/amdgpu: fix a potential circular locking dependency

2020-08-12 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Am 12.08.20 um 12:02 schrieb Li, Dennis: > [AMD Official Use Only - Internal Distribution Only] > > Am 12.08.20 um 11:23 schrieb Li, Dennis: >> [AMD Official Use Only - Internal Distribution Only] >> >> Am 12.08.20

RE: [PATCH] drm/amdgpu: fix a potential circular locking dependency

2020-08-12 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Am 12.08.20 um 11:23 schrieb Li, Dennis: > [AMD Official Use Only - Internal Distribution Only] > > Am 12.08.20 um 03:33 schrieb Li, Dennis: >> [AMD Official Use Only - Internal Distribution Only] >> >> Hi, Christian

RE: [PATCH] drm/amdgpu: fix a potential circular locking dependency

2020-08-12 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Am 12.08.20 um 03:19 schrieb Li, Dennis: > [AMD Official Use Only - Internal Distribution Only] > > Hi, Felix, > > Re: It may be better to fix it the other way around in > amdgpu_amdkfd_alloc_gtt_mem. Always take th

RE: [PATCH] drm/amdgpu: fix a potential circular locking dependency

2020-08-12 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Am 12.08.20 um 03:33 schrieb Li, Dennis: > [AMD Official Use Only - Internal Distribution Only] > > Hi, Christian, > > Re: I was wondering the same thing for the amdgpu_gem_va_ioctl() as well. We > shouldn't have any hardwa

RE: [PATCH] drm/amdgpu: fix a potential circular locking dependency

2020-08-11 Thread Li, Dennis
, amdgpu_vm_bo_clear_mappings, amdgpu_vm_bo_replace_map and amdgpu_gem_va_update_vm all a chance to access hardware. Best Regards Dennis Li -Original Message- From: Koenig, Christian Sent: Wednesday, August 12, 2020 12:15 AM To: Kuehling, Felix ; Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander

RE: [PATCH] drm/amdgpu: fix a potential circular locking dependency

2020-08-11 Thread Li, Dennis
lock reset_sem at the beginning of entry functions of amdgpu driver. Best Regards Dennis Li -Original Message- From: Kuehling, Felix Sent: Tuesday, August 11, 2020 9:57 PM To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Hawking ; Koenig, Christian Subject

RE: [PATCH v3] drm/amdgpu: annotate a false positive recursive locking

2020-08-11 Thread Li, Dennis
; > > > Regards, > > Guchun > > > > -Original Message- > > From: amd-gfx On Behalf Of > > Christian König > > Sent: Tuesday, August 11, 2020 2:53 PM > > To: Li, Dennis ; amd-gfx@lists.freedesktop.org; > > Deucher, Alexander ; Kueh

RE: [PATCH 2/2] drm/amdgpu: add debugfs node to toggle ras error cnt harvest

2020-08-09 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: DennisLi Best Regards Dennis Li -Original Message- From: Chen, Guchun Sent: Monday, August 10, 2020 1:23 PM To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Li, Dennis ; Lazar, Lijo ; Zhou1, Tao ; Clements, John

RE: [PATCH] drm/amdgpu: annotate a false positive recursive locking

2020-08-07 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] On Fri, Aug 7, 2020 at 5:32 PM Li, Dennis wrote: > > [AMD Public Use] > > On Fri, Aug 7, 2020 at 1:59 PM Li, Dennis wrote: > > > > [AMD Public Use] > > > > Hi, Daniel, > > Thanks your review. A

RE: [PATCH] drm/amdgpu: annotate a false positive recursive locking

2020-08-07 Thread Li, Dennis
[AMD Public Use] On Fri, Aug 7, 2020 at 1:59 PM Li, Dennis wrote: > > [AMD Public Use] > > Hi, Daniel, > Thanks your review. And I also understand your concern. I guess you > missed the description of this issue, so I paste it again in the below, and > explain w

RE: [PATCH] drm/amdgpu: annotate a false positive recursive locking

2020-08-07 Thread Li, Dennis
ompletion)(>recovery_work)){+.+.}, at: process_one_work+0x21f/0x630 [ 584.118358] #2: c1c2a5d0 (>hive_lock){+.+.}, at: amdgpu_device_gpu_recover+0xae/0x1030 [amdgpu] [ 584.118786] #3: 9b1603d247a0 (>reset_sem){}, at: amdgpu_device_gpu_recover+0x262/0x1030 [amdgpu] Best Regards

RE: [PATCH] drm/amdgpu: annotate a false positive recursive locking

2020-08-07 Thread Li, Dennis
ge this patch. How severe is the lockdep splat? At bare minimum we need a "/* TODO: ...." comment why we do this and how to remove the workaround again. [Dennis Li] It is not a workaround. According to design of lockdep, each rw_semaphore should has a separated lock_class_key. I have expla

RE: [PATCH] drm/amdgpu: annotate a false positive recursive locking

2020-08-06 Thread Li, Dennis
ecome a problem as well. I still think that a single rwsem for the whole hive is still the best option here. [Dennis Li] For your above concern, we can open a new thread to discuss it. If we make a decision to use a single after discussing, we can create another patch for it. Best Regards Dennis lI >

RE: [PATCH] drm/amdgpu: annotate a false positive recursive locking

2020-08-06 Thread Li, Dennis
on device B which isn't accessible. [Dennis Li] Yes, you are right. Driver have make sure that the shared resources(such as the shard memory) are ready before unlock the lock of adev one by one. But each device still has private hardware resources such as video and display. Regards, Christ

RE: [PATCH] drm/amdgpu: annotate a false positive recursive locking

2020-08-06 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Hi, Christian, See my below comments. Best Regards Dennis Li -Original Message- From: Koenig, Christian Sent: Thursday, August 6, 2020 5:19 PM To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Kuehling

RE: [PATCH] drm/amdgpu: annotate a false positive recursive locking

2020-08-06 Thread Li, Dennis
Best Regards Dennis Li -Original Message- From: Koenig, Christian Sent: Thursday, August 6, 2020 4:13 PM To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Kuehling, Felix ; Zhang, Hawking Subject: Re: [PATCH] drm/amdgpu: annotate a false positive recursive locking Preven

RE: [PATCH] drm/amdgpu: annotate a false positive recursive locking

2020-08-06 Thread Li, Dennis
performance. Best Regards Dennis Li -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Thursday, August 6, 2020 3:08 PM To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Kuehling, Felix ; Zhang, Hawking Subject: Re: [PATCH] drm/amdgpu: annotate a false

RE: [PATCH 04/12] drm/amdgpu: break driver init process when it's bad GPU

2020-07-28 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Hi, Guchun, Please see my below comments. Best Regards Dennis Li -Original Message- From: Chen, Guchun Sent: Tuesday, July 28, 2020 3:49 PM To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Hawking ; Li, Dennis

RE: [PATCH 1/5] drm/amdgpu: add bad page count threshold in module parameter

2020-07-22 Thread Li, Dennis
, Guchun Sent: Wednesday, July 22, 2020 11:14 AM To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Hawking ; Li, Dennis ; Yang, Stanley ; Zhou1, Tao ; Clements, John Cc: Chen, Guchun Subject: [PATCH 1/5] drm/amdgpu: add bad page count threshold in module parameter

RE: [PATCH 3/5] drm/amd/sriov add mmsch_v3 interface

2020-07-14 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Hi, Jack, Thanks for your expiation. It looks good to me. Best Regards Dennis Li -Original Message- From: Zhang, Jack (Jian) Sent: Tuesday, July 14, 2020 5:01 PM To: Li, Dennis ; Liu, Leo ; Zhang, Hawking ; amd-gfx

RE: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-13 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Hi, Felix, amdgpu_gem_prime_export has different define in the old driver. I added some comment in the below codes. Best Regards Dennis Li -Original Message- From: amd-gfx On Behalf Of Felix Kuehling Sent: Tuesday, July 14,

RE: [PATCH 3/5] drm/amd/sriov add mmsch_v3 interface

2020-07-13 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Hi, Jack, Please see the following comments. Best Regards Dennis Li -Original Message- From: amd-gfx On Behalf Of Jack Zhang Sent: Tuesday, July 14, 2020 10:47 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jack (Jian) ; Liu,

RE: [PATCH 1/3] drm/amd/powerplay: add SMU mode1 reset

2020-07-13 Thread Li, Dennis
[AMD Public Use] Hi, Hawking, Got it. Thanks for your expiation. It looks good to me now. Reviewed-by: Dennis Li Best Regards Dennis Li -Original Message- From: Zhang, Hawking Sent: Monday, July 13, 2020 1:44 PM To: Sheng, Wenhui ; Li, Dennis ; amd-gfx@lists.freedesktop.org Cc

RE: [PATCH 1/3] drm/amd/powerplay: add SMU mode1 reset

2020-07-12 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] -Original Message- From: amd-gfx On Behalf Of Wenhui Sheng Sent: Friday, July 10, 2020 10:17 PM To: amd-gfx@lists.freedesktop.org Cc: Gao, Likun ; Sheng, Wenhui ; Zhang, Hawking Subject: [PATCH 1/3] drm/amd/powerplay: add SMU mode1

RE: [PATCH 06/10] drm/amd/display: fix dcn3 p_state_change_support validation

2020-07-12 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] -Original Message- From: amd-gfx On Behalf Of Rodrigo Siqueira Sent: Saturday, July 11, 2020 4:33 AM To: amd-gfx@lists.freedesktop.org Cc: Laktyushkin, Dmytro ; Brol, Eryk ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing ;

RE: [PATCH v2] drm/amdgpu: fix system hang issue during GPU reset

2020-07-11 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] -Original Message- From: Grodzovsky, Andrey Sent: Friday, July 10, 2020 10:33 PM To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhou1, Tao ; Zhang, Hawking ; Chen, Guchun Subject: Re: [PATCH v2] drm/amdgpu

RE: [PATCH v2] drm/amdgpu: fix system hang issue during GPU reset

2020-07-10 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] -Original Message- From: Grodzovsky, Andrey Sent: Saturday, July 11, 2020 1:54 AM To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhou1, Tao ; Zhang, Hawking ; Chen, Guchun ; Koenig, Christian Subject: Re

RE: [PATCH v2] drm/amdgpu: fix system hang issue during GPU reset

2020-07-10 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Hi, Andrey, Please see my below comments. Best Regards Dennis Li -Original Message- From: Grodzovsky, Andrey Sent: Friday, July 10, 2020 11:08 PM To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhou1, Tao

RE: [PATCH v2] drm/amdgpu: fix system hang issue during GPU reset

2020-07-10 Thread Li, Dennis
essage- From: Paul Menzel Sent: Wednesday, July 8, 2020 7:42 PM To: Li, Dennis Cc: amd-gfx@lists.freedesktop.org; Alex Deucher ; Zhou1, Tao ; Zhang, Hawking ; Chen, Guchun Subject: Re: [PATCH v2] drm/amdgpu: fix system hang issue during GPU reset Dear Dennis, Thank you for you patch. On 2

RE: [PATCH] drm/amdgpu: fix system hang issue during GPU reset

2020-07-06 Thread Li, Dennis
ependency issue in my patch, can you show me the details? The reset_sem is only used in AMDGPU driver, if it is locked and unlocked in pair, it is safe. Best Regards Dennis Li -Original Message- From: Kuehling, Felix Sent: Tuesday, July 7, 2020 9:38 AM To: Li, Dennis ; amd-gfx@lists.freede

RE: [PATCH] drm/amdgpu: fix system hang issue during GPU reset

2020-07-06 Thread Li, Dennis
nal Message- From: Kuehling, Felix Sent: Tuesday, July 7, 2020 5:43 AM To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhou1, Tao ; Zhang, Hawking ; Chen, Guchun Subject: Re: [PATCH] drm/amdgpu: fix system hang issue during GPU reset Am 2020-07-06 um 6:01 a.m. schr

RE: [PATCH] drm/amdgpu: return an error for hw access in INFO ioctl when in reset

2020-07-01 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Hi, Christian and Alex Not only amdgpu ioctls, but amdkfd ioctls also have the same issue. Best Regards Dennis Li -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Wednesday, July 1, 2020 4:20 PM To: Alex

RE: [PATCH] drm/amdgpu: correct ras query as part of ctx query

2020-06-11 Thread Li, Dennis
-Original Message- From: Chen, Guchun Sent: Thursday, June 11, 2020 6:24 PM To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Zhou1, Tao ; Pan, Xinhui ; Li, Dennis ; Clements, John Cc: Chen, Guchun Subject: [PATCH] drm/amdgpu: correct ras query as part of ctx query Almost error

RE: [PATCH] drm/amdgpu: Add autodump debugfs node for gpu reset v4

2020-05-14 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Hi, Jiange, How to handle the case that multi-apps do the auto dump? This patch seems not multi-process safety. Best Regards Dennis Li From: amd-gfx On Behalf Of Christian König Sent: Thursday, May 14, 2020 4:29 PM To: Zhao, Jiange ;

RE: [PATCH] drm/amdgpu: Print CU information by default during initialization

2020-04-17 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Dennis Li -Original Message- From: amd-gfx On Behalf Of Yong Zhao Sent: Saturday, April 18, 2020 5:46 AM To: amd-gfx@lists.freedesktop.org Cc: Zhao, Yong Subject: [PATCH] drm/amdgpu: Print CU information by default

RE: [PATCH] drm/amdgpu: stop disable the scheduler during HW fini

2020-02-28 Thread Li, Dennis
[AMD Public Use] Looks good to me Test-by: Dennis Li mailto:dennis...@amd.com>> Best Regards Dennis Li From: amd-gfx On Behalf Of Deucher, Alexander Sent: Thursday, February 27, 2020 11:18 PM To: Christian König ; Das, Nirmoy ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu:

RE: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

2020-02-20 Thread Li, Dennis
to no ready. And then drm_sched_entity_get_free_sched will return NULL in drm_sched_entity_select_rq, which cause entity->rq to NULL. Best Regards Dennis Li -Original Message- From: Liu, Monk Sent: Wednesday, February 19, 2020 7:30 PM To: Koenig, Christian ; Zhang, Hawking ; Li, Dennis ;

RE: [PATCH 4/4] drm/amdgpu: add RAS support for the gfx block of Arcturus

2020-01-18 Thread Li, Dennis
[AMD Public Use] Hi, Guchun, adev->grbm_idx_mutex is only used to protect the access to registers whose instance switch is indexed by grbm_index. Best Regards Dennis Li -Original Message- From: Chen, Guchun Sent: Sunday, January 19, 2020 11:40 AM To: Li, Dennis ; amd-

RE: [PATCH] drm/amdgpu: attempt to enable gfxoff on more raven1 boards

2020-01-15 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Hi, Alex, it is better to refine the patch as a common function, not only used for raven. Best Regards Dennis Li -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, January 16, 2020 1:32 AM To:

RE: [PATCH 2/4] drm/amd/powerplay: Add EEPROM I2C read/write support to Arcturus.

2019-10-20 Thread Li, Dennis
To make the function behavior more clear, It's better to change the function declaration from + static void arcturus_fill_eeprom_i2c_req(SwI2cRequest_t *req, bool write, + uint8_t address, uint32_t numbytes, + uint8_t *data) to