Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-21 Thread Christian König
Am 21.03.2018 um 19:23 schrieb Marek Olšák: On Wed, Mar 21, 2018 at 2:15 PM, Christian König mailto:christian.koe...@amd.com>> wrote: Am 21.03.2018 um 19:04 schrieb Marek Olšák: On Wed, Mar 21, 2018 at 10:07 AM, Christian König mailto:christian.koe...@amd.com>> wrote: Am 2

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-21 Thread Marek Olšák
On Wed, Mar 21, 2018 at 2:15 PM, Christian König wrote: > Am 21.03.2018 um 19:04 schrieb Marek Olšák: > > On Wed, Mar 21, 2018 at 10:07 AM, Christian König < > christian.koe...@amd.com> wrote: > >> Am 21.03.2018 um 14:57 schrieb Marek Olšák: >> >> On Wed, Mar 21, 2018 at 4:13 AM, Christian König

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-21 Thread Christian König
Am 21.03.2018 um 19:04 schrieb Marek Olšák: On Wed, Mar 21, 2018 at 10:07 AM, Christian König mailto:christian.koe...@amd.com>> wrote: Am 21.03.2018 um 14:57 schrieb Marek Olšák: On Wed, Mar 21, 2018 at 4:13 AM, Christian König mailto:ckoenig.leichtzumer...@gmail.com>> wrote:

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-21 Thread Marek Olšák
On Wed, Mar 21, 2018 at 10:07 AM, Christian König wrote: > Am 21.03.2018 um 14:57 schrieb Marek Olšák: > > On Wed, Mar 21, 2018 at 4:13 AM, Christian König < > ckoenig.leichtzumer...@gmail.com> wrote: > >> Am 21.03.2018 um 06:08 schrieb Marek Olšák: >> >> On Tue, Mar 20, 2018 at 4:16 PM, Christia

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-21 Thread Li, Samuel
Deucher ; Michel Dänzer ; amd-gfx list ; Li, Samuel Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support Am 21.03.2018 um 14:57 schrieb Marek Olšák: On Wed, Mar 21, 2018 at 4:13 AM, Christian König mailto:ckoenig.leichtzumer...@gmail.com>> wrote: Am 21.03.2018 um

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-21 Thread Christian König
Am 21.03.2018 um 14:57 schrieb Marek Olšák: On Wed, Mar 21, 2018 at 4:13 AM, Christian König > wrote: Am 21.03.2018 um 06:08 schrieb Marek Olšák: On Tue, Mar 20, 2018 at 4:16 PM, Christian König mailto:christian.koe...@amd.com>> wrote:

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-21 Thread Marek Olšák
On Wed, Mar 21, 2018 at 4:13 AM, Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Am 21.03.2018 um 06:08 schrieb Marek Olšák: > > On Tue, Mar 20, 2018 at 4:16 PM, Christian König > wrote: > >> That's what I meant with use up the otherwise unused VRAM. I don't see >> any disadvantage o

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-21 Thread Christian König
Am 21.03.2018 um 06:08 schrieb Marek Olšák: On Tue, Mar 20, 2018 at 4:16 PM, Christian König mailto:christian.koe...@amd.com>> wrote: That's what I meant with use up the otherwise unused VRAM. I don't see any disadvantage of always setting GTT as second domain on APUs. My assumptio

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-21 Thread Christian König
pe of this patch. Regards, Samuel Li *From:*Koenig, Christian *Sent:* Tuesday, March 20, 2018 4:17 PM *To:* Deucher, Alexander ; Marek Olšák *Cc:* Alex Deucher ; Michel Dänzer ; Li, Samuel ; amd-gfx list *Subject:* Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support That'

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-20 Thread Marek Olšák
On Tue, Mar 20, 2018 at 4:16 PM, Christian König wrote: > That's what I meant with use up the otherwise unused VRAM. I don't see any > disadvantage of always setting GTT as second domain on APUs. > > My assumption was that we dropped this in userspace for displayable > surfaces, but Marek proved

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-20 Thread Li, Samuel
e point. Alex From: Christian König <mailto:ckoenig.leichtzumer...@gmail.com> Sent: Tuesday, March 20, 2018 2:32:49 PM To: Marek Olšák; Koenig, Christian Cc: Alex Deucher; Deucher, Alexander; Michel Dänzer; Li, Samuel; amd-gfx list Subject: Re: [PATCH 1/2] dr

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-20 Thread Li, Samuel
ucher ; Michel Dänzer ; Li, Samuel ; amd-gfx list Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support That's what I meant with use up the otherwise unused VRAM. I don't see any disadvantage of always setting GTT as second domain on APUs. My assumption was that

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-20 Thread Christian König
Christian König *Sent:* Tuesday, March 20, 2018 2:32:49 PM *To:* Marek Olšák; Koenig, Christian *Cc:* Alex Deucher; Deucher, Alexander; Michel Dänzer; Li, Samuel; amd-gfx list *Subject:* Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support I don't think that is a good idea. Ideally

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-20 Thread Deucher, Alexander
Alex From: Christian König Sent: Tuesday, March 20, 2018 2:32:49 PM To: Marek Olšák; Koenig, Christian Cc: Alex Deucher; Deucher, Alexander; Michel Dänzer; Li, Samuel; amd-gfx list Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support I don't think that is a

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-20 Thread Christian König
I don't think that is a good idea. Ideally GTT should now have the same performance as VRAM on APUs and we should use VRAM only for things where we absolutely have to and to actually use up the otherwise unused VRAM. Can you run some tests with all BOs forced to GTT and see if there is any p

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-20 Thread Marek Olšák
On Tue, Mar 20, 2018 at 9:55 AM, Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Yes, exactly. And if I remember correctly Mesa used to always set GTT as > fallback on APUs, correct? > "used to" is the key part. Mesa doesn't force GTT on APUs anymore. It expects that the combination

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-20 Thread Christian König
Yes, exactly. And if I remember correctly Mesa used to always set GTT as fallback on APUs, correct? The problem seems to be that this fallback isn't set for displayable BOs. So what needs to be done is to just enable this fallback for displayable BOs as well if the kernel can handle it. Chri

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Marek Olšák
In theory, Mesa doesn't have to do anything. It can continue setting VRAM and if the kernel has to put a display buffer into GTT, it doesn't matter (for Mesa). Whether the VRAM placement is really used is largely determined by BO priorities. The way I understand scather/gather is that it only allo

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Alex Deucher
> Regards, > > Samuel Li > > > > From: Marek Olšák [mailto:mar...@gmail.com] > Sent: Monday, March 19, 2018 4:27 PM > To: Deucher, Alexander > Cc: Li, Samuel ; Koenig, Christian > ; Alex Deucher ; Michel > Dänzer ; amd-gfx list > > > Subject: Re: [P

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Marek Olšák
On Mon, Mar 19, 2018 at 4:53 PM, Alex Deucher wrote: > On Mon, Mar 19, 2018 at 4:26 PM, Marek Olšák wrote: > > When Mesa wants a buffer in VRAM, it always sets VRAM. It relies on BO > move > > throttling to prevent unnecessary BO moves. > > > > My questions are: > > - what should Mesa do differe

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Alex Deucher
n Behalf Of >> Deucher, Alexander >> Sent: Monday, March 19, 2018 4:13 PM >> >> >> To: Li, Samuel ; Koenig, Christian >> ; Marek Olšák >> Cc: Alex Deucher ; Michel Dänzer >> ; amd-gfx list >> Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather di

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Li, Samuel
rch 19, 2018 4:27 PM To: Deucher, Alexander Cc: Li, Samuel ; Koenig, Christian ; Alex Deucher ; Michel Dänzer ; amd-gfx list Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support When Mesa wants a buffer in VRAM, it always sets VRAM. It relies on BO move throttling to p

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Marek Olšák
t; *From:* Li, Samuel > *Sent:* Monday, March 19, 2018 3:58:52 PM > *To:* Deucher, Alexander; Koenig, Christian; Marek Olšák > *Cc:* Alex Deucher; Michel Dänzer; amd-gfx list > *Subject:* RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display > support > > > > Alex,

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Deucher, Alexander
l ; Koenig, Christian ; Marek Olšák Cc: Alex Deucher ; Michel Dänzer ; amd-gfx list Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support I'm not sure what you mean by the 3 scenarios. Generally userspace selects what domains it wants a buffer to be in, vram, gtt, or b

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Deucher, Alexander
Regards, Samuel Li From: Deucher, Alexander Sent: Monday, March 19, 2018 3:54 PM To: Li, Samuel ; Koenig, Christian ; Marek Olšák Cc: Alex Deucher ; Michel Dänzer ; amd-gfx list Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support My personal preference is still to plu

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Christian König
ucher ; Michel Dänzer ; amd-gfx list *Subject:* Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support My personal preference is still to plumb this through to mesa rather than forcing it in the kernel. Alex *From

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Li, Samuel
, March 19, 2018 3:54 PM To: Li, Samuel ; Koenig, Christian ; Marek Olšák Cc: Alex Deucher ; Michel Dänzer ; amd-gfx list Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support My personal preference is still to plumb this through to mesa rather than forcing it in the kernel

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Deucher, Alexander
list Subject: RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support Christian, You misunderstood Alex’s comments, >Regardless of which scenarios we need to support, I think we also need >to really plumb this through to mesa however since user space is who >ultimately

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Li, Samuel
m: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Monday, March 19, 2018 3:45 PM To: Li, Samuel ; Marek Olšák ; Koenig, Christian Cc: Alex Deucher ; Michel Dänzer ; amd-gfx list Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support Quoting Alex: Regardl

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Christian König
m:*Marek Olšák [mailto:mar...@gmail.com] *Sent:* Monday, March 19, 2018 3:39 PM *To:* Koenig, Christian *Cc:* Li, Samuel ; Michel Dänzer ; Alex Deucher ; amd-gfx list *Subject:* Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support On Mon, Mar 19, 2018 at 3:27 PM, Christi

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Christian König
sday, March 08, 2018 4:07 AM To: Michel Dänzer mailto:mic...@daenzer.net>>; Li, Samuel mailto:samuel...@amd.com>>; Alex Deucher mailto:alexdeuc...@gmail.com>> Cc: amd-gfx list mailto:amd-gfx@lists.freedesktop.org>>

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Li, Samuel
istian Cc: Li, Samuel ; Michel Dänzer ; Alex Deucher ; amd-gfx list Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support On Mon, Mar 19, 2018 at 3:27 PM, Christian König mailto:christian.koe...@amd.com>> wrote: I think that the consensus with Alex and me is that we

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Marek Olšák
From: Koenig, Christian >>> Sent: Thursday, March 08, 2018 4:07 AM >>> To: Michel Dänzer ; Li, Samuel >>> ; Alex Deucher >>> Cc: amd-gfx list >>> Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display >>> support >>&g

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Christian König
: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support Am 08.03.2018 um 09:35 schrieb Michel Dänzer: On 2018-03-07 10:47 AM, Christian König wrote: Am 07.03.2018 um 09:42 schrieb Michel Dänzer: On 2018-03-06 07:23 PM, Christian König wrote: E.g. the last time I tested it placing things

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Li, Samuel
x Deucher > Cc: amd-gfx list > Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support > > Am 08.03.2018 um 09:35 schrieb Michel Dänzer: > > On 2018-03-07 10:47 AM, Christian König wrote: > >> Am 07.03.2018 um 09:42 schrieb Michel Dänzer: > >

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-08 Thread Christian König
Am 08.03.2018 um 09:35 schrieb Michel Dänzer: On 2018-03-07 10:47 AM, Christian König wrote: Am 07.03.2018 um 09:42 schrieb Michel Dänzer: On 2018-03-06 07:23 PM, Christian König wrote: E.g. the last time I tested it placing things into GTT still resulted in quite a performance penalty for re

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-08 Thread Michel Dänzer
On 2018-03-07 10:47 AM, Christian König wrote: > Am 07.03.2018 um 09:42 schrieb Michel Dänzer: >> On 2018-03-06 07:23 PM, Christian König wrote: >> >>> E.g. the last time I tested it placing things into GTT still resulted >>> in quite a performance penalty for rendering. >> FWIW, I think the penalt

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-07 Thread Alex Deucher
>> From: Samuel Li [mailto:samuel...@amd.com] >> Sent: Wednesday, March 07, 2018 1:54 PM >> To: Alex Deucher >> Cc: Michel Dänzer ; Koenig, Christian >> ; amd-gfx list >> Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support >> >

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-07 Thread Li, Samuel
scenario, I have no objection at all. Regards, Samuel Li > -Original Message- > From: Samuel Li [mailto:samuel...@amd.com] > Sent: Wednesday, March 07, 2018 1:54 PM > To: Alex Deucher > Cc: Michel Dänzer ; Koenig, Christian > ; amd-gfx list > Subject: Re: [PATCH 1/

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-07 Thread Samuel Li
> You might also want to prefer VRAM, but also allow buffers to fall back to > GTT if > necessary. For display buffer, this case seems not really attractive. When display buffer changes between GTT and VRAM dynamically, our driver needs to adpat too, which is hard to see the benefits and not rea

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-07 Thread Alex Deucher
On Wed, Mar 7, 2018 at 1:18 PM, Samuel Li wrote: > I think it's not useful though. Think about that, SG display feature is > intended to use as less VRAM as possible. Will someone want a display buffer > sometimes VRAM, sometimes GTT? > Hardly a case to me, and I think it's a waste of effort. Th

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-07 Thread Samuel Li
I think it's not useful though. Think about that, SG display feature is intended to use as less VRAM as possible. Will someone want a display buffer sometimes VRAM, sometimes GTT? Hardly a case to me, and I think it's a waste of effort. That also might explain no driver does that now. Sam On

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-07 Thread Michel Dänzer
On 2018-03-07 06:38 PM, Alex Deucher wrote: > On Wed, Mar 7, 2018 at 12:29 PM, Samuel Li wrote: >> >> Why so complicated? If old user space compatibility is required, just use >> sg_display=0. > > It will always just work in that case and we can adjust for the > optimal scenario by default in al

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-07 Thread Alex Deucher
On Wed, Mar 7, 2018 at 12:29 PM, Samuel Li wrote: > > Why so complicated? If old user space compatibility is required, just use > sg_display=0. It will always just work in that case and we can adjust for the optimal scenario by default in all cases without requiring the user to set misc paramete

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-07 Thread Samuel Li
Why so complicated? If old user space compatibility is required, just use sg_display=0. Sam On 2018-03-07 05:12 AM, Michel Dänzer wrote: > On 2018-03-07 11:04 AM, Christian König wrote: >> Am 07.03.2018 um 10:53 schrieb Michel Dänzer: >>> On 2018-03-07 10:47 AM, Christian König wrote: See

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-07 Thread Michel Dänzer
On 2018-03-07 11:04 AM, Christian König wrote: > Am 07.03.2018 um 10:53 schrieb Michel Dänzer: >> On 2018-03-07 10:47 AM, Christian König wrote: >>> See when I tested this the DDX and Mesa where unmodified, so both still >>> assumed VRAM as placement for scanout BOs, but the kernel forced scanout >

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-07 Thread Christian König
Am 07.03.2018 um 10:53 schrieb Michel Dänzer: On 2018-03-07 10:47 AM, Christian König wrote: See when I tested this the DDX and Mesa where unmodified, so both still assumed VRAM as placement for scanout BOs, but the kernel forced scanout BOs into GTT for testing. So what happened was that on sc

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-07 Thread Michel Dänzer
On 2018-03-07 10:47 AM, Christian König wrote: > > See when I tested this the DDX and Mesa where unmodified, so both still > assumed VRAM as placement for scanout BOs, but the kernel forced scanout > BOs into GTT for testing. > > So what happened was that on scanout we moved the VRAM BO to GTT an

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-07 Thread Christian König
Am 07.03.2018 um 09:42 schrieb Michel Dänzer: On 2018-03-06 07:23 PM, Christian König wrote: Am 06.03.2018 um 19:15 schrieb Michel Dänzer: On 2018-03-06 07:02 PM, Christian König wrote: Am 06.03.2018 um 18:51 schrieb Michel Dänzer: On 2018-03-06 06:44 PM, Christian König wrote: Am 06.03.2018

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-07 Thread Michel Dänzer
On 2018-03-06 07:23 PM, Christian König wrote: > Am 06.03.2018 um 19:15 schrieb Michel Dänzer: >> On 2018-03-06 07:02 PM, Christian König wrote: >>> Am 06.03.2018 um 18:51 schrieb Michel Dänzer: On 2018-03-06 06:44 PM, Christian König wrote: > Am 06.03.2018 um 18:22 schrieb Li, Samuel: >>>

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-06 Thread Christian König
Am 06.03.2018 um 19:15 schrieb Michel Dänzer: On 2018-03-06 07:02 PM, Christian König wrote: Am 06.03.2018 um 18:51 schrieb Michel Dänzer: On 2018-03-06 06:44 PM, Christian König wrote: Am 06.03.2018 um 18:22 schrieb Li, Samuel: addition to that I agree with Michel that the module parameter i

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-06 Thread Michel Dänzer
On 2018-03-06 07:02 PM, Christian König wrote: > Am 06.03.2018 um 18:51 schrieb Michel Dänzer: >> On 2018-03-06 06:44 PM, Christian König wrote: >>> Am 06.03.2018 um 18:22 schrieb Li, Samuel: > addition to that I agree with Michel that the module parameter is > overkill. That I already

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-06 Thread Li, Samuel
m: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] > Sent: Tuesday, March 06, 2018 1:02 PM > To: Michel Dänzer ; Koenig, Christian > ; Li, Samuel ; Alex > Deucher > Cc: amd-gfx list > Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support > > A

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-06 Thread Christian König
Am 06.03.2018 um 18:51 schrieb Michel Dänzer: On 2018-03-06 06:44 PM, Christian König wrote: Am 06.03.2018 um 18:22 schrieb Li, Samuel: addition to that I agree with Michel that the module parameter is overkill. That I already explained. Currently SG display feature needs to provide options fo

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-06 Thread Michel Dänzer
On 2018-03-06 06:44 PM, Christian König wrote: > Am 06.03.2018 um 18:22 schrieb Li, Samuel: >> >>> addition to that I agree with Michel that the module parameter is >>> overkill. >> That I already explained. Currently SG display feature needs to >> provide options for all kinds of use cases. All am

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-06 Thread Christian König
- From: Koenig, Christian Sent: Tuesday, March 06, 2018 12:12 PM To: Li, Samuel ; Alex Deucher Cc: amd-gfx list Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support And exactly that's the problematical assumption. This doesn't print only when the module is loade

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-06 Thread Li, Samuel
PM > To: Li, Samuel ; Alex Deucher > > Cc: amd-gfx list > Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support > > And exactly that's the problematical assumption. > > This doesn't print only when the module is loaded, but rather when a >

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-06 Thread Christian König
@gmail.com] Sent: Tuesday, March 06, 2018 12:04 PM To: Li, Samuel Cc: Koenig, Christian ; amd-gfx list Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support On Tue, Mar 6, 2018 at 11:49 AM, Samuel Li wrote: domain = amdgpu_display_framebuffer_domains(adev); +

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-06 Thread Li, Samuel
; amd-gfx list g...@lists.freedesktop.org> > Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support > > On Tue, Mar 6, 2018 at 11:49 AM, Samuel Li wrote: > >>> domain = amdgpu_display_framebuffer_domains(adev); > >>> +if (domain

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-06 Thread Alex Deucher
On Tue, Mar 6, 2018 at 11:49 AM, Samuel Li wrote: >>> domain = amdgpu_display_framebuffer_domains(adev); >>> +if (domain == AMDGPU_GEM_DOMAIN_GTT) { >>> +DRM_INFO("Scatter gather display: enabled\n"); >>> +} else if (domain & AMDGPU_GEM_DOMAIN_GTT) { >>> +DRM_INFO("Sc

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-06 Thread Samuel Li
>> domain = amdgpu_display_framebuffer_domains(adev); >> +if (domain == AMDGPU_GEM_DOMAIN_GTT) { >> +DRM_INFO("Scatter gather display: enabled\n"); >> +} else if (domain & AMDGPU_GEM_DOMAIN_GTT) { >> +DRM_INFO("Scatter gather display: auto\n"); >> +} > > Dito and

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-05 Thread Samuel Li
There are three major options when SG capability is enabled, 1) Allocate everything when possible from GTT memory 2) Allocate everything when possible from VRAM 3) Allow both VRAM/GTT to be available Each has its own pros/cons, and it has not been decided which direction is going to be used for al

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-05 Thread Michel Dänzer
On 2018-03-03 12:25 AM, Samuel Li wrote: > It's enabled by default. -1 is auto, to allow both vram and gtt > memory be available, for testing purpose only. Do we really need a module parameter for this? There's already too many of them. The driver should know which to use in which cases, and devel

Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-03 Thread Christian König
Am 03.03.2018 um 00:25 schrieb Samuel Li: It's enabled by default. -1 is auto, to allow both vram and gtt memory be available, for testing purpose only. --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 9 +++-- drivers/gpu/drm/amd/amdgpu

[PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-02 Thread Samuel Li
It's enabled by default. -1 is auto, to allow both vram and gtt memory be available, for testing purpose only. --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 9 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 drivers/gpu/drm/amd