> -Original Message-
> From: Zhu, Rex
> Sent: Thursday, August 16, 2018 1:41 PM
> To: 'Alex Deucher'
> Cc: Deng, Emily ; amd-gfx list g...@lists.freedesktop.org>
> Subject: RE: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do
> invalidate tlb
>
>
>
> > -Original
Am 15.08.2018 um 20:49 schrieb Felix Kuehling:
On 2018-08-15 02:27 PM, Christian König wrote:
Am 15.08.2018 um 20:17 schrieb Felix Kuehling:
On 2018-08-15 03:02 AM, Christian König wrote:
Hi Felix,
yeah, you pretty much nailed it.
The problem is that the array itself is RCU protected. This
Thanks all, I am modifying the patch, and testing.
Best wishes
Emily Deng
>-Original Message-
>From: Zhu, Rex
>Sent: Thursday, August 16, 2018 2:25 PM
>To: 'Alex Deucher'
>Cc: Deng, Emily ; 'amd-gfx list' g...@lists.freedesktop.org>
>Subject: RE: [PATCH 1/2] drm/amdgpu/sriov: For
there is no need to access register such as mmSMC_IND_INDEX_11
and mmSMC_IND_DATA_11 through KIQ because they are VF-copy.
Change-Id: I88302dc5945e0b0fa2e6411081fb798aab4fdb5e
Signed-off-by: Yintian Tao
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/vi.c | 4 ++--
1 file changed, 2
Am 16.08.2018 um 04:07 schrieb zhoucm1:
On 2018年08月15日 18:59, Christian König wrote:
Use a fixed number of entities for each hardware IP.
The number of compute entities is reduced to four, SDMA keeps it two
entities and all other engines just expose one entity.
Signed-off-by: Christian
There is no need for gpu full access for suspend phase1
because under virtualization there is no hw register access
for dce block.
Change-Id: Ie1154e2065182ba968732af87f866f11141a102b
Signed-off-by: Yintian Tao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 --
1 file changed, 6
On 2018年08月16日 16:11, Christian König wrote:
Am 16.08.2018 um 04:07 schrieb zhoucm1:
On 2018年08月15日 18:59, Christian König wrote:
Use a fixed number of entities for each hardware IP.
The number of compute entities is reduced to four, SDMA keeps it two
entities and all other engines just
From: Hans Verkuil
Now that the DisplayPort CEC-Tunneling-over-AUX drm+i915 support
has been merged in the mainline kernel it is time to roll this
out to nouveau and amdgpu as well.
I combined both in the same patch series since both depend on the
same first patch, the comments in this cover
From: Hans Verkuil
If aux->transfer == NULL, then just return without doing
anything. In that case the function is likely called for
a non-(e)DP connector.
This never happened for the i915 driver, but the nouveau and amdgpu
drivers need this check.
The alternative would be to add this check in
From: Hans Verkuil
Add DisplayPort CEC-Tunneling-over-AUX support to nouveau.
Signed-off-by: Hans Verkuil
---
drivers/gpu/drm/nouveau/nouveau_connector.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c
From: Hans Verkuil
When parsing the reply of a DP_REMOTE_DPCD_READ DPCD command the
result is wrong due to a missing idx increment.
This was never noticed since DP_REMOTE_DPCD_READ is currently not
used, but if you enable it, then it is all wrong.
Signed-off-by: Hans Verkuil
---
From: Hans Verkuil
Add DisplayPort CEC-Tunneling-over-AUX support to amdgpu.
Signed-off-by: Hans Verkuil
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 +++--
.../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 ++
2 files changed, 13 insertions(+), 2 deletions(-)
From: Hans Verkuil
A big problem with DP CEC-Tunneling-over-AUX is that it is tricky
to find adapters with a chipset that supports this AND where the
manufacturer actually connected the HDMI CEC line to the chipset.
Add a mention of the MegaChips 2900 chipset which seems to support
this feature
Am 16.08.2018 um 15:05 schrieb Emily Deng:
Unify bare metal and sriov, and add firmware checking for
reg write and reg wait unify command.
Signed-off-by: Emily Deng
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 ++
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 47
On Thu, Aug 16, 2018 at 10:36 AM Michel Dänzer wrote:
>
> From: Michel Dänzer
>
> We were always using the handle of the client provided FB, which
> prevented RandR transforms from working, and could result in a black
> screen.
>
> Fixes: 9b6782c821e0 "Store FB for each CRTC in
On Thu, Aug 16, 2018 at 4:26 AM Yintian Tao wrote:
>
> There is no need for gpu full access for suspend phase1
> because under virtualization there is no hw register access
> for dce block.
>
> Change-Id: Ie1154e2065182ba968732af87f866f11141a102b
> Signed-off-by: Yintian Tao
Acked-by: Alex
On 2018-08-15 03:07 AM, Zhang, Jerry (Junwei) wrote:
> On 08/14/2018 05:58 PM, Michel Dänzer wrote:
>> From: Michel Dänzer
>>
>> Arithmetic using void* pointers isn't defined by the C standard, only as
>> a GCC extension. Avoids compiler warnings:
>>
>> ../../amdgpu/amdgpu_bo.c: In function
This adds support for LVDS displays.
v2: add support for spread spectrum, sink detect
v3: clean up enable_lvds_output
v4: fix up link_detect
v5: remove assert on 888 format
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=105880
Signed-off-by: Alex Deucher
---
From: Michel Dänzer
Arithmetic using void* pointers isn't defined by the C standard, only as
a GCC extension. Avoids compiler warnings:
../../amdgpu/amdgpu_bo.c: In function ‘amdgpu_find_bo_by_cpu_mapping’:
../../amdgpu/amdgpu_bo.c:554:48: warning: pointer of type ‘void *’ used in
arithmetic
To avoid the tlb flush not interrupted by world switch, use kiq and one
command to do tlb invalidate.
Signed-off-by: Emily Deng
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 3 --
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c| 60
Unify bare metal and sriov, and add firmware checking for
reg write and reg wait unify command.
Signed-off-by: Emily Deng
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 ++
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 47 -
2 files changed, 48 insertions(+), 1
On 2018-08-10 09:06 AM, Johannes Hirte wrote:
> On 2018 Jul 27, Michel Dänzer wrote:
>> From: Michel Dänzer
>>
>> We were only storing the FB provided by the client, but on CRTCs with
>> TearFree enabled, we use a separate FB. This could cause
>> drmmode_flip_handler to fail to clear
From: Michel Dänzer
Instead of processing DRM events directly from drmHandleEvent's
callbacks, there are three phases:
1. drmHandleEvent is called, and signalled events are re-queued to
_signalled lists from its callbacks.
2. Signalled page flip completion events are processed.
3. Signalled
From: Michel Dänzer
Replacing the drmmode_crtc_wait_pending_event macro.
(Ported from amdgpu commit 6029794e8a35417faf825491a89b85f713c77fc1)
Signed-off-by: Michel Dänzer
---
src/drmmode_display.c | 21 -
src/radeon_drm_queue.c | 13 +
src/radeon_drm_queue.h
From: Michel Dänzer
Not needed anymore with the more robust mechanisms for preventing nested
drmHandleEvent calls introduced in the previous changes.
(Ported from amdgpu commit 85cd8eef0cbed7b409b07f58d76dacd34aa3ddea)
Signed-off-by: Michel Dänzer
---
src/drmmode_display.h | 8
From: Michel Dänzer
And make radeon_drm_queue_handler not directly accessible outside of
radeon_drm_queue.c.
(Ported from amdgpu commit 0148283984c77f7a6e97026edc3093497547e0a4)
Signed-off-by: Michel Dänzer
---
src/drmmode_display.c | 4
src/radeon_dri2.c | 14 --
From: Michel Dänzer
Replacing the drmmode_crtc_wait_pending_event macro.
(Ported from amdgpu commit 6029794e8a35417faf825491a89b85f713c77fc1)
Signed-off-by: Michel Dänzer
---
src/drmmode_display.c | 18 --
src/drmmode_display.h | 4
src/radeon_drm_queue.c | 41
On Thu, Aug 16, 2018 at 6:56 AM Hans Verkuil wrote:
>
> From: Hans Verkuil
>
> Now that the DisplayPort CEC-Tunneling-over-AUX drm+i915 support
> has been merged in the mainline kernel it is time to roll this
> out to nouveau and amdgpu as well.
>
> I combined both in the same patch series since
On 2018-08-16 02:43 AM, Christian König wrote:
> Am 15.08.2018 um 20:49 schrieb Felix Kuehling:
>> On 2018-08-15 02:27 PM, Christian König wrote:
>>> Am 15.08.2018 um 20:17 schrieb Felix Kuehling:
On 2018-08-15 03:02 AM, Christian König wrote:
> Hi Felix,
>
> yeah, you pretty much
On Thu, Aug 16, 2018 at 12:25 PM Michel Dänzer wrote:
>
> From: Michel Dänzer
>
> We were always using the handle of the client provided FB, which
> prevented RandR transforms from working, and could result in a black
> screen.
>
> Fixes: 740f0850f1e4 "Store FB for each CRTC in
From: Michel Dänzer
We were always using the handle of the client provided FB, which
prevented RandR transforms from working, and could result in a black
screen.
Fixes: 740f0850f1e4 "Store FB for each CRTC in drmmode_flipdata_rec"
(Ported from amdgpu commit
Hi Dave,
Fixes for 4.19:
- Add VCN PSP FW loading for RV (this is required on upcoming parts)
- Fix scheduler setup ordering for VCE and UVD
- Few misc display fixes
The following changes since commit 557ce95051c8eff67af48612ab350d8408aa0541:
Merge branch 'drm-next-4.19' of
On Thu, Aug 16, 2018 at 12:20 PM Michel Dänzer wrote:
>
> From: Michel Dänzer
>
> Not needed anymore with the more robust mechanisms for preventing nested
> drmHandleEvent calls introduced in the previous changes.
>
> (Ported from amdgpu commit 85cd8eef0cbed7b409b07f58d76dacd34aa3ddea)
>
>
On Thu, Aug 16, 2018 at 3:45 PM wrote:
>
> From: "Leo (Sunpeng) Li"
>
> This reverts commit 8624c3c4dbfe24fc6740687236a2e196f5f4bfb0.
>
> We need CONFIG_DRM_AMD_DC_DCN1_0 to guard code that is using fp math.
MIssing your SOB. WIth that fixed, series is:
Acked-by: Alex Deucher
Am 16.08.2018 um 20:23 schrieb Felix Kuehling:
On 2018-08-16 02:18 PM, Christian König wrote:
Am 16.08.2018 um 18:50 schrieb Felix Kuehling:
On 2018-08-16 02:43 AM, Christian König wrote:
[SNIP]
I mean it could be that in the worst case we race and stop a KFD
process for no good reason.
On Thu, Aug 16, 2018 at 9:56 PM Leo Li wrote:
> On 2018-08-11 11:54 AM, Arnd Bergmann wrote:
> >
> > I tried implementing the two functions in KCOV: __sanitizer_cov_trace_cmpd
> > and __sanitizer_cov_trace_cmpf, but that fails to build on architectures
> > that do not support any floating-point
On Thu, Aug 16, 2018 at 9:45 PM wrote:
>
> From: "Leo (Sunpeng) Li"
>
> DCN1 contains code that utilizes fp math. When
> CONFIG_KCOV_INSTRUMENT_ALL and CONFIG_KCOV_ENABLE_COMPARISONS are
> enabled, build errors are found. See this earlier patch for details:
>
>
Am 16.08.2018 um 15:54 schrieb Michel Dänzer:
From: Michel Dänzer
Arithmetic using void* pointers isn't defined by the C standard, only as
a GCC extension. Avoids compiler warnings:
../../amdgpu/amdgpu_bo.c: In function ‘amdgpu_find_bo_by_cpu_mapping’:
../../amdgpu/amdgpu_bo.c:554:48:
On 2018-08-16 02:18 PM, Christian König wrote:
> Am 16.08.2018 um 18:50 schrieb Felix Kuehling:
>> On 2018-08-16 02:43 AM, Christian König wrote:
>> [SNIP]
>>> I mean it could be that in the worst case we race and stop a KFD
>>> process for no good reason.
>> Right. For a more practical example, a
Am 16.08.2018 um 18:50 schrieb Felix Kuehling:
On 2018-08-16 02:43 AM, Christian König wrote:
[SNIP]
I mean it could be that in the worst case we race and stop a KFD
process for no good reason.
Right. For a more practical example, a KFD BO can get evicted just
before the application decides to
Seems to cause blank screens.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106940
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git
On 2018-08-16 02:26 PM, Christian König wrote:
> Am 16.08.2018 um 20:23 schrieb Felix Kuehling:
>> On 2018-08-16 02:18 PM, Christian König wrote:
>>> Am 16.08.2018 um 18:50 schrieb Felix Kuehling:
On 2018-08-16 02:43 AM, Christian König wrote:
[SNIP]
> I mean it could be that in
Am 16.08.2018 um 20:43 schrieb Felix Kuehling:
On 2018-08-16 02:26 PM, Christian König wrote:
Am 16.08.2018 um 20:23 schrieb Felix Kuehling:
On 2018-08-16 02:18 PM, Christian König wrote:
Am 16.08.2018 um 18:50 schrieb Felix Kuehling:
On 2018-08-16 02:43 AM, Christian König wrote:
[SNIP]
I
From: "Leo (Sunpeng) Li"
DCN1 contains code that utilizes fp math. When
CONFIG_KCOV_INSTRUMENT_ALL and CONFIG_KCOV_ENABLE_COMPARISONS are
enabled, build errors are found. See this earlier patch for details:
https://lists.freedesktop.org/archives/dri-devel/2018-August/186131.html
As a short
>-Original Message-
>From: amd-gfx On Behalf Of Deng,
>Emily
>Sent: Friday, August 17, 2018 10:19 AM
>To: Koenig, Christian ; amd-
>g...@lists.freedesktop.org
>Subject: RE: [PATCH 2/2] drm/amdgpu: use kiq to do invalidate tlb
>
>>-Original Message-
>>From: Christian König
>>Sent:
Set correct address base for vega20.
Change-Id: I7435980e2ca156ee2b443a97899d40aaba4876cb
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/amdgpu/vega20_reg_init.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/vega20_reg_init.c
Add additional IP block offsets.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/vega20_reg_init.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/vega20_reg_init.c
b/drivers/gpu/drm/amd/amdgpu/vega20_reg_init.c
index 52778de93ab0..c231ae6f79e1
>-Original Message-
>From: Christian König
>Sent: Thursday, August 16, 2018 9:24 PM
>To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH 2/2] drm/amdgpu: use kiq to do invalidate tlb
>
>Am 16.08.2018 um 15:05 schrieb Emily Deng:
>> To avoid the tlb flush not interrupted
>-Original Message-
>From: Christian König
>Sent: Thursday, August 16, 2018 9:17 PM
>To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH 1/2] drm/amdgpu: Remove the sriov checking and add
>firmware checking
>
>Am 16.08.2018 um 15:05 schrieb Emily Deng:
>> Unify bare metal
There are no any logical changes here.
1. if kcq can be enabled via kiq, we don't need to
do kiq ring test.
2. amdgpu_ring_test_ring function can be used to
sync the ring complete, remove the duplicate code.
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 80
Refine the patch 1, and the lock about invalidate_lock.
Unify bare metal and sriov, and add firmware checking for
reg write and reg wait unify command.
Signed-off-by: Emily Deng
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 ++
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 59
Reviewed-by: Junwei Zhang
Regards,
Jerry(Junwei Zhang)
From: amd-gfx on behalf of Michel
Dänzer
Sent: Thursday, August 16, 2018 9:54:29 PM
To: amd-gfx@lists.freedesktop.org
Subject: [PATCH v2 libdrm] amdgpu: Eliminate void* arithmetic in
Reviewed-by: Alex Deucher
From: Evan Quan
Sent: Thursday, August 16, 2018 10:36:32 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander; Xu, Feifei; Quan, Evan
Subject: [PATCH] drm/amd/powerplay: set correct base for THM/NBIF/MP1 IP
Set correct address
On Fri, Aug 17, 2018 at 10:36:32AM +0800, Evan Quan wrote:
> Set correct address base for vega20.
>
> Change-Id: I7435980e2ca156ee2b443a97899d40aaba4876cb
> Signed-off-by: Evan Quan
The patch subject prefix should be "drm/amdgpu:"
With that fixed, patch is
Reviewed-by: Huang Rui
> ---
>
To avoid the tlb flush not interrupted by world switch, use kiq and one
command to do tlb invalidate.
v2:
Refine the invalidate lock position.
Signed-off-by: Emily Deng
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 3 --
Am 16.08.2018 um 15:05 schrieb Emily Deng:
To avoid the tlb flush not interrupted by world switch, use kiq and one
command to do tlb invalidate.
Signed-off-by: Emily Deng
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 3 --
From: Michel Dänzer
We were always using the handle of the client provided FB, which
prevented RandR transforms from working, and could result in a black
screen.
Fixes: 9b6782c821e0 "Store FB for each CRTC in drmmode_flipdata_rec"
Signed-off-by: Michel Dänzer
---
src/drmmode_display.c | 4
57 matches
Mail list logo
