RB-by: Monk Liu
-Original Message-
From: amd-gfx On Behalf Of Rex Zhu
Sent: Tuesday, October 16, 2018 5:25 PM
To: amd-gfx@lists.freedesktop.org; Liu, Monk
Cc: Zhu, Rex
Subject: [PATCH 3/3] drm/amdgpu: Move csa related functions to separate file
Those functions can be shared between
RB-by: Monk Liu
-Original Message-
From: amd-gfx On Behalf Of Rex Zhu
Sent: Tuesday, October 16, 2018 5:25 PM
To: amd-gfx@lists.freedesktop.org; Liu, Monk
Cc: Zhu, Rex
Subject: [PATCH 1/3] drm/amdgpu: Remove useless csa gpu address in vmid0
driver didn't use this address so far.
Am 16.10.2018 um 11:25 schrieb Rex Zhu:
Those functions can be shared between SRIOV and baremetal
Please drop the _manager suffix from the filename, apart from that the
patches look good to me.
Christian.
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/Makefile | 2
RB-by: Monk Liu
-Original Message-
From: amd-gfx On Behalf Of Rex Zhu
Sent: Tuesday, October 16, 2018 5:25 PM
To: amd-gfx@lists.freedesktop.org; Liu, Monk
Cc: Zhu, Rex
Subject: [PATCH 2/3] drm/amdgpu: Refine CSA related functions
There is no functional changes,
Use function arguments
Reviewed-by: Evan Quan
> -Original Message-
> From: amd-gfx On Behalf Of
> Feifei Xu
> Sent: 2018年10月16日 15:59
> To: amd-gfx@lists.freedesktop.org
> Cc: Xu, Feifei
> Subject: [PATCH] drm/amdgpu: Update gc_9_0 golden settings.
>
> Add mmDB_DEBUG3 settings.
>
> Change-Id:
From: John Clements
Signed-off-by: John Clements
---
drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of John Clements
> Sent: Tuesday, October 16, 2018 9:23 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: John Clements
> Subject: [PATCH 1/1] Updated comment accuracy in PSP SOS/Sysdriver
> loading
There is no functional changes,
Use function arguments for SRIOV special variables which
is hardcode in those functions.
so we can share those functions with os preemption in
baremetal.
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++--
Those functions can be shared between SRIOV and baremetal
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/Makefile | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_csa_manager.c | 117
Do you test based on drm-next branch?
Best Regards
Rex
From: S, Shirish
Sent: Wednesday, October 17, 2018 1:12 AM
To: Deucher, Alexander ; Zhu, Rex ;
amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if they were
disabled by user
This patch fails on
> -Original Message-
> From: Christian König
> Sent: Wednesday, October 17, 2018 2:31 AM
> To: Zhu, Rex ; amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH v2] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if
> they were disabled by user
>
> Am 16.10.2018 um 20:25 schrieb Rex Zhu:
> >
Am 16.10.2018 um 20:00 schrieb Zhao, Yong:
The flags are added when calling amdgpu_gmc_pd_addr().
Change-Id: Idd85b1ac35d3d100154df8229ea20721d9a7045c
Signed-off-by: Yong Zhao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 5 ++---
drivers/gpu/drm/amd/amdkfd/kfd_priv.h
Am 16.10.2018 um 20:00 schrieb Zhao, Yong:
Change-Id: I337a61ccfeb68241a0663ba7fad6e0fec1646348
Signed-off-by: Yong Zhao
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 ++
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 19 +++
drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 18
Yes.
Is there any dependant patches?
Regards,
Shirish S
From: Zhu, Rex
Sent: Tuesday, October 16, 2018 12:29 PM
To: S, Shirish ; Deucher, Alexander
; amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if they were
disabled by user
The code base is
Those register settings have been done in gfxhub_v1_0_program_invalidation()
and mmhub_v1_0_program_invalidation().
Change-Id: I9b9b44f17ac2a6ff0c9c78f91885665da75543d0
Signed-off-by: Yong Zhao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 17 -
1 file changed, 17
The same statement is later done in kgd_set_pasid_vmid_mapping() already,
so no need to in set_pasid_vmid_mapping() again.
Change-Id: Iaf64b90c7dcb59944fb2012a58473dd063e73c60
Signed-off-by: Yong Zhao
---
drivers/gpu/drm/amd/amdkfd/cik_regs.h | 2 --
The flags are added when calling amdgpu_gmc_pd_addr().
Change-Id: Idd85b1ac35d3d100154df8229ea20721d9a7045c
Signed-off-by: Yong Zhao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 5 ++---
drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 2 +-
2 files changed, 3 insertions(+), 4
Those register settings have been performed in amdgpu initialization
gfxhub_v1_0_setup_vmid_config() and mmhub_v1_0_setup_vmid_config().
So no need to do it again in kfd.
Change-Id: I77a6c162694f810575a28d146ed86eee9b7a610c
Signed-off-by: Yong Zhao
---
Change-Id: I306305e43d4b4032316909b3f4e3f9f5ca4520ae
Signed-off-by: Yong Zhao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 32 +--
1 file changed, 1 insertion(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c
Change-Id: I3dcd71955297c53b181f82e7078981230c642c01
Signed-off-by: Yong Zhao
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 19 ++-
2 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
Change-Id: Ic25e851dce8d0d222add9e4d826d1a9f81f5776b
Signed-off-by: Yong Zhao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c
On Tue, Oct 16, 2018 at 2:27 PM Rex Zhu wrote:
>
> If user disable uvd/vce/vcn/acp blocks via module
> parameter ip_block_mask,
> driver power off thoser blocks to save power.
>
> v2: power off uvd/vce/vcn/acp via smu.
>
> Reviewed-by: Alex Deucher
RB of v2 as well.
Alex
> Signed-off-by: Rex
If user disable uvd/vce/vcn/acp blocks via module
parameter ip_block_mask,
driver power off thoser blocks to save power.
v2: power off uvd/vce/vcn/acp via smu.
Reviewed-by: Alex Deucher
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 19 +++
1 file
Change-Id: I337a61ccfeb68241a0663ba7fad6e0fec1646348
Signed-off-by: Yong Zhao
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 ++
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 19 +++
drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 18 ++
3 files changed, 35
Am 16.10.2018 um 21:03 schrieb Zhu, Rex:
-Original Message-
From: Koenig, Christian
Sent: Wednesday, October 17, 2018 2:59 AM
To: Zhu, Rex ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if
they were disabled by user
Am 16.10.2018 um
Nope, I have just cherry-picked this patch.
Is there any dependency?
Regards,
Shirish S
From: Zhu, Rex
Sent: Tuesday, October 16, 2018 12:15 PM
To: S, Shirish ; Deucher, Alexander
; amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if they were
Am 16.10.2018 um 20:54 schrieb Zhu, Rex:
>
>> -Original Message-
>> From: Christian König
>> Sent: Wednesday, October 17, 2018 2:31 AM
>> To: Zhu, Rex ; amd-gfx@lists.freedesktop.org
>> Subject: Re: [PATCH v2] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if
>> they were disabled by user
>>
> -Original Message-
> From: Koenig, Christian
> Sent: Wednesday, October 17, 2018 2:59 AM
> To: Zhu, Rex ; amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH v2] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if
> they were disabled by user
>
> Am 16.10.2018 um 20:54 schrieb Zhu, Rex:
> >
Am 16.10.2018 um 20:25 schrieb Rex Zhu:
If user disable uvd/vce/vcn/acp blocks via module
parameter ip_block_mask,
driver power off thoser blocks to save power.
v2: power off uvd/vce/vcn/acp via smu.
I'm not sure if that is a good idea.
The meaning of the flag is to NOT touch the blocks at
This patch fails on the very first resume as below:
[ 53.632732] [drm:vce_v3_0_set_powergating_state] *ERROR* VCE not responding,
trying to reset the ECPU!!!
[ 54.653212] [drm:vce_v3_0_set_powergating_state] *ERROR* VCE not responding,
trying to reset the ECPU!!!
[ 55.673692]
The code base is different.
And do you set ip_block_mask = 0xeff to diable vce?
Best Regards
Rex
From: S, Shirish
Sent: Wednesday, October 17, 2018 1:25 AM
To: Zhu, Rex ; Deucher, Alexander ;
amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if they
> -Original Message-
> From: Christian König
> Sent: Wednesday, October 17, 2018 3:11 AM
> To: Zhu, Rex ; Koenig, Christian
> ; amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH v2] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if
> they were disabled by user
>
> Am 16.10.2018 um 21:03
Replace our MMU notifier with hmm_mirror_ops.sync_cpu_device_pagetables
callback. Enable CONFIG_HMM and CONFIG_HMM_MIRROR as a dependency in
DRM_AMDGPU_USERPTR Kconfig.
It supports both KFD userptr and gfx userptr paths.
This depends on several HMM patchset from Jérôme Glisse queued for
Use HMM helper function hmm_vma_fault() to get physical pages backing
userptr and start CPU page table update track of those pages. Then use
hmm_vma_range_done() to check if those pages are updated before
amdgpu_cs_submit for gfx or before user queues are resumed for kfd.
If userptr pages are
On Mon, 15 Oct 2018 12:02:14 -0400
"Kazlauskas, Nicholas" wrote:
> On 10/15/2018 09:57 AM, Pekka Paalanen wrote:
> > On Fri, 12 Oct 2018 08:58:23 -0400
> > "Kazlauskas, Nicholas" wrote:
> >
> >> On 10/12/2018 07:20 AM, Koenig, Christian wrote:
> >>> Am 12.10.2018 um 11:21 schrieb Pekka
Add mmDB_DEBUG3 settings.
Change-Id: I5797f8973673d94c090f1c4c3a1baf082b8ecba4
Signed-off-by: Feifei Xu
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index
driver didn't use this address so far.
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
Was never used.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/si_dma.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/si_dma.c
b/drivers/gpu/drm/amd/amdgpu/si_dma.c
index adbaea6da0d7..d9b27d7017dd 100644
---
Make sure we always restart the timer after a timeout and remove the
device specific workarounds.
Signed-off-by: Christian König
---
drivers/gpu/drm/etnaviv/etnaviv_sched.c | 2 --
drivers/gpu/drm/scheduler/sched_main.c | 1 +
drivers/gpu/drm/v3d/v3d_sched.c | 3 ---
3 files changed, 1
Signal a fault to the scheduler on an illegal instruction or register
access violation instead of kicking of the reset handler directly.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 -
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 21 -
Add a helper to immediately start timeout handling in case of a hardware
fault.
Signed-off-by: Christian König
---
drivers/gpu/drm/scheduler/sched_main.c | 13 +
include/drm/gpu_scheduler.h| 1 +
2 files changed, 14 insertions(+)
diff --git
Hi Harry,
thanks a lot for response,
On Mon, Oct 15, 2018 at 11:19 PM Harry Wentland wrote:
>
> On 2018-10-15 5:06 p.m., Harry Wentland wrote:
> > On 2018-10-14 5:47 p.m., Mauro Rossi wrote:
> >> Hi,
> >>
> >> reporting about some progress made during the weekend,
> >> thanks to Sylvain feedback
I've added my rb to patch #1 and pushed it to drm-misc-next.
I would really like to get an rb from other people on patch #2 before
proceeding.
Daniel, Dave and all the other usual suspects on the list what is your
opinion on this implementation?
Christian.
Am 15.10.2018 um 11:04 schrieb
On Mon, Oct 15, 2018 at 09:46:40AM -0400, sunpeng...@amd.com wrote:
> From: Leo Li
>
> This fixes a general protection fault, caused by accessing the contents
> of a flip_done completion object that has already been freed. It occurs
> due to the preemption of a non-blocking commit worker thread
Another gentle ping? Ray, Monk can anybody give me an rb for this patch?
It's the last one in this series and I want to get it done.
Christian.
Am 12.10.2018 um 16:27 schrieb Koenig, Christian:
Great, can I get an rb or acked-by for the patch in this case?
Thanks,
Christian.
Am 10.10.2018
Am 14.06.2018 um 16:45 schrieb Dan Carpenter:
> The error handling is wrong and "ent" could be NULL we when dereference
> it to get "ent->d_inode".
>
> The thing is that normally debugfs_create_file() is not supposed to
> require (or have) any error handling. That function does return error
>
Acked-by: Alex Deucher
From: amd-gfx on behalf of Zhu, James
Sent: Tuesday, October 16, 2018 10:15:01 AM
To: amd-gfx@lists.freedesktop.org
Cc: jzh...@gmail.com; dri-de...@lists.freedesktop.org; kbu...@01.org;
kbuild-...@01.org; dan.carpen...@oracle.com
Patches 1-3 Reviewed-by: Andrey Grodzovsky
Patch 4 Acked-by: Andrey Grodzovsky
Andrey
On 10/16/2018 07:55 AM, Christian König wrote:
> Make sure we always restart the timer after a timeout and remove the
> device specific workarounds.
>
> Signed-off-by: Christian König
> ---
>
On 2018-10-16 08:33 AM, Daniel Vetter wrote:
> On Mon, Oct 15, 2018 at 09:46:40AM -0400, sunpeng...@amd.com wrote:
>> From: Leo Li
>>
>> This fixes a general protection fault, caused by accessing the contents
>> of a flip_done completion object that has already been freed. It occurs
>> due to
ret_code should be initialized with 0. The check of read/write
ptr should be activate when UVD_POWER_STATUS_TILES is off.
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Hi Harry,
in this thread some of the coding changes with open points,
as a checklist/track for review of upcoming (v2) patches.
M.
On Mon, Oct 15, 2018 at 11:06 PM Harry Wentland wrote:
>
> On 2018-10-14 5:47 p.m., Mauro Rossi wrote:
> > Hi,
> >
> > reporting about some progress made during the
On Tue, Oct 16, 2018 at 08:34:37PM +0800, Christian König wrote:
> Another gentle ping? Ray, Monk can anybody give me an rb for this patch?
>
> It's the last one in this series and I want to get it done.
>
Feel free to add
Reviewed-by: Huang Rui
> Christian.
>
> Am 12.10.2018 um 16:27
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Rex Zhu
Sent: Tuesday, October 16, 2018 1:33:46 AM
To: amd-gfx@lists.freedesktop.org; Deucher, Alexander
Cc: Zhu, Rex
Subject: [PATCH] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if they were
disabled by
On Tue, Oct 16, 2018 at 11:00 AM Li, Sun peng (Leo) wrote:
>
>
>
> On 2018-10-16 08:33 AM, Daniel Vetter wrote:
> > On Mon, Oct 15, 2018 at 09:46:40AM -0400, sunpeng...@amd.com wrote:
> >> From: Leo Li
> >>
> >> This fixes a general protection fault, caused by accessing the contents
> >> of a
54 matches
Mail list logo
