Re: [PATCH v2] drm/amdgpu: add support for user trap handlers

2020-09-23 Thread Samuel Pitoiset
On 8/28/20 10:23 AM, Christian König wrote: Am 28.08.20 um 10:14 schrieb Samuel Pitoiset: On 8/28/20 9:57 AM, Christian König wrote: Am 25.08.20 um 16:07 schrieb Samuel Pitoiset: A trap handler can be used by userspace to catch shader exceptions like divide by zero, memory violations etc.

Re: amdgpu: call trace introduced in 5.9-rc1 for Lenovo L14 Renoir

2020-09-23 Thread Dirk Gouders
Dirk Gouders writes: > Hi, > > I noticed a call trace (attached) when starting my machine (ThinkPad > L14). This machine is new and I am still working on it's > configuration but visually noticeable is that scrolling in xterms with > SHIFT-PgUp/PgDn is broken. Using the mouse wheel works. > >

Re: [PATCH v3 03/22] drm/etnaviv: Introduce GEM object functions

2020-09-23 Thread Lucas Stach
On Mi, 2020-09-23 at 12:21 +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in etnaviv. The only exception is gem_prime_mmap, > which is

Re: [PATCH v2] drm/amdgpu: add support for user trap handlers

2020-09-23 Thread Christian König
Am 23.09.20 um 14:52 schrieb Samuel Pitoiset: On 8/28/20 10:23 AM, Christian König wrote: Am 28.08.20 um 10:14 schrieb Samuel Pitoiset: On 8/28/20 9:57 AM, Christian König wrote: Am 25.08.20 um 16:07 schrieb Samuel Pitoiset: A trap handler can be used by userspace to catch shader

Re: [PATCH v2] Add PP_FEATURE_MASK comments

2020-09-23 Thread Luben Tuikov
On 2020-09-22 11:55, Ryan Taylor wrote: > Documents PP_FEATURE_MASK enum. > Provides instructions on how to use ppfeaturemasks. > > v2: Improved enum definitions. Adds kernel command line > parameters to ppfeaturemask instructions. > > Signed-off-by: Ryan Taylor > Reviewed-by: Alex Deucher

[PATCH 2/2] drm/amdgpu: add an auto setting to the noretry parameter

2020-09-23 Thread Alex Deucher
This allows us to set different defaults on a per asic basis. This way we can enable noretry on dGPUs where it can increase performance in certain cases and disable it on chips where it can be problematic. For now the default is 0 for all asics, but we may want to try and enable it again for

Re: [PATCH 2/2] drm/amdgpu: add an auto setting to the noretry parameter

2020-09-23 Thread Luben Tuikov
Series is Reviewed-by: Luben Tuikov This is a good change! Regards, Luben On 2020-09-23 10:08, Alex Deucher wrote: > This allows us to set different defaults on a per asic basis. This > way we can enable noretry on dGPUs where it can increase performance > in certain cases and disable it on

[PATCH 1/2] drm/amdgpu: store noretry parameter per driver instance

2020-09-23 Thread Alex Deucher
This will allow us to have different defaults per asic in a future patch. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 7 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++

Re: [PATCH v3 00/22] Convert all remaining drivers to GEM object functions

2020-09-23 Thread Christian König
Feel free to add an Acked-by: Christian König to all patches which I haven't explicitly reviewed. I would say we should just push this to drm-misc-next now. Thanks for the nice cleanup, Christian. Am 23.09.20 um 12:21 schrieb Thomas Zimmermann: The GEM and PRIME related callbacks in struct

Re: [PATCH v2] Add PP_FEATURE_MASK comments

2020-09-23 Thread Luben Tuikov
On 2020-09-23 12:31, Ryan Taylor wrote: > Thanks Luben, > > I'll make these revisions and try out Git's patch version setting. Well, Git's own patch revision command line option (-v of git-format-patch) would put it in the "[PATCH v] Title text" as you had it here, and I'd presumed that you'd

Re: [PATCH v2] Add PP_FEATURE_MASK comments

2020-09-23 Thread Ryan Taylor
I see, I'll add it to the end next time then. Ryan On 9/23/20 10:13 AM, Luben Tuikov wrote: > On 2020-09-23 12:31, Ryan Taylor wrote: >> Thanks Luben, >> >> I'll make these revisions and try out Git's patch version setting. > > Well, Git's own patch revision command line option (-v of

Re: amdgpu: call trace introduced in 5.9-rc1 for Lenovo L14 Renoir

2020-09-23 Thread Alex Deucher
On Wed, Sep 23, 2020 at 8:54 AM Dirk Gouders wrote: > > Dirk Gouders writes: > > > Hi, > > > > I noticed a call trace (attached) when starting my machine (ThinkPad > > L14). This machine is new and I am still working on it's > > configuration but visually noticeable is that scrolling in xterms

RE: [PATCH 1/3] drm/amd/amdgpu: Prepare implementation to support reporting of CU usage

2020-09-23 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Reviewed-By: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Ramesh Errabolu Sent: Thursday, September 17, 2020 1:10 PM To: amd-gfx@lists.freedesktop.org Cc: Errabolu, Ramesh Subject: [PATCH 1/3]

Re: [PATCH v2] Add PP_FEATURE_MASK comments

2020-09-23 Thread Ryan Taylor
Thanks Luben, I'll make these revisions and try out Git's patch version setting. Best, Ryan On 9/23/20 7:40 AM, Luben Tuikov wrote: > On 2020-09-22 11:55, Ryan Taylor wrote: >> Documents PP_FEATURE_MASK enum. >> Provides instructions on how to use ppfeaturemasks. >> >> v2: Improved enum

[PATCH] drm/include: add PP_FEATURE_MASK comments (v3)

2020-09-23 Thread Ryan Taylor
Documents PP_FEATURE_MASK enum. Provides instructions on how to use ppfeaturemasks. v2: improve enum definitions and add kernel command line parameters to ppfeaturemask instructions v3: fix alignment issues Signed-off-by: Ryan Taylor Reviewed-by: Alex Deucher ---

Re: amdgpu: call trace introduced in 5.9-rc1 for Lenovo L14 Renoir

2020-09-23 Thread Dirk Gouders
Alex Deucher writes: > On Wed, Sep 23, 2020 at 8:54 AM Dirk Gouders wrote: >> >> Dirk Gouders writes: >> >> > Hi, >> > >> > I noticed a call trace (attached) when starting my machine (ThinkPad >> > L14). This machine is new and I am still working on it's >> > configuration but visually

[PATCH 2/3] drm/amdgpu: add per device user friendly xgmi events for vega20

2020-09-23 Thread Jonathan Kim
Non-outbound data metrics are non useful so mark them as legacy. Bucket new perf counters into device and not device ip. Bind events to chip instead of IP. Report available event counters and not number of hw counter banks. Move DF public macros to private since not needed outside of IP version.

[PATCH 1/3] drm/amdgpu: fix xgmi perfmon a-b-a problem

2020-09-23 Thread Jonathan Kim
Mapping hw counters per event config will cause ABA problems so map per event instead. v2: Discontinue starting perf counters if add fails. Make it clear what's happening with pmc_start. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_df.h | 6 +-

[PATCH 3/3] drm/amdgpu: add xgmi perfmons for arcturus

2020-09-23 Thread Jonathan Kim
Add xgmi perfmons for Arcturus. Signed-off-by: Jonathan Kim v3: Align with patch 2 streamlining perf types versus event config types. v2: Resend for re-review with alignment for v3 in patch 2. --- drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c | 43 +

RE: [PATCH 2/2] drm/amd: Skip not used microcode loading in SRIOV

2020-09-23 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] Series is Reviewed-by: Emily.Deng >-Original Message- >From: amd-gfx On Behalf Of >Jingwen Chen >Sent: Wednesday, September 23, 2020 6:07 PM >To: amd-gfx@lists.freedesktop.org >Cc: Chen, JingWen >Subject: [PATCH 2/2] drm/amd: Skip

Re: amdgpu: call trace introduced in 5.9-rc1 for Lenovo L14 Renoir

2020-09-23 Thread Dirk Gouders
Dirk Gouders writes: > Alex Deucher writes: > >> On Wed, Sep 23, 2020 at 8:54 AM Dirk Gouders wrote: >>> >>> Dirk Gouders writes: >>> >>> > Hi, >>> > >>> > I noticed a call trace (attached) when starting my machine (ThinkPad >>> > L14). This machine is new and I am still working on it's >>>

[PATCH] drm/amdgpu: Remove some useless code

2020-09-23 Thread Emily . Deng
Signed-off-by: Emily.Deng Change-Id: I1a14dcc6f2d5395b2c385f4f290494ce7de108b4 --- drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c| 5 - drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 5 - drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h | 13 -

回复: [PATCH] drm/amdgpu: Remove some useless code

2020-09-23 Thread Min, Frank
This patch is Reviewed-by: Frank Min -邮件原件- 发件人: amd-gfx 代表 Emily.Deng 发送时间: 2020年9月24日 12:10 收件人: amd-gfx@lists.freedesktop.org 抄送: Deng, Emily 主题: [PATCH] drm/amdgpu: Remove some useless code Signed-off-by: Emily.Deng Change-Id: I1a14dcc6f2d5395b2c385f4f290494ce7de108b4 ---

Re: [PATCH v3 07/22] drm/imx/dcss: Initialize DRM driver instance with CMA helper macro

2020-09-23 Thread Laurentiu Palcu
Hi Thomas, On Wed, Sep 23, 2020 at 12:21:44PM +0200, Thomas Zimmermann wrote: > The i.MX DCSS driver uses CMA helpers with default callback functions. > Initialize the driver structure with the rsp CMA helper macro. The > driver is being converted to use GEM object functions as part of > this

RE: [PATCH] drm/amd/display: fix return value check for hdcp_work

2020-09-23 Thread Xu, Feifei
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Feifei Xu -Original Message- From: amd-gfx On Behalf Of Flora Cui Sent: Wednesday, September 23, 2020 2:54 PM To: amd-gfx@lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH] drm/amd/display: fix return value check for

[PATCH] drm/amd/display: fix return value check for hdcp_work

2020-09-23 Thread Flora Cui
max_caps might be 0, thus hdcp_work might be ZERO_SIZE_PTR Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c

[PATCH -next] drm/amd/display: Remove set but not used variable

2020-09-23 Thread Li Heng
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/amd/display/dc/dcn30/dcn30_afmt.c: warning: variable speakers set but not used Reported-by: Hulk Robot Signed-off-by: Li Heng --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_afmt.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 2/2] drm/amd: Skip not used microcode loading in SRIOV

2020-09-23 Thread Jingwen Chen
smc, sdma, sos, ta and asd fw is not used in SRIOV. Skip them to accelerate sw_init for navi12. v2: skip above fw in SRIOV for vega10 and sienna_cichlid v3: directly skip psp fw loading in SRIOV Signed-off-by: Jingwen Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 10 ++

[PATCH 1/2] drm/amd/pm: Skip use smc fw data in SRIOV

2020-09-23 Thread Jingwen Chen
smc fw is not needed in SRIOV, thus driver should not try to get smc fw data. Signed-off-by: Jingwen Chen --- .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c| 61 ++- 1 file changed, 32 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c

[PATCH v3 00/22] Convert all remaining drivers to GEM object functions

2020-09-23 Thread Thomas Zimmermann
The GEM and PRIME related callbacks in struct drm_driver are deprecated in favor of GEM object functions in struct drm_gem_object_funcs. This patchset converts the remaining drivers to object functions and removes most of the obsolete interfaces. Version 3 of this patchset mostly fixes

[PATCH v3 16/22] drm/vc4: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in vc4. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by: Eric

[PATCH v3 03/22] drm/etnaviv: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in etnaviv. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by:

[PATCH v3 06/22] drm/i915: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in i915. v2: * move object-function instance to i915_gem_object.c (Jani) Signed-off-by: Thomas Zimmermann Reviewed-by: Tvrtko

[PATCH v3 14/22] drm/rockchip: Convert to drm_gem_object_funcs

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in rockchip. The only exception is gem_prime_mmap, which is non-trivial to convert. v3: * update documentation Signed-off-by:

[PATCH v3 12/22] drm/pl111: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in pl111. The only exception is gem_prime_mmap, which is non-trivial to convert. v2: * use

[PATCH v3 18/22] drm/virtgpu: Set PRIME export function in struct drm_gem_object_funcs

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces virtgpu's per-driver PRIME export function with a per-object function. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.c| 1 -

[PATCH v3 09/22] drm/msm: Introduce GEM object funcs

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in msm. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel

[PATCH v3 17/22] drm/vgem: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in vgem. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by: Melissa

[PATCH v3 05/22] drm/gma500: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in gma500. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/gma500/framebuffer.c | 2 ++

[PATCH v3 11/22] drm/omapdrm: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in omapdrm. v2: * make omap_gem_free_object() static (Tomi) Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart

[PATCH v3 13/22] drm/radeon: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in radeon. v2: * move object-function instance to radeon_gem.c (Christian) * set callbacks in

[PATCH v3 08/22] drm/mediatek: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in mediatek. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by:

[PATCH v3 07/22] drm/imx/dcss: Initialize DRM driver instance with CMA helper macro

2020-09-23 Thread Thomas Zimmermann
The i.MX DCSS driver uses CMA helpers with default callback functions. Initialize the driver structure with the rsp CMA helper macro. The driver is being converted to use GEM object functions as part of this change. Two callbacks, .gem_prime_export and .gem_prime_import, were initialized to their

[PATCH v3 19/22] drm/vkms: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in vkms. Signed-off-by: Thomas Zimmermann Reviewed-by: Melissa Wen --- drivers/gpu/drm/vkms/vkms_drv.c | 8

[PATCH v3 20/22] drm/xen: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in xen. The only exception is gem_prime_mmap, which is non-trivial to convert. v2: * convert xen_drm_drv_free_object_unlocked()

[PATCH v3 22/22] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver

2020-09-23 Thread Thomas Zimmermann
Several GEM and PRIME callbacks have been deprecated in favor of per-instance GEM object functions. Remove the callbacks as they are now unused. The only exception is .gem_prime_mmap, which is still in use by several drivers. What is also gone is gem_vm_ops in struct drm_driver. All drivers now

[PATCH v3 21/22] drm/xlnx: Initialize DRM driver instance with CMA helper macro

2020-09-23 Thread Thomas Zimmermann
The xlnx driver uses CMA helpers with default callback functions. Initialize the driver structure with the rsp CMA helper macro. The driver is being converted to use GEM object functions as part of this change. Two callbacks, .dumb_destroy and .gem_prime_import, were initialized to their default

[PATCH v3 15/22] drm/tegra: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in tegra. Signed-off-by: Thomas Zimmermann Acked-by: Thierry Reding --- drivers/gpu/drm/tegra/drm.c | 4

[PATCH v3 02/22] drm/armada: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in armada. Signed-off-by: Thomas Zimmermann Acked-by: Russell King --- drivers/gpu/drm/armada/armada_drv.c | 3 ---

[PATCH v3 04/22] drm/exynos: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in exynos. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel

[PATCH v3 10/22] drm/nouveau: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in nouveau. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/nouveau/nouveau_drm.c | 9 -

[PATCH v3 01/22] drm/amdgpu: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in amdgpu. The only exception is gem_prime_mmap, which is non-trivial to convert. v3: * remove amdgpu_object.c from patch