[PATCH] drm: amd: display: Fix memory leakage

2022-11-30 Thread Konstantin Meskhidze
This commit fixes memory leakage in dc_construct_ctx() function. Signed-off-by: Konstantin Meskhidze --- drivers/gpu/drm/amd/display/dc/core/dc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index 997ab03

[PATCH] drm/amdgpu: Add nv mailbox irq in soc21

2022-11-30 Thread YuBiao Wang
Under virtualization guest needs to receive notification from host to perform reset in some cases. Add nv mailbox irq in soc21. Signed-off-by: YuBiao Wang --- drivers/gpu/drm/amd/amdgpu/soc21.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

Re: [PATCH v3 0/2] drm: Add GPU reset sysfs

2022-11-30 Thread Daniel Vetter
On Fri, Nov 25, 2022 at 02:52:01PM -0300, André Almeida wrote: > This patchset adds a udev event for DRM device's resets. > > Userspace apps can trigger GPU resets by misuse of graphical APIs or driver > bugs. Either way, the GPU reset might lead the system to a broken state[1], > that > might be

Re: [Intel-gfx] [PATCH 7/9] drm/i915: stop using ttm_bo_wait

2022-11-30 Thread Tvrtko Ursulin
On 29/11/2022 18:05, Matthew Auld wrote: On Fri, 25 Nov 2022 at 11:14, Tvrtko Ursulin wrote: + Matt On 25/11/2022 10:21, Christian König wrote: TTM is just wrapping core DMA functionality here, remove the mid-layer. No functional change. Signed-off-by: Christian König --- drivers/gpu

RE: [PATCH] drm/amdgpu: Add nv mailbox irq in soc21

2022-11-30 Thread Zhang, Hawking
[AMD Official Use Only - General] I assume the offset, as well as field, of MAILBOX_INT_CNTL register, and the mailbox irq source in soc21 adapters kept the same as the ones in navi1x. With that confirmed, the change is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- F

Re: [Intel-gfx] [PATCH 7/9] drm/i915: stop using ttm_bo_wait

2022-11-30 Thread Daniel Vetter
On Wed, 30 Nov 2022 at 14:03, Tvrtko Ursulin wrote: > On 29/11/2022 18:05, Matthew Auld wrote: > > On Fri, 25 Nov 2022 at 11:14, Tvrtko Ursulin > > wrote: > >> > >> > >> + Matt > >> > >> On 25/11/2022 10:21, Christian König wrote: > >>> TTM is just wrapping core DMA functionality here, remove the

Re: Screen corruption using radeon kernel driver

2022-11-30 Thread Robin Murphy
On 2022-11-29 17:11, Mikhail Krylov wrote: On Tue, Nov 29, 2022 at 11:05:28AM -0500, Alex Deucher wrote: On Tue, Nov 29, 2022 at 10:59 AM Mikhail Krylov wrote: On Tue, Nov 29, 2022 at 09:44:19AM -0500, Alex Deucher wrote: On Mon, Nov 28, 2022 at 3:48 PM Mikhail Krylov wrote: On Mon, Nov 2

Re: Screen corruption using radeon kernel driver

2022-11-30 Thread Alex Deucher
On Wed, Nov 30, 2022 at 7:54 AM Robin Murphy wrote: > > On 2022-11-29 17:11, Mikhail Krylov wrote: > > On Tue, Nov 29, 2022 at 11:05:28AM -0500, Alex Deucher wrote: > >> On Tue, Nov 29, 2022 at 10:59 AM Mikhail Krylov wrote: > >>> > >>> On Tue, Nov 29, 2022 at 09:44:19AM -0500, Alex Deucher wrote

[PATCH 2/2] umr: Get rid of unused variable warning

2022-11-30 Thread Luben Tuikov
Get rid of unused variable ‘limit_ptr’ warning. Cc: Tom StDenis Signed-off-by: Luben Tuikov --- src/app/server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/server.c b/src/app/server.c index 07fa42425765af..e1966b426b1775 100644 --- a/src/app/server.c +++ b/src/a

[PATCH 1/2] umr: Convert the last underscored parameters to dash

2022-11-30 Thread Luben Tuikov
Convert --vm_partition and --vbios_info, to --vm-partition and --vbios-info, respectively. The old underscored versions are still supported and understood, however not suggested in shell completion or printed in the help menu. Now, for instance, completion on --vm looks much better. Cc: Tom StDe

Re: [PATCH v3 0/2] drm: Add GPU reset sysfs

2022-11-30 Thread André Almeida
On 11/28/22 06:30, Simon Ser wrote: The PID is racy, the user-space daemon could end up killing an unrelated process… Is there any way we could use a pidfd instead? Is the PID race condition something that really happens or rather something theoretical? Anyway, I can't see how pidfd and ueve

Re: [PATCH v3 0/2] drm: Add GPU reset sysfs

2022-11-30 Thread Simon Ser
On Wednesday, November 30th, 2022 at 16:23, André Almeida wrote: > On 11/28/22 06:30, Simon Ser wrote: > > > The PID is racy, the user-space daemon could end up killing an > > unrelated process… Is there any way we could use a pidfd instead? > > Is the PID race condition something that really

[PATCH] umr: Fix a couple of options in the help output

2022-11-30 Thread Luben Tuikov
The man page was updated in the listed changes below, but the help output was forgotten. Cc: Tom StDenis Fixes: 04393f2a68fd88 ("umr: Add support for "--ppt-read"") Fixes: dc5efe99e19028 ("umr: Add command line support for "--gpu-metrics"") Signed-off-by: Luben Tuikov --- src/app/main.c | 4 ++-

Re: Screen corruption using radeon kernel driver

2022-11-30 Thread Robin Murphy
On 2022-11-30 14:28, Alex Deucher wrote: On Wed, Nov 30, 2022 at 7:54 AM Robin Murphy wrote: On 2022-11-29 17:11, Mikhail Krylov wrote: On Tue, Nov 29, 2022 at 11:05:28AM -0500, Alex Deucher wrote: On Tue, Nov 29, 2022 at 10:59 AM Mikhail Krylov wrote: On Tue, Nov 29, 2022 at 09:44:19AM -

Re: Screen corruption using radeon kernel driver

2022-11-30 Thread Alex Deucher
On Wed, Nov 30, 2022 at 10:42 AM Robin Murphy wrote: > > On 2022-11-30 14:28, Alex Deucher wrote: > > On Wed, Nov 30, 2022 at 7:54 AM Robin Murphy wrote: > >> > >> On 2022-11-29 17:11, Mikhail Krylov wrote: > >>> On Tue, Nov 29, 2022 at 11:05:28AM -0500, Alex Deucher wrote: > On Tue, Nov 29,

[linux-next:master] BUILD REGRESSION 700e0cd3a5ce6a2cb90d9a2aab729b52f092a7d6

2022-11-30 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 700e0cd3a5ce6a2cb90d9a2aab729b52f092a7d6 Add linux-next specific files for 20221130 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202211090634.ryfkk0ws-...@intel.com https

Re: Screen corruption using radeon kernel driver

2022-11-30 Thread Mikhail Krylov
On Wed, Nov 30, 2022 at 11:07:32AM -0500, Alex Deucher wrote: > On Wed, Nov 30, 2022 at 10:42 AM Robin Murphy wrote: > > > > On 2022-11-30 14:28, Alex Deucher wrote: > > > On Wed, Nov 30, 2022 at 7:54 AM Robin Murphy wrote: > > >> > > >> On 2022-11-29 17:11, Mikhail Krylov wrote: > > >>> On Tue,

Re: [PATCH 27/29] drm/amdkfd: add debug queue snapshot operation

2022-11-30 Thread Felix Kuehling
On 2022-10-31 12:23, Jonathan Kim wrote: Allow the debugger to get a snapshot of a specified number of queues containing various queue property information that is copied to the debugger. Since the debugger doesn't know how many queues exist at any given time, allow the debugger to pass the re

Re: [PATCH 28/29] drm/amdkfd: add debug device snapshot operation

2022-11-30 Thread Felix Kuehling
On 2022-10-31 12:23, Jonathan Kim wrote: Similar to queue snapshot, return an array of device information using an entry_size check and return. Unlike queue snapshots, the debugger needs to pass to correct number of devices that exist. If it fails to do so, the KFD will return the number of actu

Re: [PATCH 29/29] drm/amdkfd: bump kfd ioctl minor version for debug api availability

2022-11-30 Thread Felix Kuehling
On 2022-10-31 12:23, Jonathan Kim wrote: Bump the minor version to declare debugging capability is now available. Signed-off-by: Jonathan Kim Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 1 - include/uapi/linux/kfd_ioctl.h | 3 ++- 2 files chang

Re: [PATCH 21/29] drm/amdkfd: add debug wave launch mode operation

2022-11-30 Thread Felix Kuehling
On 2022-10-31 12:23, Jonathan Kim wrote: Allow the debugger to set wave behaviour on to either normally operate, halt at launch, trap on every instruction, terminate immediately or stall on allocation. Signed-off-by: Jonathan Kim --- .../drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c | 18 ++

Re: [PATCH 04/29] drm/amdgpu: add kgd hw debug mode setting interface

2022-11-30 Thread Felix Kuehling
On 2022-10-31 12:23, Jonathan Kim wrote: Introduce the require KGD debug calls that will execute hardware debug mode setting. Signed-off-by: Jonathan Kim Reviewed-by: Felix Kuehling --- .../gpu/drm/amd/include/kgd_kfd_interface.h | 34 +++ 1 file changed, 34 insertion

Re: [PATCH 05/29] drm/amdgpu: setup hw debug registers on driver initialization

2022-11-30 Thread Felix Kuehling
On 2022-11-22 18:38, Felix Kuehling wrote: On 2022-10-31 12:23, Jonathan Kim wrote: Add missing debug trap registers references and initialize all debug registers on boot by clearing the hardware exception overrides and the wave allocation ID index. For debug devices that only support single

Re: [PATCH 05/29] drm/amdgpu: setup hw debug registers on driver initialization

2022-11-30 Thread Felix Kuehling
On 2022-10-31 12:23, Jonathan Kim wrote: Add missing debug trap registers references and initialize all debug registers on boot by clearing the hardware exception overrides and the wave allocation ID index. For debug devices that only support single process debugging, enable trap temporary set

[PATCH] drm/amdgpu: use sysfs_emit() to instead of scnprintf()

2022-11-30 Thread ye.xingchen
From: ye xingchen Replace the open-code with sysfs_emit() to simplify the code. Signed-off-by: ye xingchen --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgp

RE: [PATCH] drm/amd/display: use the proper fb offset for DM

2022-11-30 Thread Huang, Ray
[AMD Official Use Only - General] Reviewed-by: Huang Rui -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, November 30, 2022 2:17 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amd/display: use the proper fb offset for DM Thi

[PATCH] drm/amdgpu/sdma_v4_0: turn off SDMA ring buffer in the s2idle suspend

2022-11-30 Thread Prike Liang
In the SDMA s0ix save process requires to turn off SDMA ring buffer for avoiding the SDMA in-flight request, otherwise will suffer from SDMA page fault which causes by page request from in-flight SDMA ring accessing at SDMA restore phase. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2248

Re: [PATCH] drm/amdgpu/sdma_v4_0: turn off SDMA ring buffer in the s2idle suspend

2022-11-30 Thread Lazar, Lijo
On 12/1/2022 11:52 AM, Prike Liang wrote: In the SDMA s0ix save process requires to turn off SDMA ring buffer for avoiding the SDMA in-flight request, otherwise will suffer from SDMA page fault which causes by page request from in-flight SDMA ring accessing at SDMA restore phase. Link: https:

RE: [PATCH] drm/amdgpu/sdma_v4_0: turn off SDMA ring buffer in the s2idle suspend

2022-11-30 Thread Liang, Prike
[Public] -Original Message- From: Lazar, Lijo Sent: Thursday, December 1, 2022 2:39 PM To: Liang, Prike ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Limonciello, Mario ; sta...@vger.kernel.org Subject: Re: [PATCH] drm/amdgpu/sdma_v4_0: turn off SDMA ring buffer in the s2idle

Re: [PATCH] drm/amdgpu/sdma_v4_0: turn off SDMA ring buffer in the s2idle suspend

2022-11-30 Thread Lazar, Lijo
On 12/1/2022 12:52 PM, Liang, Prike wrote: [Public] -Original Message- From: Lazar, Lijo Sent: Thursday, December 1, 2022 2:39 PM To: Liang, Prike ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Limonciello, Mario ; sta...@vger.kernel.org Subject: Re: [PATCH] drm/amdgpu/sdm

[PATCH v2] drm/amdgpu/sdma_v4_0: turn off SDMA ring buffer in the s2idle suspend

2022-11-30 Thread Prike Liang
In the SDMA s0ix save process requires to turn off SDMA ring buffer for avoiding the SDMA in-flight request, otherwise will suffer from SDMA page fault which causes by page request from in-flight SDMA ring accessing at SDMA restore phase. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2248