Re: [PATCH 4/4] drm/amdgpu: MCBP based on DRM scheduler (v9)

2022-12-01 Thread Luben Tuikov
On 2022-11-29 02:10, jiadong@amd.com wrote: > From: "Jiadong.Zhu" > > Trigger Mid-Command Buffer Preemption according to the priority of the > software > rings and the hw fence signalling condition. > > The muxer saves the locations of the indirect buffer frames from the software > ring

Re: [PATCH 3/4] drm/amdgpu: Modify unmap_queue format for gfx9 (v6)

2022-12-01 Thread Luben Tuikov
The flags have been refactored--good. Acked-by: Luben Tuikov On 2022-11-29 02:10, jiadong@amd.com wrote: > From: "Jiadong.Zhu" > > 1. Modify the unmap_queue package on gfx9. Add trailing fence to track the >preemption done. > 2. Modify emit_ce_meta emit_de_meta functions for the

Re: [PATCH 2/2] drm/amdgpu: expand on GPUVM documentation

2022-12-01 Thread Luben Tuikov
Reviewed-by: Luben Tuikov Regards, Luben On 2022-12-01 16:41, Alex Deucher wrote: > Expand the GPUVM documentation to better describe the > hardware functionality and use cases it serves. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 41

Re: [PATCH] drm/amdgpu: add GART, GPUVM, and GTT to glossary

2022-12-01 Thread Alex Deucher
On Thu, Dec 1, 2022 at 12:20 PM Luben Tuikov wrote: > > On 2022-12-01 11:23, Alex Deucher wrote: > > Add definitions to clarify GPU virtual memory. > > > > Suggested-by: Peter Maucher > > Signed-off-by: Alex Deucher > > --- > > Documentation/gpu/amdgpu/amdgpu-glossary.rst | 21

Re: [PATCH 2/3] drm/amdgpu: add GART and GTT to glossary

2022-12-01 Thread Felix Kuehling
On 2022-12-01 10:38, Peter Maucher wrote: GART and GTT are two abbreviations that should be mentioned in the glossary. Signed-off-by: Peter Maucher --- Documentation/gpu/amdgpu/amdgpu-glossary.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git

[pull] amdgpu drm-fixes-6.1

2022-12-01 Thread Alex Deucher
Hi Dave, Daniel, Just one last fix for 6.1. The following changes since commit b7b275e60bcd5f89771e865a8239325f86d9927d: Linux 6.1-rc7 (2022-11-27 13:31:48 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.1-2022-12-01 for

[PATCH 2/2] drm/amdgpu: expand on GPUVM documentation

2022-12-01 Thread Alex Deucher
Expand the GPUVM documentation to better describe the hardware functionality and use cases it serves. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 41 +++--- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git

[PATCH 1/2] drm/amdgpu: add GART, GPUVM, and GTT to glossary

2022-12-01 Thread Alex Deucher
Add definitions to clarify GPU virtual memory. v2: clarify the terms a bit more Reviewed-by: Luben Tuikov Suggested-by: Peter Maucher Signed-off-by: Alex Deucher --- Documentation/gpu/amdgpu/amdgpu-glossary.rst | 23 1 file changed, 23 insertions(+) diff --git

Re: [PATCH 3/3] drm/amdgpu: mention RDNA support in docu

2022-12-01 Thread Felix Kuehling
On 2022-12-01 10:38, Peter Maucher wrote: The amdgpu kernel module has supported RDNA for a while, mention that in the module description. Signed-off-by: Peter Maucher --- Documentation/gpu/amdgpu/index.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 4/4] drm/amdgpu: MCBP based on DRM scheduler (v9)

2022-12-01 Thread jiadong.zhu
From: "Jiadong.Zhu" Trigger Mid-Command Buffer Preemption according to the priority of the software rings and the hw fence signalling condition. The muxer saves the locations of the indirect buffer frames from the software ring together with the fence sequence number in its fifo queue, and pops

Re: Screen corruption using radeon kernel driver

2022-12-01 Thread Alex Deucher
On Thu, Dec 1, 2022 at 9:01 AM Robin Murphy wrote: > > On 2022-11-30 19:59, Mikhail Krylov wrote: > > On Wed, Nov 30, 2022 at 11:07:32AM -0500, Alex Deucher wrote: > >> On Wed, Nov 30, 2022 at 10:42 AM Robin Murphy wrote: > >>> > >>> On 2022-11-30 14:28, Alex Deucher wrote: > On Wed, Nov

Re: Screen corruption using radeon kernel driver

2022-12-01 Thread Robin Murphy
On 2022-11-30 19:59, Mikhail Krylov wrote: On Wed, Nov 30, 2022 at 11:07:32AM -0500, Alex Deucher wrote: On Wed, Nov 30, 2022 at 10:42 AM Robin Murphy wrote: On 2022-11-30 14:28, Alex Deucher wrote: On Wed, Nov 30, 2022 at 7:54 AM Robin Murphy wrote: On 2022-11-29 17:11, Mikhail Krylov

Re: [PATCH v2] drm/amdgpu/sdma_v4_0: turn off SDMA ring buffer in the s2idle suspend

2022-12-01 Thread Alex Deucher
On Thu, Dec 1, 2022 at 2:56 AM Prike Liang wrote: > > In the SDMA s0ix save process requires to turn off SDMA ring buffer for > avoiding the SDMA in-flight request, otherwise will suffer from SDMA page > fault which causes by page request from in-flight SDMA ring accessing at > SDMA restore

Re: [PATCH v2] drm/amdgpu/sdma_v4_0: turn off SDMA ring buffer in the s2idle suspend

2022-12-01 Thread Limonciello, Mario
On 12/1/2022 07:39, Alex Deucher wrote: On Thu, Dec 1, 2022 at 2:56 AM Prike Liang wrote: In the SDMA s0ix save process requires to turn off SDMA ring buffer for avoiding the SDMA in-flight request, otherwise will suffer from SDMA page fault which causes by page request from in-flight SDMA

Re: Screen corruption using radeon kernel driver

2022-12-01 Thread Mikhail Krylov
On Thu, Dec 01, 2022 at 02:00:58PM +, Robin Murphy wrote: > On 2022-11-30 19:59, Mikhail Krylov wrote: > > On Wed, Nov 30, 2022 at 11:07:32AM -0500, Alex Deucher wrote: > > > On Wed, Nov 30, 2022 at 10:42 AM Robin Murphy > > > wrote: > > > > > > > > On 2022-11-30 14:28, Alex Deucher wrote:

Re: [PATCH 0/3] amdgpu/drm: Documentation updates

2022-12-01 Thread Alex Deucher
Applied patches 1 and 3. Patch 2 is not exactly correct, I'll send out an improved version of patch 2. Thanks! Alex On Thu, Dec 1, 2022 at 10:38 AM Peter Maucher wrote: > > Explain difference between gttsize and gartsize > module parameters, and amend related documentation. > Also, amdgpu

[linux-next:master] BUILD REGRESSION 2934ceb4e967b9233d0f97732e47175574a11406

2022-12-01 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 2934ceb4e967b9233d0f97732e47175574a11406 Add linux-next specific files for 20221201 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202211041320.coq8eelj-...@intel.com https

[PATCH 1/3] drm/amdgpu: improve GART and GTT documentation

2022-12-01 Thread Peter Maucher
Document difference between amdgpu.gartsize and amdgpu.gttsize module parameters, as initially explained by Alex Deucher here: https://lists.freedesktop.org/archives/dri-devel/2022-October/375358.html Signed-off-by: Peter Maucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 11 ++- 1

[PATCH 0/3] amdgpu/drm: Documentation updates

2022-12-01 Thread Peter Maucher
Explain difference between gttsize and gartsize module parameters, and amend related documentation. Also, amdgpu does support RDNA GPUs. Peter Maucher (3): drm/amdgpu: improve GART and GTT documentation drm/amdgpu: add GART and GTT to glossary drm/amdgpu: mention RDNA support in docu

Re: [PATCH v2] drm/amd/display: add FB_DAMAGE_CLIPS support

2022-12-01 Thread Leo Li
On 11/18/22 16:51, Hamza Mahfooz wrote: Currently, userspace doesn't have a way to communicate selective updates to displays. So, enable support for FB_DAMAGE_CLIPS for DCN ASICs newer than DCN301, convert DRM damage clips to dc dirty rectangles and fill them into dirty_rects in

[PATCH] drm/amdgpu: add GART, GPUVM, and GTT to glossary

2022-12-01 Thread Alex Deucher
Add definitions to clarify GPU virtual memory. Suggested-by: Peter Maucher Signed-off-by: Alex Deucher --- Documentation/gpu/amdgpu/amdgpu-glossary.rst | 21 1 file changed, 21 insertions(+) diff --git a/Documentation/gpu/amdgpu/amdgpu-glossary.rst

[PATCH 2/3] drm/amdgpu: add GART and GTT to glossary

2022-12-01 Thread Peter Maucher
GART and GTT are two abbreviations that should be mentioned in the glossary. Signed-off-by: Peter Maucher --- Documentation/gpu/amdgpu/amdgpu-glossary.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/gpu/amdgpu/amdgpu-glossary.rst

[PATCH 3/3] drm/amdgpu: mention RDNA support in docu

2022-12-01 Thread Peter Maucher
The amdgpu kernel module has supported RDNA for a while, mention that in the module description. Signed-off-by: Peter Maucher --- Documentation/gpu/amdgpu/index.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/gpu/amdgpu/index.rst

Re: [PATCH] drm/amdgpu: use sysfs_emit() to instead of scnprintf()

2022-12-01 Thread Luben Tuikov
Reviewed-by: Luben Tuikov Regards, Luben On 2022-11-30 21:24, ye.xingc...@zte.com.cn wrote: > From: ye xingchen > > Replace the open-code with sysfs_emit() to simplify the code. > > Signed-off-by: ye xingchen > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- > 1 file changed, 1

Re: [PATCH] drm/amdgpu: add GART, GPUVM, and GTT to glossary

2022-12-01 Thread Luben Tuikov
On 2022-12-01 11:23, Alex Deucher wrote: > Add definitions to clarify GPU virtual memory. > > Suggested-by: Peter Maucher > Signed-off-by: Alex Deucher > --- > Documentation/gpu/amdgpu/amdgpu-glossary.rst | 21 > 1 file changed, 21 insertions(+) > > diff --git