Re: [PATCH] drm/amdkfd: Switch over to memdup_user()

://lore.kernel.org/r/20230614020432.44044-1-jiapeng.chong%40linux.alibaba.com patch subject: [PATCH] drm/amdkfd: Switch over to memdup_user() config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230615/202306151407.u4d2amdm-...@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce

[PATCH] drm/amdgpu: Add vbios attribute only if supported

Not all devices carry VBIOS version information. Add the device attribute only if supported. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 9 + drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +

Re: [RFC PATCH v2 00/18] Add DRM CRTC 3D LUT interface

On Thu, 15 Jun 2023 10:07:35 +0200 Jacopo Mondi wrote: > Hi Pekka > thanks for the reply > > On Thu, Jun 15, 2023 at 10:14:05AM +0300, Pekka Paalanen wrote: > > On Tue, 13 Jun 2023 17:43:55 +0200 > > Jacopo Mondi wrote: > > > > > Hello > > > > > >I'm completing the support for 3D LUT

[PATCH] drm/amdgpu: Rename aqua_vanjaram_reg_init.c

This contains SOC specific functions, rename to a more generic format .c => aqua_vanjaram.c Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- .../amd/amdgpu/{aqua_vanjaram_reg_init.c => aqua_vanjaram.c}| 0 2 files changed, 1 insertion(+),

Re: [PATCH] drm/amdgpu/atomfirmware: fix DDR5 width reporting

Ping? On Mon, Jun 12, 2023 at 5:47 PM Alex Deucher wrote: > > Ping? > > On Wed, Jun 7, 2023 at 12:46 PM Alex Deucher > wrote: > > > > DDR5 channels are 32 bit rather than 64, report the width properly > > in the log. > > > > Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2468 > >

Re: [PATCH 3/9] drm/ttm: use per BO cleanup workers

Am 13.06.23 um 16:18 schrieb Karol Herbst: On Tue, Jun 13, 2023 at 3:59 PM Christian König wrote: Am 13.06.23 um 15:05 schrieb Karol Herbst: On Mon, Dec 5, 2022 at 2:40 PM Christian König wrote: Am 29.11.22 um 22:14 schrieb Felix Kuehling: On 2022-11-25 05:21, Christian König wrote:

[PATCH] drm/amdgpu: Skip mark offset for high priority rings

From: Jiadong Zhu Only low priority rings are using chunks to save the offset. Bypass the mark offset callings from high priority rings. Signed-off-by: Jiadong Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring_mux.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: Fw: [PATCH] drm/amdgpu: add amdgpu_timeout_ring_* file to debugfs

On Thu, Jun 15, 2023 at 5:14 AM Christian König wrote: > > Am 15.06.23 um 10:55 schrieb Nicolai Hähnle: > > On Thu, Jun 15, 2023 at 9:47 AM Christian König > > wrote: > Uh, that's very dangerous what you do here and wouldn't work in a whole > bunch of cases. > >>> Please elaborate:

Re: [PATCH] drm/amdgpu: Skip mark offset for high priority rings

Acked-by: Alex Deucher On Thu, Jun 15, 2023 at 7:19 AM wrote: > > From: Jiadong Zhu > > Only low priority rings are using chunks to save the offset. > Bypass the mark offset callings from high priority rings. > > Signed-off-by: Jiadong Zhu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ring_mux.c

Re: [PATCH 3/9] drm/ttm: use per BO cleanup workers

On Thu, Jun 15, 2023 at 1:19 PM Christian König wrote: > > Am 13.06.23 um 16:18 schrieb Karol Herbst: > > On Tue, Jun 13, 2023 at 3:59 PM Christian König > > wrote: > >> Am 13.06.23 um 15:05 schrieb Karol Herbst: > >>> On Mon, Dec 5, 2022 at 2:40 PM Christian König > >>> wrote: > Am

RE: [PATCH] drm/amdgpu: Rename aqua_vanjaram_reg_init.c

[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Thursday, June 15, 2023 18:29 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Ma, Le Subject: [PATCH] drm/amdgpu: Rename

Re: [RFC PATCH v2 00/18] Add DRM CRTC 3D LUT interface

Hi Pekka thanks for the reply On Thu, Jun 15, 2023 at 10:14:05AM +0300, Pekka Paalanen wrote: > On Tue, 13 Jun 2023 17:43:55 +0200 > Jacopo Mondi wrote: > > > Hello > > > >I'm completing the support for 3D LUT on R-Car DU peripheral > > and I have used this series as a base. > > > > I'm

Re: Fw: [PATCH] drm/amdgpu: add amdgpu_timeout_ring_* file to debugfs

Am 14.06.23 um 21:20 schrieb Nicolai Hähnle: Hi Christian, Report the per-ring timeout in milliseconds and allow users to adjust the timeout dynamically. This can be useful for debugging, e.g. to more easily test whether a submission genuinely hangs or is just taking very long, and to

Re: [PATCH 1/2] drm/amdgpu: make sure BOs are locked in amdgpu_vm_get_memory

Am 06.06.23 um 03:11 schrieb Chen, Guchun: [Public] Acked-by: Guchun Chen for this series. A simple question is we don't need to hold the lock if bo locations are not changed? Well we take the look to make sure that BO locations don't change. Otherwise we potentially access freed memory

Re: Fw: [PATCH] drm/amdgpu: add amdgpu_timeout_ring_* file to debugfs

On Thu, Jun 15, 2023 at 9:47 AM Christian König wrote: > >> Uh, that's very dangerous what you do here and wouldn't work in a whole > >> bunch of cases. > > Please elaborate: *what* case doesn't work? > > The core memory management can wait at any time for the GPU reset to finish. > > If we set

Re: [PATCH v7 7/8] drm/amdgpu: Implement the is_boot_device callback function

Hi, Does anyone has the bandwidth to review this? I provide more additional information here, hope it helps. On a non-x86 multiple platform, the discrete AMDGPU fails to override the integrated one. because the PCI BAR 0 of the AMDGPU gets moved. Below is the log of 'dmesg | grep

Re: [PATCH 2/3] drm/amdgpu: Implement new dummy vram manager

Am 14.06.23 um 17:42 schrieb Felix Kuehling: Am 2023-06-14 um 06:38 schrieb Christian König: Am 10.05.23 um 00:01 schrieb Alex Deucher: From: Rajneesh Bhardwaj This adds dummy vram manager to support ASICs that do not have a dedicated or carvedout vram domain. Well that doesn't seem to

Re: [PATCH 1/6] drm/amdgpu/bu: Use legacy TLB flush for gfx943

All those workaround were only to be used during bringup and are not supposed for upstreaming. Especially we probably don't want the module parameter to override the MTYPE used in the VM mappings in a release. Christian. Am 10.05.23 um 19:56 schrieb Alex Deucher: From: Graham Sider

Re: [RFC PATCH v2 00/18] Add DRM CRTC 3D LUT interface

On Tue, 13 Jun 2023 17:43:55 +0200 Jacopo Mondi wrote: > Hello > >I'm completing the support for 3D LUT on R-Car DU peripheral > and I have used this series as a base. > > I'm wondering, since quite some time has passed without any update if > this series is still a thing and it makes any

RE: [PATCH] drm/amdgpu: Add vbios attribute only if supported

[AMD Official Use Only - General] Reviewed-by: Le Ma > -Original Message- > From: amd-gfx On Behalf Of Lijo > Lazar > Sent: Thursday, June 15, 2023 4:56 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Ma, Le > ; Kamal, Asad ; Zhang, Hawking > > Subject: [PATCH]

Re: Fw: [PATCH] drm/amdgpu: add amdgpu_timeout_ring_* file to debugfs

Am 15.06.23 um 10:55 schrieb Nicolai Hähnle: On Thu, Jun 15, 2023 at 9:47 AM Christian König wrote: Uh, that's very dangerous what you do here and wouldn't work in a whole bunch of cases. Please elaborate: *what* case doesn't work? The core memory management can wait at any time for the GPU

Re: [PATCH] drm/amdgpu/atomfirmware: fix LPDDR5 width reporting

[AMD Official Use Only - General] Acked-by: Hawking Zhang Regards, Hawking Get Outlook for iOS From: amd-gfx on behalf of Alex Deucher Sent: Friday, June 16, 2023 6:13:17 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander

[PATCH] drm/amdkfd: set coherent host access capability flag

This flag determines whether the host possesses coherent access to the memory of the device. Signed-off-by: Alex Sierra --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c

[PATCH] drm/amdkfd: set coherent host access capability flag

This flag determines whether the host possesses coherent access to the memory of the device. Signed-off-by: Alex Sierra --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c

Re: [PATCH] drm/amdkfd: set coherent host access capability flag

Am 2023-06-15 um 18:54 schrieb Alex Sierra: This flag determines whether the host possesses coherent access to the memory of the device. Signed-off-by: Alex Sierra --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 4 1 file changed, 4 insertions(+) diff --git

RE: [PATCH] drm/amdkfd: set coherent host access capability flag

[AMD Official Use Only - General] CC: Rajneesh > -Original Message- > From: Sierra Guiza, Alejandro (Alex) > Sent: Thursday, June 15, 2023 5:55 PM > To: amd-gfx@lists.freedesktop.org; Kuehling, Felix > Cc: Yat Sin, David ; Sierra Guiza, Alejandro (Alex) > > Subject: [PATCH]

Re: [PATCH] drm/amdkfd: set coherent host access capability flag

Am 2023-06-16 um 00:29 schrieb Felix Kuehling: Am 2023-06-15 um 18:54 schrieb Alex Sierra: This flag determines whether the host possesses coherent access to the memory of the device. Signed-off-by: Alex Sierra ---   drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 4   1 file changed, 4

[PATCH] drm/amdgpu: enable mcbp by default on gfx9 chips

From: Jiadong Zhu Gfx9 is using software rings which would trigger mcbp in some cases. Thus the parameter amdgpu_mcbp shall be enabled by default. Signed-off-by: Jiadong Zhu --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 2/2] drm/amd/display: disable RCO for DCN314

On 6/14/23 16:42, Hamza Mahfooz wrote: > From: Daniel Miess > > [Why] > RCO is causing error messages on some DCN314 systems > > [How] > Force disable RCO for DCN314 > > Fixes: 0e1961c93839 ("drm/amd/display: Enable dcn314 DPP RCO") > Reviewed-by: Nicholas Kazlauskas > Acked-by: Hamza

[PATCH] drm/amdgpu: mark GC 9.4.3 experimental for now

Mark as experimental for now until we get closer to production to avoid possible undesireable behavior when mixing newer boards with older kernels. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH 2/3] drm/amdgpu: Implement new dummy vram manager

Am 2023-06-15 um 03:37 schrieb Christian König: Am 14.06.23 um 17:42 schrieb Felix Kuehling: Am 2023-06-14 um 06:38 schrieb Christian König: Am 10.05.23 um 00:01 schrieb Alex Deucher: From: Rajneesh Bhardwaj This adds dummy vram manager to support ASICs that do not have a dedicated or

RE: [PATCH] drm/amdgpu/atomfirmware: fix DDR5 width reporting

[AMD Official Use Only - General] Acked-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, June 15, 2023 21:18 To: Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu/atomfirmware: fix DDR5

RE: [PATCH] drm/amdgpu: mark GC 9.4.3 experimental for now

[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, June 15, 2023 22:03 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu: mark GC 9.4.3 experimental

Re: [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

On Wed, Jun 14, 2023 at 6:50 AM Sui Jingfeng wrote: > > Hi, > > On 2023/6/13 11:01, Sui Jingfeng wrote: > > From: Sui Jingfeng > > > > Deal only with the VGA devcie(pdev->class == 0x0300), so replace the > > pci_get_subsys() function with pci_get_class(). Filter the non-PCI display > >

[PATCH] drm/amdgpu/atomfirmware: fix LPDDR5 width reporting

LPDDR5 channels are 32 bit rather than 64, report the width properly in the log. v2: Only LPDDR5 are 32 bits per channel. DDR5 is 64 bits per channel Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2468 Signed-off-by: Alex Deucher --- .../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 18

[PATCH 1/2] drm/amd/pm: revise the ASPM settings for thunderbolt attached scenario

Also, correct the comment for NAVI10_PCIE__LC_L1_INACTIVITY_TBT_DEFAULT as 0x000E stands for 400ms instead of 4ms. Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git

[PATCH 2/2] drm/amd/pm: update the LC_L1_INACTIIVY setting to address possible noise issue

It is proved that insufficient LC_L1_INACTIIVY setting can cause audio noise on some platform. With the LC_L1_INACTIIVY increased to 4ms, the issue can be resolved. Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/2] drm/amdgpu: Move clocks closer to its only usage in amdgpu_parse_cg_state()

After commit a25a9dae2067 ("drm/amd/amdgpu: enable W=1 for amdgpu"), there is an instance of -Wunused-const-variable when CONFIG_DEBUG_FS is disabled: drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_pm.c:38:34: error: unused variable 'clocks' [-Werror,-Wunused-const-variable] 38 | static const

[PATCH 0/2] drm/amdgpu: Fix instances of -Wunused-const-variable with CONFIG_DEBUG_FS=n

| 76 - 2 files changed, 38 insertions(+), 40 deletions(-) --- base-commit: d297eedf83f5af96751c0da1e4355c19244a55a2 change-id: 20230615-amdgpu-wunused-const-variable-wo-debugfs-308ce8e17329 Best regards, -- Nathan Chancellor

[PATCH 1/2] drm/amdgpu: Remove CONFIG_DEBUG_FS guard around body of amdgpu_rap_debugfs_init()

After commit a25a9dae2067 ("drm/amd/amdgpu: enable W=1 for amdgpu"), there is an instance of -Wunused-const-variable when CONFIG_DEBUG_FS is disabled: drivers/gpu/drm/amd/amdgpu/amdgpu_rap.c:110:37: error: unused variable 'amdgpu_rap_debugfs_ops' [-Werror,-Wunused-const-variable] 110 |

Re: [PATCH] amd/display/dc:remove repeating expression

Applied. Thanks! Alex On Wed, Jun 14, 2023 at 1:36 AM Ammar Faizi wrote: > > On 6/14/23 10:49 AM, Wang Ming wrote: > > Identify issues that arise by using the tests/doubletest.cocci > > semantic patch.Need to remove duplicate expression in if statement. > > > > Signed-off-by: Wang Ming > >

Re: [PATCH] drm/amdgpu: remove unneeded variable

On Wed, Jun 14, 2023 at 3:20 AM wrote: > > fix the following coccicheck warning: > > drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c:1156:5-11: > Unneeded variable: "result". > This variable is used and the code fails to compile with it removed. Alex > Signed-off-by: Mingtong Bao >

Re: [PATCH] drm/amd/pm: remove unneeded variable

Applied, but please check your mailer. I had to manually fix this up. Alex On Wed, Jun 14, 2023 at 3:21 AM wrote: > > fix the following coccicheck warning: > > drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c:1657:14-18: Unneeded > variable: "size". > > Signed-off-by: Mingtong Bao > --- >

Re: [PATCH 1/2] drm/amdgpu: Skip TMR for MP0_HWIP 13.0.6

[Public] Series is: Reviewed-by: Alex Deucher From: Luo, Zhigang Sent: Thursday, June 15, 2023 1:49 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Luo, Zhigang Subject: [PATCH 1/2] drm/amdgpu: Skip TMR for MP0_HWIP 13.0.6 For SRIOV VF, no TMR

Re: [PATCH 2/2] drm/amdgpu: Move clocks closer to its only usage in amdgpu_parse_cg_state()

Applied the series. Thanks! Alex On Thu, Jun 15, 2023 at 1:06 PM Nathan Chancellor wrote: > > After commit a25a9dae2067 ("drm/amd/amdgpu: enable W=1 for amdgpu"), > there is an instance of -Wunused-const-variable when CONFIG_DEBUG_FS is > disabled: > >

[PATCH 2/2] drm/amdgpu: port SRIOV VF missed changes

port SRIOV VF missed changes from gfx_v9_0 to gfx_v9_4_3. Signed-off-by: Zhigang Luo Change-Id: Id580820376c8d653e9ec5ebf5a8b950cd0a67e1a --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git

[PATCH 1/2] drm/amdgpu: Skip TMR for MP0_HWIP 13.0.6

For SRIOV VF, no TMR needed. Signed-off-by: Zhigang Luo Change-Id: If9556cf60dfcbd95e102b1387cf233e902d9490e --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c index

Re: [PATCH v9 02/14] mm: move page zone helpers from mm.h to mmzone.h

On Thu, Jun 15, 2023 at 03:33:12PM -0400, Peter Xu wrote: > My question is whether page_zonenum() is ready for taking all kinds of tail > pages? > > Zone device tail pages all look fine, per memmap_init_zone_device(). The > question was other kinds of usual compound pages, like either thp or >

Re: [PATCH v9 02/14] mm: move page zone helpers from mm.h to mmzone.h

Hello, all, On Fri, Jul 15, 2022 at 10:05:09AM -0500, Alex Sierra wrote: > +static inline enum zone_type page_zonenum(const struct page *page) > +{ > + ASSERT_EXCLUSIVE_BITS(page->flags, ZONES_MASK << ZONES_PGSHIFT); > + return (page->flags >> ZONES_PGSHIFT) & ZONES_MASK; > +} Sorry to

[PATCH 4/6] drm/amd/display: Read replay data from sink

Read DP_SINK_PR_PIXEL_DEVIATION_PER_LINE and DP_SINK_PR_MAX_NUMBER_OF_DEVIATION_LINE Signed-off-by: Bhawanpreet Lakha --- .../amd/display/dc/link/protocols/link_dp_capability.c | 10 ++ drivers/gpu/drm/amd/display/include/dpcd_defs.h| 4 +++- 2 files changed, 13 insertions(+),

[PATCH 2/6] drm/amd/display: Add Functions to enable Freesync Panel Replay

Add various functions for replay, such as construct, destroy, enable get_state, and copy_setting etc. These functions communicate with the firmware to setup and enable panel replay Signed-off-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/dce/Makefile | 2 +-

[PATCH 5/6] drm/amd/display: Enable Replay for static screen use cases

- Setup replay config on device init. - Enable replay if feature is enabled and psr is not going to be enabled - Add debug masks to enable replay on supported ASICs Signed-off-by: Bhawanpreet Lakha --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 19 +++

[PATCH 3/6] drm/amd/display: Add Freesync Panel DM code

We need certain conditions for replay to be enabled, so create an interface in DM to enable/disable replay. Signed-off-by: Bhawanpreet Lakha --- .../gpu/drm/amd/display/amdgpu_dm/Makefile| 2 +- .../amd/display/amdgpu_dm/amdgpu_dm_replay.c | 183 ++

[PATCH 6/6] drm/amd/display: Get replay info from VSDB

We need to make sure that the panel supports replay. This info is inside the amd vsdb (vendor specific data block). Create a function to parse the block and read the replay_mode bit. Signed-off-by: Bhawanpreet Lakha --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 37 +++

[PATCH 0/6] Freesync Panel Replay

This patch set introduces Freesync Panel Replay capability on DCN 3.1.4 and newer These patches are enabling panel replay in static screen use-cases. Other use cases will be added as they are ready *Please note that there is a bug I am seeing with these patches where there is a hang after the

[PATCH 1/6] drm/amd/display: Add structs for Freesync Panel Replay

In some instances, the GPU is transmitting repeated frame to the sink without any updates or changes in the content. These repeat transmission are wasteful, resulting in power draw in different aspects of the system 1. DCN is fetching the frame of data from DF/UMC/DRAM. This memory traffic

Re: [PATCH v9 02/14] mm: move page zone helpers from mm.h to mmzone.h

On Thu, Jun 15, 2023 at 09:15:26PM +0100, Matthew Wilcox wrote: > On Thu, Jun 15, 2023 at 03:33:12PM -0400, Peter Xu wrote: > > My question is whether page_zonenum() is ready for taking all kinds of tail > > pages? > > > > Zone device tail pages all look fine, per memmap_init_zone_device(). The