Re: Kernel crash/Null pointer dereference on vblank

2017-11-23 Thread Leo Li
Hi Johannes, The s3 resume issue looks to be a problem with amdgpu/display. Could you give the attached patch a try? Thanks, Leo On 2017-11-23 07:27 AM, Johannes Hirte wrote: On 2017 Nov 23, Chunming Zhou wrote: See the attached email, they fixed same issue, each of them is ok to fix your

Re: [PATCH 20/43] drm/amd/display: Add optimized_required flag

2017-11-29 Thread Leo Li
On 2017-11-23 02:52 PM, Harry Wentland wrote: Signed-off-by: Harry Wentland Reviewed-by: Leo (Sunpeng) Li --- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 ++ drivers/gpu/drm/amd/display/dc/dc.h | 2 ++ 2 files changed, 4 insertions(+)

Re: [PATCH 17/25] drm/amd/display: Do DC mode-change check when adding CRTCs

2017-11-23 Thread Leo Li
On 2017-11-17 11:46 PM, Andrey Grodzovsky wrote: On 2017-11-16 10:32 AM, Harry Wentland wrote: From: "Leo (Sunpeng) Li" Within atomic check, dm_update_crtcs_state is called twice. First to remove from the dc_state, and subsequently to add to it. In both calls, a

Re: [PATCH 38/73] drm/amd/display: Fix warnings on S3 resume

2017-11-14 Thread Leo Li
On 2017-11-10 01:40 PM, Andrey Grodzovsky wrote: On 11/10/2017 01:38 PM, Andrey Grodzovsky wrote: On 11/09/2017 03:05 PM, Harry Wentland wrote: From: "Leo (Sunpeng) Li" This is a followup to the following revert: Rex Zhu    Revert "drm/amd/display: Match actual

Re: [PATCH 56/73] drm/amd/display: Remove dangling planes on dc commit state

2017-11-13 Thread Leo Li
On 2017-11-10 02:00 PM, Andrey Grodzovsky wrote: On 11/09/2017 03:05 PM, Harry Wentland wrote: From: "Leo (Sunpeng) Li" When disabling pipe splitting, we need to make sure we disable both planes used. This should be done for Linux as well. Change-Id:

Re: [PATCH xf86-video-amdgpu 00/13] Enabling Color Management - Round 2

2018-05-14 Thread Leo Li
Ping :) Leo On 2018-05-03 02:31 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" This patchset ended up looking quite different from the first. To address some fundamental issues, the design had to be reworked. Things gathered from previous review: 1. User client

Re: [PATCH xf86-video-amdgpu 10/13] Push staged color properties when DPMS state toggles On

2018-05-24 Thread Leo Li
On 2018-05-18 04:01 AM, Michel Dänzer wrote: On 2018-05-17 11:44 PM, Leo Li wrote: On 2018-05-16 01:10 PM, Michel Dänzer wrote: On 2018-05-03 08:31 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" <sunpeng...@amd.com> This will persist color management properties

Re: [PATCH xf86-video-amdgpu 1/2] Call drmmode_do_crtc_dpms from drmmode_crtc_dpms as well

2018-05-24 Thread Leo Li
On 2018-05-18 06:33 AM, Michel Dänzer wrote: From: Michel Dänzer Leo pointed out that drmmode_do_crtc_dpms wasn't getting called when turning off an output with xrandr --output --off This meant that the vblank sequence number and timestamp wouldn't be saved

Re: [PATCH xf86-video-amdgpu 00/13] Enabling Color Management - Round 2

2018-05-24 Thread Leo Li
On 2018-05-18 04:10 AM, Michel Dänzer wrote: On 2018-05-17 11:43 PM, Leo Li wrote: On 2018-05-16 01:06 PM, Michel Dänzer wrote: On 2018-05-03 08:31 PM, sunpeng...@amd.com wrote: 3. The three color management properties (Degamma LUT, Color Transform Matrix     (CTM), and Gamma LUT

Re: [PATCH xf86-video-amdgpu 10/13] Push staged color properties when DPMS state toggles On

2018-05-17 Thread Leo Li
On 2018-05-16 01:10 PM, Michel Dänzer wrote: On 2018-05-03 08:31 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" This will persist color management properties on a CRTC across DPMS state changes. Signed-off-by: Leo (Sunpeng) Li ---

Re: [PATCH xf86-video-amdgpu 00/13] Enabling Color Management - Round 2

2018-05-17 Thread Leo Li
On 2018-05-16 01:06 PM, Michel Dänzer wrote: On 2018-05-03 08:31 PM, sunpeng...@amd.com wrote: 3. The three color management properties (Degamma LUT, Color Transform Matrix (CTM), and Gamma LUT) are hard-coded into the DDX driver, to be listed (as disabled) regardless of whether a

Re: [PATCH xf86-video-amdgpu 02/13] Push color properties to kernel DRM on CRTC init

2018-05-17 Thread Leo Li
On 2018-05-16 01:08 PM, Michel Dänzer wrote: On 2018-05-03 08:31 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" Push staged values on the driver-private CRTC, to kernel DRM when it's initialized. This is to flush out any previous state that hardware was in, and

Re: [PATCH xf86-video-amdgpu 03/13] List disabled color properties on RandR outputs without a CRTC

2018-05-17 Thread Leo Li
On 2018-05-16 01:09 PM, Michel Dänzer wrote: On 2018-05-03 08:31 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" The properties on an RandR output needs to stay consistent throughout it's lifecycle. However, we cannot list color properties on an output if there is

Re: [PATCH xf86-video-amdgpu 08/13] Set driver-private CRTC's dpms mode on disable

2018-05-17 Thread Leo Li
On 2018-05-16 01:09 PM, Michel Dänzer wrote: On 2018-05-03 08:31 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" The dpms_mode flag on the driver-private CRTC was not being set when it's DPMS state is set to off. This causes some problems when toggling it back on,

Re: [PATCH xf86-video-amdgpu 01/13] Add color management properties to driver-private CRTC object

2018-05-17 Thread Leo Li
On 2018-05-16 01:07 PM, Michel Dänzer wrote: On 2018-05-03 08:31 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" Non-legacy color management consists of 3 properties on the CRTC: Degamma LUT, Color Transformation Matrix (CTM), and Gamma LUT. Add these properties

Re: [PATCH xf86-video-amdgpu 0/7] Enabling Color Management - Round 3

2018-06-14 Thread Leo Li
On 2018-06-14 12:57 PM, Michel Dänzer wrote: Hi Leo, sorry for the delay. Appreciate the review, it's not a small change by any means :) On 2018-06-01 06:03 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" This ended up being different enough from v2 to warrant a new

Re: [PATCH xf86-video-amdgpu 0/7] Enabling Color Management - Round 3

2018-06-07 Thread Leo Li
On 2018-06-06 01:03 PM, Michel Dänzer wrote: On 2018-06-06 06:01 PM, Michel Dänzer wrote: On 2018-06-01 06:03 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" This ended up being different enough from v2 to warrant a new patchset. Per Michel's suggestions, there have been various

Re: [PATCH] drm/amd/display: Fix BUG_ON during CRTC atomic check update

2018-05-28 Thread Leo Li
On 2018-05-28 11:20 AM, Michel Dänzer wrote: On 2018-05-28 05:06 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" For cases where the CRTC is inactive (DPMS off), where a modeset is not required, yet the CRTC is still in the atomic state, we should not attempt to

Re: [PATCH xf86-video-amdgpu 0/7] Enabling Color Management - Round 3

2018-06-06 Thread Leo Li
On 2018-06-06 01:03 PM, Michel Dänzer wrote: On 2018-06-06 06:01 PM, Michel Dänzer wrote: On 2018-06-01 06:03 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" This ended up being different enough from v2 to warrant a new patchset. Per Michel's suggestions, there have been various

Re: DC regression in 4.17 broke suspend to RAM

2018-05-28 Thread Leo Li
On 2018-05-28 05:15 AM, Michel Dänzer wrote: Hi Leo, commit e277adc5a06c "drm/amd/display: Hookup color management functions" broke suspend to RAM on my development system with a Tonga and a Turks (using the radeon driver). It sometimes, but not always happens when trying to suspend from

Re: [bug report] drm/amd/display: Read AUX channel even if only status byte is returned

2018-07-31 Thread Leo Li
On 2018-07-31 02:24 PM, Dan Carpenter wrote: [ Potential security issue, if I'm reading the code correctly. I don't really know the code and I haven't looked at the larger context. -dan ] Hello Leo (Sunpeng) Li, The patch edf6ffe4f47e: "drm/amd/display: Read AUX channel even if only

Re: [PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled

2018-08-16 Thread Leo Li
On 2018-08-11 11:54 AM, Arnd Bergmann wrote: Building the DCN 1.0 Raven display driver with CONFIG_KCOV_INSTRUMENT_ALL=y and CONFIG_KCOV_ENABLE_COMPARISONS=y results in warnings about many functions that do a comparison of floating-point variables:

Re: [PATCH 1/2] Revert "drm/amdgpu/display: Replace CONFIG_DRM_AMD_DC_DCN1_0 with CONFIG_X86"

2018-08-17 Thread Leo Li
On 2018-08-17 03:16 AM, Christian König wrote: Am 16.08.2018 um 21:44 schrieb sunpeng...@amd.com: [SNIP] +config DRM_AMD_DC_DCN1_0 +    bool "DCN 1.0 Raven family" +    depends on DRM_AMD_DC && X86 +    default y +    help +  Choose this option if you want to have +  RV family for

Re: [PATCH] MAINTAINERS: Add separate section for DC

2018-07-19 Thread Leo Li
On 2018-07-19 11:17 AM, Harry Wentland wrote: On 2018-07-19 10:36 AM, Christian König wrote: Note that Harry and Leo Li are maintainers for that stuff. Signed-off-by: Christian König Reviewed-by: Harry Wentland Reviewed-by: Leo Li Harry --- MAINTAINERS | 8 1 file

Re: [PATCH 04/33] drm/amd/display: Use 4096 lut entries

2018-02-27 Thread Leo Li
On 2018-02-27 05:34 AM, Michel Dänzer wrote: On 2018-02-26 09:15 PM, Harry Wentland wrote: From: "Leo (Sunpeng) Li" Non-legacy LUT size should reflect hw capability. Change size from 256 to 4096. However, X doesn't seem to play with legacy LUTs of such size. Therefore,

Re: [PATCH 32/32] drm/amd/display: Fix dim display on DCE11

2018-04-06 Thread Leo Li
On 2018-04-04 11:17 AM, Deucher, Alexander wrote: Do other DCE blocks need this fix as well?  Or is this code shared with say DCE8 and DCE10? Yes, it's all shared. The hook for this is initialized in dce110_hw_sequencer_construct(), which is called for all DCE. Leo Alex

Re: spam in dmesg log from display

2018-04-09 Thread Leo Li
On 2018-04-09 01:36 PM, Tom St Denis wrote: This commit commit 5fadc6fe773862f59f8a54480f06f097f0719c26 Author: Bhawanpreet Lakha Date:   Thu Mar 15 13:01:46 2018 -0400     drm/amd/display: Add Dynamic debug prints     Created Macros for DC_LOG_XXX to pr_debug()

Re: [PATCH xf86-video-amdgpu 2/5] Hook up CRTC color management functions

2018-04-10 Thread Leo Li
On 2018-04-09 11:03 AM, Michel Dänzer wrote: On 2018-03-26 10:00 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" The functions insert into the output resource creation, and property change functions. CRTC destroy is also hooked-up for proper cleanup of the CRTC

Re: [PATCH xf86-video-amdgpu 1/5] Add functions for changing CRTC color management properties

2018-04-10 Thread Leo Li
On 2018-04-09 11:03 AM, Michel Dänzer wrote: On 2018-03-26 10:00 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" This change adds a few functions in preparation of enabling CRTC color managment via the randr interface. The driver-private CRTC object now contains

Re: [PATCH xf86-video-amdgpu 3/5] Keep CRTC properties consistent

2018-04-10 Thread Leo Li
On 2018-04-09 11:03 AM, Michel Dänzer wrote: On 2018-03-26 10:00 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" In cases where CRTC properties are updated without going through RRChangeOutputProperty, we don't update the properties in user land. Consider setting

Re: [PATCH xf86-video-amdgpu 0/5] Implementing non-legacy color management

2018-04-10 Thread Leo Li
On 2018-04-09 10:10 AM, Michel Dänzer wrote: Hi Leo, apologies for the late follow-up; I was on vacation and then backlogged. No worries, thanks for the review :) On 2018-03-26 10:00 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" These patches will

Re: [PATCH] drm/amd/display: Don't spam debug messages

2018-04-10 Thread Leo Li
On 2018-04-10 04:44 PM, Harry Wentland wrote: Ping On 2018-04-09 02:06 PM, Harry Wentland wrote: Signed-off-by: Harry Wentland Reviewed-by: Leo (Sunpeng) Li --- drivers/gpu/drm/amd/display/include/logger_types.h | 2 +- 1 file changed, 1

Re: [PATCH xf86-video-amdgpu 2/5] Hook up CRTC color management functions

2018-04-11 Thread Leo Li
On 2018-04-11 04:48 AM, Michel Dänzer wrote: On 2018-04-10 08:02 PM, Leo Li wrote: On 2018-04-09 11:03 AM, Michel Dänzer wrote: On 2018-03-26 10:00 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" <sunpeng...@amd.com> The functions insert into the output r

Re: [PATCH xf86-video-amdgpu 3/5] Keep CRTC properties consistent

2018-04-11 Thread Leo Li
On 2018-04-11 04:39 AM, Michel Dänzer wrote: On 2018-04-10 08:02 PM, Leo Li wrote: On 2018-04-09 11:03 AM, Michel Dänzer wrote: On 2018-03-26 10:00 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" <sunpeng...@amd.com> In cases where CRTC properties are updated witho

Re: [PATCH xf86-video-amdgpu 1/5] Add functions for changing CRTC color management properties

2018-04-11 Thread Leo Li
On 2018-04-11 04:39 AM, Michel Dänzer wrote: On 2018-04-10 08:02 PM, Leo Li wrote: On 2018-04-09 11:03 AM, Michel Dänzer wrote: On 2018-03-26 10:00 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" <sunpeng...@amd.com> This change adds a few functions in preparation

Re: [PATCH xf86-video-amdgpu 3/5] Keep CRTC properties consistent

2018-04-12 Thread Leo Li
On 2018-04-12 06:30 AM, Michel Dänzer wrote: On 2018-04-11 11:26 PM, Leo Li wrote: On 2018-04-11 04:39 AM, Michel Dänzer wrote: Hmm. So either legacy or non-legacy clients won't work at all, or they'll step on each other's toes, clobbering the HW gamma LUT from each other. I'm afraid

Re: [PATCH] drm/amd/display: Don't program bypass on linear regamma LUT

2018-04-16 Thread Leo Li
. Signed-off-by: Harry Wentland <harry.wentl...@amd.com> Thanks Harry, Reviewed-by: Leo Li <sunpeng...@amd.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_d

Re: [PATCH xf86-video-amdgpu 0/7] Enabling Color Management - Round 3

2018-06-22 Thread Leo Li
On 2018-06-15 02:57 AM, Michel Dänzer wrote: On 2018-06-14 09:49 PM, Leo Li wrote: On 2018-06-14 12:57 PM, Michel Dänzer wrote: On 2018-06-01 06:03 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" This ended up being different enough from v2 to warrant a new patchset. Pe