Re: [PATCH] MAINTAINERS: Add Siqueira for AMD DC

Hi, Acked-by: Rodrigo Siqueira Thanks a lot, I'm going to apply this patch. On 2021-10-08 5:21 p.m., Harry Wentland wrote: He's been helping maintain it for quite a while now. Make it official. Signed-off-by: Harry Wentland --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH] amd/display: remove ChromeOS workaround

Hi Simon, I tested this patch and it lgtm. I also agree to revert it. Btw, did you send the revert patch for "amd/display: only require overlay plane to cover whole CRTC on ChromeOS"? I think we need to revert it as well. Sean, Mark For ChromeOS, we should ignore this patch. Do we need to

Re: [PATCH v5] amd/display: only require overlay plane to cover whole CRTC on ChromeOS

On 2021-10-11 11:16 a.m., Simon Ser wrote: Commit ddab8bd788f5 ("drm/amd/display: Fix two cursor duplication when using overlay") changed the atomic validation code to forbid the overlay plane from being used if it doesn't cover the whole CRTC. The motivation is that ChromeOS uses the atomic

Re: [PATCH 10/19] drm/amd/display: Changed pipe split policy to allow for multi-display pipe split

On 2021-12-17 4:36 p.m., Deucher, Alexander wrote: [AMD Official Use Only] Maybe add Bug links for: https://gitlab.freedesktop.org/drm/amd/-/issues/1522 https://gitlab.freedesktop.org/drm/amd/-/issues/1709

Re: [PATCH] drm/amd/display: Fix warning comparing pointer to 0

On 2021-11-24 5:20 a.m., Jiapeng Chong wrote: Fix the following coccicheck warning: ./drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c:96:14-15: WARNING comparing pointer to 0. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong ---

Re: [PATCH] drm/amd/display: fix application of sizeof to pointer

On 2021-11-23 10:04 p.m., cgel@gmail.com wrote: From: Lv Ruyi Both of split and merge are pointers, not arrays. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- drivers/gpu/drm/amd/display/dc/dml/dml_wrapper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 32/33] drm/amd/display: fix link training regression for 1 or 2 lane

Hi Paul, First of all, thanks for your feedback. Before I address your comments, I just want to give you some background about this type of patchset. All patches in this series are from a week ago and came from all display teams in AMD. Keep in mind that we share our display core with other

Re: [PATCH 1/3] drm/amd/display: Don't allow partial copy_from_user

Hi Harry, lgtm. Btw, it looks like that the other patches from this series are already applied to amd-staging-drm-next. Reviewed-by: Rodrigo Siqueira On 2021-10-27 10:26 a.m., Harry Wentland wrote: There is no reason to allow for partial buffers from userspace in our debugfs. In this

Re: [PATCH 09/10] drm/amdgpu: remove unnecessary variables

On 2021-12-07 8:25 p.m., Isabella Basso wrote: This fixes the warnings below: In function 'svm_range_map_to_gpu': warning: variable 'bo_va' set but not used [-Wunused-but-set-variable] 1172 | struct amdgpu_bo_va bo_va; | ^ ... In

Re: [PATCH 00/10] drm/amd: fix various compilation warnings

Hi Isabella, Thanks a lot for all of these improvements. I reviewed all patches related to the display code. Best Regards Siqueira On 2021-12-07 8:25 p.m., Isabella Basso wrote: This patchset aims at fixing various compilation warnings in the AMD GPU driver. All warnings were generated using

Re: [PATCH v2 6/6] Documentation/gpu: Add amdgpu and dc glossary

On 2021-12-08 11:16 a.m., Yann Dirson wrote: Hi Rodrigo, On 2021-12-07 2:49 p.m., Yann Dirson wrote: On Thu, Dec 02, 2021 at 11:01:32AM -0500, Rodrigo Siqueira wrote: In the DC driver, we have multiple acronyms that are not obvious most of the time; the same idea is valid for amdgpu.

Re: [PATCH 07/10] drm/amd: append missing includes

On 2021-12-07 8:25 p.m., Isabella Basso wrote: This fixes warnings caused by global functions lacking prototypes:, such as: warning: no previous prototype for 'dcn303_hw_sequencer_construct' [-Wmissing-prototypes] 12 | void dcn303_hw_sequencer_construct(struct dc *dc) |

Re: [PATCH 06/10] drm/amd/display: fix function scopes

Hi Isabella, First of all, thanks a lot for sending this patch. This is a very welcome improvement to display code :) I added a few comments inline. On 2021-12-07 8:25 p.m., Isabella Basso wrote: This turns previously global functions into static, thus removing compile-time warnings such

Re: [PATCH] drm/amd/display: fix a missing prototype warning in DCN303

On 2021-12-07 2:18 p.m., Aurabindo Pillai wrote: [Why] A missing include statement triggered a warning when running a build with W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn303/dcn303_init.c:30:6: warning: no previous prototype for 'dcn303_hw_sequencer_construct'

Re: [PATCH v2 6/6] Documentation/gpu: Add amdgpu and dc glossary

On 2021-12-07 2:49 p.m., Yann Dirson wrote: On Thu, Dec 02, 2021 at 11:01:32AM -0500, Rodrigo Siqueira wrote: In the DC driver, we have multiple acronyms that are not obvious most of the time; the same idea is valid for amdgpu. This commit introduces a DC and amdgpu glossary in order to

Re: [PATCH v2 06/10] drm/amd/display: fix function scopes

Hi Isabella, Sorry for the delay. Since this is a large patch, I submitted it to our CI, and I was waiting for the result. Apparently, everything is alright and your patch lgtm. Reviewed-by: Rodrigo Siqueira And applied to amd-staging-drm-next Thanks Siqueira On 2021-12-09 10:47 a.m.,

Re: [PATCH 1/2] drm/amd/display: Reduce stack size for dml31_ModeSupportAndSystemConfigurationFull

On 2021-12-13 4:46 a.m., Michel Dänzer wrote: On 2021-12-11 13:20, Rodrigo Siqueira Jordao wrote: On 2021-12-09 11:46 a.m., Michel Dänzer wrote: From: Michel Dänzer Move code using the Pipe struct to a new helper function. Works around[0] this warning (resulting in failure to build

Re: [PATCH 1/6] Documentation/gpu: Reorganize DC documentation

On 2021-11-30 10:48 a.m., Harry Wentland wrote: On 2021-11-30 10:46, Rodrigo Siqueira Jordao wrote: On 2021-11-29 7:06 a.m., Jani Nikula wrote: On Fri, 26 Nov 2021, Daniel Vetter wrote: On Thu, Nov 25, 2021 at 10:38:25AM -0500, Rodrigo Siqueira wrote: Display core documentation

Re: [PATCH 1/6] Documentation/gpu: Reorganize DC documentation

On 2021-11-29 7:06 a.m., Jani Nikula wrote: On Fri, 26 Nov 2021, Daniel Vetter wrote: On Thu, Nov 25, 2021 at 10:38:25AM -0500, Rodrigo Siqueira wrote: Display core documentation is not well organized, and it is hard to find information due to the lack of sections. This commit reorganizes

Re: [PATCH 6/6] Documentation/gpu: Add DC glossary

On 2021-11-29 3:48 p.m., ydir...@free.fr wrote: Hi Rodrigo, That will really be helpful! I know drawing the line is a difficult problem (and can even make things harder when searching), but maybe it would make sense to keep generic acronyms not specific to amdgpu in a separate list. I bet

Re: [PATCH v4 0/6] Expand display core documentation

On 2021-12-09 4:04 p.m., Yann Dirson wrote: Thanks for this. It's really good to see this. Reviewed-by: Harry Wentland Hearfully seconded, let's get this rolling :) Reviewed-by: Yann Dirson Series applied to amd-staging-drm-next Thanks a lot! Harry On 2021-12-09 09:20, Rodrigo

Re: [PATCH 1/2] drm/amd/display: Reduce stack size for dml31_ModeSupportAndSystemConfigurationFull

On 2021-12-09 11:46 a.m., Michel Dänzer wrote: From: Michel Dänzer Move code using the Pipe struct to a new helper function. Works around[0] this warning (resulting in failure to build a RHEL debug kernel with Werror enabled):

Re: [PATCH v2 1/3] Documentation/gpu: split amdgpu/index for readability

On 2021-12-10 1:20 p.m., Yann Dirson wrote: This starts to make the formated index much more manageable to the reader. Signed-off-by: Yann Dirson --- Documentation/gpu/amdgpu/driver-core.rst | 65 Documentation/gpu/amdgpu/driver-misc.rst | 112 ++

Re: [PATCH v2 2/3] Documentation/gpu: include description of AMDGPU hardware structure

On 2021-12-10 1:20 p.m., Yann Dirson wrote: This is Alex' description from the "gpu block diagram" thread, edited to fit as ReST. Maybe you can improve this commit message by describing what you are documenting and also adding a link to the original discussion. Perhaps you can use this

Re: [PATCH v2 2/3] Documentation/gpu: include description of AMDGPU hardware structure

On 2021-12-13 3:16 p.m., Rodrigo Siqueira Jordao wrote: On 2021-12-10 1:20 p.m., Yann Dirson wrote: This is Alex' description from the "gpu block diagram" thread, edited to fit as ReST. Maybe you can improve this commit message by describing what you are documenting and a

Re: [PATCH v2 3/3] Documentation/gpu: include description of some of the GC microcontrollers

On 2021-12-10 1:20 p.m., Yann Dirson wrote: This is Alex' description from the "Looking for clarifications around gfx/kcq/kiq" thread, edited to fit as ReST. Originally-by: Alex Deucher Signed-off-by: Yann Dirson Acked-by: Harry Wentland --- Documentation/gpu/amdgpu/driver-core.rst |

Re: [PATCH 1/4] drm/amdgpu: Treat warning as an error

On 2022-01-11 6:00 a.m., Michel Dänzer wrote: On 2022-01-11 11:41, Michel Dänzer wrote: On 2022-01-11 00:39, Rodrigo Siqueira wrote: We have one internal CI that builds our kernel with the -Werror flag; as a result, when we try to sync our branch with amd-staging-drm-next we get some

Re: [PATCH 1/3] drm/amdgpu: fix warning

On 2022-01-10 3:19 p.m., Alex Deucher wrote: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] Fixes: 8c50db2f64ee ("drm/amdgpu: Adjust error inject function code style in amdgpu_ras.c") Cc: yipechai Signed-off-by: Alex Deucher ---

Re: [PATCH] drm/amd/display: move FPU-related code from dcn20 to dml folder

On 2022-02-21 06:31, Melissa Wen wrote: Move parts of dcn20 code that uses FPU to dml folder. It aims to isolate FPU operations as described by series: drm/amd/display: Introduce FPU directory inside DC https://patchwork.freedesktop.org/series/93042/ This patch moves the following functions

Re: [PATCH 0/2] remove DC_FP_* wrappers in dml files

On 2022-03-26 16:24, Melissa Wen wrote: From FPU documentation, developers must not use DC_FP_START/END in dml files, but invoke it when calling FPU-associated functions (isolated in dml folder). Therefore, the first patch renames dcn10_validate_bandwidth in dml/calcs to dcn_ for

Re: [PATCH v2] drm/amd/display: don't ignore alpha property on pre-multiplied mode

On 2022-03-29 16:18, Melissa Wen wrote: "Pre-multiplied" is the default pixel blend mode for KMS/DRM, as documented in supported_modes of drm_plane_create_blend_mode_property(): https://cgit.freedesktop.org/drm/drm-misc/tree/drivers/gpu/drm/drm_blend.c In this mode, both 'pixel alpha' and

Re: [PATCH] drm/amd/display: Fix by adding FPU protection for dcn30_internal_validate_bw

On 2022-03-30 09:57, Melissa Wen wrote: On 03/30, VURDIGERENATARAJ, CHANDAN wrote: Hi Paul, Am 29.03.22 um 10:29 schrieb CHANDAN VURDIGERE NATARAJ: Is it common to spell your name all uppercase? If not, please use Chandan nVurdigere Nataraj. [WHY] The [] already emphasize the word,

Re: [PATCH] drm/amd/display: Copy crc_skip_count when duplicating CRTC state

On 2022-01-18 11:49 a.m., Kazlauskas, Nicholas wrote: On 1/18/2022 11:40 AM, Rodrigo Siqueira wrote: From: Leo Li [Why] crc_skip_count is used to track how many frames to skip to allow the OTG CRC engine to "warm up" before it outputs correct CRC values. Experimentally, this seems to be 2

Re: [PATCH v3] drm/amd/display: move calcs folder into DML

On 2022-01-07 4:33 p.m., Isabella Basso wrote: The calcs folder has FPU code on it, which should be isolated inside the DML folder as per https://patchwork.freedesktop.org/series/93042/. This commit aims single-handedly to correct the location of such FPU code and does not refactor any

Re: [PATCH 0/2]

Hi Zhenneng, + some display folks First of all, thanks a lot for your patch. We had a similar patch in the past, but we had to revert it because we cannot simply enable DCN for ARM-based systems. You can refer to this commit message to get a better context:

Re: [PATCH v2] drm/amd/display: don't ignore alpha property on pre-multiplied mode

Patch merged to amd-staging-drm-next. Thanks a lot! On 2022-04-05 15:32, Simon Ser wrote: I've tested this patch and it fixes my bug [1]. Thanks! Tested-by: Simon Ser [1]: https://gitlab.freedesktop.org/drm/amd/-/issues/1734>

Re: [RFC PATCH v2 1/5] drm/amd/display: detach color state from hw state logging

On 9/13/23 10:43, Melissa Wen wrote: Prepare to hook color state logging according to DCN version. Signed-off-by: Melissa Wen --- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 27 +-- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git

Re: [RFC PATCH v2 2/5] drm/amd/display: fill up DCN3 DPP color state

On 9/13/23 10:43, Melissa Wen wrote: DCN3 DPP color state was uncollected and some state elements from DCN1 doesn't fit DCN3. Create new elements according to DCN3 color caps and fill them up for DTN log output. rfc-v2: - fix reading of gamcor and blnd gamma states Signed-off-by: Melissa

Re: [RFC PATCH v2 0/5] drm/amd/display: improve DTN color state log

On 9/13/23 10:43, Melissa Wen wrote: Hi, This is an update of previous RFC [0] improving the data collection of Gamma Correction and Blend Gamma color blocks. As I mentioned in the last version, I'm updating the color state part of DTN log to match DCN3.0 HW better. Currently, the DTN log

Re: [PATCH] drm/amd/display: add kernel docs for dc_stream_forward_crc_window

Hi Sagar, First of all, thanks for your patch. On 10/25/23 08:04, Sagar Vashnav wrote: Add kernel documentation for the dc_stream_forward_crc_window Signed-off-by: Sagar Vashnav --- drivers/gpu/drm/amd/display/dc/core/dc.c | 13 + 1 file changed, 13 insertions(+) diff --git

Re: [PATCH 0/2] Reduce stack size for DML2

Hi Nathan, (+Hamza) First of all, thanks a lot for your feedback. You can see my comments inline. On 10/17/23 11:22, Nathan Chancellor wrote: Hi Rodrigo, On Mon, Oct 16, 2023 at 08:19:16AM -0600, Rodrigo Siqueira wrote: Stephen discovers a stack size issue when compiling the latest amdgpu

Re: [PATCH] drm/amd/display: switch DC over to the new DRM logging macros

Hi Hamza, This is a very nice improvement and overall lgtm. I just one comment and one question. For future series like this, I recommend splitting your commit into minor changes to make it easier to review and revert changes in case of regressions. Also, with a patchset, you could add a

Re: [PATCH] drm/amd/display: switch DC over to the new DRM logging macros

On 9/22/23 08:42, Hamza Mahfooz wrote: On 9/22/23 10:36, Rodrigo Siqueira Jordao wrote: Hi Hamza, This is a very nice improvement and overall lgtm. I just one comment and one question. For future series like this, I recommend splitting your commit into minor changes to make it easier

Re: [PATCH v2 0/2] Fix issues caused by DML2 in ASICs older than DCN35

On 10/20/23 15:38, Harry Wentland wrote: On 2023-10-20 17:26, Rodrigo Siqueira wrote: The first commit of this series just sets the variable using_dml2 to false for all ASICs that do not require it. The second commit adds a fix to the DC sequence that calls a DML2 operation in ASICs that

Re: [PATCH 0/5] drm/amd/display: Remove migrate-disable and move memory allocation.

On 9/21/23 08:15, Sebastian Andrzej Siewior wrote: Hi, I stumbled uppon the amdgpu driver via a bugzilla report. The actual fix is #4 + #5 and the rest was made while looking at the code. Sebastian Hi Sebastian, Thanks a lot for this patchset. We tested it on multiple devices, and

Re: [PATCH] drm/amd/display: Fix useless else if in display_mode_vba_util_32.c

On 8/16/23 00:51, Srinivasan Shanmugam wrote: The assignment of the else if and else branches is the same, so the else if here is redundant, hence removed it. Fixes the below: drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10: WARNING: possible condition with no

Re: [PATCH] drm/amd/display: Fix up kdoc for 'optc35_set_odm_combine'

Hi, Consider renaming the commit title to something like "Adjust kernel-doc for ...". Anyway, avoid use the keyword "Fix/Fixes" for kernel-doc. On 8/28/23 22:50, Srinivasan Shanmugam wrote: Fixes the following W=1 kernel build warning:

Re: [PATCH v2] drm/amd/display: Adjust kdoc for 'optc35_set_odm_combine'

On 8/29/23 08:38, Srinivasan Shanmugam wrote: Fixes the following W=1 kernel build warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn35/dcn35_optc.c:46: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Enable CRTC

Re: [PATCH] drm/amd/display: protect remaining FPU-code calls on dcn3.1.x

On 2022-03-30 19:02, Melissa Wen wrote: From [1], I realized two other calls to dcn30 code are associated with FPU operations and are not protected by DC_FP_* macros: * dcn30_populate_dml_writeback_from_context() * dcn30_set_mcif_arb_params() So, since FPU-associated code is not fully

Re: [PATCH 1/2] drm/amd/display: Add visualconfirm module parameter

On 07/07/2022 10:56, sunpeng...@amd.com wrote: From: Leo Li [Why] Being able to configure visual confirm at boot or in cmdline is helpful when debugging. [How] Add a module parameter to configure DC visual confirm, which works the same way as the equivalent debugfs entry. Signed-off-by:

Re: [PATCH] drm/amd/display: Add a proper DMI match for Precision devices

On 12/07/2022 12:02, Limonciello, Mario wrote: On 7/12/2022 10:59, Rodrigo Siqueira wrote: We had an MST fix for some DELL devices that got merged, but we missed other products. This commit adds the other missing Precision devices. Cc: Mario Limonciello Cc: Jerry Zuo Cc: Qian Fu Cc: Alex

Re: [PATCH] drm/amdgpu/display: add missing FP_START/END checks dcn32_clk_mgr.c

On 2022-06-27 17:04, Alex Deucher wrote: Properly handle FP code in dcn32_clk_mgr.c. Fixes: 265280b99822 ("drm/amd/display: add CLKMGR changes for DCN32/321") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 4 1 file changed, 4

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

On 2022-06-18 19:27, Guenter Roeck wrote: ppc:allmodconfig builds fail with the following error. powerpc64-linux-ld: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.o uses hard float,

Re: [RFC 0/3] drm/amd/display: Introduce KUnit to Display Mode Library

Hi, First of all, thanks a lot for exploring the introduction of kunit inside amdgpu. See my inline comments On 2022-06-18 05:08, David Gow wrote: On Sat, Jun 18, 2022 at 4:24 AM Maíra Canal wrote: On 6/17/22 04:55, David Gow wrote: On Fri, Jun 17, 2022 at 6:41 AM Maíra Canal wrote:

Re: [PATCH] drm/amdgpu/display: Remove unnecessary typecasts and fix build issues

On 2022-06-07 13:58, Aurabindo Pillai wrote: On 2022-06-07 11:34, Leo wrote: On 2022-06-07 05:40, Chandan Vurdigere Nataraj wrote: [Why] Getting below errors: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:1414:5: error: implicit conversion from enumeration

Re: [PATCH] drm/amd/display: Use pre-allocated temp struct for bounding box update

On 2022-06-08 13:47, Leo wrote: On 2022-06-08 13:25, Pillai, Aurabindo wrote: [AMD Official Use Only - General] Isnt it cleaner to revert the original patch which removed the temporary variable and then instead allocate the clock_limits array on heap, and later freed at the end of the

Re: [PATCH] drm/amd/display: fix null pointer deref error

On 2022-06-07 13:06, Aurabindo Pillai wrote: [Why] 0 was passed in place of a pointer which triggered null pointer dereference. [How] Pass in a pointer that contains nullified parameters instead of null pointer. Signed-off-by: Aurabindo Pillai ---

Re: [PATCH 1/3] Documentation/gpu: Add info table for ASICs

On 2022-06-15 10:13, Alex Deucher wrote: On Wed, Jun 15, 2022 at 3:47 AM Simon Ser wrote: On Tuesday, June 14th, 2022 at 20:30, Alex Deucher wrote: On Tue, Jun 14, 2022 at 2:16 PM Simon Ser cont...@emersion.fr wrote: On Monday, June 13th, 2022 at 22:01, Rodrigo Siqueira

Re: [PATCH] drm/amd/display: add missing reg defs for DCN3x HUBBUB

On 2022-06-16 17:08, Aurabindo Pillai wrote: [Why] The omitted register definition caused call traces like: [3.811215] WARNING: CPU: 7 PID: 794 at drivers/gpu/drm/amd/amdgpu/../display/dc/dc_helper.c:120 set_reg_field_values.constprop.0+0xc7/0xe0 [amdgpu] [3.811406] Modules linked

Re: [PATCH 1/3] Documentation/gpu: Add info table for ASICs

On 2022-06-15 10:34, Yann Dirson wrote: Nice! diff --git a/Documentation/gpu/amdgpu/apu-asic-info-table.csv b/Documentation/gpu/amdgpu/apu-asic-info-table.csv ... +Ryzen 3000 series / AMD Ryzen Embedded V1*/R1* with Radeon Vega Gfx, RAVEN/PICASSO, DCN 1.0, 9.1.0, VCN 1.0, 4.1.0 ...

Re: [PATCH 2/3] Documentation/gpu: Add an explanation about the DCN pipeline

On 2022-06-15 07:12, Pekka Paalanen wrote: On Mon, 13 Jun 2022 16:01:11 -0400 Rodrigo Siqueira wrote: In the DCN code, we constantly talk about hardware pipeline, pipeline, or even just pipes, which is a concept that is not obvious to everyone. For this reason, this commit expands the DCN

Re: [PATCH 16/31] drm/amd/display: refactor function transmitter_to_phy_id

On 2022-06-17 15:51, Nathan Chancellor wrote: Hi Rodrigo, On Fri, Jun 17, 2022 at 03:34:57PM -0400, Rodrigo Siqueira wrote: From: Nicholas Choi [Why & How] Since we only need transmitter value in function transmitter_to_phy_id(). Replace argument struct dc_link with enum transmitter.

Re: [PATCH 2/5] drm/amd/display: remove useless FPU protection wrapper from dcn31_resource file

On 2022-07-20 15:32, Melissa Wen wrote: Many lines of code in dcn31_resource_construct are wrapped by DC_FP macro to protect FPU operations; however, there is no FPU in this region. Therefore, just remove the wrapper for clarity. Signed-off-by: Melissa Wen ---

Re: [PATCH 0/5] drm/amd/display: FPU cleanup in clk_mgr files for powerpc

On 2022-07-20 15:32, Melissa Wen wrote: An initial report from Guenter[1] shows some soft-fp vs hard-fp error from DCN31 clk mgr for powerpc. I was not able to reproduce it cross-compiling with gcc-powerpc-linux-gnu and gcc-11.3, but thanks to Maíra tips, I can reproduce the issue using

Re: [PATCH 3/5] drm/amd/display: move FPU code on dcn21 clk_mgr

On 2022-07-20 15:32, Melissa Wen wrote: The -mno-gnu-attribute option in dcn21 clk mgr makefile hides a soft vs hard fp error for powerpc. After removing this flag, we can see some FPU code remains there: /gcc-11.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld:

Re: [PATCH 4/5] drm/amd/display: move FPU code from dcn30 clk mgr to DML folder

On 2022-07-20 15:32, Melissa Wen wrote: The -mno-gnu-attribute option in clk mgr makefile for dcn30 hides a soft vs hard fp error for powerpc. After removing this flag, we can see some FPU code remains there: gcc-11.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld:

Re: [PATCH 5/5] drm/amd/display: move FPU code from dcn301 clk mgr to DML folder

On 2022-07-21 13:26, Maíra Canal wrote: Hi Melissa, On 7/20/22 16:32, Melissa Wen wrote: The -mno-gnu-attribute option in dcn301 clk mgr makefile hides a soft vs hard fp error for powerpc. After removing this flag, we can see some FPU code remains there:

Re: [PATCH 1/5] drm/amd/display: fix soft-fp vs hard-fp on DCN 3.1 family for powerpc

On 2022-07-20 15:32, Melissa Wen wrote: Move remaining FPU code to DML folder that caused compilation error for powerpc. This patch depends on [1] to prevent the error below: /gcc-11.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld:

Re: [PATCH 5/5] drm/amd/display: move FPU code from dcn301 clk mgr to DML folder

On 2022-07-20 15:32, Melissa Wen wrote: The -mno-gnu-attribute option in dcn301 clk mgr makefile hides a soft vs hard fp error for powerpc. After removing this flag, we can see some FPU code remains there: gcc-11.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld:

Re: [PATCH 1/5] drm/amd/display: reduce stack size in dcn32 dml (v2)

On 2022-07-21 01:13, Alex Deucher wrote: Move additional dummy structures off the stack and into the dummy vars structure. Fixes the following: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function

Re: [PATCH -next] drm/amd/display: remove unneeded semicolon

On 2022-07-26 18:28, Yang Li wrote: Eliminate the following coccicheck warning: ./drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c:2344:67-68: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 2 +- 1 file

Re: [PATCH] drm/amd/display: Reduce stack size in the mode support function

On 2022-07-24 17:41, Stephen Rothwell wrote: Hi all, On Fri, 22 Jul 2022 14:12:44 -0400 Alex Deucher wrote: On Fri, Jul 22, 2022 at 1:56 PM Rodrigo Siqueira wrote: When we use the allmodconfig option we see the following error:

Re: [PATCH] drm/amd/display: Remove unused struct freesync_context

On 2022-07-27 13:50, Maíra Canal wrote: All references to struct freesync_context were removed, so remove the struct freesync_context itself and its entry on struct dc_stream_state. Signed-off-by: Maíra Canal --- drivers/gpu/drm/amd/display/dc/dc_stream.h | 8 1 file changed, 8

Re: [PATCH 0/4] Revert reduce stack size for DML code

On 2022-07-27 18:22, Alex Deucher wrote: Series is: Reviewed-by: Alex Deucher Thanks Alex, Patshet pushed to amd-staging-drm-next. Best Regards Siqueira On Wed, Jul 27, 2022 at 6:19 PM Rodrigo Siqueira wrote: We had a stack size issue on DML, and we tried to fix it by moving some

Re: [PATCH 1/4] Documentation/amdgpu_dm: Add DM color correction documentation

On 2022-07-20 18:54, Melissa Wen wrote: On 07/17, Tales Lelo da Aparecida wrote: On 16/07/2022 19:25, Melissa Wen wrote: AMDGPU DM maps DRM color management properties (degamma, ctm and gamma) to DC color correction entities. Part of this mapping is already documented as code comments and

Re: [PATCH v2 3/4] drm/amd/display: Remove parameters from rq_dlg_get_dlg_reg

Hi Maira, First of all, thanks a lot for this patch. This change is really helpful for reducing the stack size. I just have few comments inline. On 2022-07-21 14:36, Maíra Canal wrote: Across all DCN's (except DCN32, that has a separate rq_dlg_get_dlg_reg), the parameters const bool vm_en,

Re: [PATCH] drm/amdgpu/display: reduce stack size in dml32_ModeSupportAndSystemConfigurationFull()

c: Stephen Rothwell Cc: Aurabindo Pillai Cc: Rodrigo Siqueira Jordao Signed-off-by: Alex Deucher --- .../dc/dml/dcn32/display_mode_vba_32.c| 77 --- .../drm/amd/display/dc/dml/display_mode_vba.h | 3 +- 2 files changed, 36 insertions(+), 44 deletions(-) diff --git a/d

Re: [PATCH 07/15] drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in dc

On 2022-05-06 11:56, Alex Deucher wrote: On Fri, May 6, 2022 at 11:43 AM Stylon Wang wrote: From: Alex Hung [Why & How] CONFIG_DRM_AMD_DC_DCN is used by pass the compilation failures, but DC code should be OS-agnostic. This patch fixes it by removing unnecessasry CONFIG_DRM_AMD_DC_DCN

Re: [PATCH 07/15] drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in dc

e FPU code on the display side. However, we have been working on that for a couple of months; we are close to completing this work and re-enabling ARM + DCN soon. Thanks Siqueira -Original Message- From: amd-gfx On Behalf Of Rodrigo Siqueira Jordao Sent: 2022年5月7日 1:13 To: Alex Deucher ;

Re: How are the DC patches tested? (was: [PATCH 00/15] DC Patches May 9, 2022)

On 2022-05-09 10:00, Paul Menzel wrote: [Sorry for the incomplete first message.] Dear Daniel, Am 09.05.22 um 15:14 schrieb Wheeler, Daniel: […] This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display

Re: [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()

On 2022-09-01 10:15, Hamza Mahfooz wrote: Address the following warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 3508 | if (update_type != UPDATE_TYPE_FAST) | ^~

Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()

On 2022-09-02 09:10, Greg Kroah-Hartman wrote: On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote: When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. Fix this up by properly calling dput(). Cc: Harry Wentland

Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()

On 2022-09-06 11:06, Greg Kroah-Hartman wrote: On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote: On 2022-09-02 09:10, Greg Kroah-Hartman wrote: On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote: When calling debugfs_lookup() the result must have

Re: [PATCH linux-next] drm/amd/display: Remove the unneeded result variable

On 2022-09-02 03:54, cgel@gmail.com wrote: From: zhang songyi Return the enable_link_dp() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot Signed-off-by: zhang songyi --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +- 1 file changed,

Re: [PATCH] drm/amd/display: Fix register definitions for DCN32/321

On 2022-09-01 15:27, Aurabindo Pillai wrote: [Why & How] Fix the instatiation sequence for MPC registers and add a few other missing register definitions that were ommited erroneously when copying them over to enable runtime initialization of reigster offsets for DCN32/321 Signed-off-by:

Re: [PATCH] drm/amd/display: fix documentation for amdgpu_dm_update_freesync_caps()

On 2022-08-30 17:57, Alex Deucher wrote: Document missing parameter. Fixes: 8889a13f99e5 ("drm/amd/display: Add some extra kernel doc to amdgpu_dm") Reported-by: Stephen Rothwell Signed-off-by: Alex Deucher Cc: Rodrigo Siqueira Cc: Harry Wentland --- v2: fix aconnector too.

Re: [PATCH v3 1/1] drm/amd/display: add DCN support for ARM64

On 2022-10-28 11:09, Nathan Chancellor wrote: Hi Ao, On Thu, Oct 27, 2022 at 09:52:29PM +0200, Ao Zhong wrote: After moving all FPU code to the DML folder, we can enable DCN support for the ARM64 platform. Remove the -mgeneral-regs-only CFLAG from the code in the DML folder that needs to

Re: [PATCH RESEND 1/1] drm/amd/display: add DCN support for ARM64

On 2022-10-27 15:24, Estela ad Astra wrote: Hello. I have tested it on a Phytium D2000 platform with RX 5500 XT. Distro: Arch Linux ARM Kernel: Linux 6.0.5-1-phytium aarch64 (patched, https://github.com/saeziae/pkgbuild-linux-phytium ) Plug and unplug: OK on all ports. Resolutions

Re: [PATCH] drm/amd/display: Revert logic for plane modifiers

On 2022-10-19 11:15, Joaquín Ignacio Aramendía wrote: This file was split in commit 5d945cbcd4b16a29d6470a80dfb19738f9a4319f ("drm/amd/display: Create a file dedicated to planes") the logic in dm_plane_format_mod_supported() function got changed by a switch logic. That change broke drm_plane

Re: [PATCH 0/5] drm/amd/display: Reduce stack usage for clang

On 2022-09-12 18:02, Nathan Chancellor wrote: Hi Rodrigo, On Mon, Sep 12, 2022 at 05:50:31PM -0400, Rodrigo Siqueira Jordao wrote: On 2022-08-30 16:34, Nathan Chancellor wrote: Hi all, This series aims to address the following warnings, which are visible when building x86_64

Re: [PATCH 0/5] drm/amd/display: Reduce stack usage for clang

On 2022-08-30 16:34, Nathan Chancellor wrote: Hi all, This series aims to address the following warnings, which are visible when building x86_64 allmodconfig with clang after commit 3876a8b5e241 ("drm/amd/display: Enable building new display engine with KCOV enabled").

Re: [PATCH V3 46/47] drm/amd/display: Fix failures of disabling primary plans

Hi Michel, First of all, thanks a lot for your review. I want to take this opportunity to discuss this topic in more depth and learn more from you and others. +(Nick, Leo, Daniel, Mark, Dave, Sean, Simon) On 2022-09-15 04:55, Michel Dänzer wrote: On 2022-09-14 22:08, Alex Hung wrote: On

Re: [PATCH] drm/amd/display: Remove unused struct i2c_id_config_access

On 2022-09-27 09:39, Yuan Can wrote: After commit 5a8132b9f606("drm/amd/display: remove dead dc vbios code"), no one use struct i2c_id_config_access, so remove it. Signed-off-by: Yuan Can --- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 7 --- 1 file changed, 7 deletions(-)

Re: [PATCH -next] drm/amd/display: Removed unused variable 'sdp_stream_enable'

On 2022-09-30 02:38, Dong Chenchen wrote: Kernel test robot throws below warning -> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c: In function 'dcn31_hpo_dp_stream_enc_update_dp_info_packets':

Re: [PATCH] drm/amdgpu/dm/mst: Fix incorrect usage of drm_dp_add_payload_part2()

On 2022-10-04 16:24, Lyude Paul wrote: Yikes, it appears somehow I totally made a mistake here. We're currently checking to see if drm_dp_add_payload_part2() returns a non-zero value to indicate success. That's totally wrong though, as this function only returns a zero value on success - not

Re: [PATCH v5] drm/amd/display: Fix vblank refcount in vrr transition

On 2022-09-21 17:20, Yunxiang Li wrote: manage_dm_interrupts disable/enable vblank using drm_crtc_vblank_off/on which causes drm_crtc_vblank_get in vrr_transition to fail, and later when drm_crtc_vblank_put is called the refcount on vblank will be messed up. Therefore move the call to after

Re: [PATCH] drm: amd: clean up dcn32_fpu.c kernel-doc

On 2022-10-01 00:33, Randy Dunlap wrote: Rectify multiple kernel-doc warnings in dcn32_fpu.c. E.g.: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/dcn32_fpu.c:247: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst

Re: [PATCH v2 3/4] drm/amd/display: add doc entries for MPC blending configuration

On 2022-08-04 11:01, Melissa Wen wrote: Describe structs and enums used to set blend mode properties to MPC blocks. Some pieces of information are already available as code comments, and were just formatted. Others were collected and summarised from discussions on AMD issue tracker[1][2].

Re: [PATCH v2 2/4] Documentation/amdgpu/display: add DC color caps info

On 2022-08-04 11:01, Melissa Wen wrote: Add details about color correction capabilities and explain a bit about differences between DC hw generations and also how they are mapped between DRM and DC interface. Two schemas for DCN 2.0 and 3.0 (converted to svg from the original png) is included

Re: [PATCH v2 1/4] Documentation/amdgpu_dm: Add DM color correction documentation

On 2022-08-04 11:01, Melissa Wen wrote: AMDGPU DM maps DRM color management properties (degamma, ctm and gamma) to DC color correction entities. Part of this mapping is already documented as code comments and can be converted as kernel docs. v2: - rebase to amd-staging-drm-next - fix typos

  1   2   >