Re: [PATCH libdrm v3 1/1] amdgpu: move asic id table to a separate file

2017-05-31 Thread Alex Deucher
On Wed, May 31, 2017 at 7:19 AM, Emil Velikov wrote: > On 30 May 2017 at 22:59, Li, Samuel wrote: >>> - Marketing can make mistakes or have IT glitches The inconsistent use of >>> "(TM)" and using a 67C2:00 is something one wants to double-check

Re: [PATCH libdrm v3 1/1] amdgpu: move asic id table to a separate file

2017-05-31 Thread Emil Velikov
On 30 May 2017 at 22:59, Li, Samuel wrote: >> - Marketing can make mistakes or have IT glitches The inconsistent use of >> "(TM)" and using a 67C2:00 is something one wants to double-check with them. > Marketing names are there for a lot of reasons. The code here is to pass

RE: [PATCH libdrm v3 1/1] amdgpu: move asic id table to a separate file

2017-05-30 Thread Li, Samuel
ucher <alexdeuc...@gmail.com>; amd-gfx list <amd-gfx@lists.freedesktop.org>; Yuan, Xiaojie <xiaojie.y...@amd.com> Subject: Re: [PATCH libdrm v3 1/1] amdgpu: move asic id table to a separate file Hi all, Pardon for dropping in uninvited. Just some food for thought. On 29 May

Re: [PATCH libdrm v3 1/1] amdgpu: move asic id table to a separate file

2017-05-30 Thread Emil Velikov
Hi all, Pardon for dropping in uninvited. Just some food for thought. On 29 May 2017 at 22:01, Li, Samuel wrote: > Understood your point. However as discussed internally before, marketing > names are there for a lot of reasons; my understanding of the policy is we do > not

RE: [PATCH libdrm v3 1/1] amdgpu: move asic id table to a separate file

2017-05-29 Thread Li, Samuel
gt; Cc: amd-gfx@lists.freedesktop.org; Yuan, Xiaojie <xiaojie.y...@amd.com> Subject: Re: [PATCH libdrm v3 1/1] amdgpu: move asic id table to a separate file On 27/05/17 04:23 AM, Samuel Li wrote: > > diff --git a/include/drm/amdgpu.ids b/include/drm/amdgpu.ids new file > mode 100644 i

RE: [PATCH libdrm v3 1/1] amdgpu: move asic id table to a separate file

2017-05-29 Thread Li, Samuel
- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Friday, May 26, 2017 3:27 PM To: Li, Samuel <samuel...@amd.com> Cc: amd-gfx list <amd-gfx@lists.freedesktop.org>; Yuan, Xiaojie <xiaojie.y...@amd.com> Subject: Re: [PATCH libdrm v3 1/1] amdgpu: move asic id table to a separate

Re: [PATCH libdrm v3 1/1] amdgpu: move asic id table to a separate file

2017-05-28 Thread Michel Dänzer
On 27/05/17 04:23 AM, Samuel Li wrote: > > diff --git a/include/drm/amdgpu.ids b/include/drm/amdgpu.ids > new file mode 100644 > index 000..1b00b60 > --- /dev/null > +++ b/include/drm/amdgpu.ids > @@ -0,0 +1,154 @@ > +1.0.0 > +6600,0,AMD Radeon HD 8600/8700M This doesn't look like the

Re: [PATCH libdrm v3 1/1] amdgpu: move asic id table to a separate file

2017-05-26 Thread Alex Deucher
On Fri, May 26, 2017 at 3:23 PM, Samuel Li wrote: > From: Xiaojie Yuan > > v2: fix an off by one error and leading white spaces > v3: use thread safe strtok_r(); initialize len before calling getline(); > change printf() to drmMsg(); add initial

[PATCH libdrm v3 1/1] amdgpu: move asic id table to a separate file

2017-05-26 Thread Samuel Li
From: Xiaojie Yuan v2: fix an off by one error and leading white spaces v3: use thread safe strtok_r(); initialize len before calling getline(); change printf() to drmMsg(); add initial amdgpu.ids Change-Id: I12216da14910f5e2b0970bc1fafc2a20b0ef1ba9 Reviewed-by: Junwei