Re: [PATCH] drm/amdgpu: use new HMM APIs and helpers v4

2019-06-04 Thread Kuehling, Felix
On 2019-06-04 16:13, Yang, Philip wrote: > HMM provides new APIs and helps in kernel 5.2-rc1 to simplify driver > path. The old hmm APIs are deprecated and will be removed in future. > > Below are changes in driver: > > 1. Change hmm_vma_fault to hmm_range_register and hmm_range_fault which >

Re: [PATCH] drm/amdgpu: use new HMM APIs and helpers v3

2019-06-03 Thread Kuehling, Felix
[+Jerome] On 2019-06-03 7:20 p.m., Yang, Philip wrote: > > On 2019-06-03 5:02 p.m., Kuehling, Felix wrote: >> On 2019-06-03 2:44 p.m., Yang, Philip wrote: >>> HMM provides new APIs and helps in kernel 5.2-rc1 to simplify driver >>> path. The old hmm APIs are deprecated and will be removed in

Re: [PATCH] drm/amdgpu: use new HMM APIs and helpers v3

2019-06-03 Thread Yang, Philip
On 2019-06-03 5:02 p.m., Kuehling, Felix wrote: > On 2019-06-03 2:44 p.m., Yang, Philip wrote: >> HMM provides new APIs and helps in kernel 5.2-rc1 to simplify driver >> path. The old hmm APIs are deprecated and will be removed in future. >> >> Below are changes in driver: >> >> 1. Change

Re: [PATCH] drm/amdgpu: use new HMM APIs and helpers v3

2019-06-03 Thread Kuehling, Felix
On 2019-06-03 2:44 p.m., Yang, Philip wrote: > HMM provides new APIs and helps in kernel 5.2-rc1 to simplify driver > path. The old hmm APIs are deprecated and will be removed in future. > > Below are changes in driver: > > 1. Change hmm_vma_fault to hmm_range_register and hmm_range_fault which >

Re: [PATCH] drm/amdgpu: use new HMM APIs and helpers

2019-06-03 Thread Yang, Philip
On 2019-06-03 7:23 a.m., Christian König wrote: > Am 03.06.19 um 12:17 schrieb Christian König: >> Am 01.06.19 um 00:01 schrieb Kuehling, Felix: >>> On 2019-05-31 5:32 p.m., Yang, Philip wrote: On 2019-05-31 3:42 p.m., Kuehling, Felix wrote: > On 2019-05-31 1:28 p.m., Yang, Philip

Re: [PATCH] drm/amdgpu: use new HMM APIs and helpers

2019-06-03 Thread Christian König
Am 03.06.19 um 12:17 schrieb Christian König: Am 01.06.19 um 00:01 schrieb Kuehling, Felix: On 2019-05-31 5:32 p.m., Yang, Philip wrote: On 2019-05-31 3:42 p.m., Kuehling, Felix wrote: On 2019-05-31 1:28 p.m., Yang, Philip wrote: On 2019-05-30 6:36 p.m., Kuehling, Felix wrote:      

Re: [PATCH] drm/amdgpu: use new HMM APIs and helpers

2019-06-03 Thread Christian König
Am 01.06.19 um 00:01 schrieb Kuehling, Felix: On 2019-05-31 5:32 p.m., Yang, Philip wrote: On 2019-05-31 3:42 p.m., Kuehling, Felix wrote: On 2019-05-31 1:28 p.m., Yang, Philip wrote: On 2019-05-30 6:36 p.m., Kuehling, Felix wrote: #if IS_ENABLED(CONFIG_DRM_AMDGPU_USERPTR) -

Re: [PATCH] drm/amdgpu: use new HMM APIs and helpers v2

2019-05-31 Thread Kuehling, Felix
On 2019-05-31 3:09 p.m., Yang, Philip wrote: > HMM provides new APIs and helps in kernel 5.2-rc1 to simplify driver > path. The old hmm APIs are deprecated and will be removed in future. > > Below are changes in driver: > > 1. Change hmm_vma_fault to hmm_range_register and hmm_range_fault which >

Re: [PATCH] drm/amdgpu: use new HMM APIs and helpers

2019-05-31 Thread Kuehling, Felix
On 2019-05-31 5:32 p.m., Yang, Philip wrote: > > On 2019-05-31 3:42 p.m., Kuehling, Felix wrote: >> On 2019-05-31 1:28 p.m., Yang, Philip wrote: >>> On 2019-05-30 6:36 p.m., Kuehling, Felix wrote: > > #if IS_ENABLED(CONFIG_DRM_AMDGPU_USERPTR) > - if (gtt->ranges && > -

Re: [PATCH] drm/amdgpu: use new HMM APIs and helpers

2019-05-31 Thread Yang, Philip
On 2019-05-31 3:42 p.m., Kuehling, Felix wrote: > On 2019-05-31 1:28 p.m., Yang, Philip wrote: >> >> On 2019-05-30 6:36 p.m., Kuehling, Felix wrote: #if IS_ENABLED(CONFIG_DRM_AMDGPU_USERPTR) - if (gtt->ranges && - ttm->pages[0] == hmm_pfn_to_page(>ranges[0],

Re: [PATCH] drm/amdgpu: use new HMM APIs and helpers

2019-05-31 Thread Kuehling, Felix
On 2019-05-31 1:28 p.m., Yang, Philip wrote: > > On 2019-05-30 6:36 p.m., Kuehling, Felix wrote: >>> >>> #if IS_ENABLED(CONFIG_DRM_AMDGPU_USERPTR) >>> - if (gtt->ranges && >>> - ttm->pages[0] == hmm_pfn_to_page(>ranges[0], >>> -

Re: [PATCH] drm/amdgpu: use new HMM APIs and helpers

2019-05-31 Thread Yang, Philip
On 2019-05-30 6:36 p.m., Kuehling, Felix wrote: >> >>#if IS_ENABLED(CONFIG_DRM_AMDGPU_USERPTR) >> -if (gtt->ranges && >> -ttm->pages[0] == hmm_pfn_to_page(>ranges[0], >> - gtt->ranges[0].pfns[0])) >> +if (gtt->range && >> +

Re: [PATCH] drm/amdgpu: use new HMM APIs and helpers

2019-05-30 Thread Kuehling, Felix
This is a nice simplification. See a few comments inline. On 2019-05-30 10:41 a.m., Yang, Philip wrote: > HMM provides new APIs and helps in kernel 5.2-rc1 to simplify driver > path. The old hmm APIs are deprecated and will be removed in future. > > Below are changes in driver: > > 1. Change