Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit
Reviewed-by: Kevin Wang From: Feng, Kenneth Sent: Thursday, October 10, 2019 3:00 PM To: Yuan, Xiaojie ; Deucher, Alexander ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Wang, Kevin(Yang) ; Zhang, Hawking ; Quan, Evan Subject: RE: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit Hi Alex, This issue was navi10 specific and was found in May, 2019. It was early after the asic back, then since gfxoff was removed from navi10, we didn’t really verify which firmware version started to have a fix. For navi14/navi12, there’s no such issue at all. Sorry for losing the track of it. From: Yuan, Xiaojie Sent: Thursday, October 10, 2019 1:17 AM To: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Wang, Kevin(Yang) ; Zhang, Hawking ; Quan, Evan ; Feng, Kenneth Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit Hi Alex, For now, gfxoff for navi10 is disabled by default, and I also verified on navi14 with both GFXOFF and FW_DSTATE feature bits toggled on. Hi Kenneth / Jack, Could you help to confirm the firmware version? BR, Xiaojie From: Deucher, Alexander mailto:alexander.deuc...@amd.com>> Sent: Wednesday, October 9, 2019 9:35 PM To: Yuan, Xiaojie mailto:xiaojie.y...@amd.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>> Cc: Xiao, Jack mailto:jack.x...@amd.com>>; Wang, Kevin(Yang) mailto:kevin1.w...@amd.com>>; Zhang, Hawking mailto:hawking.zh...@amd.com>>; Quan, Evan mailto:evan.q...@amd.com>>; Feng, Kenneth mailto:kenneth.f...@amd.com>> Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit What version of firmware has the fix? Was it recently fixed? We should check the version if the old one may be out in the wild. Alex From: amd-gfx mailto:amd-gfx-boun...@lists.freedesktop.org>> on behalf of Yuan, Xiaojie mailto:xiaojie.y...@amd.com>> Sent: Wednesday, October 9, 2019 7:08 AM To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>> Cc: Xiao, Jack mailto:jack.x...@amd.com>>; Wang, Kevin(Yang) mailto:kevin1.w...@amd.com>>; Zhang, Hawking mailto:hawking.zh...@amd.com>>; Quan, Evan mailto:evan.q...@amd.com>>; Feng, Kenneth mailto:kenneth.f...@amd.com>>; Yuan, Xiaojie mailto:xiaojie.y...@amd.com>> Subject: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit SMU firmware has fix the bug, so remove this workaround. Signed-off-by: Xiaojie Yuan mailto:xiaojie.y...@amd.com>> --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c index 44152c1f01c7..3628295469c4 100644 --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c @@ -359,11 +359,8 @@ navi10_get_allowed_feature_mask(struct smu_context *smu, | FEATURE_MASK(FEATURE_MEM_VDDCI_SCALING_BIT) | FEATURE_MASK(FEATURE_MEM_MVDD_SCALING_BIT); - if (adev->pm.pp_feature & PP_GFXOFF_MASK) { + if (adev->pm.pp_feature & PP_GFXOFF_MASK) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_GFXOFF_BIT); - /* TODO: remove it once fw fix the bug */ - *(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_FW_DSTATE_BIT); - } if (smu->adev->pg_flags & AMD_PG_SUPPORT_MMHUB) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_MMHUB_PG_BIT); -- 2.20.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> https://lists.freedesktop.org/mailman/listinfo/amd-gfx ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit
Acked-by: Alex Deucher From: Yuan, Xiaojie Sent: Friday, October 11, 2019 4:20 AM To: Deucher, Alexander ; Feng, Kenneth ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Wang, Kevin(Yang) ; Zhang, Hawking ; Quan, Evan Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit Hi there, Could someone give an RB or ACK? This patch has been verified on both navi12 and navi14. Thanks. BR, Xiaojie From: Deucher, Alexander Sent: Thursday, October 10, 2019 8:20 PM To: Feng, Kenneth ; Yuan, Xiaojie ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Wang, Kevin(Yang) ; Zhang, Hawking ; Quan, Evan Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit Great. thanks! Alex From: Feng, Kenneth Sent: Thursday, October 10, 2019 3:00 AM To: Yuan, Xiaojie ; Deucher, Alexander ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Wang, Kevin(Yang) ; Zhang, Hawking ; Quan, Evan Subject: RE: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit Hi Alex, This issue was navi10 specific and was found in May, 2019. It was early after the asic back, then since gfxoff was removed from navi10, we didn’t really verify which firmware version started to have a fix. For navi14/navi12, there’s no such issue at all. Sorry for losing the track of it. From: Yuan, Xiaojie Sent: Thursday, October 10, 2019 1:17 AM To: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Wang, Kevin(Yang) ; Zhang, Hawking ; Quan, Evan ; Feng, Kenneth Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit Hi Alex, For now, gfxoff for navi10 is disabled by default, and I also verified on navi14 with both GFXOFF and FW_DSTATE feature bits toggled on. Hi Kenneth / Jack, Could you help to confirm the firmware version? BR, Xiaojie From: Deucher, Alexander mailto:alexander.deuc...@amd.com>> Sent: Wednesday, October 9, 2019 9:35 PM To: Yuan, Xiaojie mailto:xiaojie.y...@amd.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>> Cc: Xiao, Jack mailto:jack.x...@amd.com>>; Wang, Kevin(Yang) mailto:kevin1.w...@amd.com>>; Zhang, Hawking mailto:hawking.zh...@amd.com>>; Quan, Evan mailto:evan.q...@amd.com>>; Feng, Kenneth mailto:kenneth.f...@amd.com>> Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit What version of firmware has the fix? Was it recently fixed? We should check the version if the old one may be out in the wild. Alex From: amd-gfx mailto:amd-gfx-boun...@lists.freedesktop.org>> on behalf of Yuan, Xiaojie mailto:xiaojie.y...@amd.com>> Sent: Wednesday, October 9, 2019 7:08 AM To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>> Cc: Xiao, Jack mailto:jack.x...@amd.com>>; Wang, Kevin(Yang) mailto:kevin1.w...@amd.com>>; Zhang, Hawking mailto:hawking.zh...@amd.com>>; Quan, Evan mailto:evan.q...@amd.com>>; Feng, Kenneth mailto:kenneth.f...@amd.com>>; Yuan, Xiaojie mailto:xiaojie.y...@amd.com>> Subject: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit SMU firmware has fix the bug, so remove this workaround. Signed-off-by: Xiaojie Yuan mailto:xiaojie.y...@amd.com>> --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c index 44152c1f01c7..3628295469c4 100644 --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c @@ -359,11 +359,8 @@ navi10_get_allowed_feature_mask(struct smu_context *smu, | FEATURE_MASK(FEATURE_MEM_VDDCI_SCALING_BIT) | FEATURE_MASK(FEATURE_MEM_MVDD_SCALING_BIT); - if (adev->pm.pp_feature & PP_GFXOFF_MASK) { + if (adev->pm.pp_feature & PP_GFXOFF_MASK) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_GFXOFF_BIT); - /* TODO: remove it once fw fix the bug */ - *(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_FW_DSTATE_BIT); - } if (smu->adev->pg_flags & AMD_PG_SUPPORT_MMHUB) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_MMHUB_PG_BIT); -- 2.20.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> https://lists.freedesktop.org/mailman/listinfo/amd-gfx ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit
Hi there, Could someone give an RB or ACK? This patch has been verified on both navi12 and navi14. Thanks. BR, Xiaojie From: Deucher, Alexander Sent: Thursday, October 10, 2019 8:20 PM To: Feng, Kenneth ; Yuan, Xiaojie ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Wang, Kevin(Yang) ; Zhang, Hawking ; Quan, Evan Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit Great. thanks! Alex From: Feng, Kenneth Sent: Thursday, October 10, 2019 3:00 AM To: Yuan, Xiaojie ; Deucher, Alexander ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Wang, Kevin(Yang) ; Zhang, Hawking ; Quan, Evan Subject: RE: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit Hi Alex, This issue was navi10 specific and was found in May, 2019. It was early after the asic back, then since gfxoff was removed from navi10, we didn’t really verify which firmware version started to have a fix. For navi14/navi12, there’s no such issue at all. Sorry for losing the track of it. From: Yuan, Xiaojie Sent: Thursday, October 10, 2019 1:17 AM To: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Wang, Kevin(Yang) ; Zhang, Hawking ; Quan, Evan ; Feng, Kenneth Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit Hi Alex, For now, gfxoff for navi10 is disabled by default, and I also verified on navi14 with both GFXOFF and FW_DSTATE feature bits toggled on. Hi Kenneth / Jack, Could you help to confirm the firmware version? BR, Xiaojie From: Deucher, Alexander mailto:alexander.deuc...@amd.com>> Sent: Wednesday, October 9, 2019 9:35 PM To: Yuan, Xiaojie mailto:xiaojie.y...@amd.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>> Cc: Xiao, Jack mailto:jack.x...@amd.com>>; Wang, Kevin(Yang) mailto:kevin1.w...@amd.com>>; Zhang, Hawking mailto:hawking.zh...@amd.com>>; Quan, Evan mailto:evan.q...@amd.com>>; Feng, Kenneth mailto:kenneth.f...@amd.com>> Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit What version of firmware has the fix? Was it recently fixed? We should check the version if the old one may be out in the wild. Alex From: amd-gfx mailto:amd-gfx-boun...@lists.freedesktop.org>> on behalf of Yuan, Xiaojie mailto:xiaojie.y...@amd.com>> Sent: Wednesday, October 9, 2019 7:08 AM To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>> Cc: Xiao, Jack mailto:jack.x...@amd.com>>; Wang, Kevin(Yang) mailto:kevin1.w...@amd.com>>; Zhang, Hawking mailto:hawking.zh...@amd.com>>; Quan, Evan mailto:evan.q...@amd.com>>; Feng, Kenneth mailto:kenneth.f...@amd.com>>; Yuan, Xiaojie mailto:xiaojie.y...@amd.com>> Subject: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit SMU firmware has fix the bug, so remove this workaround. Signed-off-by: Xiaojie Yuan mailto:xiaojie.y...@amd.com>> --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c index 44152c1f01c7..3628295469c4 100644 --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c @@ -359,11 +359,8 @@ navi10_get_allowed_feature_mask(struct smu_context *smu, | FEATURE_MASK(FEATURE_MEM_VDDCI_SCALING_BIT) | FEATURE_MASK(FEATURE_MEM_MVDD_SCALING_BIT); - if (adev->pm.pp_feature & PP_GFXOFF_MASK) { + if (adev->pm.pp_feature & PP_GFXOFF_MASK) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_GFXOFF_BIT); - /* TODO: remove it once fw fix the bug */ - *(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_FW_DSTATE_BIT); - } if (smu->adev->pg_flags & AMD_PG_SUPPORT_MMHUB) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_MMHUB_PG_BIT); -- 2.20.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> https://lists.freedesktop.org/mailman/listinfo/amd-gfx ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit
Great. thanks! Alex From: Feng, Kenneth Sent: Thursday, October 10, 2019 3:00 AM To: Yuan, Xiaojie ; Deucher, Alexander ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Wang, Kevin(Yang) ; Zhang, Hawking ; Quan, Evan Subject: RE: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit Hi Alex, This issue was navi10 specific and was found in May, 2019. It was early after the asic back, then since gfxoff was removed from navi10, we didn’t really verify which firmware version started to have a fix. For navi14/navi12, there’s no such issue at all. Sorry for losing the track of it. From: Yuan, Xiaojie Sent: Thursday, October 10, 2019 1:17 AM To: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Wang, Kevin(Yang) ; Zhang, Hawking ; Quan, Evan ; Feng, Kenneth Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit Hi Alex, For now, gfxoff for navi10 is disabled by default, and I also verified on navi14 with both GFXOFF and FW_DSTATE feature bits toggled on. Hi Kenneth / Jack, Could you help to confirm the firmware version? BR, Xiaojie From: Deucher, Alexander mailto:alexander.deuc...@amd.com>> Sent: Wednesday, October 9, 2019 9:35 PM To: Yuan, Xiaojie mailto:xiaojie.y...@amd.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>> Cc: Xiao, Jack mailto:jack.x...@amd.com>>; Wang, Kevin(Yang) mailto:kevin1.w...@amd.com>>; Zhang, Hawking mailto:hawking.zh...@amd.com>>; Quan, Evan mailto:evan.q...@amd.com>>; Feng, Kenneth mailto:kenneth.f...@amd.com>> Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit What version of firmware has the fix? Was it recently fixed? We should check the version if the old one may be out in the wild. Alex From: amd-gfx mailto:amd-gfx-boun...@lists.freedesktop.org>> on behalf of Yuan, Xiaojie mailto:xiaojie.y...@amd.com>> Sent: Wednesday, October 9, 2019 7:08 AM To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>> Cc: Xiao, Jack mailto:jack.x...@amd.com>>; Wang, Kevin(Yang) mailto:kevin1.w...@amd.com>>; Zhang, Hawking mailto:hawking.zh...@amd.com>>; Quan, Evan mailto:evan.q...@amd.com>>; Feng, Kenneth mailto:kenneth.f...@amd.com>>; Yuan, Xiaojie mailto:xiaojie.y...@amd.com>> Subject: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit SMU firmware has fix the bug, so remove this workaround. Signed-off-by: Xiaojie Yuan mailto:xiaojie.y...@amd.com>> --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c index 44152c1f01c7..3628295469c4 100644 --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c @@ -359,11 +359,8 @@ navi10_get_allowed_feature_mask(struct smu_context *smu, | FEATURE_MASK(FEATURE_MEM_VDDCI_SCALING_BIT) | FEATURE_MASK(FEATURE_MEM_MVDD_SCALING_BIT); - if (adev->pm.pp_feature & PP_GFXOFF_MASK) { + if (adev->pm.pp_feature & PP_GFXOFF_MASK) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_GFXOFF_BIT); - /* TODO: remove it once fw fix the bug */ - *(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_FW_DSTATE_BIT); - } if (smu->adev->pg_flags & AMD_PG_SUPPORT_MMHUB) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_MMHUB_PG_BIT); -- 2.20.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> https://lists.freedesktop.org/mailman/listinfo/amd-gfx ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
RE: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit
Hi Alex, This issue was navi10 specific and was found in May, 2019. It was early after the asic back, then since gfxoff was removed from navi10, we didn't really verify which firmware version started to have a fix. For navi14/navi12, there's no such issue at all. Sorry for losing the track of it. From: Yuan, Xiaojie Sent: Thursday, October 10, 2019 1:17 AM To: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Wang, Kevin(Yang) ; Zhang, Hawking ; Quan, Evan ; Feng, Kenneth Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit Hi Alex, For now, gfxoff for navi10 is disabled by default, and I also verified on navi14 with both GFXOFF and FW_DSTATE feature bits toggled on. Hi Kenneth / Jack, Could you help to confirm the firmware version? BR, Xiaojie From: Deucher, Alexander mailto:alexander.deuc...@amd.com>> Sent: Wednesday, October 9, 2019 9:35 PM To: Yuan, Xiaojie mailto:xiaojie.y...@amd.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>> Cc: Xiao, Jack mailto:jack.x...@amd.com>>; Wang, Kevin(Yang) mailto:kevin1.w...@amd.com>>; Zhang, Hawking mailto:hawking.zh...@amd.com>>; Quan, Evan mailto:evan.q...@amd.com>>; Feng, Kenneth mailto:kenneth.f...@amd.com>> Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit What version of firmware has the fix? Was it recently fixed? We should check the version if the old one may be out in the wild. Alex From: amd-gfx mailto:amd-gfx-boun...@lists.freedesktop.org>> on behalf of Yuan, Xiaojie mailto:xiaojie.y...@amd.com>> Sent: Wednesday, October 9, 2019 7:08 AM To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>> Cc: Xiao, Jack mailto:jack.x...@amd.com>>; Wang, Kevin(Yang) mailto:kevin1.w...@amd.com>>; Zhang, Hawking mailto:hawking.zh...@amd.com>>; Quan, Evan mailto:evan.q...@amd.com>>; Feng, Kenneth mailto:kenneth.f...@amd.com>>; Yuan, Xiaojie mailto:xiaojie.y...@amd.com>> Subject: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit SMU firmware has fix the bug, so remove this workaround. Signed-off-by: Xiaojie Yuan mailto:xiaojie.y...@amd.com>> --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c index 44152c1f01c7..3628295469c4 100644 --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c @@ -359,11 +359,8 @@ navi10_get_allowed_feature_mask(struct smu_context *smu, | FEATURE_MASK(FEATURE_MEM_VDDCI_SCALING_BIT) | FEATURE_MASK(FEATURE_MEM_MVDD_SCALING_BIT); - if (adev->pm.pp_feature & PP_GFXOFF_MASK) { + if (adev->pm.pp_feature & PP_GFXOFF_MASK) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_GFXOFF_BIT); - /* TODO: remove it once fw fix the bug */ - *(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_FW_DSTATE_BIT); - } if (smu->adev->pg_flags & AMD_PG_SUPPORT_MMHUB) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_MMHUB_PG_BIT); -- 2.20.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> https://lists.freedesktop.org/mailman/listinfo/amd-gfx ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit
Hi Alex, For now, gfxoff for navi10 is disabled by default, and I also verified on navi14 with both GFXOFF and FW_DSTATE feature bits toggled on. Hi Kenneth / Jack, Could you help to confirm the firmware version? BR, Xiaojie From: Deucher, Alexander Sent: Wednesday, October 9, 2019 9:35 PM To: Yuan, Xiaojie ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Wang, Kevin(Yang) ; Zhang, Hawking ; Quan, Evan ; Feng, Kenneth Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit What version of firmware has the fix? Was it recently fixed? We should check the version if the old one may be out in the wild. Alex From: amd-gfx on behalf of Yuan, Xiaojie Sent: Wednesday, October 9, 2019 7:08 AM To: amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Wang, Kevin(Yang) ; Zhang, Hawking ; Quan, Evan ; Feng, Kenneth ; Yuan, Xiaojie Subject: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit SMU firmware has fix the bug, so remove this workaround. Signed-off-by: Xiaojie Yuan --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c index 44152c1f01c7..3628295469c4 100644 --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c @@ -359,11 +359,8 @@ navi10_get_allowed_feature_mask(struct smu_context *smu, | FEATURE_MASK(FEATURE_MEM_VDDCI_SCALING_BIT) | FEATURE_MASK(FEATURE_MEM_MVDD_SCALING_BIT); - if (adev->pm.pp_feature & PP_GFXOFF_MASK) { + if (adev->pm.pp_feature & PP_GFXOFF_MASK) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_GFXOFF_BIT); - /* TODO: remove it once fw fix the bug */ - *(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_FW_DSTATE_BIT); - } if (smu->adev->pg_flags & AMD_PG_SUPPORT_MMHUB) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_MMHUB_PG_BIT); -- 2.20.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit
What version of firmware has the fix? Was it recently fixed? We should check the version if the old one may be out in the wild. Alex From: amd-gfx on behalf of Yuan, Xiaojie Sent: Wednesday, October 9, 2019 7:08 AM To: amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Wang, Kevin(Yang) ; Zhang, Hawking ; Quan, Evan ; Feng, Kenneth ; Yuan, Xiaojie Subject: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit SMU firmware has fix the bug, so remove this workaround. Signed-off-by: Xiaojie Yuan --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c index 44152c1f01c7..3628295469c4 100644 --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c @@ -359,11 +359,8 @@ navi10_get_allowed_feature_mask(struct smu_context *smu, | FEATURE_MASK(FEATURE_MEM_VDDCI_SCALING_BIT) | FEATURE_MASK(FEATURE_MEM_MVDD_SCALING_BIT); - if (adev->pm.pp_feature & PP_GFXOFF_MASK) { + if (adev->pm.pp_feature & PP_GFXOFF_MASK) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_GFXOFF_BIT); - /* TODO: remove it once fw fix the bug */ - *(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_FW_DSTATE_BIT); - } if (smu->adev->pg_flags & AMD_PG_SUPPORT_MMHUB) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_MMHUB_PG_BIT); -- 2.20.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx