Re: VRAM manager

2016-10-11 Thread Felix Kuehling
Thanks for the explanation (and the one on patch 1). The whole series is Reviewed-by: Felix Kuehling On 16-10-11 05:34 AM, Christian König wrote: > Hi Felix, > > the pfn (mem->start) is set by the address space manager to > AMDGPU_BO_INVALID_OFFSET which is a very high number. > > So setting th

Re: VRAM manager

2016-10-11 Thread Christian König
Hi Felix, the pfn (mem->start) is set by the address space manager to AMDGPU_BO_INVALID_OFFSET which is a very high number. So setting the lpfn to an explicit value for the validation will result in reallocation of the backing store because AMDGPU_BO_INVALID_OFFSET will always be larger than

Re: VRAM manager

2016-10-07 Thread Felix Kuehling
Hi Christian, I'm back from vacation and finally caught up with my email and code-review backlog. I added a comment on patch 1. I don't understand patch 2. I couldn't find where a non-0 lpfn would trigger any reallocation. I think this would have to be somewhere in ttm_bo_validate or ttm_bo_mem_

Re: VRAM manager

2016-09-27 Thread Edward O'Callaghan
This series is, to the best of my ability, Reviewed-by: Edward O'Callaghan On 09/27/2016 07:49 PM, Christian König wrote: > Hi guys, > > after fixing all those nasty little bugs this seems to be stable now. > > Anybody brave enough to give it an review? > > Cheers, > Christian. > > __

Re: VRAM manager

2016-09-27 Thread Mike Lothian
Hi Christian It's working for me on my Tonga now, thanks for fixing those bugs Feel free to add a testing by Cheers Mike On 27 September 2016 at 10:49, Christian König wrote: > Hi guys, > > after fixing all those nasty little bugs this seems to be stable now. > > Anybody brave enough to give