Re: libdrm/amdgpu - Fixup typedef not to hide pointer type

2016-09-16 Thread Christian König
Well thinking more about that what you probably could do is changing the typedefs to put the pointer into a single element structure. That should break only when somebody really abused the API and shouldn't change the ABI. Regards, Christian. Am 16.09.2016 um 11:12 schrieb Christian König:

Re: libdrm/amdgpu - Fixup typedef not to hide pointer type

2016-09-16 Thread Christian König
Am 16.09.2016 um 11:02 schrieb Edward O'Callaghan: Hi Christian, On 09/16/2016 06:49 PM, Christian König wrote: NAK, that is clearly an API breakage. It should have never been typedef'ed in the first place. Does that mean we would have to bump version for API change? What is the procedure ther

Re: libdrm/amdgpu - Fixup typedef not to hide pointer type

2016-09-16 Thread Edward O'Callaghan
Hi Christian, On 09/16/2016 06:49 PM, Christian König wrote: > NAK, that is clearly an API breakage. It should have never been typedef'ed in the first place. Does that mean we would have to bump version for API change? What is the procedure there? > > BTW: Why would we want to stop hiding the t

Re: libdrm/amdgpu - Fixup typedef not to hide pointer type

2016-09-16 Thread Christian König
NAK, that is clearly an API breakage. BTW: Why would we want to stop hiding the type? Christian. Am 16.09.2016 um 10:46 schrieb Edward O'Callaghan: Oops, turns out I mailed to dri-devel by mistake so resending here. The following series fixes up libdrm/amdgpu such that to not hide a pointer t

libdrm/amdgpu - Fixup typedef not to hide pointer type

2016-09-16 Thread Edward O'Callaghan
Oops, turns out I mailed to dri-devel by mistake so resending here. The following series fixes up libdrm/amdgpu such that to not hide a pointer type behind a typedef. Please Review, Edward O'Callaghan (3): [PATCH 1/3] amdgpu: Fix amdgpu_va_handle typedef not to hide pointer [PATCH 2/3] amdgpu: