Re: [android-building] $shell commands in Android.mk -> Android.bp migration.

2019-09-23 Thread Wesolowski, Krzysztof
-sync" action? BR, K Get Outlook for Android<https://aka.ms/ghei36> From: 'Dan Willemsen' via Android Building Sent: Friday, September 20, 2019 8:08:52 PM To: Android Building Subject: Re: [android-building] $shell commands in Android.mk -> An

Re: [android-building] $shell commands in Android.mk -> Android.bp migration.

2019-09-20 Thread 'Dan Willemsen' via Android Building
You'll need to execute conan before running the android build. It's not enforced yet, but the source tree is expected to be read-only during the build -- in particularly we start caching the Android.bp files nearly immediately upon build startup, so adding new ones isn't going to work. Nothing

Re: [android-building] $shell commands in Android.mk -> Android.bp migration.

2019-08-22 Thread 'Dan Willemsen' via Android Building
What is your pre-build-script.sh script doing? Right now, since it has no dependencies and no output files, you're essentially running it on every build, even when the user is only trying to compile a single file in a different section of the tree. That's deprecated since it has a huge performance

[android-building] $shell commands in Android.mk -> Android.bp migration.

2019-08-20 Thread Frederic Plourde
Hi android building ! I used to have this in one of my Android.mk makefiles : $(shell (cd $(LOCAL_PATH)/../../ && ./pre-build-script.sh)) but I just noticed that this practice is now discouraged on the Soong Android.bp build system >From the Build System Best Practices