Cookie parsing errors: conflicting information, expected token not present

2009-02-14 Thread Clinton Gormley
Hiya There has been some discussion about cookie parsing errors with libapreq2 on the modperl list, and Joe Schafer said: What version of apreq was this? And did you report it to the apreq-dev@ mailing list? While I have previously reported the errors I see to the modperl

Re: Cookie parsing errors: conflicting information, expected token not present

2009-02-16 Thread Clinton Gormley
Hiya Joe I realise that the cookies themselves may not be compliant, either because of bad JS or buggy clients, but CGI.pm manages to parse all of the examples below, in the same way that browsers try to cope with dodgy HTML. It'd be nice if libapreq were a bit more DWIM. apreq is

Re: Cookie parsing errors: conflicting information, expected token not present

2009-02-16 Thread Clinton Gormley
If you think CGI::Cookie (which is what CGI.pm uses) parses these cookies correctly, you really haven't looked carefully enough. The only thing CGI::Cookie does differently from libapreq2 is that it doesn't throw errors on stuff it doesn't understand. Whether that's a bug or a feature is

Re: Cookie parsing errors: conflicting information, expected token not present

2009-02-16 Thread Clinton Gormley
Tell you what I'll do- I'll throw the cookie headers you mentioned earlier into the test suite and see if I can adjust the parser to make better sense of them (no promises tho). What won't change is the error behavior- apreq will throw an error on invalid cookie headers, to alert you that

libapreq 2.12 failing with apache 2.2.14

2009-10-06 Thread Clinton Gormley
Hiya I'm installing apache 2.2.14 with libapreq 2.12, perl 5.8.9 and I'm getting the failures listed below. What more info do you need from me? thanks Clint waiting 60 seconds for server to start: ... waiting 60 seconds for server to start: ok (waited 2 secs) server

Re: libapreq 2.12 failing with apache 2.2.14

2009-10-08 Thread Clinton Gormley
Can you write a patch for our tests that just checks for text/*? Attached Is this just a bad test? Well they're dependent on LWP not being stupid with mime types and changing them without any notice. The fails aren't in any indicative of a problem with apreq's codebase. I was

Re: HttpOnly

2010-11-08 Thread Clinton Gormley
I see a patch in Debian which does this: http://www.mail-archive.com/debian-bugs-d...@lists.debian.org/msg543361.html thanks Clint The patch looks ok to me at first glance. If you're willing to write the unit test(s) for this, I'd be happy to help push this . thanks Issac -

Re: HttpOnly + [VOTE] TR libapreq-2.13

2010-11-12 Thread Clinton Gormley
On Fri, 2010-11-12 at 04:53 -0800, Joe Schaefer wrote: There's another patch from Clinton that we should apply too- it relates to test breakages coming from LWP's mime-type change for pod files. Oooh - well remembered. Here is the patch:

Re: HttpOnly

2010-11-12 Thread Clinton Gormley
Hiya On Fri, 2010-11-12 at 11:59 -0800, Mark Hedges wrote: On 08/11/2010 15:28, Issac Goldstand wrote: On 08/11/2010 15:25, Clinton Gormley wrote: I see a patch in Debian which does this: http://www.mail-archive.com/debian-bugs-d...@lists.debian.org/msg543361.html Sorry if I

Re: [ANNOUNCE] libapreq2-2.13 Released

2010-12-03 Thread Clinton Gormley
On Fri, 2010-12-03 at 11:52 +, is...@apache.org wrote: libapreq2-2.13 Released Callooh Callay! And now on to mod_perl 2.05! http://www.gossamer-threads.com/lists/modperl/dev/102192 thanks for releasing clint Changes with libapreq2-2.13 (released December 3, 2010) - HTTP Only Cookie