Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-05-06 Thread Morten Linderud via arch-dev-public
On Thu, Apr 30, 2020 at 04:58:01PM -0400, Eli Schwartz via arch-dev-public 
wrote:
> Why does it matter to makepkg how the go compiler downloads source code,
> or using which options? Any download that is done outside the source=()
> array is violating the PKGBUILD contract, and is not cached in $SRCDEST.
> It is therefore not persisted between successive clean chroot builds
> since those use a temporary $HOME and $BUILDDIR which is deleted between
> uses. And regardless of any other factors, it will not be able to work
> if the makepkg tool is executed in an environment where the network has
> been disabled.

Sure, any code downloaded outside of source violates the farily vague PKGBUILD
contract. However, if TU candidate starts using `patch` or `git submodule` in
either `build` or `check` you are going to raise an eyebrow. And you are most
likely going to say they need to go into `prepare`.

Source code modification doesn't belong in pkgver, build, nor check, nor
package. So why is Go, and it's silly compiler, an exception?

> So, we don't get caching and we don't get offline builds. That's beyond
> question.

One ecosystem gets closer to the goal. That is good enough, isn't it?

-- 
Morten Linderud
PGP: 9C02FF419FECBE16


signature.asc
Description: PGP signature


Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-05-06 Thread Morten Linderud via arch-dev-public
On Thu, Apr 30, 2020 at 12:56:30AM -0700, Anatol Pomozov via arch-dev-public 
wrote:
> And if we plan to encourage adding the cache warmup to all golang
> PKGBUILD (that's gonna be thousands of packages) then this extra
> complexity need be justified. Anyone who wants to follow our advise
> needs to have clear answers to following questions: Is this feature
> solely to avoid the download during the build() step or there is
> something else? Why downloading in build() is bad, does it hurt the
> users? What use-cases does show an advantage of the cache warmup..
> etc..

There are something like 140 packages using go today in our repositories today,
there is no need for some grand justification. The justification, if anything is
needed, is this RFC alone and the fact we should strive to follow the packaging
guidelines when applicable.

-- 
Morten Linderud
PGP: 9C02FF419FECBE16


signature.asc
Description: PGP signature