Re: [Architecture] [AppFac][Issue]Deployment Notification for Single Tenant Cartridges

2014-11-03 Thread Roshan Deniyage
Hi Dimuthu, +1 for the suggestion. we were thinking the same way. but the issue here is to get the modified artifact name list from the jgit api. There is no direct way of getting modified artifacts since, we keep all the version of the application artifacts as folders in the same master branc

Re: [Architecture] [AppFac][Issue]Deployment Notification for Single Tenant Cartridges

2014-11-03 Thread Roshan Deniyage
Hi harsha, You mean "pullResult.getFetchResult().getTrackingRefUpdates()" ? it has the updated branch names and internal objectId list. From those info can't get the updated artifacts. - I found a way to get the updated files list by doing the git tree diff as follows, (a) before calling the

Re: [Architecture] [AppFac][Issue]Deployment Notification for Single Tenant Cartridges

2014-11-03 Thread Dimuthu Leelarathne
Hi Roshan, I've been thinking about this a lot. I think we need to take a different approach. Since the message is published by Stratos it must not be AF specific. So i believe the ArtifactDeploymentCompletedEvent should have the following, Cartridge Alias + For each modified artefact it should

Re: [Architecture] [AppFac][Issue]Deployment Notification for Single Tenant Cartridges

2014-11-03 Thread Harsha Thirimanna
After doing JGit checkout, you will get CheckoutResult and there is a modified list. *Harsha Thirimanna* Senior Software Engineer; WSO2, Inc.; http://wso2.com * * *email: **hars...@wso2.com* * cell: +94 71 5186770 , +94 * *774617784twitter: **http://twitter.com/

Re: [Architecture] [AppFac][Issue]Deployment Notification for Single Tenant Cartridges

2014-11-02 Thread Imesh Gunaratne
Hi Roshan, On Fri, Oct 31, 2014 at 6:20 PM, Roshan Deniyage wrote: > Hi Devs, > Based on the previous discussion and decision, I'm in the process of > developing the improvement of the subject as follows, > > (1) Publish a new Event called "ArtifactDeploymentCompletedEvent" to the > "instan

Re: [Architecture] [AppFac][Issue]Deployment Notification for Single Tenant Cartridges

2014-11-02 Thread Udara Liyanage
Hi, When there are high number of artifacts, sending information of all artifacts will be inefficient. Could you check the existing GIT dep sync checkout method and check whether pulled file names are available. On Mon, Nov 3, 2014 at 6:31 AM, Harsha Thirimanna wrote: > Hi Roshan, > > Can't we

Re: [Architecture] [AppFac][Issue]Deployment Notification for Single Tenant Cartridges

2014-11-02 Thread Harsha Thirimanna
Hi Roshan, Can't we read last modified artifacts using GitBlit API from cartridge side ? Then we can return only relevant artifacts detail to the appfactory side. thanks On Fri, Oct 31, 2014 at 5:50 AM, Roshan Deniyage wrote: > Hi Devs, > Based on the previous discussion and decision,

Re: [Architecture] [AppFac][Issue]Deployment Notification for Single Tenant Cartridges

2014-11-02 Thread Dimuthu Leelarathne
On Fri, Oct 31, 2014 at 5:50 AM, Roshan Deniyage wrote: > Hi Devs, > Based on the previous discussion and decision, I'm in the process of > developing the improvement of the subject as follows, > > (1) Publish a new Event called "ArtifactDeploymentCompletedEvent" to the > "instance-notifier"

[Architecture] [AppFac][Issue]Deployment Notification for Single Tenant Cartridges

2014-10-31 Thread Roshan Deniyage
Hi Devs, Based on the previous discussion and decision, I'm in the process of developing the improvement of the subject as follows, (1) Publish a new Event called "ArtifactDeploymentCompletedEvent" to the "instance-notifier" topic of activemq of stratos side by each cartridge agent upon succe