Re: [arts-dev] Radar Monte Carlo Code
Oliver, Thanks for integrating the code into the ARTS repository. I’m currently working on enhancements that I would like to add in the future, so I’ll let you know when I am ready to commit them. I also want to come up with a simplified test, and some documentation, but that might take a little while. Cheers, Ian On Jan 10, 2017, at 9:22 AM, Oliver Lemke wrote: Hi Ian, I've committed your patch in arts-2-3-588. Thanks a lot for your contribution. If you have any additions/fixes in the future, we'd be happy to give you commit permissions for the repository. Just let me know and I'll setup an account for you. Cheers, Oliver > On 22 Dec 2016, at 19:06, Ian S. Adams wrote: > > Oliver, > > The ARTS SVN revision number is 10107. I did not include the patch file since > I have introduced newer code into ARTS that I am not ready to commit yet. > > Thanks, > Ian > > > > On Dec 22, 2016, at 7:37 AM, Oliver Lemke wrote: > > Hi Ian, > > Great to see that adding the Radar Monte Carlo code worked out so well. I'd > be happy to commit your code to the ARTS repository. But I won't manage > before January as I'm on vacation from tomorrow until January 5. > > To make it easier for me to commit the changes, could you please provide them > as a patch file? You can create it by running 'svn diff > radar.patch' in the > top-level arts directory. Alternatively, let me know on which exact ARTS SVN > revision number the files you provided are based upon (run 'svn info | grep > Revision' in the arts directory). > > This way I can apply the changes cleanly and don't accidentally revert > anything that has changed in the meantime. > > Thanks for helping to push ARTS forward! > > Happy Holidays, > Oliver > > >> On 21 Dec 2016, at 21:27, Ian S. Adams wrote: >> >> Dear ARTS Developers, >> >> Attached is the Monte Carlo code for solving the radiative transfer equation >> for a profiling weather radar. In developing the radar module, I expanded >> the functionality within mc_radar to rotate from the antenna frame to the >> ARTS reference frame used for radiative transfer calculations. This includes >> functionality to rotate the polarization basis to (and from for propagation >> away from the radar) the antenna boresight polarization basis. A README >> document accompanies the the code further explaining the additions. >> >> Cheers, >> Ian >> >> > > > > ___ > arts_dev.mi mailing list > arts_dev.mi@lists.uni-hamburg.de > https://mailman.rrz.uni-hamburg.de/mailman/listinfo/arts_dev.mi ___ arts_dev.mi mailing list arts_dev.mi@lists.uni-hamburg.de https://mailman.rrz.uni-hamburg.de/mailman/listinfo/arts_dev.mi
Re: [arts-dev] Radar Monte Carlo Code
Hi Ian, I've committed your patch in arts-2-3-588. Thanks a lot for your contribution. If you have any additions/fixes in the future, we'd be happy to give you commit permissions for the repository. Just let me know and I'll setup an account for you. Cheers, Oliver > On 22 Dec 2016, at 19:06, Ian S. Adams wrote: > > Oliver, > > The ARTS SVN revision number is 10107. I did not include the patch file since > I have introduced newer code into ARTS that I am not ready to commit yet. > > Thanks, > Ian > > > > On Dec 22, 2016, at 7:37 AM, Oliver Lemke wrote: > > Hi Ian, > > Great to see that adding the Radar Monte Carlo code worked out so well. I'd > be happy to commit your code to the ARTS repository. But I won't manage > before January as I'm on vacation from tomorrow until January 5. > > To make it easier for me to commit the changes, could you please provide them > as a patch file? You can create it by running 'svn diff > radar.patch' in the > top-level arts directory. Alternatively, let me know on which exact ARTS SVN > revision number the files you provided are based upon (run 'svn info | grep > Revision' in the arts directory). > > This way I can apply the changes cleanly and don't accidentally revert > anything that has changed in the meantime. > > Thanks for helping to push ARTS forward! > > Happy Holidays, > Oliver > > >> On 21 Dec 2016, at 21:27, Ian S. Adams wrote: >> >> Dear ARTS Developers, >> >> Attached is the Monte Carlo code for solving the radiative transfer equation >> for a profiling weather radar. In developing the radar module, I expanded >> the functionality within mc_radar to rotate from the antenna frame to the >> ARTS reference frame used for radiative transfer calculations. This includes >> functionality to rotate the polarization basis to (and from for propagation >> away from the radar) the antenna boresight polarization basis. A README >> document accompanies the the code further explaining the additions. >> >> Cheers, >> Ian >> >> > > > > ___ > arts_dev.mi mailing list > arts_dev.mi@lists.uni-hamburg.de > https://mailman.rrz.uni-hamburg.de/mailman/listinfo/arts_dev.mi ___ arts_dev.mi mailing list arts_dev.mi@lists.uni-hamburg.de https://mailman.rrz.uni-hamburg.de/mailman/listinfo/arts_dev.mi
Re: [arts-dev] Radar Monte Carlo Code
Patrick and Stefan, I have done some comparisons against yCloudRadar, and the comparisons look as close to perfect as possible using Monte Carlo integration. My plan is to come up with a method that can apply the Monte Carlo antenna sampling to any calculation of *y*. Joe mentioned you were investigating a way to sample slant paths in a 3D atmosphere to pass to RT4, and this might be a good way to account for finite antenna patterns. I’ve been working on polarimetric radar variables to include in both the single scattering and multiple scattering codes, and I hope to submit that in the future. I also need to create a test case that would be suitable to run as a check, as the one I have been using requires too much input data. As for the ppathFromRtePos2 issue, when I printed the interpolation weight to the screen, it displayed as an exact 1, but would it make sense to limit it to the 0 and 1 bounds (using min and max)? Cheers, Ian On Dec 22, 2016, at 5:45 AM, Stefan Buehler wrote: Dear Ian, yes, ok to commit also from my side. (Or we will sort out between Patrick, Oliver, and me how to integrate the code you sent.) This is really great. :-) Best wishes, Stefan > On 22 Dec 2016, at 08:46, Patrick Eriksson > wrote: > > Hi Ian, > > A very nice Christmas gift! > > I am on vacation but could not stop myself to take a first look at your > additions. Besides MCRadar itself, it's excellent that you have introduced a > sensor based treatment of the polarization, that is a very old ToDo for me > and presently one of the main shortcomings of ARTS. That stuff should also be > incorporated into yCalc. > > Did not expect ppathFromRtePos2 to be used here! That method is a bit of > quick hack, and I am happy if it turned out to work sufficiently well for you > (I expected much more crashes than 0.001%. Besides being a bit unstable, > ppathFromRtePos2 is slow. I assume refraction must be considered for > ground-based weather radars, but for other cases this can potentially be > handled both much faster and safer.) > > As yCloudRadar was also a quick thing from, I am also curious if you have > done any comparisons? > > Anyhow, most important right now is to get this into the repository version. > Not clear here if you want an OK from us to commit these additions, or if > making svn commits is not possible for you? > > You have a big OK from me (and I assume from all others as well) to commit. > This is great stuff and brings ARTS closer to be a complete tool for the > microwave region. > > (If we over here have to put this into svn it could take some time as it is > holiday times. I have no time until Jan. Anybody else?) > > Cheers, > > Patrick > > > > On 2016-12-21 21:27, Ian S. Adams wrote: >> Dear ARTS Developers, >> >> Attached is the Monte Carlo code for solving the radiative transfer >> equation for a profiling weather radar. In developing the radar module, >> I expanded the functionality within mc_radar to rotate from the antenna >> frame to the ARTS reference frame used for radiative transfer >> calculations. This includes functionality to rotate the polarization >> basis to (and from for propagation away from the radar) the antenna >> boresight polarization basis. A README document accompanies the the code >> further explaining the additions. >> >> Cheers, >> Ian >> >> >> >> >> >> >> >> *Ian Stuart Adams* >> >> Electronics Engineer, Remote Sensing Division >> >> U.S. Naval Research Laboratory >> >> *T * 202.767.1937 *F * 202.767.7885 *DSN * 297.1937 >> >> www.nrl.navy.mil >> >> >> >> >> >> >> >> ___ >> arts_dev.mi mailing list >> arts_dev.mi@lists.uni-hamburg.de >> https://mailman.rrz.uni-hamburg.de/mailman/listinfo/arts_dev.mi >> > ___ > arts_dev.mi mailing list > arts_dev.mi@lists.uni-hamburg.de > https://mailman.rrz.uni-hamburg.de/mailman/listinfo/arts_dev.mi ___ arts_dev.mi mailing list arts_dev.mi@lists.uni-hamburg.de https://mailman.rrz.uni-hamburg.de/mailman/listinfo/arts_dev.mi
Re: [arts-dev] Radar Monte Carlo Code
Oliver, The ARTS SVN revision number is 10107. I did not include the patch file since I have introduced newer code into ARTS that I am not ready to commit yet. Thanks, Ian On Dec 22, 2016, at 7:37 AM, Oliver Lemke wrote: Hi Ian, Great to see that adding the Radar Monte Carlo code worked out so well. I'd be happy to commit your code to the ARTS repository. But I won't manage before January as I'm on vacation from tomorrow until January 5. To make it easier for me to commit the changes, could you please provide them as a patch file? You can create it by running 'svn diff > radar.patch' in the top-level arts directory. Alternatively, let me know on which exact ARTS SVN revision number the files you provided are based upon (run 'svn info | grep Revision' in the arts directory). This way I can apply the changes cleanly and don't accidentally revert anything that has changed in the meantime. Thanks for helping to push ARTS forward! Happy Holidays, Oliver > On 21 Dec 2016, at 21:27, Ian S. Adams wrote: > > Dear ARTS Developers, > > Attached is the Monte Carlo code for solving the radiative transfer equation > for a profiling weather radar. In developing the radar module, I expanded the > functionality within mc_radar to rotate from the antenna frame to the ARTS > reference frame used for radiative transfer calculations. This includes > functionality to rotate the polarization basis to (and from for propagation > away from the radar) the antenna boresight polarization basis. A README > document accompanies the the code further explaining the additions. > > Cheers, > Ian > > ___ arts_dev.mi mailing list arts_dev.mi@lists.uni-hamburg.de https://mailman.rrz.uni-hamburg.de/mailman/listinfo/arts_dev.mi
Re: [arts-dev] Radar Monte Carlo Code
Hi Ian, Great to see that adding the Radar Monte Carlo code worked out so well. I'd be happy to commit your code to the ARTS repository. But I won't manage before January as I'm on vacation from tomorrow until January 5. To make it easier for me to commit the changes, could you please provide them as a patch file? You can create it by running 'svn diff > radar.patch' in the top-level arts directory. Alternatively, let me know on which exact ARTS SVN revision number the files you provided are based upon (run 'svn info | grep Revision' in the arts directory). This way I can apply the changes cleanly and don't accidentally revert anything that has changed in the meantime. Thanks for helping to push ARTS forward! Happy Holidays, Oliver > On 21 Dec 2016, at 21:27, Ian S. Adams wrote: > > Dear ARTS Developers, > > Attached is the Monte Carlo code for solving the radiative transfer equation > for a profiling weather radar. In developing the radar module, I expanded the > functionality within mc_radar to rotate from the antenna frame to the ARTS > reference frame used for radiative transfer calculations. This includes > functionality to rotate the polarization basis to (and from for propagation > away from the radar) the antenna boresight polarization basis. A README > document accompanies the the code further explaining the additions. > > Cheers, > Ian > > ___ arts_dev.mi mailing list arts_dev.mi@lists.uni-hamburg.de https://mailman.rrz.uni-hamburg.de/mailman/listinfo/arts_dev.mi
Re: [arts-dev] Radar Monte Carlo Code
Dear Ian, yes, ok to commit also from my side. (Or we will sort out between Patrick, Oliver, and me how to integrate the code you sent.) This is really great. :-) Best wishes, Stefan > On 22 Dec 2016, at 08:46, Patrick Eriksson > wrote: > > Hi Ian, > > A very nice Christmas gift! > > I am on vacation but could not stop myself to take a first look at your > additions. Besides MCRadar itself, it's excellent that you have introduced a > sensor based treatment of the polarization, that is a very old ToDo for me > and presently one of the main shortcomings of ARTS. That stuff should also be > incorporated into yCalc. > > Did not expect ppathFromRtePos2 to be used here! That method is a bit of > quick hack, and I am happy if it turned out to work sufficiently well for you > (I expected much more crashes than 0.001%. Besides being a bit unstable, > ppathFromRtePos2 is slow. I assume refraction must be considered for > ground-based weather radars, but for other cases this can potentially be > handled both much faster and safer.) > > As yCloudRadar was also a quick thing from, I am also curious if you have > done any comparisons? > > Anyhow, most important right now is to get this into the repository version. > Not clear here if you want an OK from us to commit these additions, or if > making svn commits is not possible for you? > > You have a big OK from me (and I assume from all others as well) to commit. > This is great stuff and brings ARTS closer to be a complete tool for the > microwave region. > > (If we over here have to put this into svn it could take some time as it is > holiday times. I have no time until Jan. Anybody else?) > > Cheers, > > Patrick > > > > On 2016-12-21 21:27, Ian S. Adams wrote: >> Dear ARTS Developers, >> >> Attached is the Monte Carlo code for solving the radiative transfer >> equation for a profiling weather radar. In developing the radar module, >> I expanded the functionality within mc_radar to rotate from the antenna >> frame to the ARTS reference frame used for radiative transfer >> calculations. This includes functionality to rotate the polarization >> basis to (and from for propagation away from the radar) the antenna >> boresight polarization basis. A README document accompanies the the code >> further explaining the additions. >> >> Cheers, >> Ian >> >> >> >> >> >> >> >> *Ian Stuart Adams* >> >> Electronics Engineer, Remote Sensing Division >> >> U.S. Naval Research Laboratory >> >> *T * 202.767.1937 *F * 202.767.7885 *DSN * 297.1937 >> >> www.nrl.navy.mil >> >> >> >> >> >> >> >> ___ >> arts_dev.mi mailing list >> arts_dev.mi@lists.uni-hamburg.de >> https://mailman.rrz.uni-hamburg.de/mailman/listinfo/arts_dev.mi >> > ___ > arts_dev.mi mailing list > arts_dev.mi@lists.uni-hamburg.de > https://mailman.rrz.uni-hamburg.de/mailman/listinfo/arts_dev.mi ___ arts_dev.mi mailing list arts_dev.mi@lists.uni-hamburg.de https://mailman.rrz.uni-hamburg.de/mailman/listinfo/arts_dev.mi
Re: [arts-dev] Radar Monte Carlo Code
Hi Ian, A very nice Christmas gift! I am on vacation but could not stop myself to take a first look at your additions. Besides MCRadar itself, it's excellent that you have introduced a sensor based treatment of the polarization, that is a very old ToDo for me and presently one of the main shortcomings of ARTS. That stuff should also be incorporated into yCalc. Did not expect ppathFromRtePos2 to be used here! That method is a bit of quick hack, and I am happy if it turned out to work sufficiently well for you (I expected much more crashes than 0.001%. Besides being a bit unstable, ppathFromRtePos2 is slow. I assume refraction must be considered for ground-based weather radars, but for other cases this can potentially be handled both much faster and safer.) As yCloudRadar was also a quick thing from, I am also curious if you have done any comparisons? Anyhow, most important right now is to get this into the repository version. Not clear here if you want an OK from us to commit these additions, or if making svn commits is not possible for you? You have a big OK from me (and I assume from all others as well) to commit. This is great stuff and brings ARTS closer to be a complete tool for the microwave region. (If we over here have to put this into svn it could take some time as it is holiday times. I have no time until Jan. Anybody else?) Cheers, Patrick On 2016-12-21 21:27, Ian S. Adams wrote: Dear ARTS Developers, Attached is the Monte Carlo code for solving the radiative transfer equation for a profiling weather radar. In developing the radar module, I expanded the functionality within mc_radar to rotate from the antenna frame to the ARTS reference frame used for radiative transfer calculations. This includes functionality to rotate the polarization basis to (and from for propagation away from the radar) the antenna boresight polarization basis. A README document accompanies the the code further explaining the additions. Cheers, Ian *Ian Stuart Adams* Electronics Engineer, Remote Sensing Division U.S. Naval Research Laboratory *T * 202.767.1937 *F * 202.767.7885 *DSN * 297.1937 www.nrl.navy.mil ___ arts_dev.mi mailing list arts_dev.mi@lists.uni-hamburg.de https://mailman.rrz.uni-hamburg.de/mailman/listinfo/arts_dev.mi ___ arts_dev.mi mailing list arts_dev.mi@lists.uni-hamburg.de https://mailman.rrz.uni-hamburg.de/mailman/listinfo/arts_dev.mi