---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/
---
(Updated May 22, 2014, 10:44 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/
---
(Updated May 21, 2014, 11:29 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/#review11942
---
/branches/12/main/bridge.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/#review11944
---
/branches/12/res/parking/parking_bridge_features.c
On May 21, 2014, 12:16 p.m., Matt Jordan wrote:
/branches/12/res/res_pjsip_refer.c, lines 145-146
https://reviewboard.asterisk.org/r/3485/diff/7/?file=58717#file58717line145
Is there any reason why the transfer_channel_data struct wasn't just
added to the refer_progress struct?
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/
---
(Updated May 21, 2014, 1:18 p.m.)
Review request for Asterisk Developers,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/#review11947
---
/branches/12/main/bridge_basic.c
On May 21, 2014, 3:09 p.m., Joshua Colp wrote:
/branches/12/main/bridge_basic.c, line 3156
https://reviewboard.asterisk.org/r/3485/diff/8/?file=58725#file58725line3156
So you've documented this as being an ao2 object and then it's not used
as one here. If someone else comes along
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/
---
(Updated May 21, 2014, 3:25 p.m.)
Review request for Asterisk Developers,
On May 21, 2014, 3:09 p.m., Joshua Colp wrote:
/branches/12/main/bridge_basic.c, line 3156
https://reviewboard.asterisk.org/r/3485/diff/8/?file=58725#file58725line3156
So you've documented this as being an ao2 object and then it's not used
as one here. If someone else comes along
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/#review11950
---
Ship it!
Ship It!
- Joshua Colp
On May 21, 2014, 8:25
On May 20, 2014, 8:47 a.m., Matt Jordan wrote:
/branches/12/include/asterisk/bridge.h, line 911
https://reviewboard.asterisk.org/r/3485/diff/6/?file=58657#file58657line911
Don't use a bit field; it's overkill and you're really just going to
waste space in the struct anyway.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/#review11927
---
/branches/12/include/asterisk/bridge.h
On May 20, 2014, 11 a.m., Joshua Colp wrote:
/branches/12/include/asterisk/bridge.h, lines 906-908
https://reviewboard.asterisk.org/r/3485/diff/6/?file=58657#file58657line906
This should be documented more since it's now a wrapper. Are there any
expectations? Should it be
On May 20, 2014, 11 a.m., Joshua Colp wrote:
/branches/12/res/parking/parking_bridge_features.c, lines 58-82
https://reviewboard.asterisk.org/r/3485/diff/6/?file=58663#file58663line58
What value does this add over just using transfer_channel_data directly?
Probably nothing. In an
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/#review11915
---
/branches/12/include/asterisk/bridge.h
On May 19, 2014, 9:11 a.m., Matt Jordan wrote:
/branches/12/include/asterisk/bridge.h, lines 951-953
https://reviewboard.asterisk.org/r/3485/diff/5/?file=58486#file58486line951
Terminal does not feel like a good name for this parameter.
What's more, in most blind
On May 19, 2014, 9:11 a.m., Matt Jordan wrote:
/branches/12/include/asterisk/bridge.h, lines 951-953
https://reviewboard.asterisk.org/r/3485/diff/5/?file=58486#file58486line951
Terminal does not feel like a good name for this parameter.
What's more, in most blind
On May 19, 2014, 9:11 a.m., Matt Jordan wrote:
/branches/12/include/asterisk/bridge.h, lines 951-953
https://reviewboard.asterisk.org/r/3485/diff/5/?file=58486#file58486line951
Terminal does not feel like a good name for this parameter.
What's more, in most blind
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/
---
(Updated May 19, 2014, 1:25 p.m.)
Review request for Asterisk Developers,
On May 14, 2014, 6:57 a.m., Joshua Colp wrote:
/branches/12/include/asterisk/parking.h, line 167
https://reviewboard.asterisk.org/r/3485/diff/4/?file=58327#file58327line167
The naming of this as new_channel_cb confuses me...
This is a carried over from the name it has in bridge.h -
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/
---
(Updated May 16, 2014, 5:02 p.m.)
Review request for Asterisk Developers,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/#review11887
---
/branches/12/include/asterisk/parking.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/
---
(Updated May 8, 2014, 12:40 p.m.)
Review request for Asterisk Developers,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/#review11861
---
/branches/12/res/res_pjsip_refer.c
On May 8, 2014, 3:22 p.m., Joshua Colp wrote:
/branches/12/res/res_pjsip_refer.c, lines 185-193
https://reviewboard.asterisk.org/r/3485/diff/4/?file=58332#file58332line185
I need time to grok your other changes and the possible repercussions
but I'll comment on this right now.
On May 8, 2014, 3:22 p.m., Joshua Colp wrote:
/branches/12/res/res_pjsip_refer.c, lines 185-193
https://reviewboard.asterisk.org/r/3485/diff/4/?file=58332#file58332line185
I need time to grok your other changes and the possible repercussions
but I'll comment on this right now.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/
---
(Updated April 29, 2014, 10:47 a.m.)
Review request for Asterisk
On April 28, 2014, 5:14 p.m., Matt Jordan wrote:
/branches/12/res/res_pjsip_refer.c, lines 898-906
https://reviewboard.asterisk.org/r/3485/diff/1/?file=57945#file57945line898
This feels like the wrong way to solve this problem. Having a 'parked'
variable bleed up into this
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/#review11770
---
I've got a new patch in the works for this that adds the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/
---
(Updated April 28, 2014, 2:10 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/#review11771
---
Ship it!
Yes, I like this much better! Much better than what
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/#review11772
---
/branches/12/res/parking/parking_bridge_features.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/#review11774
---
Ship it!
Ship It!
- Matt Jordan
On April 28, 2014, 2:10
On April 28, 2014, 12:14 p.m., Matt Jordan wrote:
/branches/12/res/res_pjsip_refer.c, lines 898-906
https://reviewboard.asterisk.org/r/3485/diff/1/?file=57945#file57945line898
This feels like the wrong way to solve this problem. Having a 'parked'
variable bleed up into this
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/
---
Review request for Asterisk Developers, Matt Jordan and Mark Michelson.
36 matches
Mail list logo
