Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

2015-03-28 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4526/ --- (Updated March 28, 2015, 7:54 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

2015-03-27 Thread Diederik de Groot
On March 26, 2015, 6:37 p.m., Diederik de Groot wrote: /branches/13/funcs/func_env.c, line 728 https://reviewboard.asterisk.org/r/4526/diff/1/?file=72920#file72920line728 Note the double closing parens after the first sizeof, i actually finishes the ast_str_append_substr command

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

2015-03-27 Thread Matt Jordan
On March 26, 2015, 12:37 p.m., Diederik de Groot wrote: /branches/13/funcs/func_env.c, line 728 https://reviewboard.asterisk.org/r/4526/diff/1/?file=72920#file72920line728 Note the double closing parens after the first sizeof, i actually finishes the ast_str_append_substr command

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

2015-03-27 Thread Diederik de Groot
On March 26, 2015, 6:37 p.m., Diederik de Groot wrote: /branches/13/funcs/func_env.c, line 728 https://reviewboard.asterisk.org/r/4526/diff/1/?file=72920#file72920line728 Note the double closing parens after the first sizeof, i actually finishes the ast_str_append_substr command

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

2015-03-27 Thread Diederik de Groot
On March 26, 2015, 6:37 p.m., Diederik de Groot wrote: /branches/13/funcs/func_env.c, line 728 https://reviewboard.asterisk.org/r/4526/diff/1/?file=72920#file72920line728 Note the double closing parens after the first sizeof, i actually finishes the ast_str_append_substr command

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

2015-03-27 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4526/#review14926 --- Ship it! Ship It! - Matt Jordan On March 27, 2015, 6:09

[asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

2015-03-26 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4526/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24917

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

2015-03-26 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4526/#review14855 --- /branches/13/funcs/func_env.c

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

2015-03-26 Thread Matt Jordan
On March 26, 2015, 12:37 p.m., Diederik de Groot wrote: /branches/13/funcs/func_env.c, line 728 https://reviewboard.asterisk.org/r/4526/diff/1/?file=72920#file72920line728 Note the double closing parens after the first sizeof, i actually finishes the ast_str_append_substr command

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

2015-03-26 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4526/#review14870 --- /branches/13/apps/app_queue.c