[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-13 Thread Corey Farrell (Code Review)
Corey Farrell has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 5: Code-Review+1 Used grep, found a few tests that were still using parameters with the new

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-13 Thread Corey Farrell (Code Review)
Hello George Joseph, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/58 to look at the new patch set (#5). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-13 Thread Joshua Colp (Code Review)
Joshua Colp has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 5: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/58 To unsubscribe,

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 1: (1 comment) https://gerrit.asterisk.org/#/c/58/1/cel/cel_radius.c File cel/cel_radius.c:

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread Matt Jordan (Code Review)
Hello George Joseph, Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/58 to look at the new patch set (#3). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread Matt Jordan (Code Review)
Hello George Joseph, Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/58 to look at the new patch set (#2). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 4: Code-Review+1 Compile succeeded. -- To view, visit https://gerrit.asterisk.org/58 To

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread George Joseph (Code Review)
Hello Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/58 to look at the new patch set (#4). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 1: Code-Review-1 (1 comment) Compile fails.

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread Corey Farrell (Code Review)
Corey Farrell has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 3: Code-Review-1 (9 comments) https://gerrit.asterisk.org/#/c/54/3//COMMIT_MSG Commit

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread Matt Jordan (Code Review)
Hello Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/54 to look at the new patch set (#5). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread Matt Jordan (Code Review)
Hello Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/54 to look at the new patch set (#4). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 3: (3 comments) https://gerrit.asterisk.org/#/c/54/3/include/asterisk.h File

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread Corey Farrell (Code Review)
Corey Farrell has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/58 To unsubscribe, visit

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new patch set (#3). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git migration: Refactor the ASTERISK_FILE_VERSION macro Git does not support the ability to replace a

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 3: Note for reviewers: This patch will break ABI, and can't be backported as-is. Once

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new patch set (#2). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git migration: Refactor the ASTERISK_FILE_VERSION macro Git does not support the ability to replace a