Re: [asterisk-dev] Team branches and gerrit

2015-04-27 Thread Russell Bryant
On Mon, Apr 27, 2015 at 8:20 AM, Olle E. Johansson o...@edvina.net wrote: On 24 Apr 2015, at 15:42, Russell Bryant russ...@russellbryant.net wrote: On Fri, Apr 24, 2015 at 8:31 AM, Joshua Colp jc...@digium.com wrote: Olle E. Johansson wrote: Playing around following Matt's wiki page on

Re: [asterisk-dev] Team branches and gerrit

2015-04-27 Thread Olle E. Johansson
On 24 Apr 2015, at 15:42, Russell Bryant russ...@russellbryant.net wrote: On Fri, Apr 24, 2015 at 8:31 AM, Joshua Colp jc...@digium.com wrote: Olle E. Johansson wrote: Playing around following Matt's wiki page on gerrit usage, I created a team branch and did two commits. When pushing it with

Re: [asterisk-dev] Team branches and gerrit

2015-04-27 Thread Olle E. Johansson
On 27 Apr 2015, at 14:55, Russell Bryant russ...@russellbryant.net wrote: On Mon, Apr 27, 2015 at 8:20 AM, Olle E. Johansson o...@edvina.net wrote: On 24 Apr 2015, at 15:42, Russell Bryant russ...@russellbryant.net wrote: On Fri, Apr 24, 2015 at 8:31 AM, Joshua Colp jc...@digium.com

Re: [asterisk-dev] Team branches and gerrit

2015-04-24 Thread Joshua Colp
Olle E. Johansson wrote: Playing around following Matt's wiki page on gerrit usage, I created a team branch and did two commits. When pushing it with git review {branch} only the last commit shows up. Is that the way it's supposed to be? I thought the whole branch was the review subject, not

Re: [asterisk-dev] Team branches and gerrit

2015-04-24 Thread Russell Bryant
On Fri, Apr 24, 2015 at 8:31 AM, Joshua Colp jc...@digium.com wrote: Olle E. Johansson wrote: Playing around following Matt's wiki page on gerrit usage, I created a team branch and did two commits. When pushing it with git review {branch} only the last commit shows up. Is that the way it's

Re: [asterisk-dev] Team branches and gerrit

2015-04-24 Thread Russell Bryant
On Fri, Apr 24, 2015 at 12:17 PM, Matthew Jordan mjor...@digium.com wrote: On Fri, Apr 24, 2015 at 8:42 AM, Russell Bryant russ...@russellbryant.net wrote: On Fri, Apr 24, 2015 at 8:31 AM, Joshua Colp jc...@digium.com wrote: Olle E. Johansson wrote: Playing around following Matt's

[asterisk-dev] Team branches and gerrit

2015-04-23 Thread Olle E. Johansson
Playing around following Matt's wiki page on gerrit usage, I created a team branch and did two commits. When pushing it with git review {branch} only the last commit shows up. Is that the way it's supposed to be? I thought the whole branch was the review subject, not just a single commit. /O