Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-02-10 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3155/ --- (Updated Feb. 10, 2014, 10:37 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-02-07 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3155/ --- (Updated Feb. 7, 2014, 8:57 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-02-07 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3155/#review10835 --- Ship it! This is good as is. I just have a minor concern

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-02-06 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3155/#review10780 --- Ship it! Ship It! - Matt Jordan On Jan. 30, 2014, 4:21

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-02-06 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3155/#review10795 --- branches/11/apps/confbridge/conf_state_multi_marked.c

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-01-30 Thread opticron
On Jan. 29, 2014, 9:34 a.m., Matt Jordan wrote: branches/11/apps/confbridge/conf_state_multi_marked.c, line 203 https://reviewboard.asterisk.org/r/3155/diff/3/?file=53245#file53245line203 I don't think this is the right sound file. Whey aren't we playing CONF_SOUND_PLACE_IN_CONF

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-01-30 Thread Matt Jordan
On Jan. 29, 2014, 9:34 a.m., Matt Jordan wrote: branches/11/apps/confbridge/conf_state_multi_marked.c, line 203 https://reviewboard.asterisk.org/r/3155/diff/3/?file=53245#file53245line203 I don't think this is the right sound file. Whey aren't we playing CONF_SOUND_PLACE_IN_CONF

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-01-30 Thread opticron
On Jan. 29, 2014, 9:34 a.m., Matt Jordan wrote: branches/11/apps/confbridge/conf_state_multi_marked.c, line 203 https://reviewboard.asterisk.org/r/3155/diff/3/?file=53245#file53245line203 I don't think this is the right sound file. Whey aren't we playing CONF_SOUND_PLACE_IN_CONF

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-01-30 Thread Matt Jordan
On Jan. 29, 2014, 9:34 a.m., Matt Jordan wrote: branches/11/apps/confbridge/conf_state_multi_marked.c, line 203 https://reviewboard.asterisk.org/r/3155/diff/3/?file=53245#file53245line203 I don't think this is the right sound file. Whey aren't we playing CONF_SOUND_PLACE_IN_CONF

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-01-30 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3155/ --- (Updated Jan. 30, 2014, 4:21 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-01-29 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3155/ --- (Updated Jan. 29, 2014, 8:26 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-01-29 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3155/#review10713 --- branches/11/apps/confbridge/conf_state_multi_marked.c

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-01-28 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3155/#review10708 --- If you haven't already, run the ConfBridge tests in the

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-01-24 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3155/#review10690 --- branches/11/apps/confbridge/conf_state_multi_marked.c