[asterisk-dev] Change in asterisk[11]: git migration: Remove support for file versions

Matt Jordan has posted comments on this change. Change subject: git migration: Remove support for file versions .. Patch Set 1: (1 comment) https://gerrit.asterisk.org/#/c/61/1/main/asterisk.c File main/asterisk.c: Line 390:

Re: [asterisk-dev] Gerrit plugin suggestions

On Sun, Apr 12, 2015 at 8:01 PM, Matthew Jordan mjor...@digium.com wrote: On Sun, Apr 12, 2015 at 7:04 PM, George Joseph george.jos...@fairview5.com wrote: menuextender: Allows the creation of additional menu items. I'd suggest using this for adding links to various wiki pages,

[asterisk-dev] Gerrit plugin suggestions

menuextender: Allows the creation of additional menu items. I'd suggest using this for adding links to various wiki pages, git.asterisk.org, etc. reviewers-by-blame: This might be a little too much but it automatically adds reviewers to a change based on who last changed the affected lines.

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

Matt Jordan has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 1: (1 comment) https://gerrit.asterisk.org/#/c/58/1/cel/cel_radius.c File cel/cel_radius.c:

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

Hello George Joseph, Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/58 to look at the new patch set (#3). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro

Re: [asterisk-dev] How to get peer review for patch to deprecated module

On Sun, Apr 12, 2015 at 11:26 AM, Alex Villací­s Lasso a_villa...@palosanto.com wrote: El 11/04/15 a las 22:59, Matthew Jordan escribió: On Sat, Apr 11, 2015 at 4:31 PM, Alex Villacís Lasso a_villa...@palosanto.com wrote: snip I'd recommend doing the following: * Re-open ASTERISK-20347

[asterisk-dev] Change in testsuite[master]: PEP8 fixes

George Joseph has posted comments on this change. Change subject: PEP8 fixes .. Patch Set 1: Code-Review-1 Ran the first 10 pjsip tests and all failed but 1. They all pass in master. -- To view, visit

[asterisk-dev] Change in asterisk[13]: git migration: Remove support for file versions

Hello Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/60 to look at the new patch set (#2). Change subject: git migration: Remove support for file versions .. git migration:

[asterisk-dev] Change in asterisk[11]: git migration: Remove support for file versions

Matt Jordan has uploaded a new patch set (#3). Change subject: git migration: Remove support for file versions .. git migration: Remove support for file versions Git does not support the ability to replace a token with a

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

Hello George Joseph, Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/58 to look at the new patch set (#2). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

George Joseph has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 4: Code-Review+1 Compile succeeded. -- To view, visit https://gerrit.asterisk.org/58 To

[asterisk-dev] Change in asterisk[11]: git migration: Remove support for file versions

Matt Jordan has uploaded a new patch set (#2). Change subject: git migration: Remove support for file versions .. git migration: Remove support for file versions Git does not support the ability to replace a token with a

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

Hello Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/58 to look at the new patch set (#4). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git

Re: [asterisk-dev] Gerrit plugin suggestions

On Sun, Apr 12, 2015 at 7:04 PM, George Joseph george.jos...@fairview5.com wrote: menuextender: Allows the creation of additional menu items. I'd suggest using this for adding links to various wiki pages, git.asterisk.org, etc. Added. Right now I've just got it linking to the issue tracker

Re: [asterisk-dev] [Code Review] 4391: Add blank line between headers and output for Command action response

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4391/ --- (Updated April 13, 2015, 5 p.m.) Review request for Asterisk Developers.

[asterisk-dev] Change in repotools[master]: mapmantis: Remove dependency on digium_jira

Matt Jordan has uploaded a new patch set (#2). Change subject: mapmantis: Remove dependency on digium_jira .. mapmantis: Remove dependency on digium_jira This patch removes the dependency of mapmantis from the digium_jira

[asterisk-dev] Change in asterisk[13]: git migration: Remove support for file versions

Corey Farrell has posted comments on this change. Change subject: git migration: Remove support for file versions .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/60 To unsubscribe, visit

[asterisk-dev] Change in asterisk[11]: git migration: Remove support for file versions

Corey Farrell has posted comments on this change. Change subject: git migration: Remove support for file versions .. Patch Set 1: Code-Review+1 (1 comment) So I'm a bit indifferent about the finding against main/asterisk.c,

[asterisk-dev] Change in asterisk[11]: git migration: Remove support for file versions

Corey Farrell has posted comments on this change. Change subject: git migration: Remove support for file versions .. Patch Set 1: (1 comment) https://gerrit.asterisk.org/#/c/61/1/main/asterisk.c File main/asterisk.c: Line

[asterisk-dev] Change in asterisk[11]: git migration: Remove support for file versions

Corey Farrell has posted comments on this change. Change subject: git migration: Remove support for file versions .. Patch Set 1: -Code-Review (1 comment) https://gerrit.asterisk.org/#/c/61/1/main/asterisk.c File

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

George Joseph has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 1: Code-Review-1 (1 comment) Compile fails.

Re: [asterisk-dev] Git Migration update

On Sat, Apr 11, 2015 at 10:15 PM, Matthew Jordan mjor...@digium.com wrote: Hey everyone - As an update on the Git migration, here is the current state of the world: 1. The SVN repos have been marked read-only. While you will still be able to checkout from SVN, you shouldn't commit to any of

Re: [asterisk-dev] [Code Review] 4108: Weak Proxy Objects

On April 10, 2015, 7:05 p.m., rmudgett wrote: I'm posting my next diff here, then I will discard this review then post the same change to gerrit. This way you can look at reviewboard to see the changes between patches. On April 10, 2015, 7:05 p.m., rmudgett wrote:

Re: [asterisk-dev] [Code Review] 4108: Weak Proxy Objects

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4108/ --- (Updated April 12, 2015, 5:24 a.m.) Review request for Asterisk

[asterisk-dev] Change in asterisk[master]: astobj2: Add support for weakproxy objects.

Corey Farrell has uploaded a new change for review. https://gerrit.asterisk.org/56 Change subject: astobj2: Add support for weakproxy objects. .. astobj2: Add support for weakproxy objects. This implements weak references.

Re: [asterisk-dev] [Code Review] 4108: Weak Proxy Objects

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4108/ --- (Updated April 12, 2015, 5:29 a.m.) Status -- This change has been

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

Corey Farrell has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 3: Code-Review-1 (9 comments) https://gerrit.asterisk.org/#/c/54/3//COMMIT_MSG Commit

[asterisk-dev] Change in asterisk[master]: main/editline: Add .gitignore.

Corey Farrell has uploaded a new change for review. https://gerrit.asterisk.org/57 Change subject: main/editline: Add .gitignore. .. main/editline: Add .gitignore. This patch adds a .gitignore for main/editline to ignore all

[asterisk-dev] Change in asterisk[master]: main/editline: Add .gitignore.

Tzafrir Cohen has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Why is it not included in the main .ignore? main/editline/Makefile etc. -- To view, visit

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

Hello Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/54 to look at the new patch set (#5). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git

[asterisk-dev] Change in asterisk[master]: main/editline: Add .gitignore.

George Joseph has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Code-Review+1 Good catch. I always use the external editline so the internal one never gets built. -- To

Re: [asterisk-dev] How to get peer review for patch to deprecated module

El 11/04/15 a las 22:59, Matthew Jordan escribió: On Sat, Apr 11, 2015 at 4:31 PM, Alex Villacís Lasso a_villa...@palosanto.com wrote: El 10/04/15 a las 14:16, Alex Villací­s Lasso escribió: El 08/04/15 a las 08:22, Vinicius Fontes escribió: Have you tried Asterisk 13? The bridging mechanism

[asterisk-dev] Change in asterisk[master]: git migration: Remove support for file versions

Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/59 Change subject: git migration: Remove support for file versions .. git migration: Remove support for file versions Git does not support the

[asterisk-dev] Change in asterisk[master]: git migration: Remove support for file versions

Matt Jordan has abandoned this change. Change subject: git migration: Remove support for file versions .. Abandoned -- To view, visit https://gerrit.asterisk.org/59 To unsubscribe, visit https://gerrit.asterisk.org/settings

[asterisk-dev] Change in asterisk[master]: .gitignore: Ignore tarballs (*.gz)

Matt Jordan has posted comments on this change. Change subject: .gitignore: Ignore tarballs (*.gz) .. Patch Set 2: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/55 To unsubscribe, visit

[asterisk-dev] Change in asterisk[master]: .gitignore: Ignore tarballs (*.gz)

Matt Jordan has submitted this change and it was merged. Change subject: .gitignore: Ignore tarballs (*.gz) .. .gitignore: Ignore tarballs (*.gz) This patch updates the root .gitignore file to ignore files with a .gz

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

Hello Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/54 to look at the new patch set (#4). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

Matt Jordan has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 3: (3 comments) https://gerrit.asterisk.org/#/c/54/3/include/asterisk.h File

[asterisk-dev] Change in asterisk[master]: main/editline: Add .gitignore.

George Joseph has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Why is it not included in the main .ignore? main/editline/Makefile etc. We decided that the ignores

[asterisk-dev] Change in asterisk[master]: git migration: Remove support for file versions

Matt Jordan has abandoned this change. Change subject: git migration: Remove support for file versions .. Abandoned Blech. This patch kind of got messed up in the process of trying to put up the Asterisk 13 version. I'm going

[asterisk-dev] Change in asterisk[13]: git migration: Remove support for file versions

Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/60 Change subject: git migration: Remove support for file versions .. git migration: Remove support for file versions Git does not support the

[asterisk-dev] Change in asterisk[master]: git migration: Remove support for file versions

Hello Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/54 to look at the new patch set (#6). Change subject: git migration: Remove support for file versions .. git migration:

[asterisk-dev] Change in asterisk[11]: main/editline: Add .gitignore.

Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/67 Change subject: main/editline: Add .gitignore. .. main/editline: Add .gitignore. This patch adds a .gitignore for main/editline to ignore all

[asterisk-dev] Change in asterisk[11]: Add .gitignore and .gitreview files

Hello George Joseph, I'd like you to do a code review. Please visit https://gerrit.asterisk.org/64 to review the following change. Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview

[asterisk-dev] Change in asterisk[master]: main/editline: Add .gitignore.

Matt Jordan has submitted this change and it was merged. Change subject: main/editline: Add .gitignore. .. main/editline: Add .gitignore. This patch adds a .gitignore for main/editline to ignore all build results. Change-Id:

[asterisk-dev] Change in asterisk[master]: main/editline: Add .gitignore.

Matt Jordan has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/57 To unsubscribe, visit

[asterisk-dev] Change in asterisk[13]: main/editline: Add .gitignore.

Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/66 Change subject: main/editline: Add .gitignore. .. main/editline: Add .gitignore. This patch adds a .gitignore for main/editline to ignore all

[asterisk-dev] Change in testsuite[master]: PEP8 fixes

Matt Jordan has posted comments on this change. Change subject: PEP8 fixes .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/40 To unsubscribe, visit https://gerrit.asterisk.org/settings

[asterisk-dev] Change in asterisk[11]: Add .gitignore and .gitreview files

George Joseph has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/64 To unsubscribe, visit

[asterisk-dev] Change in asterisk[13]: main/editline: Add .gitignore.

George Joseph has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/66 To unsubscribe, visit

[asterisk-dev] Change in asterisk[11]: main/editline: Add .gitignore.

George Joseph has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/67 To unsubscribe, visit

[asterisk-dev] Change in asterisk[13]: Add .gitignore and .gitreview files

George Joseph has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/62 To unsubscribe, visit

[asterisk-dev] Change in asterisk[11]: .gitignore: Ignore tarballs (*.gz)

George Joseph has posted comments on this change. Change subject: .gitignore: Ignore tarballs (*.gz) .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/65 To unsubscribe, visit

[asterisk-dev] Change in asterisk[13]: .gitignore: Ignore tarballs (*.gz)

George Joseph has posted comments on this change. Change subject: .gitignore: Ignore tarballs (*.gz) .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/63 To unsubscribe, visit

[asterisk-dev] Change in asterisk[13]: .gitignore: Ignore tarballs (*.gz)

Matt Jordan has posted comments on this change. Change subject: .gitignore: Ignore tarballs (*.gz) .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/63 To unsubscribe, visit

[asterisk-dev] Change in asterisk[13]: Add .gitignore and .gitreview files

Matt Jordan has submitted this change and it was merged. Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview files Add the .gitignore and .gitreview files to the asterisk repo. NB: You can

[asterisk-dev] Change in asterisk[11]: main/editline: Add .gitignore.

Matt Jordan has submitted this change and it was merged. Change subject: main/editline: Add .gitignore. .. main/editline: Add .gitignore. This patch adds a .gitignore for main/editline to ignore all build results. Change-Id:

[asterisk-dev] Change in asterisk[13]: .gitignore: Ignore tarballs (*.gz)

Matt Jordan has submitted this change and it was merged. Change subject: .gitignore: Ignore tarballs (*.gz) .. .gitignore: Ignore tarballs (*.gz) This patch updates the root .gitignore file to ignore files with a .gz

[asterisk-dev] Change in asterisk[13]: main/editline: Add .gitignore.

Matt Jordan has submitted this change and it was merged. Change subject: main/editline: Add .gitignore. .. main/editline: Add .gitignore. This patch adds a .gitignore for main/editline to ignore all build results. Change-Id:

[asterisk-dev] Change in asterisk[13]: Add .gitignore and .gitreview files

Matt Jordan has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/62 To unsubscribe, visit

[asterisk-dev] Change in asterisk[13]: main/editline: Add .gitignore.

Matt Jordan has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/66 To unsubscribe, visit

[asterisk-dev] Change in asterisk[11]: .gitignore: Ignore tarballs (*.gz)

Matt Jordan has posted comments on this change. Change subject: .gitignore: Ignore tarballs (*.gz) .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/65 To unsubscribe, visit

[asterisk-dev] Change in asterisk[11]: main/editline: Add .gitignore.

Matt Jordan has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.asterisk.org/67 To unsubscribe, visit

[asterisk-dev] Change in asterisk[11]: Add .gitignore and .gitreview files

Matt Jordan has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/64 To unsubscribe, visit

[asterisk-dev] Change in asterisk[11]: main/editline: Add .gitignore.

Matt Jordan has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.asterisk.org/67 To unsubscribe, visit

[asterisk-dev] Change in asterisk[11]: Add .gitignore and .gitreview files

Matt Jordan has submitted this change and it was merged. Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview files Add the .gitignore and .gitreview files to the asterisk repo. NB: You can

[asterisk-dev] Change in asterisk[11]: .gitignore: Ignore tarballs (*.gz)

Matt Jordan has submitted this change and it was merged. Change subject: .gitignore: Ignore tarballs (*.gz) .. .gitignore: Ignore tarballs (*.gz) This patch updates the root .gitignore file to ignore files with a .gz

[asterisk-dev] Change in asterisk[11]: git migration: Remove support for file versions

Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/61 Change subject: git migration: Remove support for file versions .. git migration: Remove support for file versions Git does not support the

[asterisk-dev] Change in asterisk[13]: .gitignore: Ignore tarballs (*.gz)

Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/63 Change subject: .gitignore: Ignore tarballs (*.gz) .. .gitignore: Ignore tarballs (*.gz) This patch updates the root .gitignore file to ignore

[asterisk-dev] Change in asterisk[13]: Add .gitignore and .gitreview files

Hello George Joseph, I'd like you to do a code review. Please visit https://gerrit.asterisk.org/62 to review the following change. Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview

[asterisk-dev] Change in repotools[master]: mapmantis: Remove dependency on digium_jira

Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/68 Change subject: mapmantis: Remove dependency on digium_jira .. mapmantis: Remove dependency on digium_jira This patch removes the dependency of

[asterisk-dev] Change in repotools[master]: digium_jira: Refactor module to wrap the Atlassian JIRA REST...

Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/69 Change subject: digium_jira: Refactor module to wrap the Atlassian JIRA REST client .. digium_jira: Refactor module to wrap the Atlassian JIRA

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

Corey Farrell has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/58 To unsubscribe, visit

[asterisk-dev] Change in asterisk[11]: git migration: Remove support for file versions

Matt Jordan has posted comments on this change. Change subject: git migration: Remove support for file versions .. Patch Set 1: (1 comment) https://gerrit.asterisk.org/#/c/61/1/main/asterisk.c File main/asterisk.c: Line 390: