Re: [asterisk-dev] [Code Review] 3164: res_pjsip_mwi: Subscribe fails when missing aor name

2014-01-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3164/#review10716 --- Ship it! Ship It! - Joshua Colp On Jan. 28, 2014, 6:34

Re: [asterisk-dev] Possible crash-scenario? Asterisk scheduler.

2014-01-30 Thread Matthew Jordan
On Wed, Jan 29, 2014 at 5:44 PM, Steve Davies davies...@gmail.com wrote: Hi, Thanks for looking at this. On 29 January 2014 16:34, Matthew Jordan mjor...@digium.com wrote: [snip] You'll note that the refcall is only called if ast_sched_del (eventually) returns a valid ID that it deleted.

[asterisk-dev] [Code Review] 3167: alembic: script modifications due to errors

2014-01-30 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3167/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

2014-01-30 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3148/ --- (Updated Jan. 30, 2014, 11:51 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3151: res_pjsip: PJSUA pluggable module and subscription tests

2014-01-30 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3151/#review10717 --- Ship it! Ship It! - Kevin Harwell On Jan. 29, 2014, 2:31

Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

2014-01-30 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3148/#review10718 --- Ship it! Ship It! - Mark Michelson On Jan. 30, 2014, 5:51

Re: [asterisk-dev] [Code Review] 3145: res_ari: Add event tests for blind and attended transfers

2014-01-30 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3145/#review10719 --- Ship it! Ship It! - Mark Michelson On Jan. 28, 2014, 3:55

[asterisk-dev] [Code Review] 3168: PJSIP: Correct address to which ACK is sent in NAT situations

2014-01-30 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3168/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23106

[asterisk-dev] [Code Review] 3169: Testsuite: Add basic NAT test

2014-01-30 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3169/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23106

Re: [asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

2014-01-30 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3051/ --- (Updated Jan. 30, 2014, 2:04 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3168: PJSIP: Correct address to which ACK is sent in NAT situations

2014-01-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3168/#review10721 --- branches/12/res/res_pjsip_nat.c

Re: [asterisk-dev] [Code Review] 3168: PJSIP: Correct address to which ACK is sent in NAT situations

2014-01-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3168/#review10722 --- branches/12/res/res_pjsip_nat.c

Re: [asterisk-dev] [Code Review] 3168: PJSIP: Correct address to which ACK is sent in NAT situations

2014-01-30 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3168/ --- (Updated Jan. 30, 2014, 2:27 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3167: alembic: script modifications due to errors

2014-01-30 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3167/#review10720 --- I can't really comment about bast practices. I imagine Russell

Re: [asterisk-dev] [Code Review] 3160: ChanSpy: Add ability to specify channel by uniqueid.

2014-01-30 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3160/#review10723 --- Ship it! Ship It! - Mark Michelson On Jan. 27, 2014, 9:11

Re: [asterisk-dev] [Code Review] 3168: PJSIP: Correct address to which ACK is sent in NAT situations

2014-01-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3168/#review10725 --- branches/12/res/res_pjsip_nat.c

Re: [asterisk-dev] [Code Review] 3169: Testsuite: Add basic NAT test

2014-01-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3169/#review10726 ---

Re: [asterisk-dev] [Code Review] 3167: alembic: script modifications due to errors

2014-01-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3167/#review10727 --- branches/12/UPGRADE.txt

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-01-30 Thread opticron
On Jan. 29, 2014, 9:34 a.m., Matt Jordan wrote: branches/11/apps/confbridge/conf_state_multi_marked.c, line 203 https://reviewboard.asterisk.org/r/3155/diff/3/?file=53245#file53245line203 I don't think this is the right sound file. Whey aren't we playing CONF_SOUND_PLACE_IN_CONF

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-01-30 Thread Matt Jordan
On Jan. 29, 2014, 9:34 a.m., Matt Jordan wrote: branches/11/apps/confbridge/conf_state_multi_marked.c, line 203 https://reviewboard.asterisk.org/r/3155/diff/3/?file=53245#file53245line203 I don't think this is the right sound file. Whey aren't we playing CONF_SOUND_PLACE_IN_CONF

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-01-30 Thread opticron
On Jan. 29, 2014, 9:34 a.m., Matt Jordan wrote: branches/11/apps/confbridge/conf_state_multi_marked.c, line 203 https://reviewboard.asterisk.org/r/3155/diff/3/?file=53245#file53245line203 I don't think this is the right sound file. Whey aren't we playing CONF_SOUND_PLACE_IN_CONF

Re: [asterisk-dev] [Code Review] 3168: PJSIP: Correct address to which ACK is sent in NAT situations

2014-01-30 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3168/ --- (Updated Jan. 30, 2014, 3:38 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3169: Testsuite: Add basic NAT test

2014-01-30 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3169/ --- (Updated Jan. 30, 2014, 3:38 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3168: PJSIP: Correct address to which ACK is sent in NAT situations

2014-01-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3168/#review10730 --- Ship it! Ship It! - Joshua Colp On Jan. 30, 2014, 9:38

Re: [asterisk-dev] [Code Review] 3153: testsuite: Dial tests for mid-call events, after-bridge actions, and peer h extension

2014-01-30 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3153/#review10731 ---

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-01-30 Thread Matt Jordan
On Jan. 29, 2014, 9:34 a.m., Matt Jordan wrote: branches/11/apps/confbridge/conf_state_multi_marked.c, line 203 https://reviewboard.asterisk.org/r/3155/diff/3/?file=53245#file53245line203 I don't think this is the right sound file. Whey aren't we playing CONF_SOUND_PLACE_IN_CONF

Re: [asterisk-dev] [Code Review] 3153: testsuite: Dial tests for mid-call events, after-bridge actions, and peer h extension

2014-01-30 Thread Matt Jordan
On Jan. 30, 2014, 3:48 p.m., Mark Michelson wrote: /asterisk/trunk/tests/apps/dial/action_post_answer/called_party_continue/test-config.yaml, lines 43-50 https://reviewboard.asterisk.org/r/3153/diff/1/?file=53098#file53098line43 I suggest adding a channel field to this userevent

Re: [asterisk-dev] [Code Review] 3153: testsuite: Dial tests for mid-call events, after-bridge actions, and peer h extension

2014-01-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3153/ --- (Updated Jan. 30, 2014, 3:53 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3153: testsuite: Dial tests for mid-call events, after-bridge actions, and peer h extension

2014-01-30 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3153/#review10734 --- Ship it! Ship It! - Mark Michelson On Jan. 30, 2014, 9:53

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

2014-01-30 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3155/ --- (Updated Jan. 30, 2014, 4:21 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3170: app_confbridge: MOH is not working for transferee after attended sip transfer

2014-01-30 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3170/ --- Review request for Asterisk Developers. Bugs: ASTERISK-19499

[asterisk-dev] DAHDI-Linux and DAHDI-Tools 2.9.0 Now Available

2014-01-30 Thread Asterisk Development Team
The Asterisk Development Team has announced the releases of: DAHDI-Linux-v2.9.0 DAHDI-Tools-v2.9.0 dahdi-linux-complete-2.9.0+2.9.0 This release is available for immediate download at: http://downloads.asterisk.org/pub/telephony/dahdi-linux http://downloads.asterisk.org/pub/telephony/dahdi-tools

Re: [asterisk-dev] res_fax_spandsp segfaults during fax detection - FIXED?

2014-01-30 Thread Michal Rybárik
Dear Pavel, On 01/30/2014 06:55 AM, Pavel Troller wrote: I probably found what causes random segfaults during fax detection with spandsp... Many thanks for your contributions and brainstorming about this, it helped a lot. If you have such issue, please test this possible fix and let me know...

Re: [asterisk-dev] res_fax_spandsp segfaults during fax detection - FIXED?

2014-01-30 Thread Pavel Troller
Hello Michal, Dear Pavel, On 01/30/2014 06:55 AM, Pavel Troller wrote: I probably found what causes random segfaults during fax detection with spandsp... Many thanks for your contributions and brainstorming about this, it helped a lot. If you have such issue, please test this possible fix