Re: [asterisk-dev] [Code Review] 3931: runtests.py: -d (--dry-run)

2014-08-27 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3931/#review13187 --- Ship it! I think the output is far from friendly right now,

[asterisk-dev] Pre-requesites of ast_cel_report_event breached in handle_request_refer (non-permitted lock)

2014-08-27 Thread Dave WOOLLEY
Looking at the branch version of 1.8, the following code in handle_request_refer appears to blatantly breach the pre-conditions for ast_cel_report_event, namely that no locks be held. /* XXX - what to we put in CEL 'extra' for attended transfers to external systems? NULL for now

Re: [asterisk-dev] Pre-requesites of ast_cel_report_event breached in handle_request_refer (non-permitted lock)

2014-08-27 Thread Walter Doekes
On 27-08-14 12:45, Dave WOOLLEY wrote: Looking at the branch version of 1.8, the following code in handle_request_refer appears to blatantly breach the pre-conditions for ast_cel_report_event, namely that no locks be held. /* XXX - what to we put in CEL 'extra' for attended

Re: [asterisk-dev] [Code Review] 3923: CallerID: Fix parsing of malformed callerid strings

2014-08-27 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3923/ --- (Updated Aug. 27, 2014, 9:25 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-27 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3930/#review13188 --- Ship it! Ship It!

Re: [asterisk-dev] [Code Review] 3933: CallerID: Fix parsing of malformed callerid strings - Asterisk 12+

2014-08-27 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3933/ --- (Updated Aug. 27, 2014, 3:31 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3873: Testsuite: RLS tests - nominal presence lists

2014-08-27 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3873/ --- (Updated Aug. 27, 2014, 10:49 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3950: confbridge: Add 'Admin' parameter to join, leave, mute, unmute and talking events

2014-08-27 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3950/#review13189 --- branches/12/apps/app_confbridge.c

Re: [asterisk-dev] [Code Review] 3875: Testsuite: RLS tests - nominal MWI lists

2014-08-27 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3875/ --- (Updated Aug. 27, 2014, 11:54 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3883: Testsuite: RLS tests - Lists containing lists tests for MWI

2014-08-27 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3883/ --- (Updated Aug. 27, 2014, 11:55 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3950: confbridge: Add 'Admin' parameter to join, leave, mute, unmute and talking events

2014-08-27 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3950/ --- (Updated Aug. 27, 2014, 10:56 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3881: Testsuite: RLS tests - Lists containing lists tests for presence

2014-08-27 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3881/ --- (Updated Aug. 27, 2014, 11:56 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3950: confbridge: Add 'Admin' parameter to join, leave, mute, unmute and talking events

2014-08-27 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3950/#review13190 --- Ship it! Looks ok to me. Minor nit.

Re: [asterisk-dev] [Code Review] 3950: confbridge: Add 'Admin' parameter to join, leave, mute, unmute and talking events

2014-08-27 Thread George Joseph
On Aug. 27, 2014, 11:12 a.m., rmudgett wrote: branches/12/apps/app_confbridge.c, lines 1834-1835 https://reviewboard.asterisk.org/r/3950/diff/2/?file=66863#file66863line1834 This probably fits on one line now. Ends up at column 102. :) I'll leave it wrapped. - George

Re: [asterisk-dev] [Code Review] 3950: confbridge: Add 'Admin' parameter to join, leave, mute, unmute and talking events

2014-08-27 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3950/ --- (Updated Aug. 27, 2014, 12:22 p.m.) Status -- This change has been

Re: [asterisk-dev] Pre-requesites of ast_cel_report_event breached in handle_request_refer (non-permitted lock)

2014-08-27 Thread Dave WOOLLEY
Walter Doekes walter+asterisk-...@osso.nl wrote: AFAICT, local_attended_transfer does that as well (locked by [[djw]] And it looks like handle_invite_replaces does, although the place I've found has both relevant channels locked, so may be safe. owner_chan_ref = sip_pvt_lock_full(p) in

[asterisk-dev] [Code Review] 3951: Testsuite: Nominal test for Inter-Asterisk MWI SIP publication

2014-08-27 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3951/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24116

[asterisk-dev] [Code Review] 3952: Add 'rtpbindaddr' setting for chan_sip

2014-08-27 Thread Paul Belanger
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3952/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] [Code Review] 3953: chan_sip: change assert to return for mwi_event_cb

2014-08-27 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3953/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] Asterisk Beginner learning about Channels

2014-08-27 Thread Maiquel Breitenbach
Hi, I was already here asking about the building of new channel, I use as example chan_alsa, the new channel is work, the write function record a voice in file, but i am having problems with function read, asterisk doesn't call the read function, can someone explain how the asterisk works to call

Re: [asterisk-dev] Pre-requesites of ast_cel_report_event breached in handle_request_refer (non-permitted lock)

2014-08-27 Thread Matthew Jordan
On Wed, Aug 27, 2014 at 12:32 PM, Dave WOOLLEY dave.wool...@bts.co.uk wrote: Walter Doekes walter+asterisk-...@osso.nl wrote: AFAICT, local_attended_transfer does that as well (locked by [[djw]] And it looks like handle_invite_replaces does, although the place I've found has both relevant

Re: [asterisk-dev] [Code Review] 3875: Testsuite: RLS tests - nominal MWI lists

2014-08-27 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3875/#review13192 --- Ship it!

Re: [asterisk-dev] [Code Review] 3883: Testsuite: RLS tests - Lists containing lists tests for MWI

2014-08-27 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3883/#review13193 --- Ship it! Ship It! - Matt Jordan On Aug. 27, 2014, 11:55

Re: [asterisk-dev] [Code Review] 3881: Testsuite: RLS tests - Lists containing lists tests for presence

2014-08-27 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3881/#review13194 --- Ship it! Ship It! - Matt Jordan On Aug. 27, 2014, 11:56

Re: [asterisk-dev] [Code Review] 3952: Add 'rtpbindaddr' setting for chan_sip

2014-08-27 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3952/#review13195 --- Ship it! looks sane to me - Russell Bryant On Aug. 27,