---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3931/#review13187
---
Ship it!
I think the output is far from friendly right now,
Looking at the branch version of 1.8, the following code in
handle_request_refer appears to blatantly breach the pre-conditions for
ast_cel_report_event, namely that no locks be held.
/* XXX - what to we put in CEL 'extra' for attended transfers to
external systems? NULL for now
On 27-08-14 12:45, Dave WOOLLEY wrote:
Looking at the branch version of 1.8, the following code in
handle_request_refer appears to blatantly breach the pre-conditions for
ast_cel_report_event, namely that no locks be held.
/* XXX - what to we put in CEL 'extra' for attended
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3923/
---
(Updated Aug. 27, 2014, 9:25 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3930/#review13188
---
Ship it!
Ship It!
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3933/
---
(Updated Aug. 27, 2014, 3:31 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3873/
---
(Updated Aug. 27, 2014, 10:49 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3950/#review13189
---
branches/12/apps/app_confbridge.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3875/
---
(Updated Aug. 27, 2014, 11:54 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3883/
---
(Updated Aug. 27, 2014, 11:55 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3950/
---
(Updated Aug. 27, 2014, 10:56 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3881/
---
(Updated Aug. 27, 2014, 11:56 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3950/#review13190
---
Ship it!
Looks ok to me.
Minor nit.
On Aug. 27, 2014, 11:12 a.m., rmudgett wrote:
branches/12/apps/app_confbridge.c, lines 1834-1835
https://reviewboard.asterisk.org/r/3950/diff/2/?file=66863#file66863line1834
This probably fits on one line now.
Ends up at column 102. :) I'll leave it wrapped.
- George
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3950/
---
(Updated Aug. 27, 2014, 12:22 p.m.)
Status
--
This change has been
Walter Doekes walter+asterisk-...@osso.nl wrote:
AFAICT, local_attended_transfer does that as well (locked by
[[djw]]
And it looks like handle_invite_replaces does, although the place I've found
has both relevant channels locked, so may be safe.
owner_chan_ref = sip_pvt_lock_full(p) in
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3951/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24116
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3952/
---
Review request for Asterisk Developers.
Repository: Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3953/
---
Review request for Asterisk Developers.
Repository: Asterisk
Hi,
I was already here asking about the building of new channel, I use as
example chan_alsa, the new channel is work, the write function record a
voice in file, but i am having problems with function read, asterisk
doesn't call the read function, can someone explain how the asterisk works
to call
On Wed, Aug 27, 2014 at 12:32 PM, Dave WOOLLEY dave.wool...@bts.co.uk wrote:
Walter Doekes walter+asterisk-...@osso.nl wrote:
AFAICT, local_attended_transfer does that as well (locked by
[[djw]]
And it looks like handle_invite_replaces does, although the place I've found
has both relevant
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3875/#review13192
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3883/#review13193
---
Ship it!
Ship It!
- Matt Jordan
On Aug. 27, 2014, 11:55
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3881/#review13194
---
Ship it!
Ship It!
- Matt Jordan
On Aug. 27, 2014, 11:56
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3952/#review13195
---
Ship it!
looks sane to me
- Russell Bryant
On Aug. 27,
25 matches
Mail list logo