On March 27, 2015, 1:30 a.m., Matt Jordan wrote:
The testsuite link lead to a 'this review doesn't exist' error. Is there a
problem with Gerrit, or did it not get published?
I hadn't published it. It's published now though.
- Mark
On March 25, 2015, 9:24 a.m., Ashley Sanders wrote:
asterisk/trunk/tests/channels/pjsip/config_wizard/hints/test-config.yaml,
line 8
https://reviewboard.asterisk.org/r/4388/diff/1/?file=71178#file71178line8
This needs to be updated to reflect the version in which the feature
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4498/
---
(Updated March 26, 2015, 12:47 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4388/
---
(Updated March 26, 2015, 10:40 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4523/#review14854
---
Ship it!
Ship It!
- Kevin Harwell
On March 26, 2015, 11:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4526/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4527/#review14856
---
/branches/13/channels/chan_iax2.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4477/
---
(Updated March 26, 2015, noon)
Status
--
This change has been marked
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/11
Change subject: Fixes related to testsuite GIT migration.
..
Fixes related to testsuite GIT migration.
* Add /logs to the root .gitignore.
*
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4527/
---
(Updated March 26, 2015, 6:52 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4527/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4529/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4510/
---
(Updated March 26, 2015, 12:04 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4526/#review14855
---
/branches/13/funcs/func_env.c
On March 26, 2015, 9:31 a.m., Kevin Harwell wrote:
/branches/13/res/res_pjsip_registrar_expire.c, lines 178-194
https://reviewboard.asterisk.org/r/4523/diff/1/?file=72907#file72907line178
Is it possible for sched to be NULL on AST_SCHED_DEL_UNREF? I realize
if sched is NULL
George Joseph has posted comments on this change.
Change subject: Fixes related to testsuite GIT migration.
..
Patch Set 1: Code-Review+1
Looks good to me although I really just wanted to test the Reply function. :)
--
To
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4525/#review14853
---
/branches/13/apps/app_queue.c
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/12
Change subject: Ignore JIRA uploads with license #2.
..
Ignore JIRA uploads with license #2.
License #2 is used for files that are not
Matt Jordan has submitted this change and it was merged.
Change subject: Ignore JIRA uploads with license #2.
..
Ignore JIRA uploads with license #2.
License #2 is used for files that are not patches or documentation.
Ignore
Matt Jordan has posted comments on this change.
Change subject: Fixes related to testsuite GIT migration.
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/11
To unsubscribe, visit
Matt Jordan has posted comments on this change.
Change subject: Ignore JIRA uploads with license #2.
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/12
To unsubscribe, visit
Michael L. Young has uploaded a new patch set (#2).
Change subject: Add web proxy support to commit_msg.py
..
Add web proxy support to commit_msg.py
This patch allows the commit_msg.py script to connect to the issue
tracker
Michael L. Young has posted comments on this change.
Change subject: Ignore JIRA uploads with license #2.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/12
To unsubscribe, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
On March 24, 2015, 11:23 a.m., Matt Jordan wrote:
./asterisk/trunk/tests/rest_api/applications/stasis_status/observable_object.py,
lines 25-29
https://reviewboard.asterisk.org/r/4520/diff/1/?file=72747#file72747line25
Rather than injecting a name down into the base class, how
On March 24, 2015, 11:23 a.m., Matt Jordan wrote:
./asterisk/trunk/tests/rest_api/applications/stasis_status/test_case.py,
lines 20-26
https://reviewboard.asterisk.org/r/4520/diff/1/?file=72750#file72750line20
You may want to consider moving this class back into runtest.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533/#review14862
---
/branches/13/channels/pjsip/dialplan_functions.c
On March 24, 2015, 1:15 p.m., Kevin Harwell wrote:
./asterisk/trunk/tests/rest_api/applications/stasis_status/configs/ast1/sip.conf,
lines 1-20
https://reviewboard.asterisk.org/r/4520/diff/1/?file=72746#file72746line1
Convert this to use pjsip instead.
Since technically, I did
Michael L. Young has uploaded a new patch set (#2).
Change subject: Add web proxy support to commit_msg.py
..
Add web proxy support to commit_msg.py
This patch allows the commit_msg.py script to connect to the issue
tracker
On March 24, 2015, 11:23 a.m., Matt Jordan wrote:
./asterisk/trunk/tests/rest_api/applications/stasis_status/test_scenario_factory.py,
lines 53-55
https://reviewboard.asterisk.org/r/4520/diff/1/?file=72752#file72752line53
Rather than injecting a name, you can actually use the
On March 24, 2015, 11:23 a.m., Matt Jordan wrote:
./asterisk/trunk/tests/rest_api/applications/stasis_status/test_scenario_factory.py,
lines 195-198
https://reviewboard.asterisk.org/r/4520/diff/1/?file=72752#file72752line195
I'm curious why you needed to check
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4500/
---
(Updated March 26, 2015, 5:16 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4501/
---
(Updated March 26, 2015, 10:17 p.m.)
Status
--
This change has been
Michael L. Young has uploaded a new change for review.
https://gerrit.asterisk.org/13
Change subject: Add web proxy support to commit_msg.py
..
Add web proxy support to commit_msg.py
This patch allows the commit_msg.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4532/
---
Review request for Asterisk Developers.
Repository: Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4536/
---
Review request for Asterisk Developers and rnewton.
Bugs: ASTERISK-24894
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4534/#review14869
---
Ship it!
Ok with me FWIW.
- George Joseph
On March 26,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4532/
---
(Updated March 26, 2015, 10:54 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4535/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4535/#review14868
---
/branches/13/channels/chan_pjsip.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4534/
---
Review request for Asterisk Developers.
Repository: Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4534/
---
(Updated March 26, 2015, 6:07 p.m.)
Status
--
This change has been
On March 26, 2015, 12:37 p.m., Diederik de Groot wrote:
/branches/13/funcs/func_env.c, line 728
https://reviewboard.asterisk.org/r/4526/diff/1/?file=72920#file72920line728
Note the double closing parens after the first sizeof, i actually
finishes the ast_str_append_substr command
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4526/#review14870
---
/branches/13/apps/app_queue.c
On March 26, 2015, 12:52 p.m., Diederik de Groot wrote:
/branches/13/channels/chan_iax2.c, lines 2026-2032
https://reviewboard.asterisk.org/r/4527/diff/1/?file=72928#file72928line2026
user_ref function not being used, may/might actually indicate a
refcount issue.
Because of
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4530/#review14875
---
/branches/13/main/stdtime/localtime.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4529/#review14874
---
/branches/13/pbx/pbx_config.c
On March 26, 2015, 5:13 p.m., Diederik de Groot wrote:
/branches/13/channels/pjsip/dialplan_functions.c, line 869
https://reviewboard.asterisk.org/r/4533/diff/1/?file=72956#file72956line869
len is of type size_t, which is unsigned. It will not be able to hold a
value 0
Rather
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4532/#review14878
---
Ship it!
Nitpick not withstanding, this looks good to go.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4532/#review14879
---
The testsuite link lead to a 'this review doesn't exist'
On March 24, 2015, 11:23 a.m., Matt Jordan wrote:
./asterisk/trunk/tests/rest_api/applications/stasis_status/test_scenario.py,
lines 98-106
https://reviewboard.asterisk.org/r/4520/diff/1/?file=72751#file72751line98
Since this isn't really an event handler, I'd rename it to
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4488/#review14850
---
- Jonathan Rose
On March 24, 2015, 4:53 p.m., rnewton wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4488/#review14849
---
/branches/13/configs/basic-pbx/pjsip.conf
53 matches
Mail list logo
